From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 854AD4338E; Tue, 21 Nov 2023 12:13:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D56040298; Tue, 21 Nov 2023 12:13:10 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 136F54025F for ; Tue, 21 Nov 2023 12:13:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700565188; x=1732101188; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=q4ByQjUR/Q0YGYB6XWQ0U+Iz0xZjv0JmRdC2vEbODWk=; b=AN9IOQ8HjmDmXPPP4RkCHAFn8JekKEfNfk3lH//2RpqIRgq30ne3OWZ/ YDdtqCtSomns9JyZWpYgRbOZpxjfJTPbxIxOqxVti0beTwXk4laU0vUkh yh3990btMktvT8VlFCYfHUiAQ2CRNmt+jDPPjgNLhHUsLObQrsPginwYB OO4YdIEUb7u4Kvb05qYWataS5D44T6o0MSFmOLBTdF0ygEvbEjSCNea7t iaWAmUdsbI930vkE2BtSOSk0NXlQClw2Q1r76yvbNcUAoXz4PcFXM1jaU VLVw2c3rWHWZLrS2TUxhkoVfbqxk8A3qB6Pwswjj3zOeZ3lWcwt4q/iNi Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="478019642" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="478019642" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2023 03:13:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="795757298" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="795757298" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Nov 2023 03:13:05 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 21 Nov 2023 03:13:05 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 21 Nov 2023 03:13:05 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Tue, 21 Nov 2023 03:13:05 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 21 Nov 2023 03:13:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QgLFYs84fC5xwxj6Hx2kTTagRr4pqGnDc6Z66ajuSQmOaQnqpfMkIvc5DqIbJPzitIp1a+yulRKFy/Nt4BGfULjQPQaThDlQfLT86e/q7/Ko+QTuR1Qxo5rpoqcSFkPXUztmv3ft02IjWyzvgf7NFqRbZ86fgIc/eNd1eFznF2KyFa4c2T7sUKweO6J6yq2MBh09bXuhyUQjcmlFPPW1iIOIgXTwAtJyG0uFE0iFSwQmzw25PDfsZr5NbtBod/CII3G0OXTmHuKM9qw1y/GFfIyW32VJids40Utjq2K9F+uWirU9R3T2qiDwPqM6MAJ1WezZLQPqLKcb5LjkijxZrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p8CVwhv8K+N51CzhkYqXdN9pbtwyq2Id5Cgy1F/oG/c=; b=BwHwX48eSMt8ERK79mI2glV05FcH1av/Iyq41mwMxJIJ9yHFEe//YErHEuYaG/x9X8hGoWpb1hWFzqxwWuSkA2yMfpwlaT7b8LYpFL+KhxGOPgL+ZCb7LXh4scjYA0/DKGTYG50RbSX6U/lAS2tR44pJuhLS5xSqcn9neK6YYi3qAEhCGqShGV82+VoM+MCLHpt0yoBaGK67yXgIw8oY6cRWd6ihwUU+i/AiF+8UMKRD6D5h3zB2Xs3t0akQe/2TetjnWnApBvLPIccOJOmi8KPGgOXq8xCfP1FQLpOuew3RTdzGSRCd/c090JJ6Rbfgmptbb3LIqxk7mmQVcuMPQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB7918.namprd11.prod.outlook.com (2603:10b6:208:3ff::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28; Tue, 21 Nov 2023 11:13:03 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7002.028; Tue, 21 Nov 2023 11:13:03 +0000 Date: Tue, 21 Nov 2023 11:12:59 +0000 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: , Jerin Jacob Subject: Re: [PATCH 24.03 1/8] eventdev: add capability flags for supported sched types Message-ID: References: <20231120172606.505579-1-bruce.richardson@intel.com> <20231120172606.505579-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB8P191CA0017.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::27) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: db16be91-3053-48c1-d89a-08dbea82d3fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rELOhXtajNjTD8Vq3Ompgdnnw9dBUMi26L2KKuwk6eYOhQGLOJ8Bif5SQJTVt8OYLsVVngYq7lg2ATDdXXU+vxrsc/py/+qqHuXHpHiTbhco8eJtrzbnYQaiTi2riDi1UI7NYRwWGtsXPoe8OPnZnCZFAsWUPvyzPcNvu2m45y36Tpz9qdoC3zdnSHQvb9GcraZEb+1Wsa0KolDvPemGuPsfxNP0KL0qLBxbcpHeLAQf/dg3bkPUec5vow+ac5hCXCnzWO7xPruPL6Iye35fEWMDWKE7CqPRc2Q2b/TOePdpesM2Z4QuanuWmNpscngDrCZpFpOHHWoQ1MkcrXqErWOPav5Th3Rj1KjVoxxY2zNWx/Ocbfd6AKrPxEeKjzzk5RFFrCoIXgYquDC4rky6+xnS9LwHm/xzWlqYi6mFUHtlKHV7FY9ItwhMH4O4ccX8sLAAI8C/5rky9ljZNBTauY5sMNFsXJOzExWMCDZUFGV5Ehq3QsjoIldl9LZ5OXG6RLjWOZQrtwZVTRpuXqvLNaD8PVqL1Lhlijn4tv5P1UymsgjCS8R69d19GL3mGDAP X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(396003)(39860400002)(366004)(136003)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(83380400001)(53546011)(6512007)(26005)(4326008)(8676002)(38100700002)(8936002)(4001150100001)(2906002)(44832011)(5660300002)(296002)(478600001)(41300700001)(6486002)(6506007)(6666004)(6916009)(66476007)(66556008)(66946007)(316002)(86362001)(82960400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?iqj86L55c538mKvyhvAN41ndYuP5VUIeXLdKFGbJ4viC2WHVQsMkROV+b7?= =?iso-8859-1?Q?JWXz1Xcji4xq10nRl9i4uPCbJLh5FtBvENU9OTlz57m5ZLWyUeh1udrcfi?= =?iso-8859-1?Q?MGhydL+HGkpQAXTwYBVctrbny3O92nUAW7kkKNdrfAhRI/8EqmVVJzK1Zl?= =?iso-8859-1?Q?FDyJUKyPycs3o7Jn50J4TZmXPd2Urq4ed9kmSVBXKerb+ydBPofOjgtGuK?= =?iso-8859-1?Q?FAkw8nSJy8AaGCfxiZM/TUReDBJEcEUMargzIruZ5HEbe8BpB9gXISNAYD?= =?iso-8859-1?Q?QYxYfjjQNXhENoNznHsaLIt30X11r/zl8pmbqi0+5twKk97m8qHlIClGED?= =?iso-8859-1?Q?X4eV2h6RDRS5otmIThRypfAKG6w7DtZMFo2M18WO7itYOvAHHisF1Tcs0k?= =?iso-8859-1?Q?ULvaFlYnoavaRRavxpLv97abY8CJJPpmb8ASmB5gFr2lhaSRlfBP2D/Nrn?= =?iso-8859-1?Q?P6Sbr5rglVYIzhxMqN2t4ZbnLqSv5hAaTMzGNPnD2AxRA99naLIfhJ5kFl?= =?iso-8859-1?Q?0r12i4JO9XknCt9d3V22kX1WLiUJMHD/p4E7KyMHwrpV/lA/F6Ftr3nvsl?= =?iso-8859-1?Q?sgBCMJyWWVb7ia85nQ4Y5QTSm5bvZqw3Nq2uzrMdP7n9DC/F/WQGHY886V?= =?iso-8859-1?Q?sFTFZ6pn8Rk/4nwRjKxEJ4yaSeZMvYcmNOpwK4szV+Kv1/C4S2kMZRfvBk?= =?iso-8859-1?Q?vFSnyRGBq3TVzYSRe02xRAPJYnru0YMZCT5K9pknDfXbzbkUQbkUHWVP4N?= =?iso-8859-1?Q?lkQgRS3Rr2SX08ka/4okctyMk3UAZ49SHwsKNCzoxqvWlnBi4QdpUB3pqY?= =?iso-8859-1?Q?2qVIrPUJBT5MqgiVIQIYiIek1D2ttbOENz1u3sx1qEx437K0JadwOOKgLZ?= =?iso-8859-1?Q?7ZVKculTjHc3oxdou0UMED6cAyNBQChIsQSSfaOSJhUtSmDhfDSyhkyPcM?= =?iso-8859-1?Q?DbCw6sFqT94BdXf6IyekHpHWkfF6j5uyZMTTkFofZK3wPacNXP9H50J3P2?= =?iso-8859-1?Q?0+zj4ChMrMXUDof4/i4DGi6EVHPY+Kulx9WkIo9nb4izSGpRkGOllBAgF/?= =?iso-8859-1?Q?bXZhEYek4FQvz0hbairarnSuyO5jz1X7gzLX0xbggttzif6VOkitp/jyEU?= =?iso-8859-1?Q?7oOa2/xPnHjwMKehQYR1B/INHVZLoFep5CD4mag2cNjf7axRLI8U3iGKjr?= =?iso-8859-1?Q?s41kHWZjK6wTjLjs6dGiJ0FV9YPquNlDfUQDMPWKrXFbnNtLbbVs3cLB4X?= =?iso-8859-1?Q?rcYXpYRbxVXzHyy7qIwn4aUDUxX+qn66V5UCfYfFletMsmgeFUxWJXhdKO?= =?iso-8859-1?Q?ExgWdPhiscVWyFmWLgWBsuW4Ggq876WF9DAxWH0k9NRwjHLyrNXenO2acr?= =?iso-8859-1?Q?5X6TJifSv+ZdvwLOnv166GCO056XkQs2aY7a/UvWJ7lpUBKrVzl1feqvUf?= =?iso-8859-1?Q?UOq7nIqZ+sso10jjainiOu+J1OCb4tDY+m+qsl3Y8Hoawq1lomnE5RvpZA?= =?iso-8859-1?Q?ExCIw1dKWMxNqGmGBnNI+S5V016EBwabZZIrZx1XGbYt+/kqy9dkk2FrP+?= =?iso-8859-1?Q?xPgbRg2HEdACVc/XIEog8N/B7PdAxsRIH6bWzDLsguNvfxrLdrhJ1o6d1z?= =?iso-8859-1?Q?XF4mK69vXxracpwBGUJ8RVJx3BEAKwGM7DJZUr55YWzODEAnQO5Uia6w?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: db16be91-3053-48c1-d89a-08dbea82d3fc X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 11:13:02.7575 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SwBRrGfacoesMhz+sCYMZ81jTYmmaA5SQc490hpXk1+yITFEAgij12spR9wzzF05rNiQ8R4uaL4fRGaZlIAa6N0+odORlNZjPdACKAVx3xg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7918 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 21, 2023 at 10:30:02AM +0100, Mattias Rönnblom wrote: > On 2023-11-20 18:25, Bruce Richardson wrote: > > Not all eventdev's support all scheduling types, for example, some may > > only support atomic scheduling or others only support ordered > > scheduling. There is currently no clear indication for each driver what > > sched types it supports, so add capability flags to be indicated on > > return from rte_event_dev_info_get() API. > > > > Similarly add the possible scheduling types to the capabilities table in > > the docs. > > > > Should we allow an event device to advertise > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES, but not all of these? > > With current wording of RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES prevents that, but > you should be able to allow for this without breaking backward compatibility > by tweaking the text from > > "Event device is capable of enqueuing events of any type to any queue." > > "Event device is capable of enqueuing events of any type advertised as > supported (e.g., by RTE_EVENT_DEV_CAP_ATOMIC)." > > An event device that doesn't support ordered, but does support "all" types > seems reasonable to me, while an event device that does support ordered on a > per-event basis, but doesn't for queue-level configuration does not. > > If RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES is left unchanged, the user may ask > herself what "any" means (any supported in the API, or any supported by the > actual event device). > Two follow-up thoughts on this: 1. The use of this ALL_TYPES flag would suggest to me that we should not have SINGLE_LINK as an explicit queue type, in the set of ATOMIC/ORDERED/PARALLEL, as it would really confuse the issue as to what exactly all-types means. Therefore, I think we should keep single-link as an auxiliary hint as now. 2. The CAP_QUEUE_ALL_TYPES seems a rather blunt instrument, and I was thinking that we would be better to convert it over to have the alternative flag that says that queues only support a single-type. However, even then, neither really covers the full gamut of support, because in some cases whether or not queues support all types will depend upon configuration. For example, for DLB2 driver, the docs point out that depending upon config, a queue can support either atomic or parallel, or atomic or ordered - with parallel "degrading" to ordered in that case. It's possible we could have other PMDs which allow the final combination of having a queue either atomic, or ordered and parallel combined. Not sure we have an easy mechanism to express all this, so probably keeping the status quo - possibly with your suggested tweak - is good enough for now. We also need to keep things as simple as possible for app developers too, and try to avoid too many possible combinations. /Bruce