From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C7E74366B; Mon, 4 Dec 2023 12:02:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD9EA40DDE; Mon, 4 Dec 2023 12:02:37 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 535D740DD8 for ; Mon, 4 Dec 2023 12:02:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701687756; x=1733223756; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=5q3Iw8lTjphINLuo5vk2Z4OALHt3I1/UxTNpCl3o8hQ=; b=l9cxL97Ymq+40mxK+KoAeawce9dpfSDMj9a2D1DWMIRe9J8H1lg7aLHu BHfq7bHrJkQe3SNR562czpzbX6aNLdqNNJXXdfarePhKMGdSu6noMTim2 9q4jeElun8whiODsuw5KaTt6InZlenKbFP2SWTiehrN5396Q8J2cu7vR7 UYN2fO/4+XAF/gAm/DPe/iZ2kjab2f90iAXlh/T6Ju/MzIb/n0oqkib8X pjiBqvrtMLQ5VajaRmyqLXTT6hbHOOvUBBzhCXjyHLmeiFSBOquh006wr zfka9nI58mMN25iw432KFGS723VwZCMaNn3NJPsrOjlvoggeXyQCt1q0j g==; X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="15262632" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="15262632" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 03:02:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="861343224" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="861343224" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Dec 2023 03:02:34 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Dec 2023 03:02:34 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 4 Dec 2023 03:02:34 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 4 Dec 2023 03:02:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I7Qf9QFVxBuhkyz8NUvs1ewC2xoe22hwytV/xPFZqI0CkgHpP7p04lu3FGaQM/7/tzUUMSyPAcrxM+TCv/rbcO7kqR1Se+zH58HpylEWwUjzybeSiRGc/7yZA3a89T6owTcG0+TxsRQQSnMRTDisQoPabDqZisRUVoM5A4eXG16lYI24fF175ul7F9zdluF6sK4Y6soKMOhqKUSOTF5/n/8yyetkp7l0YeFqprnpUfsIDQYQAyie97s43Rs9V4rK3vRDHRdn0uz/xsFwznP7CPjAcOfUhDCzQ4twVflT84SMdl4yzbBj/BgODfbABxNVWtKCpbhqqsusOYwhlGvVgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/PhaInHvtwWyd2SMw1b5vtuuwQyCMoqwOO3HxjivZFc=; b=jPN8XndhWXna3ShFbE9kOzf0XedYlktD44gRpBo45fsgRSRyTae0N4ID4AcZvaCR/r1088SChTzieHaiyQQNl/iY3bMcNrcaq7pCx+N+wH1H3J1FA4J08f1W5GNWCXIPZstR6gOH7RMbinZ2tRVikxsV3zs3olblYhtATahsZVdkZ9GUprdVt+eSRn2P/K7+GlR0HmdPxGKSmx7P+H9ZPVzKhjyI2u6wNJuJVKhhUzc5Hx6zeokE12a4BkiT228QQ05HE9KRrYXyWzsDhYNsqDvNH4G1TmWNrQVepG0uuqiWUjwVjgVcTpJylNc8RZ0N54IT8pwflrJtwQ9qLTFI/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA0PR11MB4592.namprd11.prod.outlook.com (2603:10b6:806:98::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Mon, 4 Dec 2023 11:02:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7046.033; Mon, 4 Dec 2023 11:02:30 +0000 Date: Mon, 4 Dec 2023 11:02:23 +0000 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= CC: Jeremy Spewock , , , , , , , Subject: Re: [PATCH v8 18/21] dts: sut and tg nodes docstring update Message-ID: References: <20231115130959.39420-1-juraj.linkes@pantheon.tech> <20231123151344.162812-1-juraj.linkes@pantheon.tech> <20231123151344.162812-19-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2PR04CA0303.eurprd04.prod.outlook.com (2603:10a6:10:2b5::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA0PR11MB4592:EE_ X-MS-Office365-Filtering-Correlation-Id: e4eefc98-55c0-4498-ec52-08dbf4b88216 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xqokWnM33ldpWkwIUS2FgAw1xP038wqpfQ87SoifRAJFPg7zCMgGM6D6ADgQzgapelIAiHvZabEZYig5bUF785cubBwMlavnHQsyUJjEYfbYP2Sa7PMmI5u0hIwB3cefga/yJuQvATK5SxaUyfbAd9FntRnAa38OAll8I64sgcLyPsy5ltH563rEyHGReeBsicAnt/bNuDqYf6drCoK40y03CuYthlb619SBgKMzDf3IEq+8qC8XHmwIXmJenSeSDF1L0bXk8M9mpDu+K81nDK2rQnBFhcgveiv0rJzF6vJ6+4elAImyRBrwK29OoOw/QkZPwMom8ZKBe6zqytv/1434dlvX4CYrtej6L7DgQwOT5Yujo+IGmRGlzi6P7RQASHEs/YeMBfkoOVjAeoPgSBFSYJEUVRBY5iS5oJznoX+FEb8yJe5ctG60oiJrGkhiUjnIv4dvjjg2Fg5O46ggBkSGeI0ozCi3ZO/dQq6LTDS7nrhD/mmb57Y0CPQnVrhKZuyt4QuGo7NVkjaIhBuV4QnCBYPGkxEETfNDxf0cmrKSO6TZjV+Dby5IbLQV6kap X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(346002)(366004)(136003)(396003)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(38100700002)(5660300002)(2906002)(82960400001)(53546011)(83380400001)(6512007)(6506007)(6666004)(26005)(478600001)(6486002)(41300700001)(316002)(66556008)(6916009)(66476007)(66946007)(8676002)(8936002)(44832011)(4326008)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajM4YjI4NVpSbWNkeWhjN09hU3NLeVlzUDlKZkZQOXFCYUFXbTlGSWhXeWFz?= =?utf-8?B?RmxwdDQyTUIyRUR3SmVCek03MjNzd2ZwSTBkSzVHcDlaY3V5Q3ovbUFRS0d2?= =?utf-8?B?VUpaQlQ5eGg1VlU0WnFvNjZxeHJwalFveHBtY1hEaWpaTlkvb3hUelgzNXpU?= =?utf-8?B?a2R1eDhNVFJydlg5MW1yRWpXVVd2cHQzdkdqcVBrT1dxVVpHRFpha09IOTBT?= =?utf-8?B?ZGcrejdUVjFHUXZFVmcybVZDYWU4U2Y0VlBOVlJ3a01yZkVHMmN2L1VyTmtE?= =?utf-8?B?c3QyTlYwY0xJVnl3MjYzNHJVNW1RS1dwdXJEZytNTWtMNEttOWZTbkU1cHo0?= =?utf-8?B?U0NCV2xmczl0OUxXZ04xczNSekp2cWExNkYyc01WRU50bDJLUjcwdVNLQ3hT?= =?utf-8?B?S1ZQemdxMUsySnR5Tnllc00wOFBlZnVpQmJVdEFneTJtY0tUN1dWakpZcThX?= =?utf-8?B?UURGanRDamFRa09ZTmErOS96UnRtbFE2MUNLcHI1eUxibXdLRmw2UHhodTJ0?= =?utf-8?B?SVluRGxHc2dYY3pIVWNYL1NkdmRJTGFyMWh3UEl0MTltRGlBVmd4UmNQa0tV?= =?utf-8?B?b21TancvdlB0a0JrUDE5bjlEbitpRkVybDRKVE11MG9kUHJRdHZHM3MvUEpN?= =?utf-8?B?UFp6dnRHdDF2T01tMGpBRW9IUm9DQ0Nld0M3V0xiYXV5TDIrNTBJUmFVY0pI?= =?utf-8?B?SHVNeDlyblVyMDJmSWZJK2JqekxTYmFQS0wzNHZlQlNlTnpVcFRJWUhWWHc3?= =?utf-8?B?aFJUU2s1NHpLV3N4aGluV2tPZ0lsTDk3L0dMZ2xQbUYybFV4dEhBa1NteVI5?= =?utf-8?B?bEZYMHFoMmFYamM1NmFtRXVkSEJGZy8xc0ZEVituNDJtNFNlVlVINVU4TGQr?= =?utf-8?B?S1hhSjJQbjluV3h1eThCc3BqU1RhQkFxRmo0Y21MWmFqU3hRYXZaaVdKdTNY?= =?utf-8?B?S1B5Z0pzSFNyeHdhNy9nSkhqcm1JSUk5QnNPRVg3bHlOOENPYisrR245c0xo?= =?utf-8?B?Zk9obzc1c2FEUDJ2ekFoR1kyb0l3Qy8rSWo2T2tqMUM4KzlPS2N5dlhnakti?= =?utf-8?B?Z0ZQNHNtL09YcHU1VmdWOTUrSjgyRUJaMW8xN0JKS1BYb3N0dzdIN0hCN1ZH?= =?utf-8?B?Q0xyYUtTekVUUWwzWmgrM2hybjZKayszcHpCRVRtbm1oeXF4dWp0SXI2R0tF?= =?utf-8?B?VHRpQU1KN0xlRVpuMm14OEdIdkU3VnhOTWJRTm9JQnYyMTdOTUk1OUJqU3Aw?= =?utf-8?B?UlI2L0ZxNGpKTmw0am9NTEg4azBkbEFYbCtYdjF2WHZ3NzF0L20rYkhJYWlF?= =?utf-8?B?V21CMnh4TFg2a2hPWmpieFlpTXJFZkx1SFlnZVM5WDNvZUh1WXFQdTlOMTNx?= =?utf-8?B?M1hIK3o2TkIzdlNtWnBJc3A1M2JFdlE2ZmdGYXlzT0xzODZEcERRSVVVQ0Ew?= =?utf-8?B?QllIWU53RFZsUmdOcWlrUXh0MDcrSWpMR0gzYzNLVWN1SGovM2Y1bVViWVVi?= =?utf-8?B?YTBzNzRhMEx4SERJTEtCVnU3c3BBVndSV2MrNUJRMFJ1S3F3ZXpTdHN0N0Jp?= =?utf-8?B?cGg4VHBCYnd6OG83MVl5b29SbW9KelJ4anBvd3dVckdwYXI0aHNYcVVhbWw5?= =?utf-8?B?R0FnVHhYQnBRSXdTenpEZjhxeHh5aVpHcnd6YjNnOVkwMFZKai9VNGZUR3V1?= =?utf-8?B?bDZPN2ZhMk5LdSt1UEhYaXcwUTBReFNnYVlaMzJLYTdMTzVCL1Q3NUhSU0VU?= =?utf-8?B?VUxKME93V2hIUjhhVzloUlFNSi9EaWZtUUdERGJFTkV4bHAxVVJRSjRMMVV4?= =?utf-8?B?Y3lPUGZKL0hVWEJwOHVpajFXOVFKZ2xheG9lN0ZzVEhtT3FQWmplbWJSUWFJ?= =?utf-8?B?NmFjclZZWHh0ZG5LWWZBUUFQL3RnWEp6TlRTaUtHQzdHcWVnTjBNdlBaNUZz?= =?utf-8?B?aUVrL2pDVFRjRmp6cy9YbWRMSjMrSittdUl4R2cwTFRESUUzbEIzRGsrcFpH?= =?utf-8?B?NzFUdm9DOU5nTCthQVMrVEZSbmFFUy9zZDc4NHprZjhheUVoSCszTFloSTFV?= =?utf-8?B?UkRzaVhkeU9EeU1zcUhUWlBiUlVXZ0h3d1FUaUIrMWV0SkQ0Y2tvWVZhTkJM?= =?utf-8?B?ZGZGemhpMCtDRGEvNVdYTXNWdnhyNGs5aWhBaHpGUS9Nek9HSTUyMW11cTFp?= =?utf-8?B?Z1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e4eefc98-55c0-4498-ec52-08dbf4b88216 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 11:02:30.3539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OrX2UZDl9oztf68F2suAydWQAqUh1kHNgAQlHiCZGG24ECBPTIa46bZ6rBWTD26FJd9EO0ukTujgXBolw7ErJZYZ4V472EApw07dBlJDyC8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4592 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Dec 04, 2023 at 11:02:21AM +0100, Juraj Linkeš wrote: > On Fri, Dec 1, 2023 at 7:06 PM Jeremy Spewock wrote: > > > > > > > > On Thu, Nov 23, 2023 at 10:14 AM Juraj Linkeš wrote: > >> > >> Format according to the Google format and PEP257, with slight > >> deviations. > >> > >> Signed-off-by: Juraj Linkeš > >> --- > >> dts/framework/testbed_model/sut_node.py | 230 ++++++++++++++++-------- > >> dts/framework/testbed_model/tg_node.py | 42 +++-- > >> 2 files changed, 176 insertions(+), 96 deletions(-) > >> > >> diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/testbed_model/sut_node.py > >> index 5ce9446dba..c4acea38d1 100644 > >> --- a/dts/framework/testbed_model/sut_node.py > >> +++ b/dts/framework/testbed_model/sut_node.py > >> @@ -3,6 +3,14 @@ > >> # Copyright(c) 2023 PANTHEON.tech s.r.o. > >> # Copyright(c) 2023 University of New Hampshire > >> > >> +"""System under test (DPDK + hardware) node. > >> + > >> +A system under test (SUT) is the combination of DPDK > >> +and the hardware we're testing with DPDK (NICs, crypto and other devices). > >> +An SUT node is where this SUT runs. > >> +""" > > > > > > I think this should just be "A SUT node" > > > > I always spell it out which is why I used "an" (an es, ju:, ti: node). > From what I understand, the article is based on how the word is > pronounced. If it's an initialism (it's spelled), we should use "an" > and if it's an abbreviation (pronounced as the whole word), we should > use "a". It always made sense to me as an initialism - I think that's > the common usage. +1 for using "an" instead of "a" in front of "SUT".