From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D652D43676; Tue, 5 Dec 2023 10:56:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAEED402C8; Tue, 5 Dec 2023 10:56:18 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id 7904A40275 for ; Tue, 5 Dec 2023 10:56:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701770177; x=1733306177; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=vmwTyH1NHXGnYjmAHzM8fYU2IPm55fWdMVAv3Z3D3+c=; b=iCV+TtNBrptP940Gd+dEyLIJKy+XniPnEJpNvUlkB+GTaKb2foyTOSd/ ln3CRLZ1sGH/7OmDu304ZfFwKPFpfTFdkSQp/0YI3EB7BVjw5eYh45KKb +bRE1UQIbkegieSrFXEojHYYBivFFFa/XDJn1fRpbKekwW5VjXpeRM+yY 0NKeiO4DT06HXuI/VDgBGHK6jS7GREy5lK1hvWgHkAFH2k3T6sIpigXf4 upGOkO9kQ02Fix4WaTgd5W1EclUp+JCZZnyTpj0jez57Aub6ziOYEoiwv ciukzvh6hnTBQHQTw+p/elvYxK+ocG8CZId1MXnUZ53+wBJIixObuJUrj Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="933180" X-IronPort-AV: E=Sophos;i="6.04,251,1695711600"; d="scan'208";a="933180" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 01:56:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="841397475" X-IronPort-AV: E=Sophos;i="6.04,251,1695711600"; d="scan'208";a="841397475" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Dec 2023 01:56:15 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 5 Dec 2023 01:56:14 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 5 Dec 2023 01:56:14 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 5 Dec 2023 01:56:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jNyNOnuZEB7VbyfP1Ej+dYBVRNokXvcqDabn+AClwoDEsqtTULlKhywOQ856N7cvp/nqeEHUscIm68AyHMjDmeutXt5i7/gF4Az9GZlaY0Jwc1yp2CK3oC73SEkT/Qf602Kj4MEpbTndB1VDtwVHujSOYMh4QwMf+SfZY/3lNWYlGxYezHXaKguufA2jhuXkOCTyX/F4d6Wf7fLlXNrktWfoMqr604pTNkyKhMWQYfSevhsjqgJ3NOZMglmlYYk2f+Yl9b4+NzKRmnXqrCeDPnEg9rY/7L0UrXuUrwHG1mgECcwzU8mGppcqa4IoEr+1NX5PA8XF1T5t7SznxB1D2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vn1foKW51OvfXsx60J3Wzs2+46UxPHtUr01wpVziyMQ=; b=nSbraIzVrHouvE5vU0ZkKUw3YwS/qMdfWW1Rd9z6/rFYHZQ/byu4kr8gQwSn2r0pabiGoTncpUNEBH6Z6wnSOoTbteAl4Wsl005TmjbFLPUsXITXLNjqtLz6zIv0r1BTKCsCChQa5+KbIlrgAxwtIf2mJavB2uRKIJeDxNvwxmWUmTWsKdqr/IJXD/8qolo+LOuIgMpJE/B60LBhY3xR2Z94Ey5IpGgGA9zGG3ufHlWnl6/sKpnh/I67TxOoT0bOV8dpJ79e4FBzJRnX2cuJSAIDvscrHGNjBZHZB2eEMdH5DXcHXv8mNZG4sWiJuQEWyRc977+gWaDnowpU4viY3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BL3PR11MB5681.namprd11.prod.outlook.com (2603:10b6:208:33c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.23; Tue, 5 Dec 2023 09:56:11 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7046.034; Tue, 5 Dec 2023 09:56:10 +0000 Date: Tue, 5 Dec 2023 09:56:04 +0000 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: Subject: Re: mbuf init questions Message-ID: References: <98CBD80474FA8B44BF855DF32C47DC35E9F08D@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F08D@smartserver.smartshare.dk> X-ClientProxiedBy: DB8PR03CA0012.eurprd03.prod.outlook.com (2603:10a6:10:be::25) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BL3PR11MB5681:EE_ X-MS-Office365-Filtering-Correlation-Id: d8ea76db-1be3-458d-a425-08dbf5786865 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3YpNInqt28mzNnyBzdK9Ls6PS/GFpzIYhXPkmWQPRWPsXLH3n79Po3YBlAawL+UHA8zXyTntkOPnxKMvSpkZpGFRoW8gAcNA2Mt1kPvGsgob1/rpHX2kqsOgbp+3ZGc6mDqbzqyrJ8UtBmanWjpUKtkjXlz7Lv9Qo6XWmHonY3sgeq3PzqdlXXkoMM+oQKUCIrvL/30WcWmAcJlHGMq4swiGTnBbyy74y33XW/aH7y/+vpBXLf96XuFylHZUmqAjOH/pukhgmcY5n9FsELJI+t8yE8GpH6TuZdueN4gNDs9EgJZv8983lRIYVayz2tVlM+cXRBlBuljjHrnzECMjtTx9kNPzhlFqdQLNoD2VfM/00m5LzmXebvBvjd1M4B6CYWUQT8lP0PNh0g3hGe0ufHP+kNkVcAjFWqxfbbemv9RK4wS8nvjTvQwQ/fD/+ap969pt2k5yQQ2xHlasjfV1BY2ocEHG7I6k/FELOTCLw55zXd7fhuxz8ShvkTk0Y2Qqswk66utyMwBe/xYCLof6pRJ1FJ1Ja+1WZvxcNw/UJVq7y6fvVZS+P6saUx82enyU X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(39860400002)(346002)(396003)(136003)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(66946007)(316002)(66476007)(26005)(66556008)(7116003)(44832011)(4326008)(6512007)(4744005)(86362001)(2906002)(8936002)(5660300002)(41300700001)(6506007)(6916009)(8676002)(6666004)(478600001)(6486002)(82960400001)(66574015)(38100700002)(3480700007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?1yGnFpiTFmIbHMjaibmpZUvJ4tc2T7I6xsT/HR6dqI0Ggb+7X3N1/vEKX+?= =?iso-8859-1?Q?0T0qzQPEj0YUJbKQrER2kb+U3zORQ6vEP0iKVlLPP3fhc2YyOnnwIniS0H?= =?iso-8859-1?Q?mMZoD8jkDPTXvtaRoYgYZ5NYsgFsJSsUtXj4QTtBLmZWTFXNjTrduRP9Hy?= =?iso-8859-1?Q?UmR3GYLWeXD7DtDIKGU2jL1pKE3hcLllP8opxv+HbbCVcZiqEkfgupqbo/?= =?iso-8859-1?Q?pRRBoSbiVo3CAunbELRtX+fWy9luwePqeNccmb6M4/ChKgAKtcv3ohSYEg?= =?iso-8859-1?Q?ZM7QULQRNz7LOW/ioi0Gy551YqJ82/OmZTGDr2rWMRGxk/6dOdtT2XUj6V?= =?iso-8859-1?Q?EqwRQuRIaEn80QHQ2j7/jpWHQvuwja9+5p6cNz9905XKPInaZzbZLZVagG?= =?iso-8859-1?Q?7VCWsKpTSNYHKAaXQzikIOW22S4SExUQ+a0v9ClhMFX4q8IsxmxbbPHqWx?= =?iso-8859-1?Q?wIJ7AT9BlJN+Tvt1S2JxqDwnft1s9kzAMJjdMAlVSWyhoRsy4gbgQZHS9z?= =?iso-8859-1?Q?dTlQFRnEMCDPFnwtfWnroLBtnOt+27Sy6y1v/LDR79OiRiQAHHqI8CtnNa?= =?iso-8859-1?Q?sgixiISkbNncz1I77v3PGOFlqmWLNkRBGzNuOrh4OexStEDRO0Rx2x7UJV?= =?iso-8859-1?Q?4vAqwySchWWTaN2iNUJC/YlftNspdWNYezETIq5Q9Uev5+KFI+H3w4Umnn?= =?iso-8859-1?Q?cWDbYCuSN5czYBFfKG/KYmQuE/ALvy6CZzUAMB3mIpMYJuvB6PyC8XvrCH?= =?iso-8859-1?Q?QUha3D87DcjUAVjyaxKExPfolb52mgFTHnAlTEJenPQc4SkKFmfMCUouJj?= =?iso-8859-1?Q?azM3AMt9wzNvBWgWAkPv/2Wu0c2fFX6Ogmk8pcXGk9MfI7JcgCHWbBrPwd?= =?iso-8859-1?Q?FSNyRlDvmHwGEen8HOnidw6b56RhKv1ZyzbZMVvi4ourT967g3UMiXp4Ce?= =?iso-8859-1?Q?EQqWZy7vu6xNMSajLVxVZBxqzixMEnjF1sO4pTICKrDCeS6q+ENhw/r82m?= =?iso-8859-1?Q?0U0MONZ87Y6Qf2YUYIV05r+5v18lm5klhEyAAcBc4XDXikWg/mmMKKQtZI?= =?iso-8859-1?Q?zeNaqvLnrM+WDIsQQ7/jdIjhmRA2felL7UQWb2qMCyYYHCrOKmC4V2wqsB?= =?iso-8859-1?Q?DkzytSMJc5HyKMTqz5DJm6bOsIomkct9lpBQEsVE5GCdlMbHgJlW1DYAYn?= =?iso-8859-1?Q?Wsx4+plNMCcqrEBs5RN0v4YD1PTAIuzJg+1gaVrKB1Yt4hW9sz+1l9V6/h?= =?iso-8859-1?Q?QtA2+VQepwL7d7yDH9cFP6cBP1f+bDj1IMPiqGstUP0jPp/Y9K3/3S8MdF?= =?iso-8859-1?Q?3QC/oBI7vapzH+OQU/BllyC910bAPgIgYVAiBJ4oc732NhnCGU/IuTYV2w?= =?iso-8859-1?Q?EM0uCDU+k0hUxh7JRvM4Z0c3xJoaDy9JSwmjZ/lttLdy56d9+YD0vzzIht?= =?iso-8859-1?Q?0pg67fAiHO4v5r6oHK25HdR2ebh3KvcQu0xCNeGhhm1CiZ8Bm+lqVXtKID?= =?iso-8859-1?Q?sXIlNHANpI7kscaEsouzC/awAryjGtHWBQqou/EiHkzOJHSxU0zlGj1LcJ?= =?iso-8859-1?Q?01+Z+fbM/VPekOR7Lp7P9MVi79FEl8cUHMxlkUIK1C10kFIdSjoDeKj/5T?= =?iso-8859-1?Q?GGH5xsjZ5HxHGOuwKkC1El9RKTq2xyjhKyi/tUsunzEkBdV+xiYnKFCw?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d8ea76db-1be3-458d-a425-08dbf5786865 X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 09:56:10.4158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MeGkVlI7mg4Prv3gHpzqL9v70NzUK3tM2RMQIBLWgtZKPp62SB++3oJrSB0pMuQ2GCuMqCJ13h+co8G+KlPBPX1TtyJkOp+ydLTnwxL/rR0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB5681 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 05, 2023 at 10:07:56AM +0100, Morten Brørup wrote: > Why is m->nb_segs initialized in rte_pktmbuf_prefree_seg()? > > It's part of the m->rearm_data, and will be initialized on RX descriptor rearm anyway. > Presumably this is to have a sane default for apps that allocate buffers directly using mempool_get functions. Overall, we probably need to document clearly for mbufs allocated using mempool apis rather than mbuf_alloc what fields are valid and what need to be initialized. /Bruce