From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Sivaprasad Tummala <sivaprasad.tummala@amd.com>,
<david.hunt@intel.com>, <anatoly.burakov@intel.com>,
<david.marchand@redhat.com>, <dev@dpdk.org>,
<john.mcnamara@intel.com>, <ferruh.yigit@amd.com>,
<karen.kelly@intel.com>
Subject: Re: [PATCH] examples/l3fwd-power: fix to configure the uncore env
Date: Mon, 27 Nov 2023 16:54:03 +0000 [thread overview]
Message-ID: <ZWTJq-EcqUPTf45A@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <25240705.EfDdHjke4D@thomas>
On Thu, Nov 23, 2023 at 02:58:58AM +0100, Thomas Monjalon wrote:
> 26/10/2023 17:19, Sivaprasad Tummala:
> > Updated the l3fwd-power app to configure the uncore env before invoking
> > any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is
> > too late because other APIs already called.
>
> You are also updating the uncore API.
>
> > + if (env == RTE_UNCORE_PM_ENV_AUTO_DETECT)
> > + /* Currently only intel_uncore is supported. This will be
> > + * extended with auto-detection support for multiple uncore
> > + * implementations.
> > + */
> > + env = RTE_UNCORE_PM_ENV_INTEL_UNCORE;
>
> It looks like this patch does not make sense without AMD support.
>
This patch is fixing a regression introduced by an earlier patch in this
area (referenced in the fixes line). See bugzilla for more details on it[1]
This should go into 23.11 as, without it, what was working in earlier
releases no longer does so.
Thanks,
/Bruce
[1] https://bugs.dpdk.org/show_bug.cgi?id=1304
next prev parent reply other threads:[~2023-11-27 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 15:19 Sivaprasad Tummala
2023-10-27 12:36 ` Kelly, Karen
2023-10-27 12:37 ` Hunt, David
2023-11-27 21:19 ` Thomas Monjalon
2023-11-23 1:58 ` Thomas Monjalon
2023-11-23 10:26 ` Ferruh Yigit
2023-11-27 16:54 ` Bruce Richardson [this message]
2023-11-27 21:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWTJq-EcqUPTf45A@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=john.mcnamara@intel.com \
--cc=karen.kelly@intel.com \
--cc=sivaprasad.tummala@amd.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).