From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74DE2433E2; Mon, 27 Nov 2023 17:54:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2587240648; Mon, 27 Nov 2023 17:54:16 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 9D020402A3 for ; Mon, 27 Nov 2023 17:54:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701104054; x=1732640054; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=sTunhCuxwMhQoFvaQ+Gnu5bkbeWCtiHrCgeAl1c0scw=; b=mNU1SET2rYXVu+OVLJWam5MPj9teI3hW0eNvox/n9YrPWO8Z5CqPa/0T 7itxQKZ/5rZyWT2lOFOk5/0bt9pgRKuWBqT23z1YPRWgd4mGTzMEpzZMb IwYWaq6niVKxagvDoq3afiT5/dWoy3mZ4W84DCwuiYDtAHrm3dcIknlQh COB/sZX9Y5mtOXpdIXPrU41J7blpM+iws9XGCHCbXdqRXifzjCuOBY7iV x8H+RYrQiQomEM9V0+YGC9upF8m8GsLKHu1bt7Zj//XYSWel4+o+kPjsY /hbFXATMGyzTvV/11oMtokzrmWcaK9tKudDE8tBcRE2sDb7Ki/oReW9O5 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10907"; a="392491987" X-IronPort-AV: E=Sophos;i="6.04,231,1695711600"; d="scan'208";a="392491987" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2023 08:54:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10907"; a="771993104" X-IronPort-AV: E=Sophos;i="6.04,231,1695711600"; d="scan'208";a="771993104" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Nov 2023 08:54:13 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 27 Nov 2023 08:54:12 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 27 Nov 2023 08:54:12 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Mon, 27 Nov 2023 08:54:12 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 27 Nov 2023 08:54:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SLqgexxXyDoBCnXf7FJJJalfiZBgNQkEnsZA4c2Yc3UyD3K3HnVwEkngMAZnXTwTUwEx02ZVSSTFVclZXZsSAe85J20VdPamg5PnxKJfjUwWLGKTzwNL/q/Uszx/eglnk0SaLvvx7908uK9wxl+OpOO2EXL2Sf1lVktjOCflntKfSlmqg9UuvqyGX9IyM45ZalzBd7QrEGpejKyfd9lLvjfMFQfNuImiLExmzVuZJtTYSVHdmD6tYEgGXEE/OK+9OZqSNbgwcDJcyZlo18QWabxO6R1kBdQTDZgeULxilqUb7tPhHFhnLNgR6FjbVbLtynDyy3nlmM8RQoWrPAGo6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XUN8Pr/7jVHRe566ncU2pggYYv+YB9JDMzZ9CdOMK6U=; b=c+JER6+3SOwkKB32wLdPDEguiGh9mpDgupX82hL1fSeYeVC8itUJAe8/w4tDpfOw2lH6h9HCC+S2l2KSTg1cBliDZjAqRO6SJU/BQFpQEtUjMKP5t2eFClvbpQA5gLnFMbBaA4KbKxuyxluBr5wmpS8bIpAv3v5TB5D4x3dW5g99yvGEWmcw3u0hNqxRIj5EF4SRn3VwIocQ237bprWAmQdSnQtLlcGwm+9yUHc2dNZlvXKM80SWBK71Wc/OOxmt59BOLo/vDlc8frsnQTtnKqGpC4T6uss4fFhQytXUHLmLCUzZEYJsolMKX39BxxnI6BEXho9zC72b2fKV/Fb0XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB4946.namprd11.prod.outlook.com (2603:10b6:303:9e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29; Mon, 27 Nov 2023 16:54:10 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7025.022; Mon, 27 Nov 2023 16:54:10 +0000 Date: Mon, 27 Nov 2023 16:54:03 +0000 From: Bruce Richardson To: Thomas Monjalon CC: Sivaprasad Tummala , , , , , , , Subject: Re: [PATCH] examples/l3fwd-power: fix to configure the uncore env Message-ID: References: <20231026151959.1458112-1-sivaprasad.tummala@amd.com> <25240705.EfDdHjke4D@thomas> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <25240705.EfDdHjke4D@thomas> X-ClientProxiedBy: DUZPR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:10:46b::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB4946:EE_ X-MS-Office365-Filtering-Correlation-Id: 46d20384-1e58-42bb-ed72-08dbef6979e7 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z5Fz16v/tQ+7q/t0GnoUnKtRyw/xmRwHjX0asy73lpaNuNdT4h7ThYeInhBx8W6nDlqb7qUUmywbxS2t1P6M5jR9lxNG1+TPExCq48pG+HwX3k1tEGdqAaLb1w2KmJIW6i9w4bX5eY+gtfPtfGb1ZEvkXvVr1rA4Gl7wadmObW9k5xNCWCdBp0M4KPSoiltKPZn92BZ6ccxc028kHS3MNsyElyx2lh/05hYTAa0FOGiCaWKVCb5LiUiS5nWYwcaBqgvie4t+Ksu/1vP9kevLJi69NKeDFAr6m0OPP1Nn2tJZughXgAZDhVQjVKTJBwsAkT99wSeT9TTBsq3MbXTJb9odBpRyJfueUjfhz96Pc0EXtVZEu2stIAuRqMUcYGs622vZGLbJ8Pb//PMlpjYz0Hf/gdS5kpMBk14PH88wxmUEc6Ddu2C3PZsQyFhA5mxSweyH1dEPPkozp5rkdhXsEq9duC4XLMqeL8CaaVOqoT2cCF4pzCgHCU9zcJbU6vYWJvYawt7JfJYLT3FeuFfL9QrMZcGM2rlBoUME16r1WxU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(136003)(39860400002)(376002)(346002)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(6666004)(8936002)(8676002)(4326008)(6512007)(6506007)(66556008)(66476007)(66946007)(6916009)(316002)(966005)(6486002)(478600001)(4744005)(38100700002)(41300700001)(86362001)(107886003)(26005)(2906002)(44832011)(83380400001)(82960400001)(5660300002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M/q6kE+rMtX3LIDFV9vHISoLo6ho5ktuBj8M7Bbg4umTU+zP38s3zMTzs7NH?= =?us-ascii?Q?DLKRm3qsz5+HS/b/rJY8XfC6jZOlia0VWPde5kKkDZu8FOJm4cN4Sks8xKPr?= =?us-ascii?Q?oMBChJBeTNmETSpfhhMFZz6944P8xgJXssJlNW0qZry+G7sr7ftOqObFAjBQ?= =?us-ascii?Q?QIS6/BB23e0Nanq2w2M68LZnIgeYDeaqGT8rS/FRSVsQwcBZfpRLxuVygMod?= =?us-ascii?Q?KHAx3rovSMDBKxQtlUxLtbfqj7J6ctDdqA/lvTN1YlDOuxYGPIUgFSIFzURn?= =?us-ascii?Q?wlnzkP5zcdR1PZuW5g9h2JCrmrcQ35Qv3RmBvsFEOcIrF18u592P9kRBAg5J?= =?us-ascii?Q?1Y3iczmTI88KEf9jLRODgXWyuhS8LrTuTW6ioiJcTSp3U27FD08tDzydofSk?= =?us-ascii?Q?jKquxYp2DcWMR/9UbyjHJ6cwDjB+EUIO7nTn3O4QcOrWM6cB/E/0uuEjlVfQ?= =?us-ascii?Q?MuMIFMwrLmuaq0yAKBbPCZLEDol+hYCtpSGEnaqC9+6p9WC9sartbQUlI5MG?= =?us-ascii?Q?DowYWsidm3xFgYA8K/TZD2IzuuOrhejEMa/M5xWdhZzHWDvcaa0kcYT0ttwf?= =?us-ascii?Q?cj7bPG710wFRei992xh7kkHzFfWLzyAzNArL2MB5apXyOrDqUEzWOt8F2DPm?= =?us-ascii?Q?ns4ussErwCe5v5r3zF1qgaXv0UBVlY0T7XX5xwStSQrvHhCknXb+eYa6BDee?= =?us-ascii?Q?729W+iwEr2jyx6PIlEqcVNSjjYK+yV6xiO39OmbWpJ1IRkNKd6gaXrKAXdYE?= =?us-ascii?Q?jQBmOqSWuXwHqfyyr9XhizsSiemAB4vO+oFdXVw2y70KHQycrdZrQ9Rp9e1W?= =?us-ascii?Q?IkCMEWzFMN5mUZSfzV8luy7QUHJZwOszaWzJXEFqjsaRoJiM+8kl33h5PnsC?= =?us-ascii?Q?yLH8tgahE1QKI9Xwzke32JCqkJSUrCiO3petqSiMZ2F7yS9vKH8a8kxYE40f?= =?us-ascii?Q?143boRgDzpJvvacKo4nJQ9n/+Y3aKM9Yo6uVX406ZQal+gNUrggz4a6ZhIu4?= =?us-ascii?Q?1RjHAIrc1ZI0s8Fu/XDkRL4RFL8TIgxOsbw9Qy1VyxoHCERWoWROABqPXwSf?= =?us-ascii?Q?7ulkLKQg5pKQ/gy9gdtfXcczLTSAh7UN5n5zUlvFivxqhocf8nyUjOk3e0Wy?= =?us-ascii?Q?OjoLicgVgiqZSNJNQQDkpnj4XQ6w98gdfRUa646syJLRo4dCZIUen4aj+pQo?= =?us-ascii?Q?AupPMvTZ/x1LtVjhox+SUHvFzJiKsdmQYaFHYP0roXDfzyGeEX2J44AsfKgY?= =?us-ascii?Q?5acvv8o2ZVj7zE0Ve3c9U/JF+BONghPDw3voQaslHRZ9PGK7wjEb+jx6FUOG?= =?us-ascii?Q?qjJq69Lh/EuZDXhc7qEP+xC0lS2nv0IOB+HtAzJGz1aeo64DKyMPbudh1KNp?= =?us-ascii?Q?3z35GVq4fS/kJ205ioDdPmuv/TyqtiFLQZhNbfiuDYxu67GSKmsrOTRXBKXV?= =?us-ascii?Q?ME8Ta5z1fvjSpgAjVWaIGGbjeK7wn1yi1ENd2GoffT7qk26Jer4Ui+8KtvrQ?= =?us-ascii?Q?visNUl6ioVHSKX9flH8a/WjXLjxGP7VpM9ZPefVoRjV2cnCHqeMTP1zTCJAS?= =?us-ascii?Q?1rwyyzDmMizLl563I0bfsIGCQMFRI4au8MigN7sazxg51psKvS5XZtJbuOHP?= =?us-ascii?Q?uQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 46d20384-1e58-42bb-ed72-08dbef6979e7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 16:54:10.1113 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VK8/4DYVL2smCNaQx0dl0MZnTaxqvyLmlXzUJjJDa8OUHD6XX4ZgfdTKhTPa7WorJkn+0BeNzZvkKqdgLblC9GjRhtlW1tuE43wkOXWKl3I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4946 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 23, 2023 at 02:58:58AM +0100, Thomas Monjalon wrote: > 26/10/2023 17:19, Sivaprasad Tummala: > > Updated the l3fwd-power app to configure the uncore env before invoking > > any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is > > too late because other APIs already called. > > You are also updating the uncore API. > > > + if (env == RTE_UNCORE_PM_ENV_AUTO_DETECT) > > + /* Currently only intel_uncore is supported. This will be > > + * extended with auto-detection support for multiple uncore > > + * implementations. > > + */ > > + env = RTE_UNCORE_PM_ENV_INTEL_UNCORE; > > It looks like this patch does not make sense without AMD support. > This patch is fixing a regression introduced by an earlier patch in this area (referenced in the fixes line). See bugzilla for more details on it[1] This should go into 23.11 as, without it, what was working in earlier releases no longer does so. Thanks, /Bruce [1] https://bugs.dpdk.org/show_bug.cgi?id=1304