From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 500F04368A; Wed, 6 Dec 2023 14:22:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05A5742E7A; Wed, 6 Dec 2023 14:22:18 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id B800A42E79 for ; Wed, 6 Dec 2023 14:22:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701868935; x=1733404935; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=saIm2m2dYMzrmmwu9idsGnud42G7Nbxq7a5mC8GP4RU=; b=KiWAYLDZxW3AulvccMu94Zi91T3pPjpDvaBmPWweLuNZAkKU4qZUhqir +KfbT0vJ3aVMLLUpSsbBQrAIwaEgQUWElVlV8VsMn6xa19AJNsBZNSb9c xe3H4n6w50VG+9pXHEk4Rq70i2Chm/67OuGWG99mDaNqaLlJAcXkCDyib TyA79y/fiAFjSQqFe+ffuB8LQnW6AjTw4dfmsabJsGGyV17eQLhTbqrcQ cAjZLOxemviqyO3nITGpNRA9dgJ69YleafB3eZ+jYhwOV2lIfQJ3HdQp1 LvWrFyaQS7uhMiLYYHyZwYdIGLShTFre5TsB/HACNzHys5uW5MpbsFbLt w==; X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="374238189" X-IronPort-AV: E=Sophos;i="6.04,255,1695711600"; d="scan'208";a="374238189" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2023 05:22:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="862110013" X-IronPort-AV: E=Sophos;i="6.04,255,1695711600"; d="scan'208";a="862110013" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Dec 2023 05:22:03 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Dec 2023 05:22:03 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 6 Dec 2023 05:22:03 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 6 Dec 2023 05:22:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AkDR/OC3U4xglBGdHlZVi0zFGgXZX38cddX/mgU+k7a/lFjbQyAjFFmE+sSQmREggmik+1167BrpFiYRCZbSe+hIXwOavhOvqqAWiZojflWZgRZ2cRL7WNxsvRfWnjdFzb5R2U0+WXQ3x5dCZm3xmMx5s1i0lVtRd4R1IRrdpBmr28qJAjoFyOe3c/2dReWDOf36iHwHKqj2S5g+CgqISCRxal2HvdF1/W9yK/aWztvwXF69SSZ+nP2G06+w9MV4x1pUhZVg9S35DH1Yqh0gYiQbzlsM0pglELMMqIf+3sBxYaVM3L/PZBoK8+E8tM4yeWZlF2sQl+GS6M3h2WSPEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l4LGUoH9inxBMyNVvgzk/Nk55XzNe24JUIoMvqLxWQg=; b=j2fNOv7IcKRQaUnvnp15T5lRPky3RqOFnRcQJrgCnXyN9PSY2ztfSx4bxIn67W6bnu6gcQjP7fP/el8EfmCXMe7fw7Dmcsgztx7v3e45YT3tB0/Vp1kEDK1KBGUwQehxhh8wS8iNX/M6AtuGdbF7Tk2u9JiuaXYDziiAGn15AYFk3zDOAx5ARS/AN6qHBFNUhREWtx4AHoLentqfz2ABbxG5i9stqMSH5xH7AW93IgDOfeRM8wraKpK3b44cVbDA1mHBg7dy6aqQbJRF7aBwt+uHMUCgONpgvXOV/JRVUkRFaqxbv3xR/6SRTNuIwcBLRQIdaISDl61JNq4PJuUVPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB5167.namprd11.prod.outlook.com (2603:10b6:a03:2d9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Wed, 6 Dec 2023 13:22:00 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7046.034; Wed, 6 Dec 2023 13:21:59 +0000 Date: Wed, 6 Dec 2023 13:21:53 +0000 From: Bruce Richardson To: Vipin Varghese CC: , , Ferruh Yigit Subject: Re: [PATCH] cfgfile: increase value length Message-ID: References: <20231206112952.1588-1-vipin.varghese@amd.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231206112952.1588-1-vipin.varghese@amd.com> X-ClientProxiedBy: DUZPR01CA0285.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB5167:EE_ X-MS-Office365-Filtering-Correlation-Id: c50ee043-e3e7-4e57-1ee7-08dbf65e53a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: os57fIP7t5UbiyJ+77jRboj6m6//EGM0YlCoXSrXMr26XSZ/oOreARVvsbhTiiT9m0cxj67SULeYbdffccR6eNo9CGn+5+XMfn4+Ti6rK3cEFQqtq3IoYDllfBzFiTKZvPX4RC/e55JvMWrCAn8QkOqGXbfSe0VnX2WpIh+7Hc/i1TkKUwevM9O1K5Oqa3XrsNQFiacoj1207wtjTd0mAoPDGcNVniHP46T623jAyPkB9qKKGukjXPenUn9j9uwiaOES28Vh6pZB3M5vahZrLB3CaOBbEPr0eeY/SyFz0pxwbamDJsitweZ8Jl9yWd3iyV35rIW9EaBOsag06Zh+TDSOsoflP2xOrR5YSca5k0tJ9jKrpOcu82cjW5BvtvmOFex0EziEfNv3XUZzfeHq+AlZOvUdZiveJRjRWTm/0ahxY7HuLpdkzI0MitG2rOYIm2XrTn7UfJ9gO+p3G1tEazL4rWe8Jv7wBhyxhEzJ0P3E4dc870uaS4PmLl/2EZ+47dFNXAufbx9oY9zA18JLjMce1UKCY+NAuzvizkt6/nk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(346002)(136003)(376002)(39860400002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(26005)(6512007)(6666004)(6486002)(8936002)(6506007)(83380400001)(5660300002)(44832011)(2906002)(8676002)(41300700001)(478600001)(4326008)(66556008)(66946007)(66476007)(966005)(6916009)(316002)(82960400001)(86362001)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TEd9gPgCRSMz/1NAkE5oiGMy2yGsly4vlMleUUsNta9OYjvcvYw3B4010ErE?= =?us-ascii?Q?zcKOWTa98gkRFHw8der32+wLyfOypE/8fJTUSL6l561mnnm3a1MjW6TXipT6?= =?us-ascii?Q?FJe9RdDnK1Rd+SqZg36KQMkmx5WUqLUoldkKjX4lZevsxemepka081ying2j?= =?us-ascii?Q?0eVXciCH+lyQDjVYqWTdz2qrFba/U9bfr4UYVM4YbPdmh6x+rEva99ndbj/a?= =?us-ascii?Q?0oecDdmFID0hyShSQO38NMPBfHMbUVVrJIdxtmUJqBYfxLuJ44CNIHNq7uyC?= =?us-ascii?Q?HlTkj8tZSOpDdX0qW3bW00cSMEbUMnI/69P1HmRiZCyMgM2EQwzCFNErAtxp?= =?us-ascii?Q?R4usGYYOXAwcdd+gqOiL0xmvUhkvyqffTQMBA7aQnLbTagQ02JbN8ZvtyTdM?= =?us-ascii?Q?uwjzuhX0Qhngh5qFmhWA/hBkU+yjSdDM/pXfuAK/i0esfEZUSo7MJvqY/zaV?= =?us-ascii?Q?8xZ8XqGOaY0P1RI613nTSZ2blFOcV1EPD48CfoC23puGR4/mWlSAbjoOYEGA?= =?us-ascii?Q?1/8PPuBdXZKuqdvbbqcXNmHNfKAbVMeCC7bj0cWZfhCAtf8+aeshywSA2coh?= =?us-ascii?Q?Ku+qYKgmFnMZ8i7Oo+2Q3WbbxyXAIyXu/4GOiJ/z7mYa+1cD85K3/SQqmvfz?= =?us-ascii?Q?muk80adrjjNY44X/DZ2t9IaH8bdK9kEBu7ARijdGC2XDuNUmpkEvTRKfAYd1?= =?us-ascii?Q?VnzJMWcJOzpLR4u4D/EcGk23Jc2INRoO1TBkv8MXv+cT0PWLWAz/IIsWyPXM?= =?us-ascii?Q?VAxE+kFDO/5HYGlI+6Oe4hQsbAsgUKZvo+6gegIyfWb0nxZetrbf+npTi3Ad?= =?us-ascii?Q?GokaJ+u0XZb8NtaGUKEw+wnezUOQDnoymaRKf/m6hq4IdsiJvGhCyls2lfrg?= =?us-ascii?Q?mO+HZQzOZ3ynct0kdDfFgUtdrVYB3j/QXJGuhbcfJvXyMIzAcFJLKPsmlFT8?= =?us-ascii?Q?GLO7K/xS9E6uArThciLByHgA8swdSQFR9sRF1F/RRz2qS6xaTu2N/mriiObR?= =?us-ascii?Q?s2EYrpNUaVCAQp6z/U5xW8xzt8WdGIclesVj4/9eGUFtsryZabQu9MC3dfs7?= =?us-ascii?Q?sKIaQkvEFzxMTRQAj7NpaddZiJb/NnaGI+Pk+nROowpUMpU0shIgDioe4mEP?= =?us-ascii?Q?O9e6BfRvSozxwgASa4mJeHb/nlvfdYPp3c3jctYhZNrqhvMuVk3A0zBqhD6c?= =?us-ascii?Q?paRLSb5UxcsSmXjwAAAcH68HqyzKoqzScsoxw6x3yvyyoU5wjHRCGnrKsNDo?= =?us-ascii?Q?l5G3fZ5NU653zt0cgjVj+fmHq0fQp+47p7roTUcBzvV8NGUZAWd5PKookjQF?= =?us-ascii?Q?jzOaDn3XL9Iy5d9+LhFfEo8bPEzgu1qUW4gRYT1yGjNxrDOskPGsdBAWLBW9?= =?us-ascii?Q?TORs7V6Ds6NRCNWiGd62aeUllwLKB/3iXG1FIjnElciPmROwjQQqMEdeJHcB?= =?us-ascii?Q?ca4XlLQ9eyrXcwnSLqQJWq8gWyXAx+E8TpPzZOyJcmqraRaPCsxFiGNq3vrm?= =?us-ascii?Q?/sDvoq0TMjlp4opnT82kfPq5oZSHQZdJriAbZkBHNYdBjrY/xDRcWCREWIJl?= =?us-ascii?Q?vPO9n2dW7PQo+JPiaH9kBVUWQNqAkUIz4Sr9puMK562xHNlGryhlXWkf8Cfy?= =?us-ascii?Q?6A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c50ee043-e3e7-4e57-1ee7-08dbf65e53a1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 13:21:59.5601 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: drKL/psyB2TXcdf+3GheAq5uz3d4T4GmC4ItvErDR9O9m6jNRwtl4qbIEMiw8pcFY7orcJV9O7vUF1X/KvIU4Tc3EnUdrYxcw4JqO7uVyTU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5167 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 06, 2023 at 04:59:52PM +0530, Vipin Varghese wrote: > The default value for CFG_VALUE_LEN is set to 256 characters. > This limits the parsing for longer strings in configuration file. > Setting the default to 2048 characters increases the value array > size in `struct rte_cfgfile_entry`. > > Files using cfgfile library are > 1. drivers/net/mvpp2/ > 2. app/test-dma-perf/ > 3. app/test/ > 4. examples/qos_sched/ > > The structure `rte_cfgfile_entry` is not included in DPDK libraries. > Modifying from 256 to 2048 allows `app/test-dma-perf/main.c` helps to > parse longer string as shared in https://bugs.dpdk.org/show_bug.cgi?id=1333 > > Signed-off-by: Vipin Varghese > Suggested-by: Ferruh Yigit > --- > lib/cfgfile/rte_cfgfile.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/cfgfile/rte_cfgfile.h b/lib/cfgfile/rte_cfgfile.h > index 232c65c77b..401353c44e 100644 > --- a/lib/cfgfile/rte_cfgfile.h > +++ b/lib/cfgfile/rte_cfgfile.h > @@ -24,7 +24,7 @@ extern "C" { > #endif > > #ifndef CFG_VALUE_LEN > -#define CFG_VALUE_LEN 256 > +#define CFG_VALUE_LEN 2048 > #endif > An increase seems ok to me, but is an 8x increase really necessary? If lines in the config files are over 1k in size, then it implies that some other mechanism would surely be better for configuration. Can we make do with an increase to 512 only? /Bruce