From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3601B43747; Tue, 19 Dec 2023 18:36:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B447D42E11; Tue, 19 Dec 2023 18:36:17 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id CCFF242DED for ; Tue, 19 Dec 2023 18:36:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703007376; x=1734543376; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=/UaZPx1hEePCO8/dd3r/rk1jwu5Yalqye6MSpvxthJ4=; b=MDPPR1ACvCnvfXQKZ0ulwBWypT/REPsy+JZlIe8wPxm16LQuCs7dhpRO wcqofJZHeJYsbJ9ghuov7G00zBSPMj4oGwG9/pC36INzSw+a0M+gmTAgc xgzlvKuTRQGxMO4iZbRy7SytAh2PV1gQhAi1/7ybmd/Wj9fxXVnDxvQx/ jfoIkv5liATzfjiTieZ/WGStvu7GLygb4FbGPMcFeG50EWTysGwn1sjPM +ZS1yxoEnKd23pPnhBJzn6S0OKeuUNA16p9Me8gLHlYEbTFTS+5djw4EH opKjTdKlw+EWvKEOTB2L6zqHYnuxvqLKYAfza4Sou/RikMRmYIzedzVIW Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10929"; a="392864361" X-IronPort-AV: E=Sophos;i="6.04,288,1695711600"; d="scan'208";a="392864361" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2023 09:36:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10929"; a="846414759" X-IronPort-AV: E=Sophos;i="6.04,288,1695711600"; d="scan'208";a="846414759" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Dec 2023 09:36:14 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 19 Dec 2023 09:36:13 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 19 Dec 2023 09:36:13 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 19 Dec 2023 09:36:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z6JauIo77D72QKyeHbULU/+twqbjhyN+1Z/TJ8PVgDtjqnmSn0AIB9v1Y+CsgI3NoUWRVq/wd9sjlKT7S9R9JWKo/+zZxbtYmgnXeDJFjubyN1QP0d6JTdMRGnUHR1KKPn+bDGaonpwX1UOPMd89ktend5CPAzy3zqWu28DiNe2SmA8T2wL4QrrIHKXWCbg+KyG679c+G+tDAGEyJwW+yhOT5B0Om+q/RnbE2LNWPugL8Ji92778y1/bZK2UbuAY1tHM3bSYJVVQiSV74BGNAPDG39He7TeECQokDNnCNT+o+uq9LyIY9Ae3QL2GaqKP+mnZgfMKApUW+tmJBvsttg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VMe3OGZu9hF5L47FqDGpOO2Q41WM875DRDhoBEQgfAs=; b=axFfOOUtG7GNI3WVCKoPvG6DlOjdwEaFM00bY/IWL7D2S8rq39vYdV0s9wzo5u2acGipQayfwEzZzM7DBgRuL/ouBo8TKdjMCtPpFQTN5r735YxpnaOI9Cr5tI1+5pBxGBDgXEf7pMGTQQ68ZyH639pnxs3XPV+qBfZ1YtLGMLy/lO+gvVEfYMUMfGwAKYukGcbgwf/tcglVJrXAPl9dqdeeRWuMzamILKZhS1Lxx3nqPweqJlMRYYjeH39vNPyZkU06gsafg7Yyf+D47eGr8txntF10SbogtExZQisIoQFZLvZpNmBK9LaUgLZXF4A+D3+7kfzs0yWTMlqNptn9TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW6PR11MB8365.namprd11.prod.outlook.com (2603:10b6:303:240::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Tue, 19 Dec 2023 17:36:11 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7113.016; Tue, 19 Dec 2023 17:36:10 +0000 Date: Tue, 19 Dec 2023 17:36:06 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: Subject: Re: [PATCH 0/2] remove __typeof__ from expansion of per lcore macros Message-ID: References: <1703006864-27378-1-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1703006864-27378-1-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DUZPR01CA0264.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::20) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW6PR11MB8365:EE_ X-MS-Office365-Filtering-Correlation-Id: ceb385db-9775-438d-52f4-08dc00b8fd6e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: th6H+mxLPHBV1MR24qLmq/oPDnOfDuVc8z4nKVY3GF7ng7nu1w70QHTWvxt0xD16Ipo6NQJXedMGNvWY+LWjUo9b1K7zmv9dDmSrkX117CfsgHaAYY60WKISMjiROp5yowHS245HpZnp4A8j/BxBFWm+tei2LG+06xQms6g5J4ZbGSwOsIC2yOyumr4OpRMfm2NtmIbT8LOSHHS1HZd/wUgNUGYonvL48cabzOJMlOCmSvIxi3mPViIcNO7SSHIbl+iUlAdNSp4cHLV/KPo8uvM/D//5BLkf/9b13su4Ugg6bGdeiKZYyEV3rVWsCwdxHPhoa6yDq/AlBY7wwvx020vEhZnI5qgjBYrfsH6pgOI2akTgjGkpnQOffwpXDLMdOt/Pezla/Gh2fJF3KiLAiIPZihz6Gj5tRV9apNy1ppHOzrUrzHA1gvyp+Sxm6xlmJDKEjgvCx0ZysUJ4Zkzp7ll1WhgUF4d4a8ll1Of0S65selIDr9swHZjDSj/SpAENLF/eDWcCpr/IpwY9Y6rCEt9x9ZmZK1PNI4bqHlMJ9INncXW4mPsD7WKpbv/UCF56 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(366004)(39860400002)(136003)(346002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(86362001)(6666004)(66476007)(6512007)(6506007)(66946007)(6486002)(82960400001)(6916009)(66556008)(38100700002)(26005)(5660300002)(83380400001)(41300700001)(316002)(2906002)(8676002)(478600001)(44832011)(8936002)(4744005)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lVlrhZla/aowxDqDcsN8dmMCY8u6P/GeX/XJ23EStDlm6helpQT1GOCr93I6?= =?us-ascii?Q?QHCJZxA6WYaxaz1/ml9XO66+li1RhJbcYdHTFi/5jyemTnsAJI8Y9OifDZLF?= =?us-ascii?Q?FrM6SX1bqKyDihFS+e8xZDFlIF77NPP0YwUiaiF46kT9L5LD+a00hVNE2pua?= =?us-ascii?Q?XHwQJE3n9eZlTqngpVG+WPRMdyCsCpAJ/MGIf9Z8pOkSs2nw2t+VzEZk9/Ci?= =?us-ascii?Q?Hd0Dpvaeo8a3i6viShShk590q8BuEZJ6A10XtcxRHyP7MLk43x+XkaxoV6GV?= =?us-ascii?Q?OXSyChy7QDfDkgQK3hHkiXMorYpSxSDVUMjeM71bz9CDs3lUNo6iTT688xWF?= =?us-ascii?Q?QQ+gCoq2dvAIG+oyZf1FTqS9GyByyxsJ1dg7Hl6nax+pI8vnuI41ek1Pap/r?= =?us-ascii?Q?NazZlecSx8sQWhcs+1Rc68mtwyX7QbncmzQGq5kS1odeorZNrTPXb/+8jGfH?= =?us-ascii?Q?gUrTfKFUKXGgdX2giV14+8zi4RjeAkpYKFZ2zi7IL7VAyQ8yTGGLWsJPZSCu?= =?us-ascii?Q?KeCgQ4wXvsrjvS7HFv3WExEgJ0F/rnEPFv6JiAqPvVUx1xTxB9O8Suf+MTYw?= =?us-ascii?Q?Chab6rf4Ks5crSx9MAFaC0uy0LeBOVlWvSFs8Sp3Kt6jJWrZwy4/Gd23lw1T?= =?us-ascii?Q?Uxs1hXnWsdM3Ylxola/TOsYzVqUjwkCtfXum9ouma8+QA7Vi+Vkvs6XoHQDS?= =?us-ascii?Q?0quXVN/h0cGEMuNGdFq3s/egcUtnaqYhERkvjGfWhSfPl8oRQLifnN2xdHBY?= =?us-ascii?Q?5UYjCBbFF4KfU9MUEd3uarcqJJH9LhlW82UVoTRchh5f9cixIJvQuaPwrcls?= =?us-ascii?Q?OMmoneODqx+oyXbqOkfHNtWIAkYtYtUsI+npIpa35QXwd445zVKw+Z060eaN?= =?us-ascii?Q?8ST2Qr1exFoQhKhlP0JyawhOTwUf2xigeH8KPM18IwKV3kfSAsZUP2zAvH7i?= =?us-ascii?Q?4b/htp5IQXpkpjOTse1rLRbd4ye2X5z1MTfiCFMT535/jy69YJCA52eYXIhd?= =?us-ascii?Q?mVf0FMokVdsw5HiM6ZAdB5XI43b5xtCLAr/ufS5gaLspVWXAI2fw5nB8kAZ3?= =?us-ascii?Q?VPTUswLMtY62uBd/vC5MTH6NOdFQZX3FlZoEJRH/s1Lc4y1cCH4ZGRAGuJ54?= =?us-ascii?Q?UaN7UmFDLzUvcnp15dbAtJC+gKA2vpyxHwdXY+70uUlf6MNSlmRYmF1JK8Qa?= =?us-ascii?Q?SM0EwvmK4M3/tsLGLdiPRQOvTiHmkaSKGB56BkmglZurQ7YLHAWbL1+Qf1t0?= =?us-ascii?Q?ZjBh8iMQD41sdCkNZXJlpCBvI6/uLdqQeGF6uwW7WfxXpGM//DB3hblOr8Se?= =?us-ascii?Q?wnBm4p8/Eu+pYYxcmSuWpT1CeEw6aJ8F7hrVKhum/NwsKJY/mcvc6k5h7voy?= =?us-ascii?Q?Edc8EEnMFUPAQnoh375YoGgWIBNjS1/GyVr50HQznm+obDzaf5T990Ci0vyj?= =?us-ascii?Q?yvR6dPc01qXUkmTgq6bHtdD62JvHzwlLhmrO2mdbPim/7dlqkFxo6RQPP3Cg?= =?us-ascii?Q?eO1MkLdn8pGjrOKfH3KEzwQQLCwPWADiJUUxtXr0JUjn6ZsZp2f0f2zhm9Vl?= =?us-ascii?Q?tTxtbvYoFK01M9PhhmkE+84zZvjNyprRFyZVkx8OvBwPQbHuseRtVD48+u3w?= =?us-ascii?Q?uA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ceb385db-9775-438d-52f4-08dc00b8fd6e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 17:36:10.6788 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wMvy5kwe7zZ49esXoDlmiRVATOdIybqvNpTXlTm0YlvUB7fthM7yokjwp+tSSGjggzRttdlkJyp9XUGlKEP6p+Ie+4yrBxrVfW2ER6NvWy0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8365 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 19, 2023 at 09:27:42AM -0800, Tyler Retzlaff wrote: > The design of the macros requires a type to be provided to the macro. > > By expanding the type parameter inside of typeof it also inadvertently > allows an expression to be used which appears not to have been intended > after evaluating the parameter name and existing macro use. > > Technically this is an API break but only for applications that were > using these macros outside of the original design intent. > > Tyler Retzlaff (2): > eal: provide type instead of expression to per lcore macro > eal: remove typeof from per lcore macros > Series-acked-by: Bruce Richardson