From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3329543750; Thu, 21 Dec 2023 14:19:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2F6240395; Thu, 21 Dec 2023 14:19:21 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id A23D2402BD for ; Thu, 21 Dec 2023 14:19:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703164760; x=1734700760; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=3qGjYU9z6gzHlUFsx2Jt5oT4ynI3+Ip42pXQLM4pjZU=; b=YjdtCfKlELB03svlbmjX5Z/B8ScvaAcGsgA4u11PERjqHKK0lgUBfr/k QuvsSp9nIBnuumK5PUK2UgAmTmKxBxhIz8hYHA7qkkvi3aojK7rYFltGq 4DWfUB9AKSL6kB4RAR5s+YX432ANodhRE2Lt/z9XJBCvgGSl7N85opss3 zwLgvAQJuZ+tCOBXBQiC/eH55Lq8p4HzVkG+C1/EvqRijMUqdbPHm+xHN 2/LntZKZK5Pzzl41I+sWqG8RrshLXjj8SupYLAFUeTg7hdDOW39TunvMp kKhpPt9IFTgQPL01tefy+e2sbdRgO/729PXLB9YWVmCT78TDKf1ehEpz9 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="375460389" X-IronPort-AV: E=Sophos;i="6.04,293,1695711600"; d="scan'208";a="375460389" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2023 05:19:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="920323884" X-IronPort-AV: E=Sophos;i="6.04,293,1695711600"; d="scan'208";a="920323884" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Dec 2023 05:19:19 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 21 Dec 2023 05:19:18 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 21 Dec 2023 05:19:18 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Dec 2023 05:19:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DuR80xbyI7kH+e06+cGtYIXIImKeRVLF4/oOzIyMKLqrdwQwIEOb3UvzMKxVhdilzK98BnoEKUNGDoqKogVbFxmnd0Jgv0V8VWctktiZnCtBmPsLUpaT9IeQmzy5XVR6S35SJ5ssLSv7C9VIs1d2w1B7/IpVv1q9rLkWXgWMGJiKib4MB6X/9NWEkDsXGndp9/2w+7NxrjkHq+sO7DOjJfMzDFECqH5yWHUSyJ6ijIwrckK1TMT2beg2NbmUWiYItV+mdsZnD1Y3uzUurGkvieLd6FTyTKpyjaLgLnZ4CBTL9jsDe+gTZX4S+WKnTrTVBAX1mICMlHJwatXvu4folw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QU5/0CYy95ugYf3BRh7aIvyUEroNXFFGIeN+3SrrcWg=; b=a5gZItHgXuzWxsEZhirFFJ/h4EAQB95Q7OHPjnOKdy3Sp/1TIomch7rMuQ79lJFuTtlUds58n3Zx1wVR9mX/FWgRwk0PlMdwYRnfFpGb6W+tnK8vckEVgI4mFigW/OF9D6u5WFWXWO9uW2wgEmDHuNFgHSSLz0Dmd2iJ5IrE6LvRj15oOBVTT30ufKEleSNoKNr1m6uDD4+iBBjepquQQW+rXiyte1WsjvJdT9vttwgpjYxvCby0/mfnH2X0m8asH+lFjHyc3KLnqtFXzhW9Zwzgi4g62//efjQ311vf+VfZ5QGXZGlCNqWXX+pez0AP7LUU9m2eVi53bUWOCHqOrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS7PR11MB7784.namprd11.prod.outlook.com (2603:10b6:8:e1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Thu, 21 Dec 2023 13:19:15 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7113.016; Thu, 21 Dec 2023 13:19:15 +0000 Date: Thu, 21 Dec 2023 13:19:09 +0000 From: Bruce Richardson To: Brian Dooley CC: Kai Ji , , Subject: Re: [PATCH v1] common/qat: option to disable asym driver Message-ID: References: <20231221122302.2834184-1-brian.dooley@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231221122302.2834184-1-brian.dooley@intel.com> X-ClientProxiedBy: DUZP191CA0037.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f8::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS7PR11MB7784:EE_ X-MS-Office365-Filtering-Correlation-Id: 04ad57f2-6cd3-4ff2-3b3b-08dc02276e39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EfA7z3YZdZkNwd0dQ6RsMPhNG30TyE39vZO3pKjggZCJGD5DjevLQAwwr7fAsYCqKqIcEsOwEZevraRHhdeZnlZ2SMsBxU9/jMwjjVtI+k4H+s7Oujq8ZsMwemYxTEkwmtMhjNIpO6EGnZoY4M9NPZHWgNDQOP/6JdP6D62CkCKlrGiaCZxaIejFqzfUgemcRNsl0tt677KC90OTyWQ7gY9UnEtqxqaRUJYCOj837wZiK9qV6XVqKgQXAUkydUhX/hstAL9rsQJRxmJOba/XxvB7CWjXfWuI8UZqpm1WtI1aZ+3fchIB/63F2fODeXE40mDLKcQRdpmubafyynZOSxSu2L1K7CiqaUqhzLenON4zQiBNMWnaN/cZnvbHgh8ueduDn0YnAe6hrd7TXFrNbxQTFdenS9jGeoMZMhMDTd3p+eDV2+u65k6CHcIs0LYp361M2sp6Oafcf23PELtM6whEXeu48KpZv1TjzpqssyQxOWU+qWJz7SvR7xHWaI/TjkSq2RRC4Q9xOKrSfjdEnwspSgZBwkifOuDluKW/eMegJEdacJF0NeKLJl9qLHwj X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(366004)(39860400002)(136003)(346002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(6666004)(26005)(6506007)(6512007)(82960400001)(8936002)(38100700002)(2906002)(86362001)(6486002)(478600001)(8676002)(4326008)(41300700001)(4744005)(83380400001)(66476007)(6862004)(44832011)(316002)(66946007)(5660300002)(6636002)(66556008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C2L0BkJkEC/Ag/AoYh2daBH0pWaNHjzxG93PPHKaFWc2zqphmtbdDxVC4eGT?= =?us-ascii?Q?2Doan3un8ygRKVmrXW6GlS5NhqHko3tDJoEiKmrSFN51QtgHpnFcanzMGWLE?= =?us-ascii?Q?QOwLXWr7B2W5EfMmUSH2A8twTTiEfN1d0IZ7jTjx/b0dCSEt199EH76QevOq?= =?us-ascii?Q?FElzbxjas97R629zlslQQOzDBK3c6S8lvSFyUfTRSlYDNhdFVmfsOxi6JWdG?= =?us-ascii?Q?3qp3yiNx0EullhozngKlwdMGCDljEURWvaGAWFZ4wwlaSSv6rK8VWnneN8gd?= =?us-ascii?Q?GnfI3A9iZilJJFqVZKXlBYxT71i/G2wGQCjF6unowhQivJsJ6BVIX0HOvaXq?= =?us-ascii?Q?J43ECBAHkqXViC0q7LsRL6LVcn+u1JVdTcbNDVEv3UFIANa5NBnEG2ugUIDz?= =?us-ascii?Q?+Yx72Q8lYUhRBYKh3TkIeq9Nw9vRh6DE9Xm3ZPzOiOrR+7uAYhfQ0woRJrcF?= =?us-ascii?Q?VY64Y8CE454CZ8NqOLjJCl49t55Br4c28GJryOjKRCQfq3jaFwurvV71HSXd?= =?us-ascii?Q?BSUqR4UO8VhlPRyu7h3k0b+xRn2NqIMtn5HVrLUmXK4X2M0QDnZTN3aHMO40?= =?us-ascii?Q?+TLoAePAW0MfpxEfze79mYCr3F9oX3Tm2b/NT7IbN1TvPzO4yiM6ZVopdqa9?= =?us-ascii?Q?vl3iBahfr3W5NvjTE6NDZi/3beqpIc+DIKCsdRAUnFMq9fQVaJrWP3RN6vdE?= =?us-ascii?Q?FbvuUnEIvfu5ue3mrNAsu+QTbNiylfsap9f8mH5YpqI2gSCU6UDBifLWBv+M?= =?us-ascii?Q?eTzXAaUr1goDoVZa2Tma7WPc9mtVakjbtUgJAo2/x8K/5rzPsID5IlrUGEi6?= =?us-ascii?Q?/eJn2DA0nntlf7XHdeJth6vL4f94pWy6X95eGlgr7KSJhPt0IdyoetqhQQdJ?= =?us-ascii?Q?tcbvBTOtTsgQtGH0Lln/DWvk2YMN/UXjpUTzKeOJ/MB7FxeTZxfNk7OkvODS?= =?us-ascii?Q?ArCtQR4npmWgMSl0ktCQ26/AfXt1oRKdFGHTBhujvdfgcoUWvuTOZeRtLDwe?= =?us-ascii?Q?3wfRwey7Xbsj9H1um2twX69nZHLxFM8pIRUvJBrYYEmlRm8E8ezLygL3knEq?= =?us-ascii?Q?QKNMzx3OTvXgiwo0uUf1MXS97NGn1Ff/PaLOP2HXJSYQTTHb7EKQ3MAVq0FS?= =?us-ascii?Q?Iehz0mmazBUucZquJhXyAWqz2GJQrj49Y415TI4hNXJAEUC7X7GMTYSW19Y1?= =?us-ascii?Q?JlmyqgEH98GrT0pBzx6urFIrCH4fXdk3md9JIWBIXVHriTd45Wyk6YaahRVJ?= =?us-ascii?Q?3sPLY3v4CXVkCjV+zuyiBYHTeKHu6/zb16jJMJBtZ5nCFlJrrqLAkK3fJQyr?= =?us-ascii?Q?52VA9LyAD0MBD68qvHBX7AfOwbY9azLq+Kw/c9Zrch2DQeIe5fFU7SrT5Hx9?= =?us-ascii?Q?FLK4OrjJ7OKTK+nZGvKOQHmk2MSEP+oCiYGAVHoiNYQE+ptTGe2v07j6ZtQ7?= =?us-ascii?Q?MtT81uSIZvpmmPGF2ljntLXaVBV55MAjxggTbBymWtu69c0oBFI4RRKwR9sQ?= =?us-ascii?Q?rn/WSzz7q9woVI7JBVpwXGm0PaIFgo8TPiIsAe4vguIVhIyp5KCuk6VI7DIT?= =?us-ascii?Q?p2ZzoIDUkz3RurzsWJz0Zvo5zFSqTduFJ7aIDd5TufR3FudggPeCPZd3g3bP?= =?us-ascii?Q?9Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 04ad57f2-6cd3-4ff2-3b3b-08dc02276e39 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 13:19:15.6982 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v7y0PUQ1PF6l1agQuNuki+QwvRqLTzbO0yL+WYhK2fc8XHZsru3XZlGctjZG8MaapQjxhCA72LCvSuq0X/AnRN10grA2LJpS2mhxEmKAKuw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7784 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 21, 2023 at 12:23:02PM +0000, Brian Dooley wrote: > Currently the QAT sym and asym drivers can only be disabled together > when building. Add an option to disable the QAT asym driver. > > Signed-off-by: Brian Dooley Hi Brian, Couple of questions that aren't clear to me from this patch: * why might someone want to do that? * are there plans to also allow disabling the "sym" part of the driver This is a non-standard way of disabling part of a driver, so it would need to be documented somewhere, as it's not going to be discovered otherwise by users. The disable_driver option is designed to take filesystem paths, and there isn't a separate path for the asym and sym driver parts. /Bruce