From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A5344375D; Fri, 22 Dec 2023 10:09:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB6E94025D; Fri, 22 Dec 2023 10:09:10 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 00E8E4003C for ; Fri, 22 Dec 2023 10:09:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703236150; x=1734772150; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=EsO/dnlUU24fpIMLFKUFUbCrerGNLJYnoosZwNwPDKw=; b=bD9SCi6gAIrqtzyfeVFczJC7CwYnpMeQoaVMEFoQY8IoSSOny8G/obGl 3NatxEpK+8pOVmfHsMRfUPkv6+smnlpt0+QcFUqVz3QHSfo6ESUt3Evml i5DW3byCKfWustJkzkXtAHCTmHG3SrWn414RWLQ1/HqG41u2OuKQRcAKv yHMFf0adMtD/kFA8DDFTBE2sgoNTchNzTv6d79Tm/2FZob9xnN3IryTvJ z3VJ3RlULuPF0sPmmkUrAItgB4eM9V3lG/WVthpS6KoUR9zLbLe0mnHjK TdS+FtTEwz7PBjz2Hyh25Fq/YH4km773RPB6L6lwggSDv0mdQbVutdhkb w==; X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="9491322" X-IronPort-AV: E=Sophos;i="6.04,294,1695711600"; d="scan'208";a="9491322" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2023 01:09:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="805892432" X-IronPort-AV: E=Sophos;i="6.04,294,1695711600"; d="scan'208";a="805892432" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Dec 2023 01:09:06 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 22 Dec 2023 01:09:06 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 22 Dec 2023 01:09:06 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 22 Dec 2023 01:09:06 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 22 Dec 2023 01:09:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h8wTwOcdhxI7VQ2awaJMx1M/aIGowAMllK4VYTq6DAcNSgYsQn+MOHJnGl/yRBJsf0QAOSWwja8Ec1gfoGwYVlXVDAsaXmkUJEQkNKsybLFpWLofEUwJtWCrj+OxlRRHcNFtReq6rw7USe8fhB/83T3WJAl7cMB1kICz2w1V1zw5/w+5OEZFLqZz71Lu36f2T1vzeM42WRwRAnmCfX81sKmzBTC7oBccIMLqxKvXFty3pyz0xSuVXeuRm9RJqlYXFmgeWBZu948EeKEm9XtDJpLv+e2SRFmC3Q1wuOVaMVST+OatJi+BWl0ihfxR7mK8ZtoWdjSsKLiXbFbSrEDy4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=isVTDgE3/aIBUtrVIgYySh3Kyx4l5dziRXG92RvmVUQ=; b=V99Haqt3xh3PJv6s6r8X+DrDL2gMsF8zHEqPxF7XzB+aiYqgSOYgiKpTwccyF3J7NFKc3zkHwFaVS62djlrlQ3UyElIRsJZWbWq3Csz0TJoqwqvq6D/D6S+79cimsedxEqTLfYRaRpaUSZAd9UU3Mjp7KpdmeG1s8dMm54hoE+NFCeY3B6RLidIsfVIJLln2j5xAMv3ALCPNh8wP2nJ5zCZ0f3CHyHqk5wPaB9lFC4sKP3aG+OTKDhfsje9VmIvW+nja9z66UqWMBWQnR1ec09kpkVz21FsZWTl5wf9O5Jjo2zF5c8T01ghMhLqxt8RiY/ezv2CTfACgBym82AaLUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CYYPR11MB8408.namprd11.prod.outlook.com (2603:10b6:930:b9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Fri, 22 Dec 2023 09:09:04 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7113.019; Fri, 22 Dec 2023 09:09:03 +0000 Date: Fri, 22 Dec 2023 09:08:59 +0000 From: Bruce Richardson To: Euan Bourke CC: , Konstantin Ananyev , "Radu Nicolau" , Akhil Goyal Subject: Re: [PATCH v3 2/2] ip_frag: updated name for IP frag max frag define Message-ID: References: <20231221113242.3351356-1-euan.bourke@intel.com> <20231221174140.3369894-1-euan.bourke@intel.com> <20231221174140.3369894-2-euan.bourke@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231221174140.3369894-2-euan.bourke@intel.com> X-ClientProxiedBy: DB8PR09CA0004.eurprd09.prod.outlook.com (2603:10a6:10:a0::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CYYPR11MB8408:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b793c52-9fe2-4d48-3cd4-08dc02cda4be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c8ouM6kFtQ7qEPgaYsL/t/E9b5xPIMKkY2APNpgBDMgrMCBL3zGMl7wN5o47Rm2i5Qd0fpyrot3pnSoKDprLORuPZ3s8S832GFx4uh3yA9c4yJTd/Poop3By8T0riDyxVR54GQYvMOHdjASpTSaIP6gQcORfad+9CUSYCKBbxQikHeRDcKr+2x4K9sw1x1An29yarPqVj0QSDGndQEkPUCNZkQBehpe94NBB2camtVTWzWur7cI8InOhwainfHYb6pxec66QCOD9fZOUahOZqC+fZ/eyrSUEy7r7FpOHN010/Ioqe8YwPJtI6dX418A9CrYv5QhT5WD626yZY2zpC0AtJ1NywZpw+zvmZ1jiXVu9XradqUQKFj2q5zLMZQzf58DtFCp0g3HglBPefAku5WKdGzY+WdkMSNUKwZlzSf+fA8mVov++JSQrz8R+fp5pmw39eF++RUCdZMKKvomdlqSJUFhnOmHgfshsRYcmcTepai5JO2rEqVDs3Z/ohxhXqTZTAriQV2jL/As5WPZHbR6W6bFMN/5L7166yShhdUF5JragJpm2OLA42D3iSMyy0HgyP5qMhH+g7fSc6W/mx+9JQ5ga14XLC31QbnRPfZcuzHloRmsv62/Rr1YJLi+r X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(136003)(346002)(396003)(376002)(230173577357003)(230922051799003)(230273577357003)(64100799003)(186009)(451199024)(1800799012)(8936002)(8676002)(6636002)(5660300002)(82960400001)(66946007)(66476007)(66556008)(54906003)(316002)(26005)(83380400001)(15650500001)(6486002)(38100700002)(478600001)(6862004)(4326008)(44832011)(2906002)(6506007)(6512007)(6666004)(41300700001)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nz1ras6EJTmH0c7ZoCcFFPq6c4O0+ewLCowy9ZI07CL/bxDg6/+B84KFkFh1?= =?us-ascii?Q?txIz+y+XrDtYhllbJMyO+Vss5AbeV4Ie+n1gpttaNJ+pKBU6twPI98LPYK9V?= =?us-ascii?Q?OiKZl32ROoqdQjLsd62Sl4e+7fLhBpmgYbEqrxeHYKX9oGqce1IOnZPqjeH/?= =?us-ascii?Q?WECUB4NqL3ixkTaItdo2CJsndjMSKIN7sPhOEiCt9D0Ed84I0svr1kvHa5Oe?= =?us-ascii?Q?k3wTZ3LCpcM0uJyrSj1wwcJQylq37EwZCqTf/4BWQ7CpUB1I/GhSeIJVHheR?= =?us-ascii?Q?L4tOeoXkdKXqGalTuE4UYiwgG4bpkW2tT8RLYUPuWHX3K/YVkGuStC3tdgFm?= =?us-ascii?Q?hrBvhaQJ8zSu1znQFOIHYJSYQQqSl/u4m2SFDfBza7bAXWaFl9gtfLnBppUG?= =?us-ascii?Q?t6qpTmzkI6yNYhf094MoaHgEJ+PAELEiwCoL5qsDNUmBi0XipgDowHD4m2OS?= =?us-ascii?Q?su79t+NJu1KthsPZoLTiCvV/l7onyHxFi1OZ/hEAg4RrNxjMnIkP5b8zs+Q8?= =?us-ascii?Q?k3waCGlnJwoqz/G+lxI9bCwbWrHVB0BHET7yr8lvaJGvR8gnPEMVL11Iu+rj?= =?us-ascii?Q?31VbcrXidC+DDDnGbnditO0u0xt9d2v3xcpyhsnd4UtiqcM00UFHoD7b0u6h?= =?us-ascii?Q?lD8CyaXJ+oFTn2ycpnR4S4z47v2Gp7lJ9IAp09+5jM/1IOVis6t3Q2wWyhst?= =?us-ascii?Q?5ex2e71ZSSAw2ujHAyiqRMaI7DyXj+PKge0nbclHtDLXyTvW8zvlRmWzIqzU?= =?us-ascii?Q?X95yK5fPSZxXjLuPFz6zkLp61xhPGzaVNJVcjlyUABsW8tooJBxpblCyRlB7?= =?us-ascii?Q?ZaOxRWa9eZDm/xUpEtfTTMq5Phh5dDKtpcTYC2B3gsazY16oIUDY5NwdiYgu?= =?us-ascii?Q?uTLvNoIvJZjR9lI6jaUplNGTrh3RfNxEF3ZG7y8gMh7XQUUgX+QkK7JrsEc3?= =?us-ascii?Q?72BC6mG+QW3iqwShf5HMf6HP2ukudCrp7hHzGo2y8HxOkv50AfN0TupyNqCA?= =?us-ascii?Q?p8xKl3fRxp+OfQmyMGUhg7lIkYf14WCyW5Xzjc1ELxLhEMC+vjBsB5aNDT+X?= =?us-ascii?Q?xmKUQWRUZRm3mnA8FlHTx7QKJrDUYBoNNNqAhXyVs9cGA3gUHdH3uHTk65TI?= =?us-ascii?Q?mN+TSRbO6DjYnEd3Hbxtauj7xQ6L4RkICkKWszhnRgbX9bmapgO/0YbJbtV4?= =?us-ascii?Q?Gm9AfNydgEElLhxMPs0nXiEN9kZHLYriPtmkxmdTqkOaP8q7h94VfbJH7EIO?= =?us-ascii?Q?bLtTog03JQkgZ7tOP+0BY2Ziub40blLmke3KAWVGgDaBv1rsMEQw8+tRod3Y?= =?us-ascii?Q?eWTGrgjvzTAJXM/sDEwK+VOWqHvbUCT6v8U6Usa4Hi6hHIj94T0uzCd5ZHqd?= =?us-ascii?Q?qR344V/csd1by/4K1dPWNQMZn36y2gZJ/rntKNa5jfq4No5dUoy73GOwVGRt?= =?us-ascii?Q?b7bx2gWebB81E7r4N9tJ4rSLDVNeH8w9/Zvqh6vNmmsfJpKGiwPC1GOhyMrA?= =?us-ascii?Q?yxzK/F/x49XPbt7zrjbqusnWde77DLiHZUQ6iMgn1PuXxW9eJB7LSHldL8e0?= =?us-ascii?Q?8wInXNOJwZ1kZVZsotTtZPlTq11z/Y2TCuSZTkvtCOvYdlz95NKA2aYxwMsj?= =?us-ascii?Q?OA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0b793c52-9fe2-4d48-3cd4-08dc02cda4be X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2023 09:09:03.7307 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hvogARs1Twg21UGUpks/bFSTIw3VON/ZwE3+65kR3EPD43V36HYaG6O6ex5ATXkJHah+p+NlWDoov6iaYV1+x1LGAdgWE1khNQqWk2zKck4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8408 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 21, 2023 at 05:41:40PM +0000, Euan Bourke wrote: > Removed LIBRTE from name as its an old prefix. > > Signed-off-by: Euan Bourke > --- > app/test/test_reassembly_perf.c | 2 +- > config/rte_config.h | 2 +- > doc/guides/prog_guide/ip_fragment_reassembly_lib.rst | 8 ++++---- > doc/guides/sample_app_ug/ip_reassembly.rst | 4 ++-- > examples/ip_fragmentation/main.c | 2 +- > examples/ip_reassembly/main.c | 2 +- > examples/ipsec-secgw/ipsec_worker.h | 2 +- > lib/ip_frag/ip_reassembly.h | 2 +- > lib/ip_frag/rte_ip_frag.h | 2 +- > 9 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/app/test/test_reassembly_perf.c b/app/test/test_reassembly_perf.c > index 3912179022..805ae2fe9d 100644 > --- a/app/test/test_reassembly_perf.c > +++ b/app/test/test_reassembly_perf.c > @@ -20,7 +20,7 @@ > #define MAX_FLOWS (1024 * 32) > #define MAX_BKTS MAX_FLOWS > #define MAX_ENTRIES_PER_BKT 16 > -#define MAX_FRAGMENTS RTE_LIBRTE_IP_FRAG_MAX_FRAG > +#define MAX_FRAGMENTS RTE_IP_FRAG_MAX_FRAG > #define MIN_FRAGMENTS 2 > #define MAX_PKTS (MAX_FLOWS * MAX_FRAGMENTS) > > diff --git a/config/rte_config.h b/config/rte_config.h > index da265d7dd2..e2fa2a58fa 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -85,7 +85,7 @@ > #define RTE_RAWDEV_MAX_DEVS 64 > > /* ip_fragmentation defines */ > -#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8 > +#define RTE_IP_FRAG_MAX_FRAG 8 > // RTE_LIBRTE_IP_FRAG_TBL_STAT is not set > > /* rte_power defines */ > diff --git a/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst b/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst > index f3ed90d700..2d422309bb 100644 > --- a/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst > +++ b/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst > @@ -43,12 +43,12 @@ Note that all update/lookup operations on Fragment Table are not thread safe. > So if different execution contexts (threads/processes) will access the same table simultaneously, > then some external syncing mechanism have to be provided. > > -Each table entry can hold information about packets of up to ``RTE_LIBRTE_IP_FRAG_MAX_FRAG`` fragments, > -where ``RTE_LIBRTE_IP_FRAG_MAX_FRAG`` defaults to: > +Each table entry can hold information about packets of up to ``RTE_IP_FRAG_MAX_FRAG`` fragments, > +where ``RTE_IP_FRAG_MAX_FRAG`` defaults to: > > .. literalinclude:: ../../../config/rte_config.h > :language: c > - :start-at: #define RTE_LIBRTE_IP_FRAG_MAX_FRAG > + :start-at: #define RTE_IP_FRAG_MAX_FRAG > :lines: 1 > > Code example, that demonstrates creation of a new Fragment table: > @@ -69,7 +69,7 @@ Also, entries that resides in the table longer then are considered > and could be removed/replaced by the new ones. > > Note that reassembly demands a lot of mbuf's to be allocated. > -At any given time up to (2 \* bucket_entries \* RTE_LIBRTE_IP_FRAG_MAX \* ) > +At any given time up to (2 \* bucket_entries \* RTE_IP_FRAG_MAX \* ) Should be RTE_IP_FRAG_MAX_FRAG. You should check all other replacements to ensure the correct define name is being used. I see a couple of other occurances in this patch where the name is wrong. > can be stored inside Fragment Table waiting for remaining fragments. >