From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9231543871; Tue, 9 Jan 2024 11:21:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E5424021F; Tue, 9 Jan 2024 11:21:17 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id D1BD64013F for ; Tue, 9 Jan 2024 11:21:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704795675; x=1736331675; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=GlYDqnfVbBcBxGYAo/Rh8F1ZkdRg3T55mVcgERd/YXE=; b=BfjTW5aw9EwyUHFDxdAnjq9PP4Jv8ISFT0s9vMqDNZx1HoP85gZUmmKc hkHgnTLE3HnvNZif21CF5lZY95VGQMqdI5vRCkh3x1SQ9qoRwLwmEKUNb l6MlK5OvthnFTAr3GTREMIX1th3kJOJDLZv9tSTSxERsoWaNou8Fa4T38 vZB21VnVVkORsu+uaEiibLeqMr5mZHFY5rHty4wjc7zxd2inJaEEwLPUt Qz9rZIPWDOpnRF5mSo5fG87ocf0QaGApQLrSzySlEtP/lmBdHP7b15rCp GTGTIqjEzhX1KP04KOyvZE9UbmlIVtNqI+yVknfOv259uR9XnT/iDBzmb w==; X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="395315417" X-IronPort-AV: E=Sophos;i="6.04,182,1695711600"; d="scan'208";a="395315417" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 02:21:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="785185507" X-IronPort-AV: E=Sophos;i="6.04,182,1695711600"; d="scan'208";a="785185507" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Jan 2024 02:21:12 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 9 Jan 2024 02:21:12 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 9 Jan 2024 02:21:11 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 9 Jan 2024 02:21:11 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 9 Jan 2024 02:21:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gOCXv71vQzVnUBW9cB8QzxVttObYpKXgfk9pa1VpG3Y22NeI1pyUK7JADwnsXNrficx8caMxTX714HeIdhSucgfKf7k9QoJbaGm8WngOkUkkjjC0l7xRf0elg6hg5PcxNGVRCd0fL/tcEP+zji90z5RoxcCgeixB8h5TkmX3m8Ldk066jus93UJ/Q/OU80k0SXgxSoGF63nq8iOiMmlAemK6Cnzl3SUCwBPX8KPomF3qnqFX0xw8MWwVWUuKK45J9jxeO7IH0uWFU/A/09+/vAjwTQ/LLlALpqPzEjcf0WODjHhPLuAa2hAxIC5ghf0LG33JxUT4qAy6LBnRAApGgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=48mLacr6ClpBezMwan0ETgapuiS5BwadtjsznyLD6iU=; b=GO8d2K2LGpFVcG7vZ3LoJZZjxxSLGt8ltRt7ypTikao8htmaJZoo0MCxmXWyVcx0wROaa7vtHdsFQ8PbZWrvOQfwCw04cFGfH6/4vCRE521nKvYkDYW0+xFcpbcsBcGHWlrPj8eYEdYcT8JGlHIXNlfZjzQKTYq5mgADMgE7j/gJgXqXRlZsCK18VuBCLrQF9/2OV29DIgH5noG8E3C+aOJ5IFjLhYgGCMTSU5IgBXKPwDaNU4oS6q2+WmNPVhj9cQ1HZZO/KDoKFKnb4n3+ARpml8kT4wgjCBlOac7aqi8D0AaPEWmJhtCsyx2ilfJ5cfiIY8Z4TceiLJ48fV7XAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB7249.namprd11.prod.outlook.com (2603:10b6:610:146::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan 2024 10:21:10 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 10:21:10 +0000 Date: Tue, 9 Jan 2024 10:21:04 +0000 From: Bruce Richardson To: Lewis Donzis CC: Konstantin Ananyev , dev , "Wang, Yong" Subject: Re: vmxnet3 no longer functional on DPDK 21.11 Message-ID: References: <2134779104.413217.1638218715124.JavaMail.zimbra@donzis.com> <1909271468.2730688.1638755553311.JavaMail.zimbra@donzis.com> <1796133353.5470017.1654262374494.JavaMail.zimbra@donzis.com> <12922153.12944.1704552603431.JavaMail.zimbra@donzis.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <12922153.12944.1704552603431.JavaMail.zimbra@donzis.com> X-ClientProxiedBy: DUZPR01CA0131.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bc::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB7249:EE_ X-MS-Office365-Filtering-Correlation-Id: d259b82a-dc58-4f77-62ff-08dc10fcb2a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oGwb1kcW8OXQU+IGJ7iWs1lGhvfMoLQ65KY4TS7fehNncVPWIDGsvJYdmHJ2WRxvMZEjQDNkLIRHjAeN/UhImRoKg4RHkpA9ssYNnkFsdCe9Y8V6tkzlWI9daLzpUiGSGr4UArBANrnQlD6FUAQoFtvKJxZqSH1ygBQDe8+HpzsE1z7FDnREz4YXoybORzSxT4vdkHl+ZBNymu/IMgj4widZM6Sf6pJWSQHb2uFCqpg7UE6/Eb4owUh7gFuaL//kZ7GKKnU4LviZtsxswT7HlulO8nc6MkZYZOon5wBeIO/sTw0mkPbWvgnbamJ6TDQO0rqRKXfhJ6KM4V9HTcMQjumPnDEKdr7AlRqyHJ1+vAJB3BPTPG6FszP2pJnu+Ks57RsrJpI4x5sRwQ9KOcQen0eVYpifRz8azElN6YUTPi5BrX7Q0LxYKWTxC4Xcd131K1Y/kOmm+7Q48YeatPh3/P4Od0UTop0pi9YhmsVTwEEYSy4auWg/NQW1itb6oJo1hYVV3jWZcaHNhJIeMyIR3BXfzhiJwR0Bx6wmzw3GFy0UMhWH/pmDjyBiPl0A4hIK X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(346002)(376002)(136003)(39860400002)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(38100700002)(2906002)(5660300002)(82960400001)(86362001)(41300700001)(54906003)(316002)(8676002)(8936002)(6486002)(66946007)(6916009)(66476007)(26005)(6512007)(478600001)(66556008)(83380400001)(6506007)(6666004)(53546011)(4326008)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c5bbLAunApD33DWgSbLIiiaGW4kryw8CmhDIs2kMZKhmkRyCRlOoxfLkGRfJ?= =?us-ascii?Q?YCFFxNgg2i3xTtr48gz/uJelaQVN3Ek8FZ7X1HZGkCJDOmYvjY1Ya8AqHuYO?= =?us-ascii?Q?tX4f0pcZVPOWkwFliet/QmOY2reXdUSXapCJtmkKPjw/JQxw+io11by4pkvf?= =?us-ascii?Q?o87JZ9e79wiuiRB1ljJ1kUZt6ciJGRQuwPo0svAvB4IUEhsDU8Bm+QQbpZ8P?= =?us-ascii?Q?EtM4ZHvW0t5NlrzV+ab7iCRITwYEZd4yt8QJzfxs5IyI0C1ySXU6DEXuvOAq?= =?us-ascii?Q?HQrg/LUWIixhpZTHNQnRyWLI7Q/X/3bpob3nF0suxW53fDo9y7RBvC/p6eqJ?= =?us-ascii?Q?cL8cm3lVh6Ry31HpLGnbhwo3y8TS5HIKZUectF4avo2aEHxqpf1zDYBkKutp?= =?us-ascii?Q?lnUwZ62Zb+pElTJ4Dm0DQJlf5YIgoh8Vy7fGUZNL1fbyh7bJyfwmMauZdbQP?= =?us-ascii?Q?pwqj2lftYP0rEO40VqpWFRIPW49pbkNxpbP2jnI21F/2y8/lph0CmMRKUbzT?= =?us-ascii?Q?IZ94gWPp2E6S6wkL9OLXMBjkfL1WeT87KKPRDCGnihvijG+jNQckoYWlYf/1?= =?us-ascii?Q?tL/DzxFlrOE+rBhfvu+RF5C0orDA9hnrNYV3q2KHQPDf4c0vubWMAjZxmz1a?= =?us-ascii?Q?b5WO7lDI9QAIjmZBUiPcjLvB4+eawypvG4zofhwZXufQzKxBunnhuLRMY1lp?= =?us-ascii?Q?hAXEBV94o1M7iPFvjGJ3yy4Gi1V5D2sRI3jQ96bn53sJvv2DbwelGvHHNMd/?= =?us-ascii?Q?z1bZ4P6Zp8T7eT7M49ulHzn8mpVTDwOneuuWmldWIGuaZcduzqwacvxBj4l0?= =?us-ascii?Q?VTmaGmnyPy1OIT721ayXBDzwnGIrp/d0+ezaObrRSuTOr8/X5rry5RbkgS7Q?= =?us-ascii?Q?cNjV4vPAQL91PTXlVvuetu6HIvB9NUm1QgHWwR4QPDtUd0n/TcDl5W9Ncf0S?= =?us-ascii?Q?YeBxDF9Ohzr67IPqsvLG+OtW3qVAw1e02NIxE2cggyCz9CAiSSrc0TQXfgun?= =?us-ascii?Q?+Osf/Z5P+9yWpXiR6NA7Thj04KBFbU3xIva2gxh9rUzyNdGZJ0kxbBP2e8LM?= =?us-ascii?Q?RYxjDj5aPMi782k6GdOvxiH9nonSAVL+ce+o2rTFSxDvc1Lx38bMNatWmX4l?= =?us-ascii?Q?b1BewENOxX1B0MwS2bDhxWp0nBexAdBE2u1JML27qKlCSbnChLaAF2HuoODN?= =?us-ascii?Q?tRON3XjRmYSbtkUgdX6AiopWaUMCef6HuM6WwwLcQQXGJ3HsEnpzJWqeezo/?= =?us-ascii?Q?EwedFaIhNN86Uk2476DE2Z+2mkDnfHXWkvOkPai5fMYdiAZ0WEoylZLYzWgx?= =?us-ascii?Q?vPZCdyeHWnIR+wBoT4nt5dFGKshDOQC89mhB3VF1CQ9YxHEOHN7Lvf38VD2I?= =?us-ascii?Q?l/jI+Twx9FIeBmSF8t+4Tz6Hro7vL9tTL5tjHBHWpR1C/957SCoWZHYJm3bu?= =?us-ascii?Q?6y0XmmqrAkHHeYE5WHUWBELkEpqWMT/nwczlWUpO8XGdK8JLXk+JDedQL8hH?= =?us-ascii?Q?C7ceuxD7HP7zZlEwBo2fe24Njqy6gWERTFbBNe0brZUkifkgipMXoeM2o/Zj?= =?us-ascii?Q?tbSNsBuHw1gvX8CXSLGCalJ6jTwiDXV4OoH+fy6zixd281hSLaTESVFAEyPW?= =?us-ascii?Q?UQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d259b82a-dc58-4f77-62ff-08dc10fcb2a9 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 10:21:09.7396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8FtNgR4oLbUxJMiXyqkUryIDWHt1m9pXqHOTk6qRkNGMO7XumL76RD03HmvnzvTlC269OU7mMzs6vDawO/o3u+NRxF9W4pk5iqrzqlxUtCU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7249 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Jan 06, 2024 at 08:50:03AM -0600, Lewis Donzis wrote: > Good morning. > > I just wanted to mention that this problem still persists in 22.11.3, and we still have to patch the vmxnet3 driver every time we upgrade. > > As mentioned before, ixgbe_ethdev.c is an example of a driver that ifdef's out the attempt to use interrupts on FreeBSD. > > Thanks, > lew > > > ----- On Jun 3, 2022, at 8:19 AM, Lewis Donzis lew@perftech.com wrote: > > > Hi, all. > > > > Resurrecting this thread from six months ago, I apologize for not having more > > time to dig into it, but in light of recent findings, I see numerous other > > drivers and other parts of the code that have comments to the effect that > > "FreeBSD doesn't support interrupts" and they effectively #ifdef out the > > attempt. > > > > Could this be as simple as needing to do the same in vmxnet3? Empirically, > > ignoring the error from rte_intr_enable() allows the driver to work normally, > > for what that's worth. > > I'm not at all familiar with the vmxnet3 driver, so apologies for the lack of response up till now. Does something like the below simple fix work for you? If so, I'm happy enough to submit as a patch for upstream merge and then backport. /Bruce diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index e49191718a..d088b42d35 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -1129,6 +1129,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev) /* Setting proper Rx Mode and issue Rx Mode Update command */ vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1); +#ifndef RTE_EXEC_ENV_FREEBSD /* Setup interrupt callback */ rte_intr_callback_register(dev->intr_handle, vmxnet3_interrupt_handler, dev); @@ -1140,6 +1141,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev) /* enable all intrs */ vmxnet3_enable_all_intrs(hw); +#endif vmxnet3_process_events(dev);