From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E7C043873; Tue, 9 Jan 2024 15:28:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BF2B40689; Tue, 9 Jan 2024 15:28:24 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 356354067E for ; Tue, 9 Jan 2024 15:28:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704810503; x=1736346503; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=NRgOhH31PU7XBABUEL4D6zXV1oVvLx0gcEBZyqslgW0=; b=LdLVkgbiYCS700S7sDiIuVJT8Rgb0EOTB2lRhCLZNnnzp3M74J8rYd3W C9OJBXSlMKsFlBvoGsyuBVVG68m9ngYUVfGCCcoAWxhN9o9tkMOhrfnRM e/VC/prmEgfzdtn5YNU/U60NZ5axX7ejUnEIvEXagdhOsTV6O8UbKulxe wSsOMaVMNVD9H9qHEd75hiF5vlEUr5FCbG8rsksyCCthuW1lLjx1KdrR0 kmq/67xCazjHzuQOxmJU9c+JcwBBJrTM4ySxxuBaRlBk1gP9WRIZeJNqe iEW9agI0qa7HjJ+v0yYZ5nYaOP6qRSEkOiCy04jtk/zN7CJENMoh+YsNS A==; X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="462491251" X-IronPort-AV: E=Sophos;i="6.04,183,1695711600"; d="scan'208";a="462491251" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 06:28:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,183,1695711600"; d="scan'208";a="30205506" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Jan 2024 06:28:22 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 9 Jan 2024 06:28:21 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 9 Jan 2024 06:28:21 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 9 Jan 2024 06:28:21 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 9 Jan 2024 06:28:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eFPnf/RjKa/WjdEvbu0vxpVHzaKuaHRXJyWnh8yfvIIGJCgrZI6kxfHELUk6fK/TQ3c1tx7BDUAqKg7Ik83NOnxicjvrLGrYphhd9BZnuHPFfKu+vN7TPZlLumw+FKpVz6FQzdz/Rm8ELC3kU0PE7vDusEuboQm302PznxJJLQwCBhLOQt72liYYcyF1StKVms3VhhIGVOd/n8GL9sgC4w/hRgSPUvxHywgv7rr77n19h0K64UqRynEwyaixC35Nn37hn/RJeBwXAb9Pr5l3QyZXZEqsqt8hFbSsw/L7zX+48J6zcjh5zvemDMa+Tl62sfUEhd3yK0dNRCdpenGF7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JxvaXLQqPMuVex/I6tVy1U70/8+rQDsF13mTHMbkZb4=; b=FsK60rkvyxMyv0lvB5eqd6bnsCwua+5LxAUjT9RqsLlb5OUFeq9aw5GNBka2IsZWkPGwyIqVe11YoOErgn9Mymha9YRzWRYNM6MHQV6C8Jy/KTzkUlRtIz1YMgDgwNnkwXWEkZFBV4SH2vPWH4SJZDKBVDqIuCV/u4w4clJOUf0O5DqTazJeB8JkdDaT1Z+mnomqq8y4vaMQW3axRL2SH8PjM2WZ+NOUP00lcXrZRPRSqApqKe9HF5/52aIEuera1lr7aTctKbLCv21Wwq/AbsnbkUN/qUfuJlGYtnpwtEXqUjTDkBjSwm3uXTqKiWCeNqGPI1f5iNh8a8FgxXuqfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW5PR11MB5785.namprd11.prod.outlook.com (2603:10b6:303:197::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan 2024 14:28:18 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 14:28:18 +0000 Date: Tue, 9 Jan 2024 14:28:12 +0000 From: Bruce Richardson To: Lewis Donzis CC: dev Subject: Re: vmxnet3 no longer functional on DPDK 21.11 Message-ID: References: <2134779104.413217.1638218715124.JavaMail.zimbra@donzis.com> <1909271468.2730688.1638755553311.JavaMail.zimbra@donzis.com> <1796133353.5470017.1654262374494.JavaMail.zimbra@donzis.com> <12922153.12944.1704552603431.JavaMail.zimbra@donzis.com> <1182416671.1246287.1704808007894.JavaMail.zimbra@donzis.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1182416671.1246287.1704808007894.JavaMail.zimbra@donzis.com> X-ClientProxiedBy: DB3PR08CA0015.eurprd08.prod.outlook.com (2603:10a6:8::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW5PR11MB5785:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b77530d-89ff-4297-a704-08dc111f3943 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eeMLtmO8OEwErxQVQJyISjKomMpuWFwA9FXrgY73KPJHjd9gYwmX1y7twpK0SOclTcXafZHseDWXKfRESyV7Znp7JgKW5jwTnPUCjsubH+UNt7dJqOYhoriIFJLw3/6VzEw+YdYrzTi5IT1zzDJxAX/UFs8/imfz5KkIwH0Kvq19vZQoSAMprKFGVledKzomWXHFsG/REqD8PJ+b41DegagtXKqTT8kM7C2PD7X0A/iqnV+LF6TrqINj3e2HzQSKAFFE8tgAZn3CuxZ2iJUz5HrE12DzlvsUn1k1jEOG2Yr1fXoyBqGDZfvr1S2Uw9EEM+9HcUrXA3jCP+dp3gct98w4aiTuJappNSGOeGmScao0ImAqmLi/SHE5EM1KM0sGOQpV4ybsyE0SmzN+Khe8zgflvaNhywh1ocjd0qaMDNbMXSF2FQJjAnTieNi1rQ4snJzEMIe0m8xkpVTGuDPWWS1ECpgf1QnAYRUj0DsMYH3ch1z2GPxxJ7BLMU3zunCV9c6riVKe+LNUrHM1378X7vEU7GqT1yZi6gfB9qjyM8ZS1C2Et/9hZGN2aMBaa+SEe3cz0SrMgpuJXw/tQ4mzQAn5HAux4RuAcTwCs42BOfYEK2b0F9nN8pQnc+wL2MEq X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(39860400002)(346002)(376002)(366004)(230173577357003)(230273577357003)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(83380400001)(41300700001)(66946007)(82960400001)(86362001)(38100700002)(26005)(6506007)(6512007)(6486002)(2906002)(6916009)(66556008)(66476007)(316002)(478600001)(6666004)(44832011)(8676002)(8936002)(4326008)(5660300002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JWbOIeu54QdJQQoMJ7KVKjNTg/w3UIYYkiO5JJfvYv2d8sKugrAuasLnf798?= =?us-ascii?Q?HEI/Ip1AswCpj5EYCUnbxk6j+aDfXy3dU7+ESFQXm413MVZkqgZRUkYmlgHW?= =?us-ascii?Q?Jx/ddK4pU/32cvrRvj19sZs4ZGN+UXiRh7URqijBotgxGm/ceVJbp4b6iblK?= =?us-ascii?Q?wDCQrqqH12KNed2ZD6AqJq7hrUwQ5Kc0ga41qxTonv3ngmrEDi2OPBmsS5E5?= =?us-ascii?Q?qK3dQzSRENKjBcq+hj9d0vb/qxHyhl0v7ZM6ijbdoxp6b4DMkOhwX2UdQ0fq?= =?us-ascii?Q?Ub+1zaPW1I1VIfDv40D3fdQzmaYtaiYVwCK8B0QFdjYxGyCAarfAs3xhnvAU?= =?us-ascii?Q?riIMefrYc/jLNfIveO/SM3LwdWm7JttZ4P9rLPrTrT2glHdt4Wwg2QfoUp3t?= =?us-ascii?Q?eFfKCuMqF0voF99h8LbMqoCCh05ooQiyOCYjwm+LyTOYuaGpL/yL3aUfDjog?= =?us-ascii?Q?ynwkXMWZW6GgcSDVVUR0Ktkos5H8FHRmF6OiMVGv5tdAo8aweo6cGRTG9Vjn?= =?us-ascii?Q?IRHUyuR21n00Kur4RXrkQZO5cOLb9H+lJ3yXOuVnosbzec7d6ULk5mcD4sJR?= =?us-ascii?Q?sQoK2+mnUYgBHo5HKTUfaIcUvfJcu0aBcInw1/Jpm2Ru+ilZD0ZKPlaFEgkG?= =?us-ascii?Q?qjwhajeKK4zZgmsBIs5KbvUkZKuXYqiRhWzaY9g1XocRu+GpfuUciCdVYSUT?= =?us-ascii?Q?qVl9P9WLCaH8n2w5REi7g3cfrZCSXK3e9CPT+SRJhIlK+vQBeCDR+7InJLnZ?= =?us-ascii?Q?5jrmLCHcPyDJm8yyTPX+FvQT/CaEh38pfMBZdo6vL+HnAmFgrGmU/bORQ0UO?= =?us-ascii?Q?Or7O57sFiFK5A00X7gNjJ9I8inYrMK3e+8kvmlrQpwNWwgnf1CmWv9QlMpei?= =?us-ascii?Q?XstrS6bHxST2xqtggQElNNS6na3n71FZy7Y/++EXr7tIoZ2fiS1y2XrnVz62?= =?us-ascii?Q?dGAb4VDIuReRPD96XlDknFww+kHoEWiqnJW8/h674o1h20NAkHZ1E+hwES1U?= =?us-ascii?Q?/v9w+v1gigLgZ6I+Eyl3B+8z0RliQ06PCoVrBasIDlCtrGNt3/HnLQoBfoMf?= =?us-ascii?Q?D2C0NuJafRhIEhB72oCeY3wJDbtsPwk7A0tU42RNbblIYd6Y3kfFceW2I/An?= =?us-ascii?Q?IEXHAYeQyXmIW6zdFLnD1QEvARxU0btUKyxm5pE703Ga825ypOVUhElmIz37?= =?us-ascii?Q?D9Baw7IapiMFV41GbR6PjQV8wK0Brk4EZX1b6yMwWXPAHBBZq37YaSTSE3Zv?= =?us-ascii?Q?MiaCQCoiHkkbI1HfmJrYiVYvX2k29mkAj8JCNqX78dOOKJUV84wlnUSsYxq+?= =?us-ascii?Q?1QYQsDsGLi1SPOJhliAwn8dJibjBL6mNXoKGwPjkKy0xbDBanJ5xRPSeLRgk?= =?us-ascii?Q?IhS05ZesO1ZjZgEzjrMEYEFLc1fH4wHyZUJBpyQcz2oyrTwitQUl2zcOBj7B?= =?us-ascii?Q?zyn8CrgfjfVPgJB7V8a2p/UQ485yC1Jyjjw1xbljC7dVNAYr98h4CG5VBkUi?= =?us-ascii?Q?YLLyLdXHaK09lojfk1+Iqs6tL4b9qPCJJBBz+15hfRih914ifi8SwhYjjWqG?= =?us-ascii?Q?LFqH5sfat1uuRLEWkIB2bGieK/8cAzTQq7P5+st4nSw7QgTYODjxw9YhkRRt?= =?us-ascii?Q?Ow=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2b77530d-89ff-4297-a704-08dc111f3943 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 14:28:18.4732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XLDLK6RWo1Qqj3PtFaeg/V7AJVgHGY9PSfmOOLxOJRnvOwUVNlji8Np3m7QnHXVy9MHEPCIYE7TrNpq17VrP5aVQRKbvwqpLrZSdNRov7bA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5785 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 09, 2024 at 07:46:47AM -0600, Lewis Donzis wrote: > Hi, Bruce. > > I'm even less familiar with it, but we do quite a lot of testing using VMs, so it's been quite handy. > > Your patch seems very reasonable, however it also produces a warning: > > ../drivers/net/vmxnet3/vmxnet3_ethdev.c:264:1: warning: unused function 'vmxnet3_enable_all_intrs' [-Wunused-function] > > Adding an #ifndef around vmxnet3_enable_all_intrs() eliminates that warning. Right, I should have compile-tested on FreeBSD myself, before sending the suggestion. Patch has now been submitted. Please test and ack if the fix works for your use-cases, thanks. > > Please pardon the uninformed view, but we've been using FreeBSD + DPDK for nearly a decade, and I thought the whole point was to avoid using interrupts. We have no need or desire for them in our applications, so we just hope the sprinkling of interrupt support code throughout the drivers doesn't cause any harm. But I also realize we're probably in the minority on this. > In general, yes we try and avoid interrupts on the data-path or fast-path and use polling. However, for some use-cases where traffic levels are low, interrupts may make sense to save power for fast-path. Even if not, interrupts are useful for things like error conditions or for monitoring link-status changes (LSC). Unfortunately, we don't have any interrupt support on BSD, so fixes like this are necessary. /Bruce