DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Lewis Donzis <lew@perftech.com>
Cc: dev <dev@dpdk.org>
Subject: Re: vmxnet3 no longer functional on DPDK 21.11
Date: Tue, 9 Jan 2024 15:35:37 +0000	[thread overview]
Message-ID: <ZZ1nybXrj_xARSkz@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <519672326.1276848.1704813707871.JavaMail.zimbra@donzis.com>

On Tue, Jan 09, 2024 at 09:21:47AM -0600, Lewis Donzis wrote:
> 
> 
> ----- On Jan 9, 2024, at 8:28 AM, Bruce Richardson bruce.richardson@intel.com wrote:
> 
> > On Tue, Jan 09, 2024 at 07:46:47AM -0600, Lewis Donzis wrote:
> >> Hi, Bruce.
> >> 
> >> I'm even less familiar with it, but we do quite a lot of testing using VMs, so
> >> it's been quite handy.
> >> 
> >> Your patch seems very reasonable, however it also produces a warning:
> >> 
> >> ../drivers/net/vmxnet3/vmxnet3_ethdev.c:264:1: warning: unused function
> >> 'vmxnet3_enable_all_intrs' [-Wunused-function]
> >> 
> >> Adding an #ifndef around vmxnet3_enable_all_intrs() eliminates that warning.
> > 
> > Right, I should have compile-tested on FreeBSD myself, before sending the
> > suggestion. Patch has now been submitted. Please test and ack if the fix
> > works for your use-cases, thanks.
> 
> I compiled it and ran it just now and it appears to work just fine.  Thanks very much for submitting.
> 
> > In general, yes we try and avoid interrupts on the data-path or fast-path
> > and use polling. However, for some use-cases where traffic levels are low,
> > interrupts may make sense to save power for fast-path. Even if not,
> > interrupts are useful for things like error conditions or for monitoring
> > link-status changes (LSC). Unfortunately, we don't have any interrupt
> > support on BSD, so fixes like this are necessary.
> 
> That makes sense.  Makes me wonder why there's no interrupt support on BSD, i.e., maybe it's better to fix that than to have to fix "avoiding it" in the drivers?

Sadly, interrupt support was never implemented for BSD, which is why it is
missing. If someone has the time and interest to do up the patches to add
it, it would be a welcome addition to DPDK.

> 
> I kind of feel like we're a bit orphaned in the FreeBSD world.  I don't know how many others are using BSD, but it seems like we're in a relatively less-supported environment.
> 

Linux is the dominant environment for DPDK, which does mean it gets most of
the attention. However, we do want to keep supporting BSD, so please
continue to flag issues to the community as you encounter them. Smaller
bugs we can certainly endeavour to fix, but adding things like interrupt
support probably requires someone to explicitly step up and dedicate time
to implementing it properly.

Regards,
/Bruce

  reply	other threads:[~2024-01-09 15:35 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 20:45 Lewis Donzis
2021-11-30  8:53 ` Ferruh Yigit
2021-11-30 13:42 ` Bruce Richardson
2021-12-06  1:52   ` Lewis Donzis
2021-12-06  9:16     ` Bruce Richardson
2021-12-06 12:08       ` Ananyev, Konstantin
2021-12-06 13:58         ` Lewis Donzis
2022-06-03 13:19         ` Lewis Donzis
2022-06-03 15:25           ` Ferruh Yigit
2024-01-06 14:50           ` Lewis Donzis
2024-01-09 10:21             ` Bruce Richardson
2024-01-09 13:46               ` Lewis Donzis
2024-01-09 14:28                 ` Bruce Richardson
2024-01-09 15:21                   ` Lewis Donzis
2024-01-09 15:35                     ` Bruce Richardson [this message]
2024-01-09 23:55               ` Stephen Hemminger
2024-01-10 13:36                 ` Lewis Donzis
2024-01-09 14:23             ` [PATCH] net/vmxnet3: fix use of interrupts on FreeBSD Bruce Richardson
2024-01-09 16:00               ` Lewis Donzis
2024-01-11 12:03                 ` Ferruh Yigit
2024-01-24 12:34                   ` Lewis Donzis
2024-01-24 13:58                     ` Ferruh Yigit
2024-01-24 14:04                       ` Lewis Donzis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZ1nybXrj_xARSkz@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=lew@perftech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).