From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36F4D43864; Mon, 8 Jan 2024 12:02:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2335840263; Mon, 8 Jan 2024 12:02:56 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id 68FAD40261 for ; Mon, 8 Jan 2024 12:02:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704711775; x=1736247775; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=RW8ew1p5VqRm2AfG6VrPoprEJ5e1JtnkVHQ7JM3uhPQ=; b=anE3ZWkMFlFHiaRMy+nrxlxaSzBRKtmeqVk07rFw5Tq24zOLPceqGnVT La5k66c7tYK5iPJCMjzrK7PetQ3qDLBNYnuWjMZbcMwbQ8hfmbi2eFuWA Jl3EtNEg1UfunauRU1G5p8Gwjr46wK+S/tCsxyN8L/z6MOaChIVeIeepf xNcVQ8xT7a9JpULoyvUaDCUukfWYDAaJibte0XC9p7YJhjTy4e/9+j0PE G010BTttEdAst3rqVUQk51Ucbyd078kdWkUr14f6joFg17Gl4Gl9KF97o q/cLybydk/wO1z82T3xFrEL0Nzp2n5sBUD3ppuPAAEqvfUhQE6+ZnbH9V g==; X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="4931552" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="4931552" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2024 03:02:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="23129481" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Jan 2024 03:02:53 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Jan 2024 03:02:53 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 8 Jan 2024 03:02:53 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Jan 2024 03:02:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iZ9SjS6bmjMeU373/asUOrHE7mV1uqqLURFKKDKCLTc7vnMRJ7lVaDMPTL+lEYZv/UEX8ehOaU454drayNlRuYm5487LIPBLngGVm3Y9IC/eDxwIZaLr45bB4IWStNqDMRl36J6zgzxUsbAi/vjtLETDKIhi7BC6T/v6XDCHAJpUT/olumMfSOqMWJ+yYBbzc14yxZ5x+XPbzwy+c2y3ZBy/D5wCZJ213nG4hHDulMLGb3T2Avb0F0oqV8TUch2UGEre/96bzmfbCbsc1W3NVko4kTw5YaC+pFCQEbjFBzRGWALpjO94TnQ15eNLFxtVL+v2DXkCC71z6hD2s1ioPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YfCu1H5X0l2GkFBVt59rGakejhhF1J5BJQP9Ty5zfGg=; b=GZFDUAmdkQEdqekSedUXaUTj/jvWjp/+WWMzX11Bu4qxwI/Bt71b9kzFdX9gRkAzAizaLYq8CHFV6KpMfEnm/9SSq105OB7DBGevvLCAmd+vhiZ5UMVmploj6a1wKqwb04RDl6nh0/gaokT1eZHLN8gFsSfxqydpyi4S5jgZdfwxIy+wx1r9tN/pIIcgZJXiFQea6A1R/qYKmKI5X/27mGn+rT2iV9GbgahdoKMQOIiTAzjHbYsGz938a/8qCSRi+fnFjSaB+6mJB5nJuKLJBL/9giSBxevaDoux1Zp/ajTvwUjegWbI3l+Gb2MVxXq2w4OWZBZDxU1L1Vi00niMvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ1PR11MB6156.namprd11.prod.outlook.com (2603:10b6:a03:45d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Mon, 8 Jan 2024 11:02:43 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 11:02:43 +0000 Date: Mon, 8 Jan 2024 11:02:39 +0000 From: Bruce Richardson To: Jonathan Erb CC: , Subject: Re: [PATCH v2 2/2] telemetry: correct json empty dictionaries Message-ID: References: <20231224220201.762377-1-jonathan.erb@threater.com> <20231224220201.762377-2-jonathan.erb@threater.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231224220201.762377-2-jonathan.erb@threater.com> X-ClientProxiedBy: DB7PR05CA0058.eurprd05.prod.outlook.com (2603:10a6:10:2e::35) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ1PR11MB6156:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c6db968-4a54-4088-bb2c-08dc103956bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MEbYPwRERglusSnZcBI6du5WNUoNQpm0k9NrfqcZxFt+An8d89cXmo6Wojac1z5z2tlGjddh8HV9V+FjpwJi/qWr09F1xMFEw/QurYzhJOWQ1nAU8YvL1XrY4I7F8KFUVzgPQnAmufgFmQNU/n5piasoWYzY1NOowtpULL6Oh5q1QcGNwRYEgeemgwkvFP8kEEuS59RV4KcsEeIX57JDrFthXrVTSGKWKGoUb9G46s6Hkc5jxraQfW9ufi95m58Mbdvv+YU5Qa+ftg2nBy3bgPKukVtdbLFDX0NUXDw0YuQe4mtW8rzR0kjr4dIyLwea6OtEERqvDSnf5b1v46o9WoWFukRkQT0jPjSrtdpoTHh1VQr3dq/sQYU9AP6Z0TM5dw4+d4//EOVSepvzpWzjrXvlsZiSqD9H2bQD+FPOOF1Bsrbir6Vzs09eT7Z4pUfgA73hod1c3S6IQA3aCNBHA6wyNdUPC1rtGXY+eJi+lfehNLtP5XQwSU1ZoUTI0u2vx3IyA+mUhx7HJ4InGwyuJvldc9WAqre5JWmhVrM6LIm5OINj6tSUxul2aCJ33qSe X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(396003)(39850400004)(376002)(136003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(26005)(6666004)(6512007)(6506007)(6486002)(478600001)(38100700002)(86362001)(82960400001)(4744005)(2906002)(41300700001)(5660300002)(83380400001)(66946007)(6916009)(8676002)(66556008)(66476007)(316002)(4326008)(44832011)(8936002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AhLQCgVf6Iau17IJ2qkKVgLGBzFrkKqfWwEVzy+ZgBiJay2NZChQHvHgK9ya?= =?us-ascii?Q?jahYyLG+BDmeGmEyxCpHPJNbS0dZLXse9STFCV0GVP+Zn+WlryNAfVMDQWbo?= =?us-ascii?Q?SitAVoh+BjfuoWRf7idwvHgeLEjUNl/1oN6wteOQKNzxX7E+w9PigN6fSvBv?= =?us-ascii?Q?pZL7inUgqh8EeM/5IEAYQ3hyPCb1MOSR8d2N99Mva1TxFwQliPF+fOhtmQmC?= =?us-ascii?Q?w9rlAgMg+i+n8Q+Fs2e7VCtUFzzYycflaY2Wubr5BmhQSCAU3JReLUXnH1iO?= =?us-ascii?Q?9zpm5Herhrle/YdYVFE16q3eSyQU+rJKQQIYfnJ9YMCFv7P16G9gGuFPLih4?= =?us-ascii?Q?wHrfvUoCrqb5PRUXyLX9YWE0fcO0HMely8Wn7XWGxDUZtJm3Iah2hGz/LwKU?= =?us-ascii?Q?Wp4nf9e0VjDqBvkX6yKRK17hzmuWS+ollIeZgiRAUXclWq+8lT5NoHj6xbgW?= =?us-ascii?Q?nLTfT+CMCPyK20xa1Dv0KRZHFyLf2GJrBy/2UXoASNE7xYK+DjQhLVNdymHr?= =?us-ascii?Q?ZxFutXPP8ela6LSO6zRtJWDPgFi1bb6+NJbL1oxxOXPV36O74F86OoopjeTH?= =?us-ascii?Q?74lK86Lzq4OnsG9oxwJ3CfDneAAdMOaPV4jNLujZL4xjkAOn6Zg9KXnDMgh8?= =?us-ascii?Q?3SCNYzkqbbL9WZ5mIL5JcTEkNsnhsjrbVlAAGUnHy1oRMy2JYtKumfawdVsI?= =?us-ascii?Q?GIRF8tOmNeFQ0LpY0Fw+qSgjfEKdgvawZsx7eKpGgY9UwC3+7rqWoShQF4Yi?= =?us-ascii?Q?386tYy/WsjXj1l9RfB3bTxKQWLgwjJQlbIdIa7NGZuO6N9YjH0M5SfnJ/Lr+?= =?us-ascii?Q?XdY5BkNWQ3C18Bf/Oz4sreign2XQL5qS1HIazqxCe7O+X0+3Y5plKw8L+AqV?= =?us-ascii?Q?gWCKbrThquOIh4KXWEvurxpRZw5483dIrl15Epj8j5m7pA746yk5zoUeZbk5?= =?us-ascii?Q?PDIg4wk+zzpwGJPyQDBIPeLvQjr8fNecoykk+LC0uJOifgrB8hOftbA/6bBf?= =?us-ascii?Q?MdfWDMmyXIg9XN6fhbAtCu5QG8rulN1BnqcSHoURPlMZk7khNGeTI0hvUtWc?= =?us-ascii?Q?YO7eaL2aQ1+wrjOudU9xmhTpvx2nnUWK3rbgNEAnlQcMUcRyePXk4efcAmVa?= =?us-ascii?Q?W6IQO/XfITmaChlffiKC9nUmZBG1q4OP7rqNUq90KoN0pdl7MNN3eLukGjVk?= =?us-ascii?Q?i9tJJ5WRa7JgopsDaeERAqIVE8dFVAIm0yn2rGBG69iPpMQBcpD0BotA0feD?= =?us-ascii?Q?lOUJrfkFr7uGHSeYsytxgCTt3RQyzGdk8MCkGsjIcbkEaeoVGICstq7GkWb/?= =?us-ascii?Q?SBUfBG/Ug0dW6W5dBFaBuLvwKGx/Lx2+ZLeuUvCBOsbgX3/hK4RDr4H9OP93?= =?us-ascii?Q?E0BKSjizBMh4oP54x7xLDgQLIpEsLHQO3ShsI3qnhGFIOlrdpKpD2jyNn0WQ?= =?us-ascii?Q?kST55+hXmKcUICIuSQSoJrZ4hI3z4TvYhAJLOiQNJmgQhjsQ8BSx/n6OXwOE?= =?us-ascii?Q?d4t4iF5+hAWQe8TXZulub9qg3Jwj+Dz7t0MQYJgi1eu2r9QivnDhXizPoy7/?= =?us-ascii?Q?rDf2Tgr18cZjT40H+gbuLLfv6xFSsVeg45ir6dmsJsRtYsqAJxUvg/6EtVGM?= =?us-ascii?Q?tg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4c6db968-4a54-4088-bb2c-08dc103956bb X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 11:02:43.5134 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kwdk4HInJQks0UjGHhXAFdJwwsYhRDWcPZloFUP3Q1/u2yZBHV1Gmvhc80x0tWiTeKLQmR7V1+CZ9dpfCpkpeQOk0dsRH4gGyVE3Ub6sibk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6156 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Dec 24, 2023 at 05:02:01PM -0500, Jonathan Erb wrote: > Fix use of incorrect enum name. > > Signed-off-by: Jonathan Erb Please merge this fix into patch 1, so we only have a single commit to the repo. Thanks, /Bruce > --- > lib/telemetry/telemetry.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c > index 0788a32210..eef4ac7bb7 100644 > --- a/lib/telemetry/telemetry.c > +++ b/lib/telemetry/telemetry.c > @@ -169,7 +169,7 @@ container_to_json(const struct rte_tel_data *d, char *out_buf, size_t buf_len) > d->type != TEL_ARRAY_INT && d->type != TEL_ARRAY_STRING) > return snprintf(out_buf, buf_len, "null"); > > - if (d->type == RTE_TEL_DICT) > + if (d->type == TEL_DICT) > used = rte_tel_json_empty_obj(out_buf, buf_len, 0); > else > used = rte_tel_json_empty_array(out_buf, buf_len, 0); > -- > 2.34.1 >