From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7AD9439A6; Tue, 23 Jan 2024 10:56:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64CD3402BD; Tue, 23 Jan 2024 10:56:48 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mails.dpdk.org (Postfix) with ESMTP id B4D07400D7; Tue, 23 Jan 2024 10:56:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706003806; x=1737539806; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=tcaUMKlpLgYFOhtU9C6T3LQD/AOXY0Ra7j8THbsQRys=; b=aSANzJifPqfcRneDkI1UIWMPNKb0BcZtpNNCJs7eJl4Q+AY/jpixofki sstQVGK5lqGJLkEutOXZ0A32nYdKm6t3WiNv2J2f3u10yPM391YBwaqLY 2sOKyvfOVpv7XfJfc7gR7TsY5skyHnZjcYoSz5cfetUl8TvOYMfeNoB1p aY+eXcgZrv3pekUAh5TWo5Lz9+GaePHfka22DGdyAPjwCNjmLL2WJ8mdm OpSLq/MQ/YilcfnC3aGVhdCB3GLoe3BCyfPDowJQgN0qW2Nk1gwuWC1lO yU9uURiPfKkrhNxSWCNAwt8M4uSu30zty4QmarPpEDSqvscsGaDwGrXf4 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10961"; a="8144023" X-IronPort-AV: E=Sophos;i="6.05,214,1701158400"; d="scan'208";a="8144023" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 01:56:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10961"; a="909240751" X-IronPort-AV: E=Sophos;i="6.05,214,1701158400"; d="scan'208";a="909240751" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jan 2024 01:56:43 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 01:56:43 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 23 Jan 2024 01:56:43 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 23 Jan 2024 01:56:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ra3zuSbjV46vCBCSZoeGFyeuHCHVFvOIMQVCT3iAJ/ADShdoVuflSWQlqor7v0oplkcg+f5bJqxahxuYn69yH6jjaf0YVSfoIskYgaQAHuj3cZd62fR9bucqs4biJ3Nb7nxZiXZB3VhR6xKKwxIsS8n+vUoexJV7HMjGaAshLURiuQJ2belYqE8t7FQzuB/tMxKJg/jHS2PDQiKD4ADBwNsnxt9TG/fCY6nxd3y1pMbmfzqclQu5+bUOOmVejpCzpdnf5wjYwQ2ifpo8VABTqKC0tMcG2lhLsxChIGcjkio49ZHqxubW3QORjiOpKTlMvtOmlq+ZgyjKtjwXMUHOrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WowVevjxlDsuUeyxF01LvppbAa83ZXYhSlg8vFQk8vI=; b=oMmNQPWp4WHz8yNYa86Qx/13CrjxwUEeiI0G1Czw9iAuIYfl1J3q4LP9HKDnjH9NiQabMoIEMQYwRKTLgtJCQz6qO7N94vYniQ61dfXZKJ8qjLOshntiNHQ09c04JHOyQ8aHv+tdOxAl0NvTlQhq8GNRYocu8MJBSqSt6kbMgVYddSGyS2QUm5jm5QXSDp1eL250Ghsd0QhqCkpGVtvkdCP7cQ4CRpwbO6D+t3r75Rg5tDqT2XKiKz5M5Ft2Il5XbShq3+8oMTLQRB1myPYPNvZq1Su6d0vbW6xOShIse9SxPTqtI53OW911vU29Jmt9Wn0L9NNZVLRM3NZ3V7btGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7262.namprd11.prod.outlook.com (2603:10b6:8:13c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.32; Tue, 23 Jan 2024 09:56:28 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7202.035; Tue, 23 Jan 2024 09:56:28 +0000 Date: Tue, 23 Jan 2024 09:56:23 +0000 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: , , , , , , , , Subject: Re: [PATCH v2 07/11] eventdev: fix documentation for counting single-link ports Message-ID: References: <20240118134557.73172-1-bruce.richardson@intel.com> <20240119174346.108905-1-bruce.richardson@intel.com> <20240119174346.108905-8-bruce.richardson@intel.com> <10e10beb-b842-425d-a591-4992e06255cb@lysator.liu.se> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <10e10beb-b842-425d-a591-4992e06255cb@lysator.liu.se> X-ClientProxiedBy: DUZPR01CA0222.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b4::29) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7262:EE_ X-MS-Office365-Filtering-Correlation-Id: 040c04a7-278c-4181-bfd5-08dc1bf99146 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vt4edHaXycwRxoBDi1agvyJYlZG5SzxsJjp0zWP5eMR/YJzLSS+rovO5YFUS5uk2Mj62VlWRKrIsAxdDFoWCQDZ0tvLIO/Do7kD1sFWV3E3cCY8xFE8O/P5bkuwe8nkE4XGzVtWtmFPZ9OA5q0lqyMbQJt/b2k5TSlCIEIB3WT18niP045qd9Wb4TN9gMY6ptb/41Jb+l5QGG/aV93q+Lvek/swP1uMREOUopMXoInSphArTDSaFLyrsWXviR7RSWleiW2OzDHHoPY00OXcVlm79Wa+DYCXXr0rTWqYaFAV3m0B2OxhQwWF+se9Hsyi46ztPo/B2pLGJ2MZxVqG6Zw2DjhUPqNRfohky8cUTfumNL7nUrI6/M4qVIxxTLYuvpeqj9j88BFkLXXA6fybcU60hzDlPSoclY57c0XldBe9p6SRAvnTJwBRFKRkQWQjYY7wWS4U98oFOVpmK6M6TIh0L2kXuk/vCAyrPdRuuNpuVe7swfxhNIBh1fsEnL8Xokmmt6yAeLH8VAOQpsO+NJ2eqDe7EPIJN2BxcZhzYDAU3EcYqmJYmhxtf/dxrdQy7cDNMLv6M3XOmtKhsMQm98Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(136003)(376002)(346002)(366004)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(6506007)(26005)(6512007)(6666004)(53546011)(66574015)(83380400001)(5660300002)(2906002)(44832011)(41300700001)(8676002)(316002)(6486002)(6916009)(966005)(296002)(66946007)(478600001)(4326008)(8936002)(66556008)(66476007)(86362001)(38100700002)(82960400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?T3D9CNch9kxaBfe35iJiY1vhq3ZzhMXMKC3yTKMohdaIWGdE6EBkMBjHmt?= =?iso-8859-1?Q?cN0ZCClZ8n95bKg4rR1wzW9irzKgz5Nymwc/7LlSa9qO+w9HYtYX++zOK5?= =?iso-8859-1?Q?7TB4ffsgEG+V8SzBOVgzlo0Sc/qiwSSRuQfCay9zaWMWMaxY4iRFFO/yDY?= =?iso-8859-1?Q?0+gtLLdXNBK3ctsD3IW4sSYRHEacNUnAux7HOw1bu76zNjf8iKPcCbW5rk?= =?iso-8859-1?Q?hbQwgzMSSAGSCQInnGG8dvJ4p/p5zhhPHmtChTXxSvNB3wlDgzgSXs/YIF?= =?iso-8859-1?Q?CfXJ9A261oTVPVQ82zFA5k3VH8yRvV6/SyfOkFTveaSJiU3Wunyavg/hgw?= =?iso-8859-1?Q?08ZIXDUR92XoRwPGbJUNmq1Kmb5+Pym0ZriyLAlmAFvn1auZ63LsqJhWlj?= =?iso-8859-1?Q?r+JIqeibCLN4N0cCAeQWHkhgZrAc3jYvwCc4LA43ApAlP0OuMlWytdth9e?= =?iso-8859-1?Q?GBvZO1HmwXjigJ7w5iHb7y/zRKuRwInzuqVaHth5lw0L7McNb299DoHeRC?= =?iso-8859-1?Q?jv4n/0hVGeZntszTiOOYJs8P+oLdJaX0VknG2J05NQ5va9WN89HmD9hOOn?= =?iso-8859-1?Q?yP5e7PHImIFGtTZ/aY5YyXI4haWyd/MVwlV3FYDNOZlbBJ9Nliy36qvzsU?= =?iso-8859-1?Q?Ix6D3/rWPL1RRiHRLpJNVxHWkMBee2Zeog1Ha5tWAl3tgI+lkLsknZ8xT9?= =?iso-8859-1?Q?2ZTSCVSGvkC1d1iL2cwuLqeltvgY1jtjQqlvHClNScA7yKVHMueE4p8a0S?= =?iso-8859-1?Q?dzD9No/u5560iYbJk2dAefgbA3B1FELX2rLmbsCC7ZVf+6ecAdm/HNyidw?= =?iso-8859-1?Q?NTKffqC0yJ7qXVHZKYi2EeLtz2fDXlG4HTt1x8OwpjkEoJf97SuRxWC67C?= =?iso-8859-1?Q?8yw/FvCUfvah3E1Yyc9HD2LK3n4iINuBQrsPtPnKodRgwY0FQMFqbJMQ28?= =?iso-8859-1?Q?Q7gjB9W8fc64a6TUpbr59nc8ttkh55Tq5jpFaXplXDPoEPX4T4g5PsqLCI?= =?iso-8859-1?Q?++e+Hfcii6VIItmGRPApGaHgjye8TChUmXKwFLiAjG7rPSnvdlEN/OecUz?= =?iso-8859-1?Q?Fn6efJTxJL/uFncza4wKbs+NnQr2eCDQxztNfAuK05rSSIDWzijBRpQGT1?= =?iso-8859-1?Q?gRdQmx27QmDHkJIpKi+Jzox8c0FXjawQID+2QCSO+ZbNnkqIjGXgjYa5rz?= =?iso-8859-1?Q?PAoX6J3L2M022yNUp6uQmmPzx/CUbj7IIcplQnNdV4fODO+afxPUoNNvP+?= =?iso-8859-1?Q?mu7lEhBTFny4hPe4L9oxAp/9k9Om+h/It3Cw+7cmX3eb4g1ehkAEb9WzLI?= =?iso-8859-1?Q?NCCcL3CbhRb/d7xD2HxzkCYpV9d1unAsHAtZVNTm9C5WTsYAeJEBElwrIX?= =?iso-8859-1?Q?WXqHK4TgmRob/KVVQDpORGhHS7ybt99sDeLY+jTKGTfnm6B9lTXb/xxYOS?= =?iso-8859-1?Q?xoSeNUwH9hedHAiPBGwOUzPwlJelPosQaO9Uq+Z2W2fjq9Q0tScldGzDaw?= =?iso-8859-1?Q?tliqa+0eZ3XT4jEYjrPFrDmDhr/GqtIEtz3lg+Vi3OkYIqLbIynUjTODN9?= =?iso-8859-1?Q?l6htJPfk/T60PLfpn4telrsE/WplDh2+tZcHCIGLJtZKrMGWUlfi+1HaEu?= =?iso-8859-1?Q?CzxEiY1UgnTO3JD45aVH9QUdk0OOTofTtUtgMPO30C9vQ6PKc0LAUCkA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 040c04a7-278c-4181-bfd5-08dc1bf99146 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 09:56:27.9704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ASDNs5xW97HhZl7qAjHJGw0Bv8QICaOWDygiOoMj7hgFQ3kUyI9CNYcwbZLZxNphNuVQPGDUbGLX/CIcqtP/QWqW+ZkPQjlD6oCMC6H6Cvk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7262 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 23, 2024 at 10:48:47AM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > The documentation of how single-link port-queue pairs were counted in > > the rte_event_dev_config structure did not match the actual > > implementation and, if following the documentation, certain valid > > What "documentation" and what "implementation" are you talking about here? > > I'm confused. An DLB2 fix in the form of Eventdev API documentation update. > The documentation in the header file did not match the implementation in the rte_eventdev.c file. The current documentation states[1] that "This value cannot exceed the max_event_queues which previously provided in rte_event_dev_info_get()", but if you check the implementation in the C file[2], it actually checks the passed value against "info.max_event_queues + info.max_single_link_event_port_queue_pairs". [1] https://doc.dpdk.org/api/structrte__event__dev__config.html#a703c026d74436b05fc656652324101e4 [2] https://git.dpdk.org/dpdk/tree/lib/eventdev/rte_eventdev.c#n402