From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26B8D43927; Mon, 22 Jan 2024 10:05:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABFD54028B; Mon, 22 Jan 2024 10:05:44 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id E95F140271 for ; Mon, 22 Jan 2024 10:05:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705914343; x=1737450343; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=y6BxSb1oBqKdvhX7Jy1MQMJS0Jk8L84pQ5L40ej09o0=; b=Enpi70bDF4Ea4DF47vpaokBmqjpFJCoDQeQeiL6b6lk58H0JXMS1rSZ5 AnLgNRenCLsu2fogemgM3KuXcEbAbMREw6ifqvog7ziP1GKWou/AhkR5O sqHNBX4istcoG8D47rrssP76YWRgv2vrPVsqZODgIkbiAY2ugOfqLG03q YRb6AhGqfXWbWdSM5Pjue7+AUP/um/1VJTSyf0wYf5B05xRDIdwu8YvpA 8BAJbpz6NItXzPCpFdCU03Q4H3U6/Le5/RZmDl5/2in+KdHttQd3+mfqI TOxqeCT1WpMiDnbz2zdp5ujMzSqiLSwc+Rx3V8sJ6KoVlvpI5nZ6LVG4Z w==; X-IronPort-AV: E=McAfee;i="6600,9927,10960"; a="44304" X-IronPort-AV: E=Sophos;i="6.05,211,1701158400"; d="scan'208";a="44304" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2024 01:05:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,211,1701158400"; d="scan'208";a="27291686" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Jan 2024 01:05:41 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 22 Jan 2024 01:05:41 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 22 Jan 2024 01:05:41 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 22 Jan 2024 01:05:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aL4Z9YFi9DxNCKMhJRr3xqZtvlDMST8pMmanAuatoZoUwH4yTM5MGaKh25sfpcka2UTrVuBcnV3U4DwkuF84PJqflBXHBeTJs3+gI261mC2OcZV9DNBv0n1+Q6kw0opf8hF3vFpNnyy6Jbhp4ZtUkSmS2UaZSd5HYQYZPegD1lwJYiI0QOLuYAMdKYYETj8UXkSLWoWDdfN2/Pvi8tHzavVKYsqN3HG9yqmuNehsvilhqNOJCdKivExDLUhxaDKhbMh8VrrUe859VM7Kt8NBlTNPJV7jmHMPz7QHBauOU//SxgV5cJ1EhngtjGMB2La29KA0/ZPXT68jaD+aGYtotQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dCgnpKpfiSnfFsKvuSy9ek3fEuPOteP7tcvdCWXG7/Q=; b=cJ1mt/6DuD0dJengncjjDyQ8XiP/SQx1USAZ7zA6W2U3mEqvh08z1WXuAM2MvaIAb9JM90qDeO/jDCp2a788rCtbKBEh8EBUW1nN8lpZMKFrDlM1Jxzi97qOoW+fmtkQO8NTnRl76yLuvaP5Jj4cXVQB/6ChTVth8x5bte6jqq4hj08tjsIFNh87cRxmwc1wAiVmrr8r2kII3lM+/EbQ2yoAw9JEY2JU+nGYpKoUFT4qbefbDyFfifkSwSksnq0QPYM9e+cEH2qQCm3nyRszJYFnFNgu0iUKVzs+tJny5ot+MC1pwGyBrMVhS9eQnxlnfAXyfXw0tI+uCNSGTABALg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB6566.namprd11.prod.outlook.com (2603:10b6:806:251::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.32; Mon, 22 Jan 2024 09:05:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7202.028; Mon, 22 Jan 2024 09:05:31 +0000 Date: Mon, 22 Jan 2024 09:05:27 +0000 From: Bruce Richardson To: 1819846787 <1819846787@qq.com> CC: David Marchand , dev , ciara.power Subject: Re: =?utf-8?B?5Zue5aSN77yaIFtQQVRDSF0gbGli?= =?utf-8?Q?=2Ftelemetry=3Afi?= =?utf-8?Q?x?= telemetry conns leak in case of socket write fail Message-ID: References: Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB8PR03CA0030.eurprd03.prod.outlook.com (2603:10a6:10:be::43) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB6566:EE_ X-MS-Office365-Filtering-Correlation-Id: 91e4a882-a6f4-45aa-bcef-08dc1b294932 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tIcgohovB3RaHk1EJIkhFSeoT64JxXrkNm+7/s7DWk0PIHoyqn2T65HfBRNJGReHx1XFZETG2wT8V5UkeeVQjG9N4jtz5Bl8Uw719Q8xHGlM7eOalgunXSpCXBXKlBO1N4bT3IDus/61WJOZ5dai3/THifnJRIUSHaDxRHdpTyc9C5KXnFoL8W4/dbav9nfL0jizbkP2msnib8fbOV/8Bs8CMgL+i2fAfo/0VmEQL1u5g4guUah33wNflEVJ5M2TqrKzNmB7DqRwwJ7wpPQeKQYJ+zFARG2ffmQA4EXuzouf2QqDEP5Os7wsXDj0ebwYXqGojMejYypLE2RS9DfW1AJJPaw8vFWrgrqi6mh4Xc7PwHHuodsTvnfHgiTvxWxhtYLCN4OIcYo9h+eV/BARm5hN79OzUTPVZ0gfBcl2JQD/SEAS816RIODTfCPZananpDb8rdUO3BUJMi+nnuDzizxMqdDBswhYVDKMUQXQdFiy6M4QSua2gqMbXgSpqld+VbPURptDIk5s5zwv9UoEnMQPaebT5aJp9uq2ffLUge/SF9+okBJbI+UsLOYfEWPVgGF0V9hFuFWpJTUDtSee6A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(346002)(366004)(396003)(136003)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(83380400001)(38100700002)(26005)(5660300002)(107886003)(4326008)(8936002)(41300700001)(2906002)(478600001)(6486002)(66946007)(6666004)(966005)(6506007)(6512007)(66476007)(66556008)(44832011)(6916009)(316002)(54906003)(86362001)(224303003)(82960400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c01tZHlRTnRMU2VCVnhlUjVaWER1YzIyaGUvRGQ5SEgxRGRUaFRwSmZwK2VU?= =?utf-8?B?cWxNNWxHemllZFNYdmtDRTRGSlV1WTQwcGdXeXMvMVdSZTZNaGhOU0d0Q0lq?= =?utf-8?B?ZnA0NmVsZm8vYTcvcXlVdjJIeW9WNCtvejRmVWYzWHh1anpFTWowdVpTQTNU?= =?utf-8?B?UnU2N3hIZzVOYTIraXBuQkpXZERvRk4rR2ZDUGEweHlJeWp0Ymx0Q0xNMEo0?= =?utf-8?B?WEZ0M3JNeTBoUmxDRC85Q3FyK0V5bDJ5d1ZPcE42R0srNWtPZGhCTzNQYjlT?= =?utf-8?B?TVhUTFRBK0xSMm0zYnNBb1JsR1BJYzRMMS8rVzU4aHNvK1MrU1BpMTM1eWhn?= =?utf-8?B?UHJWaXlUQWgzREs4TXBONDEyZ0ZnYzV6MjBMQnprN3lEQVFodjlQbzA3bzVR?= =?utf-8?B?UHUxdE5KNDRrd1g4bDU5OERJVEY0eG5iaVBlMGVXMkhhLzlSdlFqMDVrd0hR?= =?utf-8?B?dVFFd0tQSks2VnRNU1V6M2pVMlNYbUdERnkvTGppME5LZXdqQVZMWjQ3U0hS?= =?utf-8?B?a1d1QjJ5QzgvU3Zqbk9DdDRrNkZyUzhPV2VXUlU4N29TMitGZW9FMGNpRE04?= =?utf-8?B?ZGR4cHJ4Zy9FNXFyQzU1NUJTWnJiTlJsa1dZVjZZaXVYb1hmZWx2dkFpSnlj?= =?utf-8?B?TENkcWtJZ0E0N1lWdnlIUExwR2VudXVQSW5ZYnNZYWlDd0padnBMZlVIQ3k4?= =?utf-8?B?RnZkWlZ6UUpRNCtrWXJOZytKa3YwMHpnN3hJMHRBQTJBRmtpblNZZGJoV0l2?= =?utf-8?B?QjNwRWlESWZNdE5oSHVnTlBZWEJYak5vcUZuSkhkdjFLbG9tTnZRRGNUT2ZW?= =?utf-8?B?L2oya1pPWmFkY3RpdzU0azZ6NElIOThkaTBHVStBRm02dVhMUSsxRVZ6QTUr?= =?utf-8?B?dVN0NXJadEkvUERhOG9aU1VlUkczZTRNVXhMZzRHVUpKWEdETU5PNFoydFYx?= =?utf-8?B?WVZWYlVjNVM1SnpoRG0veXBCNW9MVElLL2Nub1MzYm4wSkptSi9CS3hZTUZk?= =?utf-8?B?RHA3a2F3b0xXaFJwRVZTSVlXL01TQ1VnM0NRS3lOMTdkVm1ZSWZDS2RYNzVL?= =?utf-8?B?RDZ6TmJNcGJUOHdMMUFCRWpXYlc0a1BQakI5dWp0T1lMQkt1cGdUMDFTWElM?= =?utf-8?B?U1NTTmlweXNlOTJtNUJ1WVFmNWg5L1dGWWpETGlTaE1TUUszaHJWVXJPTTVm?= =?utf-8?B?S0haRytlSmZxS0xBZkhZSlRaVVE3dTFtQklLUFVvUHoyRkRucGZ2RmptQ2Uv?= =?utf-8?B?NlRYY0ErSkNGanpzZllJL0Z5ZDg4WldrR3dUUWNXbmgrd0xzM1h0d0pCZFlt?= =?utf-8?B?bVN4WTF2Y2htR2VXcnl3T2ZhQmN4TCtOSTNTNjFXTUZMcVBLMkhWQXBGSkR6?= =?utf-8?B?SHY4VDRINW9oSmtCMGQyVTRzMmcvbXRNdUYvbityR2UrdmNCZElna3BGZFFs?= =?utf-8?B?dVhobHpsaTVYelN0SlZjOFlwaElXZ1pjUStpamo3NEpqQW1IVk5qR01Ncm9J?= =?utf-8?B?bk1NNXBRd0FjRlIxYzNZLzdUNC9UMGdqTitBZCtQaGZ0L1ZQUnpaVk5GVC81?= =?utf-8?B?S3FqRThRUVlDcEhQVGhqRUsxamN4anJHMHNibmJSTWsrUFdDZDd5eHU0ZytU?= =?utf-8?B?VElVREtpMkw3U2xFbDEwZ0xudmhmNlpTckd0Wjk5NkE1VVF3MGQ1RmxUckt2?= =?utf-8?B?SHplSmoxSFovUmJjNXhiN2J2UnhuYW9obHF3NFcwT25LSE5sYnZlSS9jR2xy?= =?utf-8?B?QXMydlk1czlDRFVZKzE3U3JXdWZIbGZQZEVpd1dQdU9iVE5VNGxDQUZZVXRQ?= =?utf-8?B?SnZtUHozVmpNYmZ1T2I3bEVTd3ovNGpZNEd4dWFVTUJRTSs5L1o4SkI5Ymsv?= =?utf-8?B?NWVCQ1U3RmlvcmluNjRMN01xS0NhUVpJa0VhSmZubytpeUpYMjRzL0wyZFJ0?= =?utf-8?B?N0xlZ0RyVE4wZ1ZJWnVQMFJFU3BUTjIxRE1pTm9XTFNJU1cvMWQ0dTcxaFk0?= =?utf-8?B?WUVZcUZBSzM2bHJSWVNyZEx5K2NVWENWaWk1d091SlVPUE9oOXB4NkN6UzJG?= =?utf-8?B?QU80cjJYbTJzY21sMk5nZkhrcUZIdlByL3VvdmNMSXVQd2gyQVNyMWQ1WHB5?= =?utf-8?B?ejlaNVFEOWRHSVBwNGZKRVlLUVF5bmZNV1V2b0VEamlINld0N3lnUGY3N29k?= =?utf-8?B?UXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 91e4a882-a6f4-45aa-bcef-08dc1b294932 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2024 09:05:31.6435 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JlfWKHv9aFOIHIM5AL0lHV8J8Egy9fhiBQMhZ4yacb01ppycHiNWK2EeS8MRvLFREC50n6FKNe/ta33XCy+2L6t/QlxJLEOXU0uCvqPlxwg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6566 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Jan 20, 2024 at 12:18:38PM +0800, 1819846787 wrote: > I have modified my commitlog and resubmitted the patch, but I seem to > have forgotten to add a [v2] flag to the patch. Do I need to resubmit > the patch again? > It's better if the v2 is added, but it's probably not necessary in this case. However, I see now you have resubmitted as a v2 anyway, which is fine. Please mark older versions of the patch as "superceded" in patchwork (patches.dpdk.org site - you'll need an account created with the email address used to submit your patches. That will allow you to update the status of your own patches yourself) Also, one other tip, when submitting a new version of a previously reviewed patch, unless there are major changes, you can keep any previously added acks from reviewers. For your v2, for example, after your signed-off-by you could have also added the "Acked-by: Ciara Power ... " line. Hope these tips help in the future! Thanks for the contribution. /Bruce > ------------------ ԭʼʼ� ------------------ > > ����: "David Marchand"; > ��ʱ�: 2024119() 11:54 > ռ�: " "<1819846787@qq.com>; > ��: "dev"; "ciara.power"; "Bruce > Richardson"; > : Re: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket > write fail > > Hello, > On Fri, Jan 19, 2024 at 12:40�6�2PM sunshaowei01 <[1]1819846787@qq.com> > wrote: > > > > Telemetry can only create 10 conns by default, each of which is > processed > > by a thread. > > > > When a thread fails to write using socket, the thread will end > directly > > without reducing the total number of conns. > > > > This will result in the machine running for a long time, and if there > are > > 10 failures, the telemetry will be unavailable > > > Thanks for the patch, do you know which commit first triggered the > issue? > This is needed so we add a Fixes: tag in the commitlog for backporting > the fix in stable releases. > See > [2]https://doc.dpdk.org/guides/contributing/patches.html#patch-fix-rela > ted-issues > > Signed-off-by: sunshaowei01 <[3]1819846787@qq.com> > We need your full name in the SoB tag. > Like, for example in my case, it would be David Marchand > <[4]david.marchand@redhat.com>. > -- > David Marchand > > References > > 1. mailto:1819846787@qq.com > 2. https://doc.dpdk.org/guides/contributing/patches.html#patch-fix-related-issues > 3. mailto:1819846787@qq.com > 4. mailto:david.marchand@redhat.com