From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42A17438FD; Fri, 19 Jan 2024 12:54:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA56E40A75; Fri, 19 Jan 2024 12:54:38 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 783664029F for ; Fri, 19 Jan 2024 12:54:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705665276; x=1737201276; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=CkeYqOalloHIkiDMzekWobVYYdbxfJnyEMo9Ao0MgPM=; b=MgMlf2oW8xqW5own43t31zR8SGa/USB8OQA+M1tWqGmcP4RQEYs91Dqu 7Ez/qM5x2FogcZeGWqSssTU/BISIBU3e6a1nEH9zpuxa4EY2BYScV1iG0 6yvu9HeJAqisKPQHDbEI5T3TrsJaOHA8DgrQ6tr2N1KdBev5B4O4qMgL/ FcpvfGCcAtw4e8cdNC9YbVa16El4nG6O3YxrlXgJX9mmq7WYo3l+Un5vb aImIMeGloiM3u5YUutRCMNW+Gi9Qk+8Vs5A75M8qV+xKZbuFIUEkR5ISh SHalARJ11t4GaxwS37E2T/t9q9JJTsAQmU05dF8eNA1mg3Df2v6Jzgurq w==; X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="625893" X-IronPort-AV: E=Sophos;i="6.05,204,1701158400"; d="scan'208";a="625893" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2024 03:54:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="928387087" X-IronPort-AV: E=Sophos;i="6.05,204,1701158400"; d="scan'208";a="928387087" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Jan 2024 03:54:34 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 19 Jan 2024 03:54:33 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 19 Jan 2024 03:54:32 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 19 Jan 2024 03:54:32 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 19 Jan 2024 03:54:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cn2MPLn1T1ZOqsPZjdidv3aErIC8OXiTTM0YEMs0b3NAgw6ciSnp+sDe+7J+uacOtVtUQLWnKwOsK84HnU5Q1Hn7BcIGzz9vK8Z9P6MyyBCthokc2Ei63sZaom12ToGcuvkyr73kNXlpiIyvzLINBr+GJnzTs0YwjrkRd69C9xobJoTGsv9rXMiWRgwA5WPIo7N3NFfVstHP4Lj9j+ToKEB5icVTwKwAhCnU79FvzmRaGH87tI2/JD5rxTw1TwtaOXc/mvE5ydT2L0ud6EUzDehiWck+vzA5c3ZWRrU9nGCtzNPXCPEyo+mxtJA7Wj7TwQy6I6U9un2ZzUaQUaFDcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7E1zyOudk8aJIPHxKWRYbY93bpMkWnSsyyr+1oBmsfg=; b=h40CMX7SB9g7cRyEOEERfu+huG3nHKd9IJ0WP9WFoSAiGPm8UYYgcDniiCwNi9bACAJxBNmS6OOEgM2Rd3L+bgRUbC/yI5OGMnLhXYQ01j4nGHjrzhBnSLWWIfIueDUQkqIdBvHnnT91VTB64Q2BSdf+xek5Lr3QY65y4gHoSFDWG0Abw+aVBvnNKPW0uz8fQvgh9HEizlUXzTV5Kq4/KcDxZ2tDwyCfxmMGHxVbBWPG+7g5fiFRAqzDsLL/Fi2S8k184SUjWtQ5p4JNwnzY05KYb8HiA5M+kCN3y0UDAKp90i/bCcVTWmxaatAl+tdPQKDI+wpNiWJeRI5ROz92pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB4790.namprd11.prod.outlook.com (2603:10b6:510:40::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.26; Fri, 19 Jan 2024 11:54:30 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7202.024; Fri, 19 Jan 2024 11:54:30 +0000 Date: Fri, 19 Jan 2024 11:54:25 +0000 From: Bruce Richardson To: sunshaowei01 <1819846787@qq.com> CC: , Subject: Re: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail Message-ID: References: Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8PR04CA0014.eurprd04.prod.outlook.com (2603:10a6:10:110::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB4790:EE_ X-MS-Office365-Filtering-Correlation-Id: 1535b217-592a-47d3-afb6-08dc18e5653c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4TMuq42PK2+nlNcTrWR50s15m3zN/i/uauZ65/QDtuZXCah7xA66idRjih0hi9W3PJRGFdXsxyxmKcal5oXwedo8Rea8XtIT20y9S9PFInTaw7/1HQ+G7KlBka/auwf76qaqI9rlgxgITR+Cd1EPBjxbxWEp7DLF4qaKSPFaOqFeXv/FoW95d8fDAnQ+QaqIbhvR/JdDmlzYCl5BITnv2iHUXoPrdVT1XOyGdY5Bc5/nczkvxHYf33x2jWQY5V3mPRycTPnMjcahlpxA9uMYy0RRXLNVRNaj9jSVfFWbyzYNvnYYHrYJplL/Bk0PXrZqSDP7Gr8pUIdn3wyz04/P4Mr8P1ElQ/S6MZC8J9c4ItnHXgnQxId4UNuMqcCQJX2/Wk8abKMwR1sTeCJsCeAF11TOmXztJEhs88TaYE3yROgCap6VnjPPI2e1AL6KFOpg/pTaQOhQhBC8dgk42YXmllBXxJ+kVK+HXHfYE5K9V8UNeCrLFwJSmITZ7OhAUN1SpRteHEr39BA569VhKNrDEyVir/FrQuGGHHWFH99sauBmjvmPJstrFQXQ67wm3ipS X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(136003)(346002)(376002)(396003)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(83380400001)(86362001)(41300700001)(82960400001)(38100700002)(6486002)(478600001)(44832011)(8676002)(8936002)(66556008)(316002)(66476007)(6916009)(66946007)(4744005)(2906002)(107886003)(6666004)(26005)(6512007)(6506007)(5660300002)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aIrBXZvyd2mFdkPkaPV6fnJ7Hjf3mB+PGh335NIyB2jDjsQyE2wPcunAM9oP?= =?us-ascii?Q?kGw/fAh/FxHEwXMeeZhAE0aXd2VRx0nqSryIhQLBtD9yy7beUq/xkf0oohxB?= =?us-ascii?Q?bZ+j5EU/ax9kmXkMYcAB6ECbm0WCIMnvS5xPEfWf/sEyz9UfU8iH3u3Hi/UG?= =?us-ascii?Q?ZFUgFC+56ob6AjzxDnz5xNpFB/6oZJ7kAsC8MDegZGICRtA1cQji0/JLQFk5?= =?us-ascii?Q?Kjmw8ZrSpIXGbWrNly1zX9DGojt+Sbv7FocWSxPSZfqkd4LP52rm9MibrEIF?= =?us-ascii?Q?+qPvo/qLXsRLahHQjDc/+ZcS0ndBNG42VxwzTvl9cK7xw8+Df6eQwmY+Zsof?= =?us-ascii?Q?dqFzta2Gt9VFbyQnxBlq61x2CUvb0C5dYUGgdKea6M3OA8YuSS+tXMNXBOh/?= =?us-ascii?Q?+SKTmuCJP+Z0LGjK4+/j/IfWYvsR3m98gBeMOmxOI9F43321wB4PVbPceELS?= =?us-ascii?Q?Ld4aZGk0RuyV39RawbiQ2AaxoMbf5YRzq25i5t/QB2BhIb/R0p5fwm7Vo83M?= =?us-ascii?Q?z3zYSHj/c1TQKjbsBiqM/RFVEhxxzmRaJwIuzWGqT/+lIu+3tqWkusLSXDdF?= =?us-ascii?Q?XaPhSyFCg9wtejIARvzmoaCt9db/mYmgP23y0e2PySakcn5Bv0pjQUIjCDaG?= =?us-ascii?Q?Xs75kK47MCT0KrtYc686xKiMpOim3gzmd09voJ2L+L8KLR9LOX/VUTIkql4B?= =?us-ascii?Q?0kWKsLgxoB6Nm5TjYr6a3/Z9mKMATE5nDBtA1+ft9uQp1Bpri2ZkdvlRqnyH?= =?us-ascii?Q?7JJUaoemgidMxL/KimUtYd3l7T3Apb+2VKCd21ZwexKJe1qN7o+kx5XYpQ2x?= =?us-ascii?Q?VhLC5RVA//iAcqK3lPEv1Q8zGH8amx2NQVC2BjEQChuHvuE9wiAsGfXO4X9Z?= =?us-ascii?Q?HvT0F9Ag4v9fOoPCfiafsLGe9wuHHUMtQAOxUCSjrW8SBIXpB1sCt80UwihR?= =?us-ascii?Q?qF8pFKnQuFEnf1JEKy5xgs2gn9y0Vz1pk0RYez28yQLTdir+U3Xc1M72DAic?= =?us-ascii?Q?SrtYh4DXeE731NeB7pDAU/GxPpEdcWASg7NzabdK/kWebsDNWFgwftbrU7wi?= =?us-ascii?Q?dyXm3UX5RGksHqC92OC/6C+T1CP7axFxzDf+BntctoegBNpZQ5gD30OoAZwG?= =?us-ascii?Q?DMiyLY3yN8ua5ooIEu3FpC+KX7pb2QUiT0Z2ZYtT12Rp9JeVoOT0oIwY+Qid?= =?us-ascii?Q?Ul4HO3M0gsnt2wrm3UMcjhscpMjg8Z08xFqdgdgd7k2ZN4EDsMsxSIkUc6F6?= =?us-ascii?Q?1FlQMm1x86Dtf0/hJyxsbOsgL0QXEzd2P8TTM2mhMRBJKIFhCkC7C5Os0mGj?= =?us-ascii?Q?wHVOCkqh02bzs/isiipcPKjtYpyl5QHpuec1rknr+6FxXeoKRBWcF/ldP3C1?= =?us-ascii?Q?CpHSabCcS41511Z/tiQCAHub7X/499gR+y74liCcxP8C0TcNwAER8PiJD38M?= =?us-ascii?Q?m+ABkdN3Iyfx2UmI/NVDpiJw56e7OOj3lRR+WU1EDr2rWPOPv/XeuZJPOAip?= =?us-ascii?Q?ekF4ovyuOFNU7kIGH++DqknKbZ+Re+nElIci+OJhfgp+JWPOjoapFwxZCGEB?= =?us-ascii?Q?GrU9GgYNbxyXBfAOfPRZvMTTQ27ZclfK89Vo/E9BWG2feJ3qZxGa9777Nora?= =?us-ascii?Q?AQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1535b217-592a-47d3-afb6-08dc18e5653c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2024 11:54:30.5820 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2Uzs0dq4o+NlvplJ84iPDyUZ2YgsZCq/dkpZBBcQ9vImyB3q72+t7I8p0yvxs3o0ME6N/uqFYY2gmu7Si03kJlI+sQvm5Ws/oL+yp306YMQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4790 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 19, 2024 at 07:40:00PM +0800, sunshaowei01 wrote: > Telemetry can only create 10 conns by default, each of which is processed > by a thread. > > When a thread fails to write using socket, the thread will end directly > without reducing the total number of conns. > > This will result in the machine running for a long time, and if there are > 10 failures, the telemetry will be unavailable > > Signed-off-by: sunshaowei01 <1819846787@qq.com> > --- Acked-by: Bruce Richardson