From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE086439B6; Wed, 24 Jan 2024 14:27:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B9BB42DC5; Wed, 24 Jan 2024 14:27:13 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mails.dpdk.org (Postfix) with ESMTP id 3530542DC4 for ; Wed, 24 Jan 2024 14:27:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706102832; x=1737638832; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=1StHBar1qltUdzBNnFJ9nFuqwJO9oCcG4+q+fZOvMWk=; b=DAKNYYC7oINGZUw607ZtdiHBffIj4Q6/A+udwxeaNgPjoIONp8p16hjB STijo+MvsNXclBnFhd0jDA+lhTotPujx23Ksoj4RMgxZj4RwguG2bfXEv F0JSsCidXYF4HrRv4VW6f/c1sO11EO1QBCthkXgdzjwjIa9GKTkFra15d 0C+MQuexyKkuBTQrEULzUJjp4bnBIJfGzrIwSHc699ozYk15Rjr4YgZs9 anFJ1Z7hF8+4mKb+SEvrP7QsRy5uMMio8WbSue3GWuAnKJy5v0hnr3x9K +3saVxoSTOz1EYF8SHTLL5bwaT5OhJoZmPufsJMPxw3ahvcUdweKWjWIL g==; X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="8514251" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="8514251" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2024 05:27:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="929683436" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="929683436" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Jan 2024 05:27:10 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Jan 2024 05:27:10 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Jan 2024 05:27:09 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 24 Jan 2024 05:27:09 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 24 Jan 2024 05:27:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k/8pG9Zilv3RSTc5xfjQv/yYaBc4TEAxoL0wfkYElyBUdKFQ2cHRTu9LOUTH8FdKbgpOCYVvfExU+rfWDpVI2CapyNCb9RkCYstueGIH8Hu3OST5leuu+4kbEGt+FyWgvtyA4JlPlEnH0k7qvSQ9aiVPqyHBX68OKLOn4TQzg5qsf/fkBrnHyx5vQeElofikjkXMM5EiOU8qN5tegL6hrwAbNUQhM0nYHWkTP5fxahFuiNOhd8p6FMp8s/WPxTDPw74h+cAaL7CQIkZRb6lZFx5GqSCqTLzvsussBDIr9eRGavdChszj9f6/xjJNl+PbXEV1bqPgwJJopxx74t2QiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xhEJ6EJvEvqXo9VnUoIMlhv6gDKyTcl4ypLgZV0xxYs=; b=dmzWfsOHCErZ16sio7YKsOMz+LTKBoX5uMYeEacU4xPUwuApjNOG5EYaC1t3DJNIJlOJ8X04WGfJc/M+4cfxcji1UFOowaDFJFf3iO7u/H9LD/TX2DGtklkqGlTuEGHuoWmAb0kugRMI45KMXvW0yPUOtkMC2yKoLfau8CCd2U066uh6AQi2nHxlG501B00VX4At0detNRiBckyYkDkPWHqryYXPeHbsG4mUb2p1zUerBkbXaXQ60/M6zsD7IEdKslKVp7S1XlT1M+0ewgmohW0yjS8UWoP/GO49aIBTI5Ri/mi6Lmo8QMVqAuAkI4r+ydKW3QBc8byFc7LmrPEUkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB7067.namprd11.prod.outlook.com (2603:10b6:806:29a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.24; Wed, 24 Jan 2024 13:27:05 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7202.035; Wed, 24 Jan 2024 13:27:04 +0000 Date: Wed, 24 Jan 2024 13:26:58 +0000 From: Bruce Richardson To: David Marchand CC: , Thomas Monjalon , Chengwen Feng , Kevin Laatz , "Elena Agostini" , Jerin Jacob , "Kiran Kumar K" , Nithin Dabilpuram , Zhirun Yan , Pavan Nikhilesh , Ciara Power , "Maxime Coquelin" , Chenbo Xia , Andrew Rybchenko Subject: Re: [PATCH] lib: remove duplicate prefix in logs Message-ID: References: <20240124120450.546364-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240124120450.546364-1-david.marchand@redhat.com> X-ClientProxiedBy: DUZP191CA0011.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f9::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB7067:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b7afc88-982a-4e51-8e57-08dc1ce027dc X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AFxdWMjap3K6R04ynqn+YLqWEYlr0gU4HAZObNo6KBtwVTG35fs1OH2QK1r9eVrGiQJuQ1SND2Zr9VS/QCuUZiuzAwkIQE3YLcg/Ne9vA1zXrAsK1JYkS6NjernuKqujO5OhLBk3ucK4gl2p98eOLbO2WxBVzAorRWgp2hEvhjNJr1+7aWeFYkAcjN7nQx+t1XsUi6CjMtJcyuMK/y7LUaWJgexhGI6mZq4hTOO3wtKdBjNrGuVeCfr3Rn+HTYhBzQYpj7x9+QBIhy/AkYAf/xzmNlk4RSkN4emFtOnyz2AF5kirIhPmoMpmChHynGzpkaKzV79OLVWBo5oMBL/mrOnMenqTK6Nyokvuz/uXtb4mkLp14RPXluOypF6rqGCurZuV70Yyf9xTExVDglDlCg04BE/YN5At7whMngwRdNz1oKsunNZODWTk0REiR756pIIjwTd/xboass4EerBPA8zDMBdiBjtlaoLTIz+tqq+PqJMnbEhGt0SN8wRldHbNc3JUDE2/KT/prxTfiYbRivJ+j19yUTUJDYq5IUG6q2F3D693m3Bgn6f8pmAa7vmV X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(136003)(376002)(366004)(396003)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(83380400001)(6512007)(26005)(38100700002)(6486002)(4326008)(44832011)(8676002)(5660300002)(8936002)(7416002)(2906002)(478600001)(6506007)(66556008)(66476007)(6666004)(54906003)(6916009)(66946007)(316002)(41300700001)(82960400001)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?azag49h/OS6avMfl9l5LNGtmW2aRnBHRrQ9ufGOQUEMd2bxU67kVM/7p2m1I?= =?us-ascii?Q?dsIAOd6BwIIpk3yreInxQiNMPkqZcZxrKloeUjuoL2KwkqirX+Uc0XSpC+tU?= =?us-ascii?Q?LBm1jJSBl/hjJMuDYgTDsjT+kGkaq8FV1Yo99Yz3SG5YhZTiY+25lxO2HV83?= =?us-ascii?Q?rm2Da7zZt40fz3jMHUYHWFYC5MzBzTqqIcnfRy+Iik30ITIR2HRJfE+ZAmOQ?= =?us-ascii?Q?vt2nkHcFEPEbjcfsEm7yiuT+5vtAHPwSvNmRaTKCu4xGf/OAyBgtJXUcX5Wy?= =?us-ascii?Q?QqItwCz8ZiSYonZ9Bqywbt27py7Jdd8v0a/LiX3p+6UIiM29ZwwijYKj5uk+?= =?us-ascii?Q?MCDINWysX5B/34h7n0DLXQ3LxnPiZx0IDigmq0zq65ryzAlBLCs57u3TRhbQ?= =?us-ascii?Q?vVxCdDcw2aglMiu255i/pLjHekd40rMdb2AFu9nxCYNsuuYsspJ423towqKI?= =?us-ascii?Q?rLlqYNazwLJLdRvGVZBWGr31ZnjB/PfuCsty4FZrSbkpm9XXmLtQMnYPTtdi?= =?us-ascii?Q?v/U/Un+rvGHCEr5jUDXKTwezb2jNF1T0oj7j5yseql0m8LLHjHKDy6GT1h45?= =?us-ascii?Q?Lu+0Z471cKFQa0b1+AGaY52j+mb+qEgEZ0laXyE5llgkNPidu67QLhlolyND?= =?us-ascii?Q?SsPuXSh5XBxX1mHZhRjQ+P+Bps7dpwCU2HFr5bV5OZX7wKnf36is8zJM1fd7?= =?us-ascii?Q?R6uEtYNfkqrrbAUHYmpOL5N+yncnEBo/IVBZBU94Y5h7lbJSFz5C43gxuQgX?= =?us-ascii?Q?nxFYoNxWmIjDXxu40qL+GS97qH8LR8fZYB3EnB/Yc1ENfC8+RHR1LZG9aHNd?= =?us-ascii?Q?rtbeignJYADwyhJmrU7ebC3yUMWeZwBqVTSgsEX1VGbLir6qsCSKeb1jiDx1?= =?us-ascii?Q?iGhuWADc2/Xnf9/A/BDTXlnXJMfg6QUx53yIemLBFVN0XljdQ83Jfs776BIs?= =?us-ascii?Q?wWb+BqPSM61Feh72+6UzE9xV6y+BTlQeWIp7Uof/2eEwxr5bgxuqfacFUixg?= =?us-ascii?Q?xY+KSNPHbRj8bm+n4qLX0Y+NJmQT1qS20yNVRwvN/IuBIHpEq/OvTb8cy1+t?= =?us-ascii?Q?xZvsxSVWTJJUKEUq991etFMaVb0HKEcIaa8w9frW03N0V2OJGGOY7oLTbVaH?= =?us-ascii?Q?UpNs5cl8dGTU2RYeHKbKPUV9SKZCW9BK3SED8CWicpvP97ZOGhBTkhgB6Pmi?= =?us-ascii?Q?TW4Rygb2EBSMHynouyly0Y4o+F/rBRefmoc9IO1oYV987q2ui/JIsMjgZTXU?= =?us-ascii?Q?VxtF0w6aVZEFsQmeowtggTNeKxl8FI9z7JkOJd0g3BQQJopOZKgonlwyfBmY?= =?us-ascii?Q?tol/l1QEtdZkhz1MVeCPQI7LTfkBHRSpTPaAGAyz7YE7oEVmco34bBdLn82C?= =?us-ascii?Q?jsp8BdB5BdCoQTWlGZxs73s0tsJDyS+hNPXHw98WFPGsrsWqHlObTIRSiLnu?= =?us-ascii?Q?uNKNtJDN/QSiZYsZpiF5zoU+HC9o4LDC72oyNhcpuE7rG528XEuMTiB9MR6C?= =?us-ascii?Q?4H4C93JtyHr+a544/gYzwIaVMsHzDTgazOouESNUuyu+9uz7mzhVW6Kwb1Ch?= =?us-ascii?Q?Lu57K7gDLQ77wYg3dMEOvs0mRylTQQbkaKCY7iAMddt6vA+LKdYZ6cDooMtK?= =?us-ascii?Q?FA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4b7afc88-982a-4e51-8e57-08dc1ce027dc X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 13:27:04.8742 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kEi2mRulIHEDk0y4OfOIKewiX5Ex663ZTbk5W+qOCAm6U5vlAT27CP3SU79c2Wc6accK4Ot0BrxfwaxJ7Ev/TqXZIQaNKSDAP45b8I6C3t4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7067 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 24, 2024 at 01:04:49PM +0100, David Marchand wrote: > RTE_LOG() macros prefixe the log messages based on the logtype. > This results in logs like: > > TMTY: TELEMETRY: Attempting socket bind to path '/run/user/...' > TMTY: TELEMETRY: Socket creation and binding ok > TMTY: TELEMETRY: Telemetry initialized ok > > Remove redundancy in some libraries following their conversion to > RTE_LOG/RTE_LOG_LINE. > > Fixes: 97433132c2ed ("lib: use per line logging in helpers") > Fixes: 0e21c7c07d62 ("lib: replace logging helpers") > > Reported-by: Thomas Monjalon > Signed-off-by: David Marchand > --- > lib/dmadev/rte_dmadev.c | 3 +-- > lib/gpudev/gpudev.c | 3 +-- > lib/graph/graph_private.h | 2 +- > lib/node/node_private.h | 2 +- > lib/telemetry/telemetry.c | 4 ++-- > lib/vhost/vhost.h | 6 +++--- > 6 files changed, 9 insertions(+), 11 deletions(-) > > diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c > index 5953a77bd6..dbaa14f262 100644 > --- a/lib/dmadev/rte_dmadev.c > +++ b/lib/dmadev/rte_dmadev.c > @@ -35,8 +35,7 @@ RTE_LOG_REGISTER_DEFAULT(rte_dma_logtype, INFO); > #define RTE_LOGTYPE_DMA rte_dma_logtype > > #define RTE_DMA_LOG(level, ...) \ > - RTE_LOG_LINE(level, DMA, RTE_FMT("dma: " RTE_FMT_HEAD(__VA_ARGS__ ,), \ > - RTE_FMT_TAIL(__VA_ARGS__ ,))) > + RTE_LOG_LINE(level, DMA, "" __VA_ARGS__) > Is it not useful to have the prefix in the log macro itself? That way it's consistent across all messages. /Bruce