From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C90CF439B6; Wed, 24 Jan 2024 14:28:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B58D942DC4; Wed, 24 Jan 2024 14:28:47 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 051CB42830 for ; Wed, 24 Jan 2024 14:28:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706102926; x=1737638926; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=iM8iIHUpJBssXAGoeIRApRT+5nM8VfvHxfRlbKJZENY=; b=h50B8haegmIcn59wPINImakZ77zJP7vNzqgmgcbt98iAGI1hyr3qY2rK mFeaiW+h2OFIXdMxY5EnTDyziXWQcDJbEYY3GYPsQfn6n8XIxp++mNQoG G0nZPFMpXbqFtIaH3OmD1Wu7sh8FbHD/fkY3T9IhK4xaFek2hwcwtDUrV J4rbB3W/+NBr7hm1L45YTwz5a/4tR/E+OCJFtGsfQnwbjotz12JO5wTwC PZ0yTeFiKAJ9qLkZiEul6/TUSZl6iMBhbizir2YevdsjCfY/HbJVpP8kv T2YvF7oT2Xhi5PRb94GZYOMNUMdn9Snlp8Q3XmiMX4CasVrmdr1FqxO9t A==; X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="8494300" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="8494300" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2024 05:28:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="786417123" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="786417123" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Jan 2024 05:28:44 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Jan 2024 05:28:43 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 24 Jan 2024 05:28:43 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 24 Jan 2024 05:28:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XqBMGMpwRT3OAqi3xYo7afliCq6jbSAyA5/4ewMB16apqCamWLjUnrV7cIKoe9DcL0S+xA9PSKJF+eHJOpCbw7fKdd3wR8irU2qRkuTRUjGvISTvDC+c3QOp8btQf6XOmTCQKIKdWNchtJcTIoZw1NpGG4A+0OvX16x5phWjIof78V7skn38wh6+0t9e90dRTlieKF1nG1zudeFuKirjhVn5BzsimjjywjknkKE2LHjj3sg6K2XeGpDEqIqcXnTltun4mPDcBIWyV5e0DIm1lfh1pkEzNi7wsqhUqQDIuhx1wqylNJAcVlDZVEVi+ogMKSy2P4zXFUcF5fUEJGxR0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xPms2712YBgSIl57kXTIUtMzgYghCSl6u6eI2r/6FXo=; b=UY0iOSIwNg5TmH3WnXBd0zDeM91Li4c/4zgrPHD16bbNQW7rDQOTUuWxKTljWHPWplxpWGbWMHt7iuXehk6liTN5y/IwEWLY16k4Dvnq5yvDYL8iqQp3hLptsuw5WXyPoLdIgUHKYCpGmC+HwDOVtxpXlbYi9ipwaNg0ys1M6q8XERnhpsjRk0Cy/8zG8oeV+oizKHdwygrJ44FC7B/Ljqnq9X/h1Lp64z18hkdPvsDfpgqY9iU4q5NlfDxrK6dPX2vc7ITvKmt7uQd1xQiuDE3NGYaEYOgHIblfVdZPeyOsO29mUXv3mKw2xATVcWcYXkGSMlVq3Nz5q3VwcvQ4YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB7067.namprd11.prod.outlook.com (2603:10b6:806:29a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.24; Wed, 24 Jan 2024 13:28:40 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7202.035; Wed, 24 Jan 2024 13:28:40 +0000 Date: Wed, 24 Jan 2024 13:28:34 +0000 From: Bruce Richardson To: David Marchand CC: , Thomas Monjalon , Chengwen Feng , Kevin Laatz , "Elena Agostini" , Jerin Jacob , "Kiran Kumar K" , Nithin Dabilpuram , Zhirun Yan , Pavan Nikhilesh , Ciara Power , "Maxime Coquelin" , Chenbo Xia , Andrew Rybchenko Subject: Re: [PATCH] lib: remove duplicate prefix in logs Message-ID: References: <20240124120450.546364-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DU6P191CA0037.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53f::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB7067:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c108d2f-7458-40d9-cd3b-08dc1ce060c2 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: im7AERjRHSOYd2W87M85GielxcVLfgOJb+ybYgcWjlgHW/dEQ6gCyu5gB0hLkyH7LvvcXUlZxJfA4ZpuSlJpaWzlZdtdvfN4wPn5vRhZFAvGzEHPNHH3YDh/MCTPvciWB/oh1dKvWAXIrIPyiotPI4MCRUzyJ6PMNdc9uNQVZkwRzLY2m/EyBN8qfuvHKJKBeu8l/rP/o6mn0ckUtiegjZSB3ghqP/MZemm2avq9v7APiBGjABV553HiE6/mZhKlqLI5ckHuDL6Bz1WEM7IQlgw0swy28r0A57K/mElhPCiMcbKaHD5VzatGJCRnzcGhiqfTlhffjc34f6y2OuEID8ZlWMXQgl9YvI7FTcotLBNm2PaHdxfj/ymDxveRs05wkPrjlX1dZHX4pz3RVtPkGdrIviiwgxUbrrONapFoG3mGojhglOw+627WuxHriBlTJ8gzcVhHfBJqh31FvN8Oj45QvaI1F9zLAbQ1bDT3Zn8vu8D9sS4j/LsSjVGv5DqYw75Jy2njDpR3eHcUmoM+N7cJ3XUQV0QH/+h2KdC01hQOM0RXZX93T5gGAl3VIBIy X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(136003)(376002)(366004)(396003)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(83380400001)(6512007)(26005)(38100700002)(6486002)(4326008)(44832011)(8676002)(5660300002)(8936002)(7416002)(2906002)(478600001)(6506007)(66556008)(66476007)(6666004)(54906003)(6916009)(66946007)(316002)(41300700001)(82960400001)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AmQer7JsBUSjqAOGGz3v2fHvtL15uE6x5WA47qGBUgfYbYeX4AQreDyEIiBy?= =?us-ascii?Q?F6nAINY+NVE8ohr5NzjWQQ7lcRw1vEm7sWtu9Ypuh5Iyay90fe94lppslgNm?= =?us-ascii?Q?XQr9g6fXj/y58i7XXUqzHO5EbK8QgyU+wSOrR/4WDr68TaiPyH5tLC9eSHQB?= =?us-ascii?Q?tdR4KBRWKwk8PO+837MRxVhcsWRRnH1+Y2bdPPRkzbp33vRnt8Xg1VUsEXBe?= =?us-ascii?Q?Qs5DVuCsZW2GaRaD3+7ZnkO+UL4/kBG98nbmUZf5/NdRBpyfPg/BU1gQIHKh?= =?us-ascii?Q?NUEVYvUAya7KT3kXozJQkhVjWs6cVd7b5QN97CvhubGftEvEfCK9PxD1zJ39?= =?us-ascii?Q?F/10SIpTwBZbdo19L6y2AUwEsWjhkNObDHhZqTZLpN+WXOsT43rk9BVA339n?= =?us-ascii?Q?YA5vnCwCpvsDPHAQwz3Wh2KaL6jfcwAKexVE1ApyLVqqZHo4Ql68zarPPZfM?= =?us-ascii?Q?vJT9E9LjWN1S0usCVfRrPZr44JPPRxVBaUT8d4padvRmrSZd/oQrpdTc72eU?= =?us-ascii?Q?1GQdMjDClmzigZDFkFjnLSUol5i0xZevOqBW5u5C0CayQcAD1ytuzbf7671/?= =?us-ascii?Q?UpTP+MeEz9VICSPkEHQ3sddhLmuK26zgs8EQwMm6/xplqqk5dsTtvc1RdZZG?= =?us-ascii?Q?6oMnwVESbg+wDeSHqI8O17ANwa4GI3itLZNvYBVSeD3fFKL6gqwUKZEDmKpH?= =?us-ascii?Q?HSPuMYZ2C2PARdoGoLnV87jyqoW4NYYyj68GPUZk1k8oTjjgq2WHH9BfkO25?= =?us-ascii?Q?7Q7Q6cbnfqg1LDt1LGQ7ZoEA0JMI34b45SIvNXxSZmtS+cAmIUY2mRHGVhI7?= =?us-ascii?Q?zRHr5Aq+kStKtxEcE2pvZXfBpLBds0MG7caHOci6b2zkONV9iFKizs0oRE3u?= =?us-ascii?Q?/j8W7Ndq4kN216T5Wx6xULRPv3fkISrON+rjGKa/7ZGmtw6HydmCyS/OPi/Q?= =?us-ascii?Q?Z99WBdlpdHCV0BKCem5V9jcsvtJL7iRYPNr5cxivOJmuVGWbBLuokCYhACDS?= =?us-ascii?Q?MU7nYDBOkC7iAP1zYqMjLWmIaNRcWkYlUStD/0ayAVH0Yohwmn3gzcNUxEDt?= =?us-ascii?Q?281cWID7U5Yyqsusdglmq2jMl6HcKlwLJDQIBYS81XpFp5t2zyEyhkYYvsxb?= =?us-ascii?Q?RoemIT1kG0GrPWrLCgBB5JYE56wPbkTeMttXTDqh5AWW9BkG2gLLxnzR16D9?= =?us-ascii?Q?iicxMk4KGqMA5SLT6DEwGcYQ98ZKLh4YMP9kIiLL9/sDOxD6q/mngJ68+1Cm?= =?us-ascii?Q?R8dsGsysFgbx0bxd6Yv75d4Q/w5uLn9KJZgdt8V478G4OKLdzm9MBewX/wfg?= =?us-ascii?Q?r8VFonSwmL1ML+uxOQiblnaUx5qdJTdJnIdFcp4wdRiDlLgNUrKqIattbDt4?= =?us-ascii?Q?vTmvL3bxwZF2TUIrqnRCP0jELOhJIEhdI+UdIudIG1E92jDO/TyawAsBpqqX?= =?us-ascii?Q?4N0JK0FNNmAlSZPtj5vcU6akrsEW0MgUf3KnwxjBR3rxPwv+63spyJB9I0R8?= =?us-ascii?Q?3cJy0AncD06js2IX9uUpoNDKSjCgrKXrPTU7U7zj95Kbx/9xp0jOdQggUCvo?= =?us-ascii?Q?4OH9VO6b5ZBiXa7wMP5xIaZ0SdAmCDIqvKC012WDE7Lkc5HttvDSbQnob7Hn?= =?us-ascii?Q?1g=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7c108d2f-7458-40d9-cd3b-08dc1ce060c2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 13:28:40.3177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aZpgf39JmReWtKPCRwml6KdOUYZ1sfvGEb3E8b47ud1s3NSq+MC+MhXnv97r++bn5HToBWEbUngzJnYDnmiD2oEJvbiRVUuFzVYDmXQg/Kk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7067 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 24, 2024 at 01:26:58PM +0000, Bruce Richardson wrote: > On Wed, Jan 24, 2024 at 01:04:49PM +0100, David Marchand wrote: > > RTE_LOG() macros prefixe the log messages based on the logtype. > > This results in logs like: > > > > TMTY: TELEMETRY: Attempting socket bind to path '/run/user/...' > > TMTY: TELEMETRY: Socket creation and binding ok > > TMTY: TELEMETRY: Telemetry initialized ok > > > > Remove redundancy in some libraries following their conversion to > > RTE_LOG/RTE_LOG_LINE. > > > > Fixes: 97433132c2ed ("lib: use per line logging in helpers") > > Fixes: 0e21c7c07d62 ("lib: replace logging helpers") > > > > Reported-by: Thomas Monjalon > > Signed-off-by: David Marchand > > --- > > lib/dmadev/rte_dmadev.c | 3 +-- > > lib/gpudev/gpudev.c | 3 +-- > > lib/graph/graph_private.h | 2 +- > > lib/node/node_private.h | 2 +- > > lib/telemetry/telemetry.c | 4 ++-- > > lib/vhost/vhost.h | 6 +++--- > > 6 files changed, 9 insertions(+), 11 deletions(-) > > > > diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c > > index 5953a77bd6..dbaa14f262 100644 > > --- a/lib/dmadev/rte_dmadev.c > > +++ b/lib/dmadev/rte_dmadev.c > > @@ -35,8 +35,7 @@ RTE_LOG_REGISTER_DEFAULT(rte_dma_logtype, INFO); > > #define RTE_LOGTYPE_DMA rte_dma_logtype > > > > #define RTE_DMA_LOG(level, ...) \ > > - RTE_LOG_LINE(level, DMA, RTE_FMT("dma: " RTE_FMT_HEAD(__VA_ARGS__ ,), \ > > - RTE_FMT_TAIL(__VA_ARGS__ ,))) > > + RTE_LOG_LINE(level, DMA, "" __VA_ARGS__) > > > > Is it not useful to have the prefix in the log macro itself? That way it's > consistent across all messages. > Sorry, I think I misunderstood the problem and fix. Please ignore this mail.