From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 896B043A22; Wed, 31 Jan 2024 17:19:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 360FC42D7B; Wed, 31 Jan 2024 17:18:59 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 643314026B; Wed, 31 Jan 2024 17:18:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706717937; x=1738253937; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=qBKAjlEpxjlHOqGOygrX2xZ5yyo/WpTQcW2AZ34Tq3U=; b=CwlZG8VPiLKltLMlfDV9K0A5ycwNVAo+6aSmytxejtUC+XrRfEmKcQwc k6/d2xlOpVbUfnPXu4moF1tcmChipTMmYT7GUCKiM4n5ylAwhpig+5n+H OjAs7AOyChPsFu43w5y7M7Zrse3q+/zaVcNpA1FWGWoHGK4IE8kRuPSQc BwWySzWkCvT2r3nUdkH/gtplBhe+6YMiWxKBtlXZrm9XGxD7YOQCqAEaf jIA5i0FeZ5oLKG7inW0MvIpVkNrf7ov82HaPYzqriweMa60BWlImjg6zn /wAjCAJzDbIWwGhNhX29f7pAUEwqctBY0S+UMOdiM6kJCnX6ew4jMWDFQ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="394081067" X-IronPort-AV: E=Sophos;i="6.05,231,1701158400"; d="scan'208";a="394081067" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2024 08:18:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,231,1701158400"; d="scan'208";a="30553853" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 31 Jan 2024 08:18:56 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 31 Jan 2024 08:18:55 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 31 Jan 2024 08:18:55 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 31 Jan 2024 08:18:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aPfD/ksB+gRvgfI3HF1sH4TBH7cyW0AHR02ULUjVCL4w7k8ip/B5ajRftNXEYNxILnHz4f5Jw6mbqgscMxR8SkfgYsXtQpK5joE9699K4liUPGO0kGw6ovHcSUNXx90+mMjW57QzFtt1iTDpivz9JGwGMT1IBtCdkUz14n+3ODzmWh8E4KYsl725JBGPnKJlR72t3IFIvApggYjTQSjWeYBs5KFAjV3sZSQREr6/GKCf1S0Tf9SCd3yya31givk5SjemVA53lirWPdxAyDaNFRBCI0lTVMS4Rbu4bHr5sVvPo4I35kOfLSMTT4f80Lh8hKa6KFIx1ioHdfOmihUB9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+ccGje+SmtpwIGCAA7+TrL7UiTYqIewc0Cd0XmaXYpU=; b=iZ1Zcl6t9b3LkFX25W1HhRbvDsLehF/xCb+sLfWNhm+NiVU+4eC5WXp/mwNyIYr97DBuGIrZxjAJnQDDRiPdTQ6jopl6qIZab/p+j4Ldd2Uxk99tVv4NMql7LAr0qoy2UdhIPfXx+glnMxNJhkPMacxQbgCAt6RaU69Z1PyhbOvj1q3a9BUjr43vthAk08ScZF1GTJ55G977DUR2uBAzvpLXvhj0CuIFwcLDzxeihTAYY1Y/zjL6z48Xan1BrrIO319rh5NJCRYPtSOlMmbzQgEfe5t1mDfpEueLwXjb9NHUKNsa/XyAAynvMu9ykwDeeI8AczqSJ5FvHrfsro+wRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA0PR11MB4527.namprd11.prod.outlook.com (2603:10b6:806:72::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.34; Wed, 31 Jan 2024 16:18:51 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7249.017; Wed, 31 Jan 2024 16:18:51 +0000 Date: Wed, 31 Jan 2024 16:18:46 +0000 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: , , , , , , , , Subject: Re: [PATCH v2 07/11] eventdev: fix documentation for counting single-link ports Message-ID: References: <20240118134557.73172-1-bruce.richardson@intel.com> <20240119174346.108905-1-bruce.richardson@intel.com> <20240119174346.108905-8-bruce.richardson@intel.com> <10e10beb-b842-425d-a591-4992e06255cb@lysator.liu.se> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB8P191CA0012.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::22) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA0PR11MB4527:EE_ X-MS-Office365-Filtering-Correlation-Id: ec18964b-9fa7-4e39-28a8-08dc2278501e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gAGle3SY5SFJDYniWZwg/CFPy90pEG9oWh7n2f0fBmtv9ooJLktbHJmprJ+tQCvWdF6rYwOUml88XIeFlynR1VKzK5O9Ouh5dC5K8teHJFf4MDybtazo/pvbyryEPSo9RCD7jP7EsRZ/Y7woupj9tHyk3MiyQ/u3cIJFKfE32QaHCuEke8r1LPSJhMEgUGGBxkRXaFKLazdIbY0G6SHH+XtE+5u+d8JequjsHlpATWTRclqb4gEhvuRaQtyyUPYg19ogiIVSTPYbEtgbmPgVKBNK3KemI+2xxNx02lNmNxz4ZC35tZHTDVgjBteoaYQKteYZ9LLkpBvpeJRbFxr1gSzn1PEmPZrcH4OzW3rCnGDngys1YXxj1aeESG5dv+Izh5CdLp4l3oK4c+brbOmnpSysiiNdYxWQK0dydWm1ICZAcUfoUfhlRLMSimn1c8S+zwBbmSVsB08VA4eilX6kGZfngfkEvEHXI/8oMkFRdi+RQcUiXN13Ig+KwS9nrZN8XX0zQ9PNeX0b6lB1Msfd6OTdXCIExP2xaR17O+h+eE6/MfyOmBzc6MwQZR6IMHLX2qD3lyDkANVbun0K/D8u/g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(366004)(376002)(396003)(39860400002)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(26005)(66574015)(41300700001)(966005)(296002)(6512007)(6486002)(316002)(6916009)(53546011)(6506007)(478600001)(83380400001)(6666004)(38100700002)(82960400001)(86362001)(5660300002)(2906002)(66556008)(66476007)(66946007)(8936002)(4326008)(44832011)(8676002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?cH9GhA6sbpk3jHq0hBVVLExB/JZg/RsgfR7Gpm881Ak9EEEhrmeH5pqSU7?= =?iso-8859-1?Q?rA2b6N0Q0idDJpFn5/259BVcIyJmP1xMDlq3NfsYMMeAZVVUcLmYpLRr1v?= =?iso-8859-1?Q?hqQDFcv412ydlSCgfV4uXnK7E1EgFOQM6qhlsixDQsbwNF73pYiWaBDQFr?= =?iso-8859-1?Q?2Rzouke2R3e3m+HhSjfYdBbRC4cWavIBtSB/qFv6TpHKCSZiA+X4fuCzBN?= =?iso-8859-1?Q?GbGV8SMgy7aavN5oGxYe8WmqpuB3E1HVlH2oNiveqwByfe43T5r7Sluh8E?= =?iso-8859-1?Q?Vxyct+hUpsd1XsSQaeMDmtyTVY3paukMDpY03mwm47g1KBvyfJv4nzsxVK?= =?iso-8859-1?Q?34V6MbW2lYvKk8K5NKrpD603gz66iIgAcubnU5r8DcTrx6t7e7BYG2cuCS?= =?iso-8859-1?Q?JuJczSeigAe+t2zKGRBoc3aoKnJmQgWhIm9rHQdPROovrDmJwHn8cSJwFA?= =?iso-8859-1?Q?+eBArWMYBSnYkYloku4dMkfzhBGDV3lzV2gbAau1w7tufbrlPT+wYhoZIC?= =?iso-8859-1?Q?GPJK0uXRgy0w6djtUo3eD5GuG3tVdQgrsx6dsLLcVNwMhfnH9Y9flk3Y0A?= =?iso-8859-1?Q?Kc2LLff/GMTUTzUJS/nJQI52X/XOcpLH6XMj4/9ZQWZ2anjiQFBGQCNnFU?= =?iso-8859-1?Q?uKfKAQylomG0fEaxHFxI5e/WjbZcGlfg2Vl6x3KniYfn83lkTAm/YqmkA4?= =?iso-8859-1?Q?bXqlPCXX5joQ8R2qmF2ZDYdqh/lIr9Qhy6exeej8SC2fPfPjgkyc+T/WJv?= =?iso-8859-1?Q?Jc7TKWQQoVdCSJsqLS1NFuQ8OBg97e+byspoi4bz2TqmsWg5kulo+gUD7V?= =?iso-8859-1?Q?1PRaCPMaL9xXpoep+6GH6vxAcF2eUqcDcaH8G7ZzzRQcDfeJYZaLqNNPrH?= =?iso-8859-1?Q?ZupWGjoV1tkW/uJpJ3P7dvsbrnCDez3CP1Dq6aXxgA7AYR8072BcoQ9SB2?= =?iso-8859-1?Q?FS1NgObILwCUygWxqfsONCO6BcmVXXldD7E66nmdFBsLmyK35Mc0X860Wv?= =?iso-8859-1?Q?HI4jNcDZC3aZX16xb0yCtrzGal+VozC/8W7/DZ0I4Kh5MsulNsHud4VqDW?= =?iso-8859-1?Q?PZZAnSDr+2X2gteLQRY+3QW+WlGaaOcLnIGfbwqC3ZAfqOoiakAgbMdTfj?= =?iso-8859-1?Q?vnKApU7kjaDSxJNq0TNWxoGn4WMBvjVTfUo67BT0PH02Go7CD9k85+Q64/?= =?iso-8859-1?Q?NBuhMeXLBTwJg2wNUBuP+e/70Qw4LT+upJTNi7MmWYDmUVeVXC7LvcMjWv?= =?iso-8859-1?Q?omphMIvlyIYy8vEh8eTiQQPBVTsnbfiFJgpL0SXgvVp5Wazh2mndWTvc0P?= =?iso-8859-1?Q?PKwQeDpu3lMxDcrmMllyxaCOd2visuJrc1JFz8siXVjGK2VwTj7wmNBXYm?= =?iso-8859-1?Q?xvGQdEw/U/LdSq0eG0Ch368udrnQ+bgyvwzwYdkSqLRHdloS2lGwTJlf76?= =?iso-8859-1?Q?F6LeGqP5Qxb+R3Tyf9A/vOY3gi5iOqGZeXFiz0uB+e4bg/O0uOy3B024Nj?= =?iso-8859-1?Q?+5lDkSVw6seto2D/+CTGWvPm+nrWHwekNFOLsrEx/rPhNx6396pSITRCnU?= =?iso-8859-1?Q?TFFosRemxQpPcexOIYr31RJ9vcXSmJ1AL460du2jHxsUzzWoanttkvX27Z?= =?iso-8859-1?Q?s/1gJlFGCN/38Xh1ShBwaQm9g7dJXmL6twQVApfZWymdXOTmmLixo8zg?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ec18964b-9fa7-4e39-28a8-08dc2278501e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 16:18:51.7317 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U7biwxPSTr5+80RA9GbiwwaEjUKCf4B0h2iZyhZoAV3HEGpJ7n+FWhNQLouhZlTsdX44+e/+k3w3hrjapY1WIcaJhYtKn0H4qwBsGPaunHw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4527 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 23, 2024 at 09:56:23AM +0000, Bruce Richardson wrote: > On Tue, Jan 23, 2024 at 10:48:47AM +0100, Mattias Rönnblom wrote: > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > The documentation of how single-link port-queue pairs were counted in > > > the rte_event_dev_config structure did not match the actual > > > implementation and, if following the documentation, certain valid > > > > What "documentation" and what "implementation" are you talking about here? > > > > I'm confused. An DLB2 fix in the form of Eventdev API documentation update. > > > > The documentation in the header file did not match the implementation in > the rte_eventdev.c file. > > The current documentation states[1] that "This value cannot exceed the > max_event_queues which previously provided in rte_event_dev_info_get()", > but if you check the implementation in the C file[2], it actually checks > the passed value against > "info.max_event_queues + info.max_single_link_event_port_queue_pairs". > > > [1] https://doc.dpdk.org/api/structrte__event__dev__config.html#a703c026d74436b05fc656652324101e4 > [2] https://git.dpdk.org/dpdk/tree/lib/eventdev/rte_eventdev.c#n402 > Dropping this as a separate patch for v3, and just including the necessary doc corrections in the previous patches for the info and config structs. /Bruce