From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9407343A3C; Thu, 1 Feb 2024 16:24:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79B0B42E28; Thu, 1 Feb 2024 16:24:41 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mails.dpdk.org (Postfix) with ESMTP id 73686402E4 for ; Thu, 1 Feb 2024 16:24:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706801080; x=1738337080; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=2Dgm/zTVC1ikO+OhcGqZob3yL/4ZjtEU/GPPpP7/HUw=; b=D+Ektdt19Mva/rng2SofTehYIiGfaIysbQMHzuXfz7PmiqdUMtiOXqFk xQ8fuYbkSso2ouidnTRYGSA3bHjZRznXBr92sL4xtj82VarZu6jc6BVpG dCTifhFX5xqd08HeEStAlMNP3eKwroWPpxPPgpFk6D//HMnIAlePO6wGj ZVhh6xQFuv29rmoXGWjm9sOOQEosl4HfDwUceJvLUFd4tk1Su4Y3Vrg+f BOyNZL4pK0/MPA9epZxYvWGBXJt8gtbBomM/CEV0jyefpl108rqcTnwEC 0q+e4xfuGfe0lDBqLYomy8fvq9+UVLNewUrLdJGN9ywrAFPr5Sb+FErlL A==; X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="10572876" X-IronPort-AV: E=Sophos;i="6.05,234,1701158400"; d="scan'208";a="10572876" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2024 07:24:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="879139730" X-IronPort-AV: E=Sophos;i="6.05,234,1701158400"; d="scan'208";a="879139730" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Feb 2024 07:24:39 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 1 Feb 2024 07:24:38 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 1 Feb 2024 07:24:37 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 1 Feb 2024 07:24:37 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 1 Feb 2024 07:24:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ko8tZclOIioqeoUlIwLuX6ML4cSV0BrQjTCti8GIHes9OhbIEvEKFlrgd65N0OBH1dkZ8JX23gNektXlleM1ZeGL+x8rVUW8RbmC7jKzfaEwNNMMAs/VC5FZr6wEcryU7ofJDR4Au6yNxB3DIGVSvWpgqjm3vqk9j9QghI13zCVAgXLfvvgroo9E8TcDyWywADOtPCmn2hMhGF+x5K1s9iSjsqaIPuIB6ppw3JeMN+IZwR+F/JGz9pojgCoYdkmLG2HBEXZi7wLBFQv/XXBRKtxca0xfSGYDmQ9OIcbJUe1ElVL38URZ3ZvhVE63bmDLqUiDRn+zAO6DjQ0sUGOcaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zNfx1wDfLMCWIRvVTkehHjgMydXrd2xlPbaR5xBASdM=; b=BilBI9PcUyx8h8V88NEbhY4HyveRJjUXgMY8HP3wIqeklk/lDJEyqltMLqEUrtfuSnDOt3lTJpntPInC0w5AADWL7wAWc9kt4JRptIGrtqwJXLSC5QJSApTXxC7Jl7F95Mt/NZirhVcttxfZKBXeRoobNq6i4rwzOpPUJkM+kxn7WzKvMhHSz6GC/RSY+mRsPOqhCGe8JXwNXeq8XxzFJITjcYWcbkcDqvDk9z1eU/PZxfGzTdDtkILaIXT8kqnUyHbYmCCPbHGL9SL9Z/GzTS4RaM4tEvk+IaeFAwCtUjPayV0O7fidPGtjeDVimrORj3Zs3OTiRPKFZivAIsMY/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB6991.namprd11.prod.outlook.com (2603:10b6:806:2b8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.31; Thu, 1 Feb 2024 15:24:34 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7249.017; Thu, 1 Feb 2024 15:24:34 +0000 Date: Thu, 1 Feb 2024 15:24:27 +0000 From: Bruce Richardson To: Jerin Jacob CC: , , , , , , , Subject: Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields Message-ID: References: <20240118134557.73172-1-bruce.richardson@intel.com> <20240119174346.108905-1-bruce.richardson@intel.com> <20240119174346.108905-12-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB9PR06CA0002.eurprd06.prod.outlook.com (2603:10a6:10:1db::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB6991:EE_ X-MS-Office365-Filtering-Correlation-Id: 014997cd-9ca7-411b-4efb-08dc2339e4fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3IiS1S9dH6nA8ep+PfY3lqNP+nWhU9aN7r5BFoww1Vc0+tlj2cIJsRv1Te7f0yPDdZqRbYFOfwWinEc80lcz6e0g4F/9xIY1j3ZOHWsOGD4aiwBvb+hQXsMCx83EaxWhjjRbt3aNujdZ5fwov1JKjZuL70Ryd3l/PLBrDBmKuLg6AGYdEdu0Rno/LfcAAVj5DFL3I9+wjQiZGx72kXUqbig8wfrN4uRwcv8qg83dykAJ22grR42O3Fx0M1p9ulRX9ewXd6vJEZ22FTjJ+iaCIOF7eqkp0jOUm3/hhEBFHPipNKXjd63hjxfHFK9LQmF2iiXD8vlzk/wjaGMptbPPQocu9c0HRXEXo9TE4p98vkU5qgvRqnK4r4gl9AFVLpHjlWrYUJ3qNTpyqB2UIpnv3FbpQbyBC9aeqk32o6YhF1smXXduQnr0CKAQdzxCbKffm/HQ3bcYdxzAMjwBo43wIYWbil85t35Qa5JRX5UWd1H5tZRPMgnqnUsnz2F2BDtXsRPgci4l89pttmsaORGs86KuZcTekayJc7fD0vHJLal+mq0ru0bvO7TXpOMDaYbs X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(376002)(366004)(136003)(396003)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(6666004)(478600001)(38100700002)(316002)(83380400001)(86362001)(82960400001)(8936002)(44832011)(8676002)(6486002)(26005)(66556008)(66476007)(53546011)(6506007)(2906002)(107886003)(4326008)(6512007)(66946007)(5660300002)(41300700001)(6916009); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWxUWUxKSnlRVlFtb3pocEpXeWU4UUJmOUxHWVpmeXA5MmxNZGFTdGFLbVMv?= =?utf-8?B?OHN5aEhXT3phRGhOSnQ2WHdNMzhvamxQdUVEckJhR0Ura2ZJTDlUM1RaWjVG?= =?utf-8?B?TU1zd05oTlhBbkZuOWtWN1VZQVFGYlV3RUQxWm5jTm9tTWZmLzVaTjlTNGVs?= =?utf-8?B?MFVNUHFIRFh2b0YzNjBSbWNiZ2hzUDdvZWRiRkhmNkhra0diZnpHZGVSK1l2?= =?utf-8?B?OFFubDFsTEU5Rnp2TGkxWFQrejNxbFN1L0JiMWFHUUFra0FCd05OVWNBbEU1?= =?utf-8?B?MHBuSjh6L09VQjQ0SkJsb3M5eEhNNng0SnpWUWJTa05qck8yWXlGcGVRV2xS?= =?utf-8?B?NDFZT21VakRnWkdpWHVQOG5lMDM1T0xKeHMwQ2tVazU4Qmh1cm45WDNnMUkw?= =?utf-8?B?ZWtobElPZ2RFbU51cWgwU0N1YlZKaU5rVU5EcC9tQ3UwZE9SS2FXc1RhNEtr?= =?utf-8?B?Ukw0KysvQ1JRU1BtbGw0RTU2c3YvZGkyVVNpK3NJdlh3aktDZVQwb3ZNdlNR?= =?utf-8?B?MmtBSDMyYytKV2JXY0pQekZtZUxHYVU2OGxHd1ZCd1UrUXVzR280RVFrQVVR?= =?utf-8?B?cEFiMXBIZDJTWmZqbG5lZ2hjTVhWblZOcEZaUnA0NmlDRXZhVk8xSEd6aFh4?= =?utf-8?B?Y0tQTXlMSEtVa3RIaU9heVlrYkVUSGZGMWljSnk2YlRYd21lYXJGdkQvQ1or?= =?utf-8?B?Q2gzY04vdlJEMEtJSHowS1lqN0laM0dBSUtKakZDMEZwdVZkVllabnBsblM2?= =?utf-8?B?RFViclAyZWxhWCs4RWpnU1RJQzRKVkd6cEp2RmxsRVUvS0dES09BRHk5dWJx?= =?utf-8?B?MzVzYkVmVWVrQVR0TUxVTTZJb2pkalBpSHRNOUZLOXRDeFZWZSsxb29GTm9G?= =?utf-8?B?RHdKWDJiU3FjWTFUNmZQcjNLdDdjeVdpZmZRNlhtR1VZemF2NXJ1cEx1UVYw?= =?utf-8?B?M2I0SG8yZ1BXYzZPcTJhVjRmODBVTE1tYTQvSmV6NTZiOE4zVVRJd3d1Y1JH?= =?utf-8?B?Q1VOeUdlMFZWMTVoTm1EK0lsVUNSZ20xZjZkaG5QUnp4MnZzdXJMUldoZlFZ?= =?utf-8?B?TWs3cWNIVWpCbFpjQWV4K0ZYMWJxTEtRVFNxWHRESDJIbXpmejNOOVZleGcw?= =?utf-8?B?SEg5TDFmYTdZRU9XMjdCTXFtcjRWeFpES1Q0TFJIL2FHanFWTXpFQ3QrTDc3?= =?utf-8?B?ekttUWVTTG5ZWFRsN1hodm5mZFNjWTF5WkdubWx3L3lTTnRQUFdLL2xqZ0Yz?= =?utf-8?B?RGhYOHZ0TlJESC9Gdm9sZUdGZVNPbHluUSs2cjE4U2I2MlJpTmsxdVJXMWFG?= =?utf-8?B?MStVUWtpUHhFUDlUdlhBbXdiK1R2RXVsbVV3Ymk3My9BY0pPSFpHZVVDMzZG?= =?utf-8?B?cFozNG5CU0daaThhMWJ4eFZ0ZmdYUjlXMmhMMmZRTlFRYjF4NkRZam1zOWt1?= =?utf-8?B?VHRUc0FBdFpmTVA5emZiWFVmS3dtUDA5Wk5Gc1dPTHFpUmtOYjB0VW55TEFh?= =?utf-8?B?SnIzRVhMdDV2Wm1ZLzVzUXp1RU1oalBSWTFuSTJZajB5ZFpFUkxBUWhTRWxR?= =?utf-8?B?dHM4N05IRHE0RVRiZTFwNGQ2ZlVtaVhvVHZYZVdaNHRyR1lOdHhUeWFYZjdW?= =?utf-8?B?SlRlS0ZtaldVdHFDWjJIaE5rOVZ6NlppN2lxMmJmTWxrZnJwcHVSSFd0UGJS?= =?utf-8?B?ZnhtbTBsN1JpT2FVMERjUXd2V3gvS3czK2xNZVZ2aGtTakxmTjJ6WXM0WGNE?= =?utf-8?B?R0x4ekMvNnkyNDVxYjlBd3hwL2UreDRpai90d2U1cnNDVlRZOTdVdnFYWDEy?= =?utf-8?B?VGRab3k5WE5NR3FhOFdYNTVZTURkQzRWdExDYUZxb3c1OXd3NVhwUzNDSlBz?= =?utf-8?B?eGJLM3VLaVBQREFWTzJaTE54T0srMHJITUFLMDBlMUJxVTc2RURPdVNlY0hT?= =?utf-8?B?RjExU2Y5cytDR04zZU0yM1lhUHJRZjkwaURYcHc2TGdaMWppMk1WVnMwTFg3?= =?utf-8?B?NU5OOHZKWko5YXRzZ3A2SnRLT2ZJc2tyWlZ1REx3ZEVTcEhML3pFWHZCUXZn?= =?utf-8?B?N2JSL0l2MzBzc3Q1TndkOUtsdG95cWRrbW5xMGtNNExUV1ZSSVpXT09MczFS?= =?utf-8?B?eHVXMTBTRllNWFZtRXJaN3lvK3pXYS9HeEdGMFhQK1hDZFQwVCs4cjNWL0tp?= =?utf-8?B?UFE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 014997cd-9ca7-411b-4efb-08dc2339e4fb X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 15:24:34.2987 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tHi4MSpyd2lOllQBRDqf3tyEay4b7Y5EHfSMTP7qBVWKcpmt+RiX7FBiRefHmeH5qTxrEjprKd6znAlm/mPKhCa71W6ZBFodVZ8ziEDqNso= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6991 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 01, 2024 at 08:30:26PM +0530, Jerin Jacob wrote: > On Thu, Feb 1, 2024 at 3:05 PM Bruce Richardson > wrote: > > > > On Fri, Jan 19, 2024 at 05:43:46PM +0000, Bruce Richardson wrote: > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > > For the fields in "rte_event" struct, enhance the comments on each to > > > clarify the field's use, and whether it is preserved between enqueue and > > > dequeue, and it's role, if any, in scheduling. > > > > > > Signed-off-by: Bruce Richardson > > > --- > > > > > > As with the previous patch, please review this patch to ensure that the > > > expected semantics of the various event types and event fields have not > > > changed in an unexpected way. > > > --- > > > lib/eventdev/rte_eventdev.h | 105 ++++++++++++++++++++++++++---------- > > > 1 file changed, 77 insertions(+), 28 deletions(-) > > > > > > > > > > #define RTE_EVENT_OP_RELEASE 2 > > > /**< Release the flow context associated with the schedule type. > > > * > > > - * If current flow's scheduler type method is *RTE_SCHED_TYPE_ATOMIC* > > > + * If current flow's scheduler type method is @ref RTE_SCHED_TYPE_ATOMIC > > > * then this function hints the scheduler that the user has completed critical > > > * section processing in the current atomic context. > > > * The scheduler is now allowed to schedule events from the same flow from > > > @@ -1442,21 +1446,19 @@ struct rte_event_vector { > > > * performance, but the user needs to design carefully the split into critical > > > * vs non-critical sections. > > > * > > > - * If current flow's scheduler type method is *RTE_SCHED_TYPE_ORDERED* > > > - * then this function hints the scheduler that the user has done all that need > > > - * to maintain event order in the current ordered context. > > > - * The scheduler is allowed to release the ordered context of this port and > > > - * avoid reordering any following enqueues. > > > - * > > > - * Early ordered context release may increase parallelism and thus system > > > - * performance. > > > > Before I do up a V3 of this patchset, I'd like to try and understand a bit > > more what was meant by the original text for reordered here. The use of > > "context" is very ambiguous, since it could refer to a number of different > > things here. > > > > For me, RELEASE for ordered queues should mean much the same as for atomic > > queues - it means that the event being released is to be "dropped" from the > > point of view of the eventdev scheduler - i.e. any atomic locks held for > > that event should be released, and any reordering slots for it should be > > skipped. However, the text above seems to imply that when we release one > > event it means that we should stop reordering all subsequent events for > > that port - which seems wrong to me. Especially in the case where > > reordering may be done per flow, does one release mean that we need to go > > through all flows and mark as skipped all reordered slots awaiting returned > > events from that port? If this is what is intended, how is it better than > > just doing another dequeue call from the port, which releases everything > > automatically anyway? > > > > Jerin, I believe you were the author of the original text, can you perhaps > > clarify? Other PMD maintainers, can any of you chime in with current > > supported behaviour when enqueuing a release of an ordered event? > > If N number of cores does rte_event_dequeue_burst() and got the same > flow, and it is scheduled as > RTE_SCHED_TYPE_ORDERED and then irrespective of the timing downstream > rte_event_enqueue_burst() > invocation any core. Upon rte_event_enqueue_burst() completion, the > events will be enqueued the downstream > queue in the ingress order. > > Assume, one of the core, calls RTE_EVENT_OP_RELEASE in between > dequeue and enqueue, then that event no more > eligible for the ingress order maintenance. > Thanks for the reply. Just to confirm my understanding - the RELEASE applies to the event that is being skipped/dropped, which in a burst-mode of operation i.e. when nb_dequeued > 1, other events may still be enqueued from that burst and reordered appropriately. Correct? /Bruce