From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE8B243A4E; Fri, 2 Feb 2024 11:32:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABB0E402BF; Fri, 2 Feb 2024 11:32:42 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 92F0A4026E for ; Fri, 2 Feb 2024 11:32:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706869961; x=1738405961; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=MR7jR4F6/6jDXsvyL881LR0KBGvPeR9YtSIRv5J7K2Y=; b=bCk7YzMz/FqNbSnzqK2hm3byOgfQBRQ3XZgZtbyg95e2+399SCOkb2E8 XMtEsJsfhghl5hRWy9OQnlzTEYbVmguqUY+28u44PsZEpZAAaptrNnRxT v/xIV9AHYyqD1TRyh70dQC73e6XSJlPtutdISjUg1VEIb9eb04khzN0Q6 Ps8AO3vxv8oFha6PwI2Dv8w+jxfcngzaCkImvEX32cUQGyVWOdlFFBVdd j8H5PBElJomLuURGUZ7vkbiBnb/gTf9mqqPc1oITRctQ+RxgTP8YfOjau 0S76awcPEKFSEF8HyBtKrByA6Snubn9qCjxbfvFpBwqoQbxnctwFuuoSB Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="46606" X-IronPort-AV: E=Sophos;i="6.05,237,1701158400"; d="scan'208";a="46606" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2024 02:32:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,237,1701158400"; d="scan'208";a="31132580" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Feb 2024 02:32:39 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 02:32:37 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 02:32:37 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 2 Feb 2024 02:32:37 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 2 Feb 2024 02:32:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZQqctbKTs4D+eRNNgeARfwHn9r0iFU+B6yqLOkHE0WeeyoW9s9vVScCVUgoPqwTKEou7nlNNYrq5rF1y2089WUDlWpHryoWWh3gxOaq8Z+xYudXTxQ8OIzc7B5T8r0CBJYYh8M8CYRqOkJZSpQK0Px07aOTsn/IL9Rv1e8iiBJJoutMVJ3Xnrdp/StqW4AuHj9LaGZTtQnDDgu4kptRw2W2HA65gxyO1mgFrmnPWDeQZYerI5WI2t8kDb5ewLfxbyw4+R9iVvQVh6t5bSH2kAgICeJooLEazyq0w4q13Z2CYT3UGCKp8CRz0LF9nob9ecEWx21E+5tajl3dIUoXoXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CHXh4LSXN3MjqDW0v2OcOBwbcK1CEebi7cZnl/RrIYM=; b=g3C4EfJhZxuHWma2pbaHjRg/cWSBIV1jBlJHEOY4z71q9HlMUw+8CHjOiKxWSqVAG9me1qEh2t1SYxw0U8hGB4R9WH7G+49zdkP7mGNE1lulwyTRRqEJE1jzsAXbqm2wZLfZCbkP7ta4TQhBEFliaoGJMJdOOOC1CN4ghMzIA3cd6HHpiTqaFuwcrc66Bm80jbugooB9wTngTmrPdlwGFAgE9MswIJ+ET42gNwgQ0GveQZ81DU5obBPw/TkI4iRXi1EHtQyMfuNDKkiIVxjss8R3lZ9lk7twPFgg5zgqY+SVZnT0XurwChviewu3lacy525Kc+aqzT55xnQI7MycQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW3PR11MB4761.namprd11.prod.outlook.com (2603:10b6:303:53::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.27; Fri, 2 Feb 2024 10:32:33 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7249.027; Fri, 2 Feb 2024 10:32:33 +0000 Date: Fri, 2 Feb 2024 10:32:28 +0000 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: , , , , , , , Subject: Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields Message-ID: References: <20240118134557.73172-1-bruce.richardson@intel.com> <20240119174346.108905-1-bruce.richardson@intel.com> <20240119174346.108905-12-bruce.richardson@intel.com> <211a59b9-095d-418e-be82-b49f4e5d1d00@lysator.liu.se> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB3PR08CA0035.eurprd08.prod.outlook.com (2603:10a6:8::48) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW3PR11MB4761:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d33be29-d071-41c8-64d4-08dc23da43ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 37xLCdNFpd/6twcgDcDmOQTEahOAj3ORNl+yBt70TwHCVuOGulc/nD425MhQiv7p5fZGHRp1slImxMA94ZVJJuFjLY4cJH/zrMzZHvp8b2rT/dU/EdIeiO4LrcT1PM+gHoDPTQqoE1bR1NblA//3F7W+acurha24IlajMbNvVHKoY1c5uhfEaNYlfhic77/hv05K63pnu+NViSUnWYAtTSNxIRggYtbrbAjiy6zW40W9oSzuipNK3Zza6Vy6ZBoAiC16IcqoWrvSfZDU8+9BJzIxkhDU0t64rGuQ3S3yJLLSpVgq1/unuVOsHG8AyNxXVEAbl8zR55TdEGa8aEp6F/n2lwMqV75YBRYSjAzZfjoo/EekBQRCNwmqiLGTuM0vncw7D4za/Nj1bGEQJ/wVmcI6vJXxxGMt25M0Ch5PKVuLJuHHFjR/8CV1pSuk8iuu0DhvAOe5nfhOBq5alBsxCjEvuqGqpL12jiPdzBhwLleu5++mMWzb8+fTVGc4iEBynwvS38dD/Oc4wOr9QyDTatVU3s6YczLRBxKCp8TXhDc4nSStogxuQurCRZYWaGsJ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(396003)(346002)(376002)(366004)(136003)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(5660300002)(478600001)(6512007)(66946007)(6666004)(6506007)(53546011)(8936002)(6916009)(86362001)(8676002)(66476007)(4326008)(41300700001)(316002)(66556008)(296002)(26005)(107886003)(38100700002)(82960400001)(83380400001)(44832011)(6486002)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?r+6fb3OYduqDX+STECFhdKigvAi9GERtGqpbtoZNEbgensbfQDQYMmtKTX?= =?iso-8859-1?Q?dkyDj10EVQMxGy8PYEmg3zgNpJsECLGhukyiamOqmjmgodjO9H1zScQYA9?= =?iso-8859-1?Q?0nAgHk1grhM1BUqSKIpjU6WSxrr4z+HMFCS7vFBXbA1ajBMf5+05AbBnio?= =?iso-8859-1?Q?fIVPtYPE08aD0Xk3vKDNAIn/vSUwY+SGAn6V76i8Teqdg17WmYghNtZMex?= =?iso-8859-1?Q?JecNvo+LsxoGXBsglOtEv+cln2ajJ47iwnflfiaW82Q1pemw2LX2kngo/a?= =?iso-8859-1?Q?DeMmN1BTi8h7Ont0xsrvLmTOVr7grvW4w9fikBf1lQoS9vIJaBEBj26YZk?= =?iso-8859-1?Q?VDIotgDt1qN/OUDL+FkuSyUlkMn40lh9pIJBlC/SmWhs1s8LqHbBTlgvO+?= =?iso-8859-1?Q?lf1w0IN1kb3/17DdU8PcnUsF9ptvMHzYrPK+o+3M3ia6FcOTcSDym5owxQ?= =?iso-8859-1?Q?Y6NLKzWM23Ryjz3kq3LmRtIlXggDdHANdhH1kLkkCxXVBfw+QQeSwDJTSo?= =?iso-8859-1?Q?O7X4mu7B/n6xbT14lcR7cM8+uoM97gakBsgXT0FZBecg/bfG1jO10Y7WaR?= =?iso-8859-1?Q?NtBASpPeO4ZzoLuuYhqr6Dr3YZQPpC0ugx8bGW3/uH/JdqdIr7/vRVu5AH?= =?iso-8859-1?Q?3p7Ob7HoYYjZO3HN5xURuPvxTAwLO74IQPegeO9NWvscOob2BOO1HbqKU2?= =?iso-8859-1?Q?ymHyh1CtW8sbkGSGxkqyJ9aMFX884JLf9L3gLUU9ymjupQrJ2n51LQ+0WB?= =?iso-8859-1?Q?AXVsa8A7UbiBZU+ZXgyw/G/E3whOK1rrUsLpkAQ5pd3vHicfiSZsaedYGD?= =?iso-8859-1?Q?CiA2l3OIEjq2a/yych+rDmgTfj4B5BTbEUWSVAFPzW/Xg4H8xnc6PUlFbe?= =?iso-8859-1?Q?6iaABaQOVr3bUnPLnHkprpzDIG46FzS/GwLrvna/eUmxYrBGVwtG3bib8A?= =?iso-8859-1?Q?IXwnaUow9tY+5lWZ7sIt1acOJcc4Uet1sW5DaGEbD0FbNuy/mRXgLfcJeO?= =?iso-8859-1?Q?kvT/PlIdkdEg5GdB4C2pzBVSwgeD111/c4Q9lP3VaQkUfk0sBnyaN6NAUr?= =?iso-8859-1?Q?6agJqj//ZNhvY7JfsSXL+QJiu40D9AZ0IhPTS5yBaZ8djOCE6+rTBhnPc3?= =?iso-8859-1?Q?N6ZzWVb/MnfIxR9NW2o4UcEeHNHAta82oExbcAhzltH8lmgbsHTuzYJG1J?= =?iso-8859-1?Q?n9beC1VUUVjfiWQKrz0S7gHmhCD4MkQ1FHe6p5b1k9muRTOterdkgzT5Uk?= =?iso-8859-1?Q?hiDt3Q73jUawXK2lkYwza4pJPDmVrk7+n2jf/FOe/I24DhC5rHDtUZucsD?= =?iso-8859-1?Q?bqHAJ0HLpvFWDUFFqW5t0gPHtCIHDBuXduWIRHD1BAT0gBtHvJCgx3UXF7?= =?iso-8859-1?Q?h7OiK56ZxsKyns4wNJ+Wq1mqkTdHmPl5WsHGZ7KYOPiacAyeV6dzK/ESyG?= =?iso-8859-1?Q?kh79+Uz5h8IZjh3HYw2uAY3n5nGSEDWKXB4JfToBqTcWrdUOqIAEwKMx/R?= =?iso-8859-1?Q?rVbPSU3vWMRlc3Fmyq61AK80pZcCrsznzo5p8+ZRL4Bip6jzQncWbsRiJq?= =?iso-8859-1?Q?3sx37uHwYV90ppoPtNxMN2ljoJkhzqbYA4bNVY6EaLPCw46ShDuIDCGbsI?= =?iso-8859-1?Q?kG1e/7wphv1YAxfp++TdSqJD73dDD0M4Ozlh7iKeydyko5oBN0GPb26A?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3d33be29-d071-41c8-64d4-08dc23da43ea X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 10:32:33.0060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 06rlEnT2ms3OkiQbtnngaJcDizh0iJwTkusRNTkpyWsT+0pLYfIKLvTiISzNyKHtLERnT/ppCjUx3HTYIrx2Lgi4tC3RujLzDpuRAc6xtIQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4761 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 02, 2024 at 10:45:34AM +0100, Mattias Rönnblom wrote: > On 2024-02-01 18:02, Bruce Richardson wrote: > > On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > > > For the fields in "rte_event" struct, enhance the comments on each to > > > > clarify the field's use, and whether it is preserved between enqueue and > > > > dequeue, and it's role, if any, in scheduling. > > > > > > > > Signed-off-by: Bruce Richardson > > > > --- > > > > > > > > As with the previous patch, please review this patch to ensure that the > > > > expected semantics of the various event types and event fields have not > > > > changed in an unexpected way. > > > > --- > > > > lib/eventdev/rte_eventdev.h | 105 ++++++++++++++++++++++++++---------- > > > > 1 file changed, 77 insertions(+), 28 deletions(-) > > > > > > > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > > > > index cb13602ffb..4eff1c4958 100644 > > > > --- a/lib/eventdev/rte_eventdev.h > > > > +++ b/lib/eventdev/rte_eventdev.h > > > > > > > > /** > > > > @@ -1473,53 +1475,100 @@ struct rte_event { > > > > /**< Targeted flow identifier for the enqueue and > > > > * dequeue operation. > > > > * The value must be in the range of > > > > - * [0, nb_event_queue_flows - 1] which > > > > + * [0, @ref rte_event_dev_config.nb_event_queue_flows - 1] which > > > > > > The same comment as I had before about ranges for unsigned types. > > > > > Actually, is this correct, does a range actually apply here? > > > > I thought that the number of queue flows supported was a guide as to how > > internal HW resources were to be allocated, and that the flow_id was always > > a 20-bit value, where it was up to the scheduler to work out how to map > > that to internal atomic locks (when combined with queue ids etc.). It > > should not be up to the app to have to do the range limiting itself! > > > > Indeed, I also operated under this belief, which is reflected in DSW, which > just takes the flow_id and (pseudo-)hash+mask it into the appropriate range. > > Leaving it to the app allows app-level attempts to avoid collisions between > large flows, I guess. Not sure I think apps will (or even should) really do > this. I'm just going to drop this restriction from v3.