From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34D6F43A50; Fri, 2 Feb 2024 12:33:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F56242E2F; Fri, 2 Feb 2024 12:33:51 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mails.dpdk.org (Postfix) with ESMTP id 1060D42E2F for ; Fri, 2 Feb 2024 12:33:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706873629; x=1738409629; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/howxEr2WyrKNxIpdSfqLJq134+gxpbp1REIFhACC0Q=; b=l/leqwItnJ3q190srvA6CuyiBMAIEzmP5PqTK47RUMxTD286fIBJkMbN Za1aV8nMdZK1Pm6CasgdKtLBzJHdttbnXvi6Bxb94H1oZenLTVVC5bWmh 9BqUjFgwXG53yvwKPMJMd5jyzB/0kKiudJQ6jTTG1L+6xmyVkGZmt/zGC Aszq0mzAlgWsPVyPFci3QoKlri6gP2981J78/EwuE8ME/9dabndAcD54m c2kU0dW+RqQt/Uj++upG5LGnT501OKXRPNla5qKH3Ys4v0KQ2daH1iyoN 17E0YPblmpScTsTHdkU+g76GtqbOC4yGJqnJbCh1AOi9cNNvBtfp201fH A==; X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="10792684" X-IronPort-AV: E=Sophos;i="6.05,238,1701158400"; d="scan'208";a="10792684" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2024 03:33:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,238,1701158400"; d="scan'208";a="37487788" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Feb 2024 03:33:47 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 03:33:45 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 03:33:45 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 2 Feb 2024 03:33:45 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 2 Feb 2024 03:33:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8AgFGG2vDhnENdTh84TEfi8hlkKI5e1nqHLOrEbQvD7I8J9LL5GXMiN6xbqBGSgOx5XNHUeMJ+usANrujyKtA3WeeieVpXHS72FncO2VnsVfcJSwPM7e/4NLYDZtzQpXhtznXA/Nsy0NJzZ899fnZIn0t9X0ONDs24V+FetHHdAfc37+4mad8iqBkQkDgjPFoqyGwN/AZM0Cu4BuJ5qqCUvnt/AnKsuUJm/0i0tsJQFG1v7gd4HKUBq1yS7AF4eeBP6dCG/VGDvEIHwgPZdraoVeTvMHE5pbxHjvU6VhQk4NxybRdDMSiiQca/dI0t2o0lm0IHX5tpnwXeq1G5ZBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bBnnqlYUEVJFgpGvOjyGz0wG3iSTa/ne3VyVrZzbzWc=; b=Go8cCDdr6sPtGGVV7IhLH2OWlm1YsT49cPYnVj/J8GO11faxWF9GeL5x7kw9VKu9jqjaw4Oeq2Apt0OxB25Q6eNahnh0BXAfhcr4P7/kBjZxWtelGATS4TbmcmtQPlFeCPFRRaEz48ESVhnjbmYais8QYbiOqUyJ2lX4h9HZmkccdxH06werH96D8huD/dhhDaNQS1coTadO/Vvgw3YgX44xw9DVvfB5+Zaxi6pLV2og2plMQvUjqj8do3Kt5b+Nakhclx+tzxyT4BMbZXVPKXW3gYwip2GK2hZ4XyHLA3HODFyJYMi0JlZjbTILxvyS49SxOaxZZSErhMM2exVG7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA3PR11MB7653.namprd11.prod.outlook.com (2603:10b6:806:306::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.22; Fri, 2 Feb 2024 11:33:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7249.027; Fri, 2 Feb 2024 11:33:25 +0000 Date: Fri, 2 Feb 2024 11:33:19 +0000 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: , , , , , , , Subject: Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields Message-ID: References: <20240118134557.73172-1-bruce.richardson@intel.com> <20240119174346.108905-1-bruce.richardson@intel.com> <20240119174346.108905-12-bruce.richardson@intel.com> <211a59b9-095d-418e-be82-b49f4e5d1d00@lysator.liu.se> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DBBPR09CA0005.eurprd09.prod.outlook.com (2603:10a6:10:c0::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA3PR11MB7653:EE_ X-MS-Office365-Filtering-Correlation-Id: c742e75a-3208-493e-0101-08dc23e2c524 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J0KoNYXseDtLOlUIh6PSfrDBEA+cxqK7xnvvegCYPYIKd6kqRBhECQnfiKSSK2I+jzDPR2FwAAi+XK9lGC7MTUrdsXHpanfvvn6RYtq6dlRUw9ToZKuZmeAizpH+pr6RvCvE6jTren5AdHbsefWIb1HhvxSJDzXCWecqAe/kW3UrrpP6uij7/xgTew9PXc5w8LQxANkv+csz038yeuNHQcD9VmU9lobmRS6jOjZbSnxhtKNP4DiSSEdnzF1U5xf9xdRTBGyvbQ2exwXoI5vHaHsZFf6909T1X3sQGHavAGa6U0iF668ZSY1uiXqniCp70FSbjt490MtZDj1P6W2S4a8bDX1pA9cH+JyFHLNI0GXWVqiqcX1OojWtBJhVbBes//S2m3DRH575NeMIY5ZJmQC2DvPL7LobablKz4vlPnMM0UJ99KeRiJK1QpduUe5gMYyVkwV4j2423/FJsY8vsnxApOuBebWmdVxc5HMK8HtjqXvhOW76gmIgYkrJKfgVvnen9KG47mvFzCIAb/nbBOgbHOjxHm+GCgDAql+94j1Kj6wgsIUhldulGavlM6e7 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(376002)(366004)(396003)(136003)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(107886003)(26005)(66574015)(316002)(41300700001)(66556008)(296002)(6486002)(6666004)(478600001)(6506007)(53546011)(6512007)(38100700002)(6916009)(82960400001)(66476007)(83380400001)(86362001)(66946007)(8936002)(44832011)(5660300002)(8676002)(2906002)(4326008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?DdNUJBwfmuUNaQs2Rg7KS6gF/OIG3yld3cL4OxQnELpE8d7+GCMMkwTZjD?= =?iso-8859-1?Q?kdGFQNUo5EmI3zxByvnQfzBnBPbelH+qU3Z5AgTZoA7/1C4sgpcyDexVCG?= =?iso-8859-1?Q?0zLHMy0WqCULEI1GQJ0K+BnfiupAZLUNsZAiGwx6fPMjyj9puDS7RxCztr?= =?iso-8859-1?Q?FYIWceHQ+qWJ1sxacIk0DyarKuiKG39ZfLG7q2lZ5zhakqDdS1G5l3wdMG?= =?iso-8859-1?Q?UEccet7Ce3wZuscE6y/Nrky9lY36zshcKZIHdWDsD6ah7uNp/ERNWlNEtM?= =?iso-8859-1?Q?zqozqjtUsFw+jbAEUABtzQ4Yau7kA8cD7p5rEPHo2crti+nWnhoL3k0fOi?= =?iso-8859-1?Q?xSGZiiBnLakLlgtYUqUERqu42oiRIow/aqon9GX4psh3aHZmruEgFPFftZ?= =?iso-8859-1?Q?onF03UyKj1Pg7iT1TELLrS91jGW/2432ymQmadhFShLssaGZiXA071wrk8?= =?iso-8859-1?Q?4d7defIO9uENHEWMT11+dM92X7BvKJX//VBKc508s6337ApzVoNSfaZjDF?= =?iso-8859-1?Q?z8ayf4H6x+e03pidcLAJYvO3kIryZH0aiIb2qzb0e9B2maSxCX8lSfJYR2?= =?iso-8859-1?Q?LzgXrfM6oEUb3b/bviDQsOvooVpNgv2pxVsZ4Ucy/bEVbThzHoM/RNYlEq?= =?iso-8859-1?Q?tEjofCujJLtZgB/HaKWvBt/vXKGo5dDOAiRU/rlYMpOM6rY/Q7eoWg4ikf?= =?iso-8859-1?Q?GPonPa4hIUVkIBmg0oGM+kyowQYUT61hNP5uLRGXfa20pe2ALS4UzfGXDo?= =?iso-8859-1?Q?vNFZl7eo4rR6GXEX7eRG6OMK7SHdUx8QmbliaLc5j1fmdkpkVgu9d+vZlc?= =?iso-8859-1?Q?yN4IWiLcZbZ50v+Mq+2FOnlHAHps6f3Nct4gS7PfDhjyFJ9NBZT1Yp24c+?= =?iso-8859-1?Q?GdoY8EY2BOhugcMJjo+DEFQQV/5ma5sBc/+41RPPbCN3+3PpGkjqkt29yO?= =?iso-8859-1?Q?ZfJ9kzr8XkfQA8h6hE5F8ARm1M6uukGYNM+DNZqPBeepIZTIpbkpyZ/i6D?= =?iso-8859-1?Q?7scSpQ0Vqva/10kJSlFC3tsD5FtdG7v9ADXqKKckEt3U1Ao4NT9w7a2/2o?= =?iso-8859-1?Q?YM1n1RBk5p9JXNxwWJHLMYqQjGnzY1Zjz8pfaKGkOTJ5yuWmYIK8fUrJ0H?= =?iso-8859-1?Q?u+Q19QFHjmReW908CYdPFLl8Zad7oYAmCOiiRDhP7cblYf9GBUiHCTadFa?= =?iso-8859-1?Q?OvQr3wSwTHIGMAttEicWEspkv/RzetVBzHIKlqg0t+GcHJ2PgPZSrAxLat?= =?iso-8859-1?Q?sin4mQgBaL4xjK1QPQDMk5/2nHAdazxRHr81Wea+CRne1OIVxQN102ZVbH?= =?iso-8859-1?Q?85hiMZnmPm5j3BbFvKAboj1YhWajcNm5QtRaQDo5/+dXS1Fis35Qy/xa4M?= =?iso-8859-1?Q?7Vxb7R5GLw1Rfi9wq5Fi0A48BQKI+PHKw4MknyBEbu23eJlTC0V6H3xIoV?= =?iso-8859-1?Q?hrRxFJs8VuxQkxNOFbCk2hVNplpzNiRnuFVKv1I7nZEUXwHq/DMccClPeg?= =?iso-8859-1?Q?bjJ5oN0v+ZNLLNNL5/qdGTugRtO6tMm6gzqP8xumAt1wTAE18DVbBpk3wQ?= =?iso-8859-1?Q?dW2iCZ7CvWQYpHgOzjpXbmsblcpD0EJUJSIUIWRrob4GA0vGjmI30ULuKD?= =?iso-8859-1?Q?sIPLgHikxzBZjmgG32YMCmfLfZhmJDh1TK717xhLj/9UbSUgdL+V4+Lw?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c742e75a-3208-493e-0101-08dc23e2c524 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 11:33:25.9159 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k7vO/g+NKYZdjjvHMuP3pEbN73PZt/3dg3InVLJZCQ/WssjAeZmb4paexAEZWnmi/YNarrKRFeGT5P9x0qt4hi6B6KiR1ffCou1tDTX56Ck= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7653 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 02, 2024 at 10:38:10AM +0100, Mattias Rönnblom wrote: > On 2024-02-01 17:59, Bruce Richardson wrote: > > On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > > > For the fields in "rte_event" struct, enhance the comments on each to > > > > clarify the field's use, and whether it is preserved between enqueue and > > > > dequeue, and it's role, if any, in scheduling. > > > > > > > > Signed-off-by: Bruce Richardson > > > > --- > > > > > > > Is the normalized or unnormalized value that is preserved? > > > > > Very good point. It's the normalized & then denormalised version that is > > guaranteed to be preserved, I suspect. SW eventdevs probably preserve > > as-is, but HW eventdevs may lose precision. Rather than making this > > "implementation defined" or "not preserved" which would be annoying for > > apps, I think, I'm going to document this as "preserved, but with possible > > loss of precision". > > > > This makes me again think it may be worth noting that Eventdev -> API > priority normalization is (event.priority * PMD_LEVELS) / EVENTDEV_LEVELS > (rounded down) - assuming that's how it's supposed to be done - or something > to that effect. > Following my comment on the thread on the other patch about looking at numbers of bits of priority being valid, I did a quick check of the evdev PMDs by using grep for "max_event_priority_levels" in each driver. According to that (and resolving some #defines), I see: 0 - dpaa, dpaa2 1 - cnxk, dsw, octeontx, opdl 4 - sw 8 - dlb2, skeleton So it looks like switching to a bit-scheme is workable, where we measure supported event levels in powers-of-two only. [And we can cut down priority fields if we like]. Question for confirmation. For cases where the eventdev does not support per-event prioritization, I suppose we should say that the priority field is not preserved, as well as being ignored? /Bruce