From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0995943AF1; Tue, 13 Feb 2024 09:57:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB438402AD; Tue, 13 Feb 2024 09:57:31 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id 89D5B4027B for ; Tue, 13 Feb 2024 09:57:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707814651; x=1739350651; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=FQWat5pc8Gi6IKtLwT7PZ4mezUYCw/owNnHIGiSquVw=; b=ThOtHVniycjvZzgKWSqgGlPf7UjQSs6psCMNAkA422XJlX9Y1d6v8JwE Mv9Zmosm5+dgTuW1J8EOgqFEKH7JmNVg0dpjg5C3NdXvfRDCYj8fzUImp eEov/P/M9XKZ6ieJ+7kC6fwkeShw8KQX7q9Tq25Nk8CNcHIkpEHU4jYnI H897pogB7XJ61NvvE9IoyJD1GhTAKIPzDAT0ovRtcHqCcB8nrcV8wDw3f +aFILJCKu6/P6IznIvIlVZX6XYdrtFQZt2zss7vyM3Xry4qAlyusmcwR7 u6XRQ/jI1rrS2g35UMkd0Uvl5yiHFPixeb/3ByrjuK2Z64PAiqjpsPeFS A==; X-IronPort-AV: E=McAfee;i="6600,9927,10982"; a="12903176" X-IronPort-AV: E=Sophos;i="6.06,156,1705392000"; d="scan'208";a="12903176" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2024 00:57:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,156,1705392000"; d="scan'208";a="2782121" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Feb 2024 00:57:29 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 13 Feb 2024 00:57:28 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 13 Feb 2024 00:57:28 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 13 Feb 2024 00:57:28 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 13 Feb 2024 00:57:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SPPrmKACSMHPF9Z9J4tryj9n4bA7b1xrR7hUPJwSUIeLSuCfwlDu4ZIe7rozGzIgMX4UmTQU8HJA90wH/WvQ1xAI5ase8R3ZqzdtArEwgcAtT1Jo91Ik6B1X+cVD9EDFqm0msI2c5Rfvi0hi8/ZCqOkQ1Y3faO8qZ3GBw5ruidRUKl5TaR9N0AfL8GxKSobP9gJ6GDHI+G3GlhPdFycoZGmiB3bGPLSIwjLXoHVVZeuoNi8mKwGgMr10MYKJzZrShwMb9b91LSpj6fkFl/ttEVLJHJyLoCnIZmSAB3Zp7lcSMg6NceGEvvoN9eY9J3rrNYs7dbboGK4ak7vd8LK9wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lbK3AlKX8OxEH86F6ctk32VXT9DhI4z7xRUK6cejK6o=; b=Wr7G5IB8TTGub2ZiENQpzjSkimoJV+GQUJNDOhHxfL0vJZvnZ6S6gaqWNRy1rQEQmx5sYrVjCwKRngFYE1yUE1NCUqAE+n4DI/KLXn8aF2/1hJ6KYCEAghaVgaLyeRi7EP0UF7OfLk/QM07tFzKC7jo5P8A0fN3C/q/0HTiGR9HyU6WYmVT5NB3nwyY+xtLTKFXZ0HX3d2rBNf9rxJAWLTdKPkxJ0KLotFM85AuzDGJ68H/QeacmfJPBetXSoF0U9DhZxPLFYFebk6JzOpdi+e+7VHTTayaFPwqZO9jLB6anrkxnvYBo+Fg0SKVONiZFCfWqqHtZDksAqhIa6DT6eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BN9PR11MB5307.namprd11.prod.outlook.com (2603:10b6:408:118::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.39; Tue, 13 Feb 2024 08:57:26 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7270.036; Tue, 13 Feb 2024 08:57:26 +0000 Date: Tue, 13 Feb 2024 08:57:19 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: , Andrew Boyer , Andrew Rybchenko , Chenbo Xia , "Konstantin Ananyev" , Maxime Coquelin , Subject: Re: [PATCH v2] RFC: replace GCC marker extension with C11 anonymous unions Message-ID: References: <1706657173-26166-2-git-send-email-roretzla@linux.microsoft.com> <1707806741-29694-1-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1707806741-29694-1-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DU2PR04CA0006.eurprd04.prod.outlook.com (2603:10a6:10:3b::11) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BN9PR11MB5307:EE_ X-MS-Office365-Filtering-Correlation-Id: 86e40905-29b2-4c1c-8a74-08dc2c71cd28 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eZ2JmPOJ+UVy8P0Ifj67qjQtRejEZ3f1hrsxywzGHJFIbDCbv3P4OEdYQ1G8+7aVwFOHxD8/F2Cu0SMxM7VHK1Hlx6DWd2RBLm/ijdKoaNaAWNRlwTNHeo73s9hCgC63jeZ7WyUbYEUKfYUBf3UIBpw78SVDvJT0x5cS+7lg4Ve+/qObDk9UMv34PHhnizBKnxVBp52EVJXiVqcCapdcNR1xwXHURFGakKFGxPhmGMZXH7OBvcEuF2mM0WjM5G0tX5lR6SuZ4LEUDabxHTdOrYl0pIAL1GF90GPYYPy2wkjqlPMGGuwp8xGw24khl8gMcuBZMTITqpYTDHxufmlpnU2uRdWnzcvH9RRhHifDrWEhv2vIoJHkfBfkwh1V8fVkjnnbhYxaqQn0MxvodDxnn6TEbYtgyIk1KXD1YUCgwn+lWcMYOT72NQEY/FQg54hWVRGzmN0hk7U47AIxJqq+Z1eKX4uVm+NfCxtnEEUlT6e2aGsVpZN7TRnpijSWtXiSEbFe2Kpsp5kgZMX7/PQC209NPRM1AaOk8oHzVtLmmIR3n+QfpqjJZzMeWZ/y8a5J X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(376002)(396003)(366004)(346002)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(8676002)(41300700001)(6666004)(44832011)(38100700002)(8936002)(4326008)(2906002)(6916009)(54906003)(316002)(5660300002)(66476007)(66946007)(66556008)(26005)(86362001)(6512007)(83380400001)(6506007)(6486002)(478600001)(82960400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uhCflLMKauce3MwplZm3GQIRRggF7VUAKCZ6fctWMeaCKAXAA5Y8I3TySuwt?= =?us-ascii?Q?rFDHPiPpvwZjp7qzgztvwi4x6qZRtxNDZfWZImO+mYrtDPrerNtRKRbLcC60?= =?us-ascii?Q?usaPh5cnVgpmQ8JpX86uvz+7LtusVbviXiq31xY1a/11Fca4s4duEKxCLGuG?= =?us-ascii?Q?IUuIRx65eyBYhJGSESRK7Rp7j4v39AiT3DMAxSGbFXIoxf+pGnWmCAL8R7P7?= =?us-ascii?Q?rCmuVHeKj5kG3T/WrUJhDT1ifeZ6VGhwAxGWoYQUY7zF43d5axE1MFwVkBOe?= =?us-ascii?Q?NNII1aQlpA+/WBl+5Y/m2LbfpmTq9BfWjQQELMTntxPdr1r0bvUjgo0nbvBD?= =?us-ascii?Q?5jIainbmafrB9M435TOoW1AMicmJZT39RtrkZly6dqDdirzWt4S8DTGEnPMn?= =?us-ascii?Q?PgIyLrPslzN7EBFTBnhJqQ8nYhMCgrA93fEAjyYKSYx95BTDusCfP7hJeY4H?= =?us-ascii?Q?Gg+N98mavS5Z1IucNaK3BQozaiSoRdLWL3UHa/7l9fJB5pcSATmSOoWBIuj8?= =?us-ascii?Q?Ui7ACkNYJ3/mt56020mrtDlhOujV9tLX6m+LKsYNITz5HwbXeSY7lmMRinCW?= =?us-ascii?Q?ppzjabouzFOduOG/XxBVLoJv74rD+BxDBQoNTKfYQ/8SBZzBiD9q+YUa+t2l?= =?us-ascii?Q?481fmQEkS4Gk0ZdZqlOUvEBzPtfSNedTm4Ncec+9EFuC/2/2QT3JfNKWq18f?= =?us-ascii?Q?liP2TpbSj5itH174y+T3Q9H0Sr4yRp12xIDfvmV1T2veQdsIyCmcDsddMGZQ?= =?us-ascii?Q?5aqL4ix/2Pp3NuUOq4tkScmC143oEDD4/g3j1PbBN+lpf5/GNCZ1t6L3j1vj?= =?us-ascii?Q?LpbzskB9Zm/8XatBI4kwv9cvaYE+nSUh4XBfQWuWfjTT0NK57Lp15/pq4JUZ?= =?us-ascii?Q?rdiuX3wjJJNI6s/uwDrCbEHlukSgkTv3PQ0r5fG2CQn2hi4crBrjXRC27XIi?= =?us-ascii?Q?5EYTNbDg9SR8JuFQKlBnDRhMM0kv9u24UGDMOICIqwRmkry0uyEPQPhNSOJS?= =?us-ascii?Q?3RzInsGbHR7Le6STYrDo5RVTqBKU4fJoj8H4zW7SsKmaE5dEjaiqT04sa3tA?= =?us-ascii?Q?QEg3eoe+YUsauF9PJHkc59hl2IPcHeHvjT0y3tEmP4uwqjxdq22v+vNouG18?= =?us-ascii?Q?mjylqQQ2PzB2UsT9/rmU/FnzuXTuSErEj7qCb9McrMAvaCTdDbndGmfYXZ4c?= =?us-ascii?Q?NqNqO769Aw9702IXzZT0Wbta132qfYscq00SEQTDOb3bYgtCKUyHLrNc1jQ5?= =?us-ascii?Q?/DzbUGsgLVlBKCMuquksRvk5b0cK17pB6r6wFU6OKT0c7V4uC5ipRpi2hMLu?= =?us-ascii?Q?lKfvwAwShEcbducdvE2IdYxIQEBLg2kn8Y0EqAawp9dX+Q41d+wxYwbO0R9R?= =?us-ascii?Q?RJwSKMPzvxnh+aMv2C9vSYc8DyOwuKFNogtl+s6yKBQCNNXHnd6j+oisM96b?= =?us-ascii?Q?/HM5A0x9ZAsoYuUUSwuUE4zYFAl51bAryTvAYtTJU3nPbgmN1A5X1E1hJHde?= =?us-ascii?Q?afqHiorDR4pEmQKan1vFWw/WSKNhWyBOG8bjQoOz90WTGGGXd1tbYhHMb9WB?= =?us-ascii?Q?BwLy4EXpcwYxDjmKe5lZgi8xMlbKuKNKwMcKvXwsMehZXOGL19TMWblNASI+?= =?us-ascii?Q?hg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 86e40905-29b2-4c1c-8a74-08dc2c71cd28 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 08:57:26.7122 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Da8ZGpONDZrfIjn3+6Uc4XjIiqEpY/Wdy+3OIEIzYU/XFaZmUgFKtAnPq+1Qod3iUp4EE19FcheunS02o3ODSZPwcZZOuTgTfxsAilLO/VI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5307 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 12, 2024 at 10:45:40PM -0800, Tyler Retzlaff wrote: > The zero sized RTE_MARKER typedefs are a GCC extension unsupported by > MSVC. Replace the use of the RTE_MARKER typedefs with anonymous unions. > > Note: > > v1 of the series tried to maintain the API after some study it has been > discovered that some existing uses of the markers do not produce compilation > failure but evaluate to unintended values in the absence of adaptation. > For this reason the existing markers cannot be removed because it is too hard > to identify what needs to be changed by consumers. While the ABI has been > maintained the subtle API change is just too risky. > > The question I'm asking now is how to gracefully deprecate the markers > while allowing consumption of the struct on Windows. > > I propose the following: > > * Introduce the unions as per-this series except instead of adding members > that match the original RTE_MARKER field names provide *new* names. > * Retain (conditionally compiled away on Windows) the existing RTE_MARKER > fields with their original names. > * Convert in-tree code to use the new names in the unions. > > The old names & markers would be announced for deprecation and eventually > removed and when they are the conditional compilation would also go away. > > Thoughts? > This seems a good approach. +1 from me for the idea. /Bruce