From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2491143B05; Tue, 13 Feb 2024 10:03:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5F5E40F16; Tue, 13 Feb 2024 10:03:30 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id 63837402AD for ; Tue, 13 Feb 2024 10:03:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707815009; x=1739351009; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=4xIZ7OQhZittrxxR7gms6M5kBWGbpO9ifkrkm60UA/s=; b=ACWqJFKALlrqXPet6CGa+vtZY9vwwDR51yuqZlQLEYTI1tAvtxZfJv+G c6I9Hrhm3/0P23Y1MKnK69uhMVvHGIa+KO4ewGasKRm8cxAkcDg5d8NgX bNJRjq5jZBcLPCZAg6O1SV71cQtDdd+P97CWfPXGLGPCHFbp29SQC9jyB 4i8R0jsXb3dt5BMsSWryh8r6VKoDalc7SQiBl4ZDIbfHBYi9h43pl/+Zi BAXo6uJPXim/H17R/UcO3SZ4rORhmFHwALV5iOsBTT8Sibwv5yQrZWbWb mq8tC0ATjC5vlWuaMzwQ9nC2Ag4aEEaW/0mFrmi7fCmdHNmPm+JnU6e2T A==; X-IronPort-AV: E=McAfee;i="6600,9927,10982"; a="19325743" X-IronPort-AV: E=Sophos;i="6.06,156,1705392000"; d="scan'208";a="19325743" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2024 01:03:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10982"; a="826056898" X-IronPort-AV: E=Sophos;i="6.06,156,1705392000"; d="scan'208";a="826056898" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Feb 2024 01:03:26 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 13 Feb 2024 01:03:26 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 13 Feb 2024 01:03:26 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 13 Feb 2024 01:03:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kCi9JZt/KAz61xaQGACcmZRlliZvN7g9w7Zq89iVjs0YNM1BttEvw9yZxQgzdB0DyfPyP4C5mi9GkgaUqK8M8RVierYmV1mVvIqvhf3fBpWL/lcpxsJzfnNBcmNPAAR/8Ksw+Bok5c6Z6+YL5W5b4AAFRmtLpwUbvVwupu/LoBuQ7vV/Uuhuhd7IbTUie9+jlH5NiE8DduyGwsfz8ithZjKBIDnPLdh+/t423ONbuufcvQOEXMQG2tcz5k89fYufl2c11eUBlZap/MoNfuLIe6kW62aj22cXqEPqQVn1gLuW3+TlR7K6aD8SEXZsJKtJXGdXoLrbZ7lcvtDK4un78w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Z4pgUP8njgWRly6budS5r6cN9X77VzEck/RskBigiU=; b=M4tVCkrusqW7OyMCx2CfHO4QOBJ2j2X3z3xMHgF9Zm+0GwVcQe6bErEKUazkHt1WaJukHHKqsNB6WA11EOKSfjEimRdFMQcp2+EhGz0zC0POa2/WQ0eGUHK5Pj505Tdb0hxcaycs5ZYB3LdANFB+JCtIz9FUvexRg3mVRd6y8e9ewDDzCNCRHBzHj8QJ4kN5/bdqI6c5LuKLZ1J/0FkN0mNSuRYKd0mfKVzTK35z7p2+OkfY6vJNf8QhO5Ci33CbTHObpCwK7rQEjyebmRttwkTT1YoLMlpxXac9k7+CpytjT4BOOs4t/fmtAAnLe7+7BVqvX0QMio3Ho5C7xa6oNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB7590.namprd11.prod.outlook.com (2603:10b6:806:348::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.33; Tue, 13 Feb 2024 09:03:24 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7270.036; Tue, 13 Feb 2024 09:03:24 +0000 Date: Tue, 13 Feb 2024 09:03:16 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: , Anatoly Burakov , Ashish Gupta , Chenbo Xia , "Cristian Dumitrescu" , David Hunt , Fan Zhang , Hemant Agrawal , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Konstantin Ananyev , Maxime Coquelin , Reshma Pattan , "Sachin Saxena" , Sivaprasad Tummala , Srikanth Yalavarthi , Stephen Hemminger , Sunil Kumar Kori Subject: Re: [PATCH 03/15] cfgfile: use GCC and MSVC common VA ARGS extension Message-ID: References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> <1707774557-16012-4-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1707774557-16012-4-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DU7PR01CA0023.eurprd01.prod.exchangelabs.com (2603:10a6:10:50f::20) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB7590:EE_ X-MS-Office365-Filtering-Correlation-Id: bf86a8ad-376f-4b46-b9df-08dc2c72a27b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4/24sGP7gYSseus6Nanw61AZJHDJqYM99ECTCQLHz7L5qd2WCx1eAVboAjZJ/L4PLa98jt+LCjz84wx8hjduV3mMHNx+sOYw7XEt1ZGbQ41E1XZBnVPNOgWHaRKvniRQcbyrD962qPs2K57I7G2dAxCsg71W/NcAThtbw4Ym//tLGDbft1f/DF2LkUCcGlfW2QUs148p4sK2NloyJ8Q10LmLYqlBJaDY7xMPQceIXwO3fcuB081z05cRLp69/w1cQ+pYHBCRSlqwR24WI3YAH/J2IuG6xZDrXddFo5x0icKATFAYew9i8P9EdncAzZ7hj8CcN97ES2/wlNNyvjbC3pUV2SoJ70Gk9T6ka42pBDRQYsO/b0yUw3sn79JvSj2Ys/cVa3cC8A/LixqD2VP+laTpIoNO0VF0+fycjOOqPi6XW703I++a3I5vmT7TKKdi9dqo9ixrziGTHBzY2CXpWyHXQ1RGpM8RqB4HjO2zq7jd5vE7HeukiKkgpdMWrxa+xAr0DYYgLXd0hAff1EdlD5PCUcMaNmy6Sn+vSJlL/3aT4HESFr8x53Zgh8Z4kdJP X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(366004)(136003)(346002)(376002)(396003)(230922051799003)(64100799003)(1800799012)(451199024)(186009)(6486002)(6512007)(6506007)(44832011)(2906002)(5660300002)(7416002)(66946007)(82960400001)(86362001)(38100700002)(478600001)(83380400001)(54906003)(6666004)(316002)(66476007)(4326008)(6916009)(66556008)(26005)(8936002)(8676002)(41300700001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YAGTTVS9JjE171hUuMS4T7UBXE+yhfm0yXijd7GqPj05+jhN1YqukNqY8QNf?= =?us-ascii?Q?4HOFXC1KXnxXfEIVchIzF51KCb5fkaWJZxoolPdtwtmLa1boYhlHtptR5ouV?= =?us-ascii?Q?EZ/LZxz/6FbU6sah3MuWWb6FxYk/O8P6nwVyRXExXC9dn2erOuFfuIvY+fvR?= =?us-ascii?Q?sj5fSMwSGUriImRjS8ioVN27FVjnWtDSNxjk5CXubWHeneHK8fVHQMzdmqNo?= =?us-ascii?Q?CwWozv2LPvxCGSVTAk8828jsL0/8ETGjena/iWh2Rv8Fl14lEKqt3/su9INV?= =?us-ascii?Q?r3sdWCo1IS5vl6PxizrAL1kvqVvPwKchwIYF1DNeIoUOYa0gmHhL4Pkixjyj?= =?us-ascii?Q?Ed63V5V09k+kMY7oSLQoRqijgLFnb4/pgAhyMJR3964CHll+7YynkebCuuLD?= =?us-ascii?Q?dXWCziNhVnTveQZJAL/3WZfMYh2JSljMLBmwch24bLgS1PZNEt4N+yLFJKr3?= =?us-ascii?Q?CvTDkr0xgq68RCXnF87+71gUXtw3U3v0lBL8TSKHICmvboJdDt23V/eAsryD?= =?us-ascii?Q?wyX+x9Zy7OnbSZLY+o0S0pJvLMjSA6s3UqCUAqzjz0Fllooi/5BOrhN5jwpO?= =?us-ascii?Q?1rM1PAn1KLHyUwPfW50aomBNXRj5nRT43OV+mbLCEe7UG2U2qOLTAznROWaI?= =?us-ascii?Q?CdkkJjOcdSyfGgxKcri1MxN1iYD2cmA7XTDLw4I6yUaJihdny8UkDFEd8epb?= =?us-ascii?Q?u/06SquAdSE3ld7SWHy654Ns2zOPvTHLC8vTHPph3C04zm5Gy7KgEr/kG169?= =?us-ascii?Q?5OsufO+3rgfO3pWmLds6LuwLyY3t1TYZX7r31Bw52dSmo2S1+3Ng7ZMu+GCD?= =?us-ascii?Q?Kxa2uNtVMAHYQhKnmws8GScE+4OTX2MlxvfcsRRR/KF7WDJHHxH0yuJlu9zA?= =?us-ascii?Q?OvuA5PWWAY/YeKziGVd0233/USBt4FX1OWWd7aQHb/LCMfcuCGfd5+js6hui?= =?us-ascii?Q?BD/YLic2osRrL7U5hTAgI3svBOkuL4RkHEcduENTWw0p/kfAI+RWnQ0U265o?= =?us-ascii?Q?9oQWEBg6BCH1ar7PIuxNj8J0LXdvvch1Xsp3TiP86xah0+xTB+Pz35se5K91?= =?us-ascii?Q?ZJEB3YAvHm3GV+va2vqQwP9t/LjKr9Q1R1LHkp3WhYsV3o9LaUmbHC2Prl5Q?= =?us-ascii?Q?42z7lOc1t1YIfO26vytngx7gHZipbDgi6WHP+gOJek7R35UlYHU4oN4xTxw8?= =?us-ascii?Q?l/Zbbv7B7f76kvp3FDEmXwL46iYIje3CCY62c1zm73eEecsT/zXqa9hoEDHa?= =?us-ascii?Q?IhnNAblbxvTk1RZII5U3ylQwnEXGmfGe30lPhMMHC5Saee9RjDspPI4/Xh+A?= =?us-ascii?Q?VShb5n4qO19rAGIOJj7qediGpkbtMkoOjZmL9TRhL500R1Z8BAL4i6VWut4y?= =?us-ascii?Q?KKLKm8uV1KDzcTZEt/7kXEY9fWrF/MqrlHIVMfEod5BH62zr6/VMUwohVCGW?= =?us-ascii?Q?YVQYHd3zXi2iz4V0602rB7P4SBNAp2lGvmw/iPK/yrIRMxMAEUJ4iyQJuWmI?= =?us-ascii?Q?QyrV0/buM+GC9GWhVDbCX8lbqUSw6ZHWcrHh6+rPjd2MbhZiZiEumMuxe5EQ?= =?us-ascii?Q?kkIJmm7RcZdyjSprjLjwkGLz/G0d79nCZfswSOkfJ1z7rif/dqv9N6SeK479?= =?us-ascii?Q?oQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bf86a8ad-376f-4b46-b9df-08dc2c72a27b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 09:03:24.7219 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IyEnMVKwaS1HvAgZGhoeTIUvYFa/ePsRgusyYROtPw1vZ44G2WvKSnOwNN95Y3oBHsPtNtkTAi2MDcz5ksz50FBtsBQbcwL5jo4iscmLZy4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7590 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 12, 2024 at 01:49:05PM -0800, Tyler Retzlaff wrote: > Use ... and forward with __VA_ARGS__ instead of args... and args. > Neither mechanism is conformant with the standard but the former works > with both GCC and MSVC. > > Signed-off-by: Tyler Retzlaff > --- > lib/cfgfile/rte_cfgfile.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/cfgfile/rte_cfgfile.c b/lib/cfgfile/rte_cfgfile.c > index 6a5e4fd..e006508 100644 > --- a/lib/cfgfile/rte_cfgfile.c > +++ b/lib/cfgfile/rte_cfgfile.c > @@ -31,8 +31,8 @@ struct rte_cfgfile { > RTE_LOG_REGISTER_DEFAULT(cfgfile_logtype, INFO); > #define RTE_LOGTYPE_CFGFILE cfgfile_logtype > > -#define CFG_LOG(level, fmt, args...) \ > - RTE_LOG_LINE(level, CFGFILE, "%s(): " fmt, __func__, ## args) > +#define CFG_LOG(level, fmt, ...) \ > + RTE_LOG_LINE(level, CFGFILE, "%s(): " fmt, __func__, ## __VA_ARGS__) > /* >8 End of setting up dynamic logging */ > Reviewed-by: Bruce Richardson