From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEB5643B57; Tue, 20 Feb 2024 18:50:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CA84402A7; Tue, 20 Feb 2024 18:50:33 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id D299540289 for ; Tue, 20 Feb 2024 18:50:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708451432; x=1739987432; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=vt+UfUe0E5D6TQlMZNnJadtcmn/QcJQ7h5/FSN4GhO8=; b=Q3/Zc766UBXohvM1UJq8rW5IY35Vh8enF+UIS1d12+Cyjj8tc1veGAS1 c62N9JVXy7wcdt5Nx4VNU0FY5/KFoz7AnpIpSfXfGZhYPlx6xP83+dtYB gW0z5a6kbuqPQPJjEXJbyd2Rwlu/R5WiHs95Ytsx5AoOR4N/4RsbGDxtz Iw2wr+Qi1G6A9rfU9OzxSzXN3Z9DWncbBk1GDy3ghtgw+312O6JogvA9S /I89NBmesI0SBC7wMRYByU6qCvUYH4cnWymRg9MaL6ppIDuu956208xfT SIZ2+aKG/LW+A4dMjgIkveJGuBUDnki/nvaj1uxvwFrPHaIjC1W6j/NYc w==; X-IronPort-AV: E=McAfee;i="6600,9927,10990"; a="25029148" X-IronPort-AV: E=Sophos;i="6.06,174,1705392000"; d="scan'208";a="25029148" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2024 09:50:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,174,1705392000"; d="scan'208";a="28010865" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Feb 2024 09:50:25 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 20 Feb 2024 09:50:21 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 20 Feb 2024 09:50:20 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 20 Feb 2024 09:50:20 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 20 Feb 2024 09:50:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f8U7aNzDHsha/uGuvG+Yb6TUyvPxwbtGV2il5x/wKFz7dc+sOTOkIxTzSKiafhEBR9xuLrfLCXSZ44yAsetN68mhmM5DB+DJQMhkjRjgewY1oDucs/FI8bW8mmlTdRztVCYtyOJ7uPovQoxJcNe6ySqf0GoBhocQV7sMygvWCyD8K/Rf2syRwJwLC7VzcQj8tWCojj5tX/X/6aT9Q2FpGThnQ7AM2CjytB7S2JPyI6MsGL9xODEsQCG7IyNDmKbsK9aVa18dv1a+Ne4selxFaSw99Rr8rSSnWWYF5UFQ78C0ZKN1wOgzw39Cilb8rKHag1Pw15NsUBqDsiX8uaOW/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D+hYz/uNanhxTrte2ioMyK6tnRxJGK7x4iTxP30FtxQ=; b=IoJqApe17XIen8h+XLrxmyA5qZQkuZsBVtrRH0KPp/6kUgxBfmr2SxXMU5aUXqdjACgoh4VRCJLqv76iDA6SN4Qw2BPraM1LUhjrAuE8QhlcHG5mwXA7EByST/u+vw/eJVIqd1xCBdEZtFN8OnGtG3DmYwSMv5Zx/DeDxbGDsfvrYhjc8qZ0px1c6DEMZhcdxcI4hsK9MBgMI4Bgcmo0KyyZ7Pb1GyaBIUmNEuY8oVL4Wo1tjMMSyRJjyw3Cpw17KA8ZOcjbsFeIur18AkI79yTRBC1grHwtpceDg/0lJwnw0KveY0rNwfVCdURyjRXDEbUlwT4ELcrsDDdfYo0P1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA0PR11MB7863.namprd11.prod.outlook.com (2603:10b6:208:40c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.32; Tue, 20 Feb 2024 17:50:18 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7292.036; Tue, 20 Feb 2024 17:50:18 +0000 Date: Tue, 20 Feb 2024 17:50:12 +0000 From: Bruce Richardson To: Jerin Jacob CC: , , , , , , , Subject: Re: [PATCH v3 10/11] eventdev: clarify docs on event object fields and op types Message-ID: References: <20240119174346.108905-1-bruce.richardson@intel.com> <20240202123953.77166-1-bruce.richardson@intel.com> <20240202123953.77166-11-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB8PR06CA0062.eurprd06.prod.outlook.com (2603:10a6:10:120::36) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA0PR11MB7863:EE_ X-MS-Office365-Filtering-Correlation-Id: 937288f5-7f6e-477e-7b29-08dc323c665d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HgljDWtRCZwyE2EgzT9GL4H3Kz/jVNNw+8q+KbEw8MpdbgoK0zJylZXzH47oGFoTQMiUVACU0ueTlyJjRTR4kbY9hCrxyWHlASb8G/1PM4zWyN+aphOa60sqD44VpUti2bGOiv6VawP25jrCIvG6lvM1UQMzNYG70cPPSR1Wj2HPL1cv31kqJZSSpYYT5bWVGXRx9xSuiaRZOpXDe4uxvODfdr+nUdqKDjr/driAqOU1EQX5gRCl2sQfJR+/ijhV2EEabEWE3jZtodbwnBP5bbOI2DV9l3o0lF0C+Mgu4fjT0TWWA/xqjI9mo22p/POj83ynfe51vf/IkICQX5dEKopPH+USOlpxl1HYxCrodPfByMtrNS0x+jAzWpRoXt3fmnl1GWJm4pZmZfSNpso5uBg6q01gpmP+GWgK1E6xwr0G3Of1rFSA2p23zxiCc37LVF5/vD0M6IOkMUON1o0dI4aoSZsz/U8BSrnESPS97GQzui7nUpvuwHUWqjytHInTTRz9EKanoqku3Y/b0EXtO0iojlywbA6qslSWLJNdPxg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjdkVTRLeEpGODlzNFpkRk00OUVYUlFXRkRpaWRTYUJJdExGMWY4RlFlVTBF?= =?utf-8?B?RHNPMGZjUmFqNXVGT1hXczZ3MDFlOWJoMk9pcEJuZmZuWWc3MkVFVm1CWEpu?= =?utf-8?B?YWtkMzNvU0lXbEFodGhDTThvSXo2Mkpmd2NQNGFKbk5vTkhabElMb0pMRm82?= =?utf-8?B?RzdHVEQ0cHduUnZNaGJGVEc0R1BleWQ2TkIzN1o5MHhFWXlTUmlnbjJlL1ow?= =?utf-8?B?bkNoWXdjcWFuUy9kOFE1a3RKcDdnOHFsL1VjM09nNzZQME9zb3JhbmZ0VkJU?= =?utf-8?B?aytSVHhSR3ZuRDdlTzVpd1hYdnhDdlpOd2xsMVo0TjhucEhUek9sWUFnd2lp?= =?utf-8?B?dXlnQWNFRGN4QWkxdGpuRjI0dVlEZDZZTm1Zd2NQRG1jZVpqMjFSQ2hVbjcv?= =?utf-8?B?QS9NUUxiWUtaSENwUUFCQy9DODg3QUhZM293ck1oVW5NMG9OeHRRdUhBY2Np?= =?utf-8?B?Z2FDZ3ZaOXdKbGVrNi8xRm5LSTZuUjRxZXlYMk1hRWlaaVkvU05VMUFBNzlV?= =?utf-8?B?UWYwaDV2V3BodTZxYXVKTjBSUlhzMlVVcm9uY1FtbEwyNGxGSzhyK0xjSTg3?= =?utf-8?B?RUNObEZFT3hJbDcxQ0FxcjdtbmVlaVJSdzJKMXpPNW42dFhvQ3FDL0Zja0Iz?= =?utf-8?B?T1YvbUZVM2MvbUxTdC9yYll1WjVCQVpyWnhmdnFlSEpKN3gzb3RpdTUzSjds?= =?utf-8?B?OXNmMjVoRSs3UGlDTlRuSEs4NUZwU1hqVFRrc2UwOHJ1OGN0aTNwTlRqV0RI?= =?utf-8?B?aXhZZlVMNkFaeDJrcElSNFk2R3B2RjdtRTByUHZhb2E1ZHozdWk4dHBBTTZa?= =?utf-8?B?V3dnbE5JME9kb2tXWk4vOUNzcjFhY0lVWUtNZmhobUZRSlRXdWJkZkE4TmVz?= =?utf-8?B?UlAyR2Q1eWFLQXZEcHZNdmJQbGc4SnhkQ0tEVXlSNWY3Q0hBaHljMTlYOVE0?= =?utf-8?B?eEpFd2NJRDFvOXJXYTU4Y29tTUpidW1DUEFpbjBJS3Nuc0Y2RjhaKzEyclVP?= =?utf-8?B?N1FQS1dQdmNFbGRkRGxXYkYyVFlldDBDRGxFK0pxK3ZReE03M1NOMnEvSDNV?= =?utf-8?B?ZVZiWDcwSXZhdUY2ZW1QRG4yb2FmTTQzenlZRno5OGZMaGhSTzJIb2VUN0Rx?= =?utf-8?B?SEFWNGs5MVNxdHZUWlFXQnpZNEVhMExDSkRXLzQydUFqUTdIWVRWU3FrQ2hP?= =?utf-8?B?dTJYeTFUbjVEVnB6Q2wvSDNiYUdTMWY1Z2U4MXJNL3ZoNFA0bGs0NG1BY1Bv?= =?utf-8?B?QkZSMTNrbU01cDAzaER2aG16aGRSd3ZoN0VQSXFiNUQwSHI5N0xhUnBzYkhr?= =?utf-8?B?MVQrQnMxR0NEUEZLSXAzcmkyM3lHcUVrQ1llcTlsMXkvcUduWFpzeDFKanpY?= =?utf-8?B?NGljUGRHVFRTZDVxMEdTVGIxd2FUVDVzSEVGa0tzUXR0ckFpa0dFN2RzNnRo?= =?utf-8?B?TWUyNXRCbGFEeGMzVXFyK2tlcUFhdldXT2RNcS9JUWlkSGgyMDJobGsvV1cr?= =?utf-8?B?eGdIdm9IWXlLUERBU3NjdjNnUGI4UXl1M09tdDVFYXVzSXJKMlFqSHVtbS90?= =?utf-8?B?WW82TXQ0clhsMlBjZjRwTGxxSWtlREMwcG5pOXBIeHdNQkY1eFhDRFJMS2VU?= =?utf-8?B?c01OQ0tJbXR2MnMwQlRaVjZ6RU8zbVhJQllxR2pRMXA2MWhTMDlSODlPS29R?= =?utf-8?B?Qi80ZzUzUTZhbVpVTVRBbmV3dHV5a2hpUTdOQzg5Q2FXSitvME5iamhqQWRZ?= =?utf-8?B?b0M0ZnJCd2FmbG5iM1hlemR3WnRURHl1eHpoQitRQ01mNVN5dWp4blhYU0hy?= =?utf-8?B?MU5MMC9mamdRU1VKNFZqeW5GY21aQk1QTEVYR0UyaFBoMlNCRmU0Snlyak1o?= =?utf-8?B?MnhxaGJaaDRxQWh3bmUzN1RPOThZZTl5UUdxdDVSbUJYSW9OdnA4bGVhamFx?= =?utf-8?B?RXFvOFE4czFsZzZMNi92aCtXWGZiNkJBM3lrWWRLNFpza2RLOVF2aWk3RVRu?= =?utf-8?B?SENPNDdMZjlZMmx6emo2SnVacTZBSHVTT0ZLRk9XWWFxcTh4M2QwR0E1ZkR6?= =?utf-8?B?ZGJzVUdHREp4TXQvTUQyRm9HOHhDWDBCOWwydEQ4SUpLblU0WXg5ZGw2clla?= =?utf-8?B?OVdEQ3hrZWJZcXB6aVk0N0ZySHlIdFZzZzFQZ3U0dmFrNmNzUFhMZmJoQTQx?= =?utf-8?B?bEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 937288f5-7f6e-477e-7b29-08dc323c665d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 17:50:17.9462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E1yyCDwsWp99mQq1SAn1kR+FlxwdUSvJJDBkTQQbqlyTF/WnR92hjy68BW3QVidnTkdwcc0P1XXSZBewOSfQ5mNF7k84fd/i4bP+bpHiMlg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7863 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 09, 2024 at 02:44:04PM +0530, Jerin Jacob wrote: > On Fri, Feb 2, 2024 at 6:11 PM Bruce Richardson > wrote: > > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > For the fields in "rte_event" struct, enhance the comments on each to > > clarify the field's use, and whether it is preserved between enqueue and > > dequeue, and it's role, if any, in scheduling. > > > > Signed-off-by: Bruce Richardson > > --- > > V3: updates following review > > --- > > lib/eventdev/rte_eventdev.h | 161 +++++++++++++++++++++++++----------- > > 1 file changed, 111 insertions(+), 50 deletions(-) > > > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > > + * the scheduler is now allowed to schedule events from that flow from to another port. > > + * However, the atomic locks may be still held until the next rte_event_dequeue_burst() > > + * call; enqueuing an event with opt type @ref RTE_EVENT_OP_RELEASE allows, > > Is ";" intended? Yes, it was. :-) /Bruce