From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2853A43B61; Wed, 21 Feb 2024 11:28:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 954F94067E; Wed, 21 Feb 2024 11:28:48 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id 66F36402CE for ; Wed, 21 Feb 2024 11:28:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708511326; x=1740047326; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=0glMgNP+QoPhO3mis8XFyOU0nz/pl+y/n/BAth28Yng=; b=jPTl17ZK2R+o0wdPPgtKEsDJ5+JVGVF/sN1V1mK50+6jFDrarZ+V5GVt 5QTA+TDprxlxuUNF4bSKhEkfwNOXJ5i/qvoI34QGw4AA9trpJNVUnDin+ OObY52m1pmmj76HBf9iScXQTZuN2C4zEgANvhh6ta5VAxHJiffAjrFdRZ 8IJyhK2CmFYH1/sIIaGRELStperjGVSpi42l4wHN2/I8hKpCtJp+A0UvG 6G04y4rD1BhC4T+H4RXvkJumAef/cO+uMO62aVMt/rb0sgQtpICG4RhMu 5rwME/sVIMZc8DrFmpnMaKpS8CQ+uFcwBS7BVCfE+KtB3eaaXSMTj7bI9 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10990"; a="2531614" X-IronPort-AV: E=Sophos;i="6.06,175,1705392000"; d="scan'208";a="2531614" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 02:28:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,175,1705392000"; d="scan'208";a="5025223" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Feb 2024 02:28:45 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 21 Feb 2024 02:28:44 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 21 Feb 2024 02:28:44 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 21 Feb 2024 02:28:44 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 21 Feb 2024 02:28:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j0mSvjoLh21Rf8v6SFJi0wlWiyRmLrJ/S4ZRo3duNjLev0Pw8V0fvIevcnOEcub1a5wNmZFHz4vO74FNf22C6BO+MeHUQ22bNHRmHJVLp8g21p1Qson+YvVPfCO57nGWUFh9UEAxLku9oMiPn2NuivuX4b0QI5yGtTGxGNTtHM0i5p40EA75VdkBFsYhcIJEPShX1uvUeEFlepX4BZQABp18WnCTVL+eBJuuqstyNqxxpKkj2Dsm3GZgin/kwkbwRIM19d4ZNUBM4qjM7+F/9Io/qYXBBDhnUUZVt+Pv5dxk1GfO8XAAmHd5HX0KFDvHO4f//Ywhzx1gXGZSFbtwCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1NoSoIVOLQ73AEZ3tHutmsnVmYKnxHt0akbINWQL+Lg=; b=dLKbk8eDV05rq7pefmXJ7Bc0Kb4SnUP5vb3E5HyBHQHS+1WOPkdVElTMZSXk2FBFfvQZDHuUdmLVWyxghUDGv4yixY8kQbB1hlD0gfiDYMZACJGmOovM/Qtfr3ukr4PvV/tNgE+o8kxLpfavEZaSA2D2ky8PPmeaQd4msQ64ziOKkZKea+6JMM0RYbCUEfXQiE4NxPxa78D3+tpfH83T2Rta1+UQP5zg0Ar+4zBQad3P15un5uq93X5IUjeF8hyxorO//zx3TYjbsmFUG9RPcp8leLB0FmXuEfNrzeUn4EymY4hIpzu6U6XiCU2fjcvdBIwQUXPIqgGPGkSN1YKGuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB7345.namprd11.prod.outlook.com (2603:10b6:610:14a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.22; Wed, 21 Feb 2024 10:28:37 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7292.036; Wed, 21 Feb 2024 10:28:37 +0000 Date: Wed, 21 Feb 2024 10:28:31 +0000 From: Bruce Richardson To: Jerin Jacob CC: , , , , , , , Subject: Re: [PATCH v3 10/11] eventdev: clarify docs on event object fields and op types Message-ID: References: <20240119174346.108905-1-bruce.richardson@intel.com> <20240202123953.77166-1-bruce.richardson@intel.com> <20240202123953.77166-11-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB6PR0301CA0074.eurprd03.prod.outlook.com (2603:10a6:6:30::21) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB7345:EE_ X-MS-Office365-Filtering-Correlation-Id: 8610452b-0cdd-4ad0-7cbd-08dc32c7dd6a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AYzH5u6oIF20ULC75BVAlggQUcwsAg19HHOyyDyiFOCZcYkwufDZP7qJjXeGbgZGmdmtZe/sJkdceO7RLDph3MoNZXbhhdDFqLSkEOa6oVU41ozIOWwQuCl1yr1psEqq4W2pMhG6es7nmXUySxisPbL2j4EZctFeyaKslzUumS1lCBzQe9+W4zjqIsdaE8e/5zqAMzZ6qbwZX4iaIrOGCvYUURSfSeVJnQanxEW++NR3UsMQU5BhbK0EJAFMff7Ed9T7eSEuRHyEO4pqDAC1L3lQ31cxH5ZdlY0txVN5XzksG7YH4jbyy9NL0kYw5EpsfzwZ0TyMRSfJ0NI5fOpAzZx0B2e7kYYYnDxM8PW3hT4Sss8WfInSRUTTUm0etV5GEKMLz+96QZ2AgylruYJ7stfJ3AXe4fklD5BbCooks077SwJFCMGlyijU3PkplIXsv87n3srIUu81UF90nT8zoE2pmnEjzmC0/a0Boz8x4RT+kRLgaSLCodRL9iQEr8Jd1f8z06lg3StY8d+jy943ws0reCdxwgUpjTDF07DlAcg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmRWUFgyd01PbW1kNlZmaFJJeVpuMDhycExlbGZXNUtDZ01Kb3ZHaDV6TnlQ?= =?utf-8?B?UFV5Vmhjdlk2c0w2L09ycmM3U0pwcDUzVHJFdE9IcEx5Z3NiVlR3OCtyZXV3?= =?utf-8?B?a0tJMjY0NGtKNE1KNjNQWTZ0NkQrYm5vMlE2NWcwQTMxTDQwTmFzRDZLQVkz?= =?utf-8?B?ZTN3enIvVldhVzVER0JxaFlkekptWXYrcGkwbVNCZ3VmV09aSVVaMWV5TVc2?= =?utf-8?B?dWJkSlkyMWhXRUN0OU00dWhvL0pDemozNnZFNkRKa0Vxdml6MHg3WW16VnI1?= =?utf-8?B?eVdmaGU2RkhIZzZaR2k3b1VsNzJtMVoramtyUlNQUWpRbktnOXUrUEZzcERF?= =?utf-8?B?cXNsZDdPQWpXaFFZSjMzQVR4ODRYekI2MVBsb0x0T0tXY29nU3J5OFNEcVhR?= =?utf-8?B?M09zeVNkWG8vSmc4VVEwcmpsNzNPdkp0S0taOUN5RCtZcDNvZURoc1FlYzNF?= =?utf-8?B?N0dScFNLUmxRSElDV09neTVydEJHMkR5N1FqT1VWVlV4M01NRkQrcjZ1MEhI?= =?utf-8?B?b3VQVnc0QlM3MGhWTjlLVzhmS1RNYWgzVkoyd1RObmtxV1RSRVpGVytqb0Z5?= =?utf-8?B?V2d2a25tVURyR1dmR3hVS0ROOUFtbDVhakUwTnkwcFJ3djBjakYyT3dQcU51?= =?utf-8?B?NVJhdThQMUlHYTNqWHRQdFNURGNCTmFXbUdKcVZmeE5XVnc4aCtrTUZMaGU3?= =?utf-8?B?THZoNEd5YzluaGxhRUFYRTlCSjNiUmsvR3FnakxzbzdJckl1aHNmbjRkQUtN?= =?utf-8?B?UkdLQzVlQ29ZY2hmR2Nnc3NqSWJjUzltZlA5SXBjWG1KYnRCT2kxcXlPdmVh?= =?utf-8?B?WTlZd256c0tGbU1ZaTBVZktUQXI1eHdOR1hleU0wREZOWVd2MlBwdWpBdnFV?= =?utf-8?B?dzBIREVzU1VPZER1WWVBR0RwdGhER1FuZXp2Ym1nRlJpZ2E3RFRibGdmWnFR?= =?utf-8?B?WG5iVThZSk1nQUt4Kzg3eWs2d1dEYndyUVI5KysxbVY0Q1pqWnNOKzd6azVz?= =?utf-8?B?amtOdURwN2wyS0tWb3J1U1ZJWjBwZk1VbjdkWHNKSXh3S2xaRzNXT3VvRmwx?= =?utf-8?B?K2o4TVFtbUFCYmdRd2hNNWlEcjNPcytYWUpBWkV6UmhIdnVqVDdTYnNnQUZC?= =?utf-8?B?cTVoM253WDIwelYwV0orT00xOHV1UHo3MXZNTUxYcEsxbXdVa2V2RFhFODhv?= =?utf-8?B?aXp1NTVPNDFUelVITkUvWE1ySCt2UDJ1dUxaNDMyZzAwOWN4UlhmdnArTFpI?= =?utf-8?B?QmYyT1dwcUZLaXhHb2pLS0FRMlFYZGY3M0V6N1pRMmUyZS9wVXBJbHprV3pQ?= =?utf-8?B?azFkdktOSEdHQVJNdE1QbTN0NGRFZ0E3WEFYckUxSXFYK29Jb3phUHYyUDIz?= =?utf-8?B?SmlhNUo0eGtkUk5WMmJDZUdpRk5aL1RIRkZoNVlMSXdSVTVMc3NZaGozcXhh?= =?utf-8?B?NHV4eUFoZ1RraVREcElKbE1NTzVBQWl1NEREc0NLWGpaV0krUnZMelowMi9o?= =?utf-8?B?MFhiVFdlZFJNMGdBSCs5bGxxQXNTMnpTZUNYSzJnMlByMlZKdGZKVFpsYjE3?= =?utf-8?B?Zkt3ZWpSQUl1dHlBNkFJOGJ4N0l3OXN6RjZZUHRxVlgrOUIxMmZYZVF5TnM4?= =?utf-8?B?NnA0TGVpWE5Xd084QUNlbEZWVzV6ZkFLMFZYNlBqTmhILzdPNk92UVhiaElT?= =?utf-8?B?TWxGU01tYmdKSTViN1JnRUpsQVZORGhJb25aa1BWU3g0MVF0SWZaYmNROXdB?= =?utf-8?B?K0Z4emE5Vkx3WW5YZVBKNVQ0NWpMVk5zclEwODhPTGQvOXhSSFdqU1BKc2ds?= =?utf-8?B?bHVmQnROOVJ0TUNQZ1NUU1dzQ1NNNGNoTmJ5NDVOeENYclFtZVdpaTJxcFRK?= =?utf-8?B?OXVCc2thMjYzc3BrMXc3a2U0bzg4L1BKSWhXOExPMjlHSEdUdlNwRmlNTGFk?= =?utf-8?B?bkloRXpPT3ZSamowU2VUUmFuMlpQQWhTRkdTVjh0M2Q5SThaL0h0bkNhbHc3?= =?utf-8?B?ci9yZWdtRER3WXdoL3RaY0IyTXF5b051R2NpTlk3ZWVPSUVzV3JvYXFoNnBL?= =?utf-8?B?bEdaK05ldzR3cDJEdlVjcHNMdVhiNGQ3Y3R4N0FkV0FKMnR5SjUwaE5sWXVt?= =?utf-8?B?VXVsemhPYWNIa2tDN0RLVjVqc1FKUnNLMVlGajZoUUI5TDA1VmwvbzBMenMr?= =?utf-8?B?THc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8610452b-0cdd-4ad0-7cbd-08dc32c7dd6a X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 10:28:37.6293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 270Kzzt14ZAdUgVfNobM0ouWWzScL8mWjnQ3vY4ZwtJ6tiQ1NFRZs4p0MmGYejwYvPjfyYVFY4IpkS1m6j3PRGUHgr2rkUNZujeTeEv+lAA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7345 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 21, 2024 at 03:01:06PM +0530, Jerin Jacob wrote: > On Tue, Feb 20, 2024 at 11:09 PM Bruce Richardson > wrote: > > > > On Fri, Feb 09, 2024 at 02:44:04PM +0530, Jerin Jacob wrote: > > > On Fri, Feb 2, 2024 at 6:11 PM Bruce Richardson > > > wrote: > > > > > > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > > > For the fields in "rte_event" struct, enhance the comments on each to > > > > clarify the field's use, and whether it is preserved between enqueue and > > > > dequeue, and it's role, if any, in scheduling. > > > > > > > > Signed-off-by: Bruce Richardson > > > > --- > > > > uint32_t sub_event_type:8; > > > > /**< Sub-event types based on the event source. > > > > + * > > > > + * This field is preserved between enqueue and dequeue. > > > > + * This field is for application or event adapter use, > > > > + * and is not considered in scheduling decisions. > > > > > > > > > cnxk driver is considering this for scheduling decision to > > > differentiate the producer i.e event adapters. > > > If other drivers are not then we can change the language around it is > > > implementation defined. > > > > > How does the event type influence the scheduling decision? I can drop the > > For cnxk, From HW POV, the flow ID is 32 bit which is divided between > flow_id(20 bit), sub event type(8bit) and > event type(4bit) > > > last line here > > Yes. Please > > Dropping last sentence in v4.