From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9EEB43C89; Mon, 11 Mar 2024 16:23:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D96C4027C; Mon, 11 Mar 2024 16:23:52 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id 872704026B for ; Mon, 11 Mar 2024 16:23:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710170631; x=1741706631; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=QFwj/S1V9MmGCf0t1ZdJzXfHO+1iXF7OKr/TDS3vjzQ=; b=MF32sHo5B5BaHZCj6OvP94gICfxECWPhWfnp0eCfNumPWE1FAIeovXVY doy7hY+exethd6W0MhK996UFzYMuhN/wIMJOr+Jble+c/fonTsVBeJE9Q LDASQgk6xmyE7k9jUVs6smvN1jXWFaaTi1hNtnSn0O/93GtQ5EAZB/wVl 1CBJ4TO6tPyZOSJO6no7WFAfhnCeBVwXxhaF/CReIA5s9quk13EcJgai/ o2ouKKuao5P0wDcLARTaFIN4dGQsdzMrTNHd/VP96Gar6GG929J3VIX2H EK61Ms9kR5ld02G5KDjo1jT3jAwyQJ1/UR5PfmQGYFLH97ANtVVdtd3bh g==; X-IronPort-AV: E=McAfee;i="6600,9927,11010"; a="16278349" X-IronPort-AV: E=Sophos;i="6.07,117,1708416000"; d="scan'208";a="16278349" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 08:23:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,117,1708416000"; d="scan'208";a="48653821" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Mar 2024 08:23:50 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 11 Mar 2024 08:23:49 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 11 Mar 2024 08:23:49 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 11 Mar 2024 08:23:49 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 11 Mar 2024 08:23:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IkAFouFuq75fEd/IfBxBSGtxvilq1fta9iJm3u4+dadbntG46MlUtVsfl2BtKJ8wG/aM98F9vUMgESun5FlyetLrqjK7uARBVtIG7pp7tALqJiLJnTiAxBuoMxxVZ80lRrf4CTZGi9OYGUL3xjZKDnzDmuDs8lQZxzwga11+OYSemz+JL7cIJaoD3aoa5pLwq2HcAk7pLxb6Q7gSZpNbguihH2OIoXViEU9itGA9TyJ0VOQgp9ky8uSSJLuSeW+y6np5yAFLIMCpZC3qH6HC5+6vAEMIwp1OPiLlz32VEXvLeuYRqYpjJ2mVtXEDvu048/P4KDSOl7DPLbGrVzwoGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kQyGZIx5uxW4HDq7yWVTPLgUILYrDYmluQghcZ0JtKg=; b=aHS8uzOIsnJ3yaQnsryUoq0f5+ZyBNCyOn7pIwaZxaWS8jGBDibz4ysT1RkUbvJZMSHJ1wQJtHsUkDsaI4C6d2miAJXcFWVgI4gkJeHCwn/HqzGV+7omftEb09iXf3IdtrCsOORgnC659rfNIzZhZAdDr+mrMlxU/oEZ4oN3+Uv3NPuzT9/Tx+3h+CVM//EW5TZ2moE0l/I6OKIWQbZNYWd5XqaZT9kJAlRwwk2WPhmyTeoYdnGOppHoYywhj5T3ZbGfxoFLh18X4jU82oXFSYWnz8mSPpOixmhqFMKPQOgc6FEKwUbTiRbeAHcmq14fY3zEfF4e07an5Iu6UTgInQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB5036.namprd11.prod.outlook.com (2603:10b6:806:114::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.8; Mon, 11 Mar 2024 15:23:47 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7386.016; Mon, 11 Mar 2024 15:23:47 +0000 Date: Mon, 11 Mar 2024 15:23:43 +0000 From: Bruce Richardson To: Paul Szczepanek CC: , Honnappa Nagarahalli Subject: Re: [PATCH v9 1/5] lib: allow libraries with no sources Message-ID: References: <20230927150854.3670391-2-paul.szczepanek@arm.com> <20240311144706.204831-1-paul.szczepanek@arm.com> <20240311144706.204831-2-paul.szczepanek@arm.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240311144706.204831-2-paul.szczepanek@arm.com> X-ClientProxiedBy: DUZPR01CA0193.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b6::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB5036:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e8d08f7-90a4-4f0d-28b4-08dc41df3ed6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DT8Lz/l/y8dC4GaOD30/77urOJLQwCU9oFe2s8ehrLg1mKGlVnIQgnLH35MkTRGVeStHjFRlIqbA1DFvO4LGLNymlOMtJHQHOBZtSsRWximbjAdg0sOLwPOD3PeAW7M1BdZJil22jTtsMq7i0VeuNot/vpdDrujcvZRw9G+yGbYKFFoIG9sbd+vo+cUAsJ6sz0M4KLk/6e3j9YfmxyXHHoqTnSUoe13LB5rE0MuM5lGz9FsuPNbhJ5kjDOsATZPokfwN6blpmuUbkPI7YlkY9dOIgzSOJoKhTDmq4mIlxG3l9+2XSTTXUewLGiUU5w+Oq7R1cnVzIaP89Dhj95+WfkNB9QpJxLfIoXvdDSFUrPcekgw1pBTFzOLr9PUArFs3K1p2aDXdOb8/WpJpUknTW/P3nlrsoDc5Mudj8Im96yzJgZzMViU6J8XWyDD8hYsfEid+jeT1cy6PRpwR0gatJVP8epXP2ov6Eg0B9mZdPPRallVhX10/E4OFepnko4qyU8mDYJBfl3oYJrNdYK+E+HG4x+QkhgplxeeJe1mRybSDwijHVEwEKep01aGHTQWyPL36DgHw8OJ2ugCMXdSazgQ3w+/vUU2oVETU4owxGbmP30T98b18pOuAa2rLl5GfgEbH4peVLo7HZ/SxmIxNCo+Lw9FJKLCXc+MjlmR4zE0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qlU36ArgsLyjuMo5lc6lj1jHjtauoLSXeBWODb9Q+R/kEwInrBeW3ooCP6ud?= =?us-ascii?Q?wzVJohJiyhYh/JchYgDSbi9bQ19Wae6ce2sH7xgTDdnp55z/0FMPutYQAA1L?= =?us-ascii?Q?J4I7zy1AShJSB5G/rXFd1P0byFsDrHiYFG5QxGZLUDtH0kYZye00zz7jk8kx?= =?us-ascii?Q?M9PhE5bLYXrdO2fFjRGhwqKCutoFd8L78pqpRSTQpucfss5RTSaIjUf1Eu7u?= =?us-ascii?Q?Ps+tX2UVYypw1K3p+WxSgVYObqds5uYa66J0a0DGgbRPOyKOh5aELg5zzgAG?= =?us-ascii?Q?O9meTC+LsbUw5fN07cyjDT+OQNR8BJ+U27aHuKmwvZFT+SdBYrbpu3mE/Qm8?= =?us-ascii?Q?Irowiu3ECc5Bl/wKMBgntK0LXCsnnSz//LuvJfsaQZorTQToB5a/gyDggAe8?= =?us-ascii?Q?WxXQn08mPY2PuKHB6HhVhyOsxMeNuFoZPzMtP3N+7+7FtgTyyIzoI0uE/6Kd?= =?us-ascii?Q?85rxiF0sys8FLhWHZiwzv//iH/KvwPoKy6vYRJVk900kB+wxqPLybXu19lGv?= =?us-ascii?Q?JdPHZu7/qek/FrW/Rr8VLfsiTefOWBzIcXbWW8CeV0p0Cq1EExpFtCUXnmNV?= =?us-ascii?Q?dWIQHBItAj2AvgyXP7Ljwf4NGE8bbCcGDXROq+xuH+nUQvgd/IF5oTV/JS1H?= =?us-ascii?Q?fc8kpdd90+M818Vva45GCPigNbXRsOf336yCmRaJWtyeHQZFljxQVU0juZJv?= =?us-ascii?Q?n3QgjZLBygIjoMGT/acaHoVxIol2ae12vR81ArNf+x6hruIXsF5Y6ak8Vn2+?= =?us-ascii?Q?KXMtqXwbxauFxWN0ndmdZWfXZ1mh4dr8vKu1fHLvDXpzipExvyxE/iln4qiR?= =?us-ascii?Q?kvvKbjsQtIwjuLobyn5+F0I+lpQXJ/HEItpYuPXiv1qhNnKjoQCQYIe0EJQV?= =?us-ascii?Q?Vry3KmixGR0ApmDCn0iSCD451uvRQzk+wccGlC0Yw8LCelC3/FGENAZnjBot?= =?us-ascii?Q?CwUJ9sRd+kA+ZpOkDB3A8edzW4Ve+u5E3/j4oLfrCLb6yp/Puk6WNdw20aFo?= =?us-ascii?Q?rkrYmbWvQ/4H3w+XKGwkXPovQwXnIJqapc0Sn7tPTK/XCDbXjEyQPYacSVJs?= =?us-ascii?Q?amTY8NHFn6vkR7oCX4ttvD1PMUi5CMrIcQYDKS1KWI6N6f+KEc6+yIIW7U8q?= =?us-ascii?Q?tRYQ05+UV3GXYqorCUjuq2r3FWlfj0m9I0bbHNsHLZNr3xehrspdkHgCFD68?= =?us-ascii?Q?wWN9BsMrnjkevBwgOAkPysaGfAFJVl9sbQRLo+QvvilQyogWXEWZzzs6G0OI?= =?us-ascii?Q?jsupWHX4+1gePRMXdYtFhGX0w48LiMl7FO5AP2cLdnUiSFUAErxKAQc5P/PD?= =?us-ascii?Q?sCuZTXLqf4eP9BgooNn4N7wXnJ2UfYiwd8ppVWz/fynOcQiZcaYwccR973IJ?= =?us-ascii?Q?rflbQhzrcK10YwP/SJj7u6pf9evsVBGs2Q810Z1JbOnwaL3abVB4g/7TCh5c?= =?us-ascii?Q?XE1jQSadL09A/1jSwJNHlHiVOQXHVRLLQKkeHGnJZZkQOceh5bPNs6egnPVW?= =?us-ascii?Q?rxB8eM8poOOg15VBkf2x4nI0sJ0EFRJ9UTE0vea1MuCwAC8wgHaurfhUelUF?= =?us-ascii?Q?JHvFBv9khhYhYkS7uszGJRx8xnA6azVlCN0ree4KqdAfjdCNM0YDqQb9hL/F?= =?us-ascii?Q?qQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3e8d08f7-90a4-4f0d-28b4-08dc41df3ed6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 15:23:46.9837 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XapMOtdjir46w/jdvi7f9RF/Rx9XqtGU48LF73vLWVYKKZLypRx4PoRX0WNUaw2E3536+jm8Tk3FU+uzR9P9RL1X/VKSuRsBycE32vjYkNc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5036 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 11, 2024 at 02:47:02PM +0000, Paul Szczepanek wrote: > Allow header only libraries. > > Signed-off-by: Paul Szczepanek > Reviewed-by: Honnappa Nagarahalli > --- > lib/meson.build | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/lib/meson.build b/lib/meson.build > index 179a272932..e4e31f7ecf 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -222,6 +222,20 @@ foreach l:libraries > includes += include_directories(l) > dpdk_includes += include_directories(l) > > + # special case for header only libraries > + if sources.length() == 0 > + header_lib_dep = declare_dependency(include_directories: includes, > + dependencies: shared_deps) > + set_variable('shared_rte_' + name, header_lib_dep) > + set_variable('static_rte_' + name, header_lib_dep) > + dpdk_shared_lib_deps += header_lib_dep > + dpdk_static_lib_deps += header_lib_dep > + if developer_mode > + message('lib/@0@: Defining dependency "@1@"'.format(l, name)) > + endif > + continue > + endif > + > if developer_mode and is_windows and use_function_versioning > message('@0@: Function versioning is not supported by Windows.'.format(name)) > endif Diff is much clearer this way, thanks. Acked-by: Bruce Richardson