From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E916D43C35; Thu, 29 Feb 2024 12:54:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3C81402AF; Thu, 29 Feb 2024 12:54:42 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mails.dpdk.org (Postfix) with ESMTP id 7A131402AF; Thu, 29 Feb 2024 12:54:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709207682; x=1740743682; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=cf7c+YcsdU/biPJsuZMTGjF0K771Xf47YzSMFlZ67ME=; b=EK6XkljVgrxvRMRTTBAmlGtxUjJH9g15sMyJj3AJGNRuuTHEYJdTVFOv y8/ZwPVNzP5Gc01m5e9MjN7/aOsB2aTUYbb036JrFx5YrSxeDdCmCcR0u kxgCJLzu8bUUyaAJhMQh2IpGak9pAysRBFbvQS3UjsCwmnyjxW/AeOTxr A+BIahuNOikZYOVJHcKIPPJaxnsA9Xtmbjh2rWcfXzklDsoX7nEqetUqL OekSnjmYsi/cucxasv1/K6QiF8s/500QlzmN9g0zoH72wqOVbJBG+Eed0 KH80o42nGoDIEl9fH8E0NZiulybCt3hz2BB9L9Ancn7brqsPKZU7HbgkN A==; X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="7492939" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="7492939" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 03:54:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="45319632" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Feb 2024 03:54:40 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 03:54:40 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 03:54:39 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 29 Feb 2024 03:54:39 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 29 Feb 2024 03:54:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZnX4sF+IAOguAiqVV/MGEVT296PkXqfmDk3Ka7nJ5VsSQoHoYbXmishzQQZzz8CPndQ8k92ORuugVCMN6yNh4AJ40aG3uiEeZdpoIOsFM3vZOW1NrTDG2bcqKnFGhQoAz88S/0mpnDfe9tvp9atb2ySbMnc3FCb95bA4ygmkBgwoXUuCdEUUp+JKyHDmgeJoPNFvDY7xKxdiwuqTXztPJRKBOW0EHNmk/46eMvpKxdnz19IdpnBDjI9SS1Enmq7X4heVU+cGsVH94E0vDLYZE8ftJVB1wyI4HdMx6qeRx/Zgimh4memd0kxFv7CIvRmG0L1tovTZ/PILjFaowaydzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5sx/Dn7sPGN31UxduJwsB56gazj9fhurMXaeYqWhVN8=; b=jc2nfCTi1VgEaLlh9axu/N1lZlE6jo13uIX5wBn6cop+U5mSc7AFfia1prnF4FXBLqYHMGXQLg2n2+YcwzcL69ewN3OgXHMLFhIvo153rgAbDbsdGvk9JW62Xh5R0+EpHEDGAJ5vJpsFohz8oLOincQYG7B9kWxTMgN6W+17fZPC4TBPgSWEKE9H2V9lNKON1eoDHlIdHjCI1L4CJwc8F+EUaYPj9Hhi2GL75nH8s8XiZGRf+CT1Yr3jrze9G8rRijw/zWBWPt3UDXAmrkxWfXP0b5kd+j9JlJOAg380yfSR8AEEnosJJubx7yS0HnqwVIkDHRZfINyz+zjz6EchXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB7398.namprd11.prod.outlook.com (2603:10b6:8:102::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.12; Thu, 29 Feb 2024 11:54:36 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7339.024; Thu, 29 Feb 2024 11:54:36 +0000 Date: Thu, 29 Feb 2024 11:54:31 +0000 From: Bruce Richardson To: David Marchand CC: , , Jingjing Wu , Qiming Yang , Qi Zhang , "Haiyue Wang" Subject: Re: [PATCH v2] net/iavf: remove error logs for vlan offloading Message-ID: References: <20240206095607.339410-1-david.marchand@redhat.com> <20240206103420.341328-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240206103420.341328-1-david.marchand@redhat.com> X-ClientProxiedBy: DB7PR03CA0102.eurprd03.prod.outlook.com (2603:10a6:10:72::43) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB7398:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e345459-98df-4b83-d48c-08dc391d33a1 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8HjG0j1cEzT5RsHv+E6MMFdO0oOXWidiDuoPXqOQTglCFmpEeZJXT1f+ZT3Il942FxzgcuvEgPkBqkKNJoyl/m6iYMvb/fGLhrifTjO68ZpX6v9TVzIdmZldPmQhiaOqvMaj+cTe60Xy2/3gswSIUfII2LANgsNybEOsXMy63BI6T/KqpFnuIbsi1MLYwQ3iSscePo8qwzCa/n5yhgtXtlmO33itH2XmJwY5n61bLsHglJtCba0Pce2wqv2KrT+ItmJhPIi91YwHkb9lIkWKI2royRiplVaP9pTxd+vKBh/ZDiELnLQbAfV7z9oHqITd8g3gDRsAkP+2kRhBtHf3tg56DM35DNZFv19+hRY6Oq1PBKfzYfuGpNdSpMqJ5Iw/CcFS/TGqf3XDaRhorP2njwZGHMjy06tEg0++ULdS7yHRQlCM0Vu8nD/p1eZcHK4yV6xzO/L8YeRJ9Lr1jY9PaxrP1ooEA5upt/tHeHoc4pEVjt1Th7dtp2TNbpW3pbKsHDcu67O6/3pAf+29bIOszVSYkWWnnnOmiO3V2UpHAAkk4ZbKX2Qarb8QFkhIvKlrQVpY92ELOZzVrE/dvT403w967vCqe+DALUxHvYa1ugREvNcjCSz1mn1amsXKtwYb X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?G/719LvZvtQGCnp4dYQDf+1GkDI7hju0EnaTC14HtBy3On6XDIyfZxfCiaWd?= =?us-ascii?Q?Wm/da7lrP3qqFNgfoax720SJkZEn3ucAabO/VwwZNtSDQG2OdXfZcITAMCf9?= =?us-ascii?Q?TlrXnrK+RjyTXfLlCsixWzV3kOKxB9/IG67bfRIi+flUkVa23ZLvwOIPLrH+?= =?us-ascii?Q?xuncsckgB2LEYi1d14hoFJ2Xi2s8luqE/HtdwpHWLxdIhpw4BYiE/spyOlou?= =?us-ascii?Q?SjhsILx9B1vyxuOUo+/GDrWY7yRKBES37o5rNwbrTwsWSJUxIN4gkAJ1H9Vr?= =?us-ascii?Q?vNC9OiwEShXmLGI8BoOHslZ0XfPTaiCpNYc1+rauXrGH1st6vJQuZXIJNDwf?= =?us-ascii?Q?c4zyCijWAkzvn5lCbfhwIquXcSntOjvQBuyvsKBGunx+txtMEYu3lCozftmG?= =?us-ascii?Q?fg7UNMHYTUIaQK0aqg8hwmhnKCjwj5agdodwWOdrwvtE/8DAvRrdAu8YZ0dc?= =?us-ascii?Q?pQ43SDedXVGE+x3wjDTXx/mnfdgKKuM3R2/kMosFCZ7DoS532yvaPGjD0G8t?= =?us-ascii?Q?TjiOYc+Zpxm9lZ7u7VsEWOTwG3TqcKrP3buzGVcC63ZNI1IbbW/mAzHnq/kb?= =?us-ascii?Q?vblSmBwnIpqGjb6+1QzqFJdSlHU5pZfqPGx+pGpQi1KfTU19hEalvGhftljr?= =?us-ascii?Q?sfFaEmXmctiWDJyjybDr4saSbLGhhfrj+U9cztYLoCY6GUUvoDRpq/JzD8SG?= =?us-ascii?Q?4Mf591eAQRBeqNvW0Ns6EpH6hxgbUJtlpiUg8CzQmXO56dyw9m3OaS2ko16+?= =?us-ascii?Q?pZYJt2e7HidFwFJuB0I+KC4AHH4gaQgRW5MEr8F2nfBpfG4X86EAKNL4p0Aw?= =?us-ascii?Q?aBtEycDpTFByxJapt0KE3uKPw7rJsHyW/WhZlr0mGqmAOFhPXrj5C2pys9YL?= =?us-ascii?Q?n+fYs6iILFttPvQpZwi6Z1jL19dtojc+j3pboSbJ2R/kcBQWuAg+l5LN9cB4?= =?us-ascii?Q?PpWEWCi1w8QQQxEGKcbzK1TudDhwqVMURmuXkJIofcXg/PyTCK5yTwYQZF8Q?= =?us-ascii?Q?H+X2erG9DOEy/efK0oOpS7c61yQWZd09dHh33F6a0ncgIIbWk8kSgOkGWh+C?= =?us-ascii?Q?NLaqSg8HL6StyI/2I+u+fVpINFt5cspkxDEQjztCm5dW0zTNYWM8wYbcOmJY?= =?us-ascii?Q?alhUcaLGCmK5/j/xt00ltJ72r8scpSYfAuBXuaQIYeAqYt92GhhXgwjGiA63?= =?us-ascii?Q?0JJ9efr3qS46TUaTCTaey3Vp2G5AtgbYMUNvMrheKoQOvGg8Y4Q7kHFyNJji?= =?us-ascii?Q?T14kjim8SsoK76pBaMZPyrPrY3LXhlrGr0Mpm4b/fCWtSsGFwQFgkRhUqoCi?= =?us-ascii?Q?dBkNragJIQfi7WExICrm6tbv2F6cHEywuyiv4QTm+E7+NjnO1TWgn4EV9usn?= =?us-ascii?Q?q0/88jUjHROSNjdplvoAAEvFOJqPeEr6rXJT1Dl0rOB6r3wG2rjcSZ5ttqK0?= =?us-ascii?Q?dspkUdgfOl20Esu9588sYFsiPLcHtf5ftjJIlguwcFHbObmqoIx3FHu1NEJe?= =?us-ascii?Q?5Ky1FQSRx2Gzsccb9B1hzNR7cMO2HcccoEIh2TWViWoZ5HLF1dAFikeE41Ki?= =?us-ascii?Q?EC4NdsjpTA9G/40s003Vl3BSPJk0GVIL0uBHZbsWvLN8HS6v8tHFTz9bCEdx?= =?us-ascii?Q?SA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7e345459-98df-4b83-d48c-08dc391d33a1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 11:54:36.4953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ES6VXB1hewH4WjsfmpA6uPmINLMj27T2R/kH/jiyPJOcfxhUERzwFaibYSWqGdCV3fvWTA/jQrqYu3Wtka+nb6k6f9JSFTGFpKqZNH/WDFk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7398 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 06, 2024 at 11:34:20AM +0100, David Marchand wrote: > This was reported by RH QE. > > When a vlan is enforced on a VF via an administrative configuration on > the PF side, the net/iavf driver logs two error messages. > Those error messages have no consequence on the rest of the port > initialisation and packet processing works fine. > > [root@toto ~] # ip l set enp94s0 vf 0 vlan 2 > [root@toto ~] # dpdk-testpmd -a 0000:5e:02.0 -- -i > ... > Configuring Port 0 (socket 0) > iavf_dev_init_vlan(): Failed to update vlan offload > iavf_dev_configure(): configure VLAN failed: -95 > iavf_set_rx_function(): request RXDID[1] in Queue[0] is legacy, set > rx_pkt_burst as legacy for all queues > > The first change is to remove the error log in iavf_dev_init_vlan(). > This log is unneeded since all error path are covered by a dedicated log > message already. > > Then, in iavf_dev_init_vlan(), requesting all possible VLAN offloading > must not trigger an ERROR level log message. This is simply confusing, > as the application may not have requested such vlan offloading. > The reason why the driver requests all offloading is unclear so keep it > as is. Instead, rephrase the log message and lower its level to INFO. > > Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > Acked-by: Bruce Richardson > --- Applied to dpdk-next-net-intel Thanks, /Bruce