From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FEF943C3D; Thu, 29 Feb 2024 18:09:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70CD242F5D; Thu, 29 Feb 2024 18:09:59 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 0672E42E2A for ; Thu, 29 Feb 2024 18:09:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709226599; x=1740762599; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=KohUgZGiLCczlN8WultEgc89fYUa4aUu0DJbK1Xfpd4=; b=Gk/KqRTesepa72G4lAZdzZ+UJ3XIgaJ0ArCY9YFryYXhA5PfY8F9B1P+ 3keQMSZzaUaz3lr/CmYgxnHiVNrTFc4CsEO5CK+FMIkRiKanwTPJB6M9q +LRsD3Np1aKwJzBczkOBX2pm8wd2aPBwDEEYVsuAGwqexiD1s5xbfnhal IsrImrGFlzWpkQKt7fXz+uQwcsmcEbaddrgwg5ZnAXNOStJg9KRjLJY6M L7aPSGc5wNjWUjKseknpVOA/Y1x1Z8ml8G0fvAh+e7Ll/iQg9QMDezge0 76v4liZ5v0cHBqlT9kBp2bnShvyRzBuHf+ukFDGoXYe+giqeRXkJbq8OG Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="26176950" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="26176950" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 09:09:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="8137192" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Feb 2024 09:09:57 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 09:09:56 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 09:09:56 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 29 Feb 2024 09:09:56 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 29 Feb 2024 09:09:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EIVwdG9pckNm6y/M9vyKygDddgCESVoYsQujkZTnr97lTWSxnaxirietcnp0krBD0VSa2b/ZbEreYrz6RagihEG94ZnecKhiInRtJkRf7YhN8QcW4ARqCtXY4bGX18K6dGeMCDEcCToUb+HdBXJYhLA2kWarEb2kTQ3N/uZAQJemVZq8qmQbO+HhYjbot4uXLZ4S0v89VysOuiFTPY9w9D/rPOLYYEMoo1Mf6SSP+xKUgvpxr6e2VS3evd6K78zvHga5lrWS/ymGWhXxEdzNVPotDo65qp3/yhLM5wV6guJlTLy0HhSW5/UevjIMjl6c/kDjsv4wQNz0ukGHCRhf0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vj0SfZ2l9vWEQy+LZrEv5gGTB8CSrkW46C3Ws3m+62k=; b=hJGc+KgrPGKKxdYh1OGneIhcm0oOI6tXa84L1usvWQg6qrxZcHcIdQkFW6VB0GiX17nLsf5nN2S0Ai3XM+F7esBuo4q/Aqf8j1KvYsxV6T6Vo4+V5ZFAwLUBgci6qN5KdsEqYhnFsnXzSId1PR0dQlVyHtIQ469X3/iSPddtkFHV+4bcyLBq9GACNNVqjYekcHID6AfL7JR+fWGFwz9QraUVltzY7kN/Pwkh7o0vqL8Pdj6N6NVj0ptfrJ0eZxmQMoF2C+d3p+rUKPfpT+rkpaNC8V1ylY6GM6s5GS4qfCbdxSeIlgaWlt+ApbGgVhFcZzbMjlS7mzl1i2vNVvm73Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB5861.namprd11.prod.outlook.com (2603:10b6:510:133::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.12; Thu, 29 Feb 2024 17:09:53 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7339.024; Thu, 29 Feb 2024 17:09:53 +0000 Date: Thu, 29 Feb 2024 17:09:48 +0000 From: Bruce Richardson To: "Medvedkin, Vladimir" CC: , , Subject: Re: [PATCH] common/idpf: refine get packet type Message-ID: References: <20231222165128.2899806-1-beilei.xing@intel.com> <1b6b8467-d770-4ac5-a4f7-7f7037766b14@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1b6b8467-d770-4ac5-a4f7-7f7037766b14@intel.com> X-ClientProxiedBy: DUZPR01CA0295.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::11) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB5861:EE_ X-MS-Office365-Filtering-Correlation-Id: 165c8fd4-24b0-4a03-a53e-08dc39493f15 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YH2P8JI1Lq8t3b1BID+zJxgRSCjhstoFe4cudtz69fywnCUICPOBF9C26tkC13KTTcZpQO7atEETIEq2Al0MyHDJufOMYL8WsWa/zHwEUAFY40FH72sggEQ4MiBz1yjmKjW7KJ9wDnauojRv8KmJ+Vc00OpNDamIyRdMp4S7tFfZr3hlDlcNzom68IPcsUpU5/O1TxweWlbM5kzVuz3Q9EjVgwAhL2P8BaO6hE1RPPJC6etwxX44qf89bFxO7LcJMGrYvDxBzdWMq2D7mxSsSvFCPi6hVpsInV73nx4iwd3qI+SSc93MuCPG7Z6StZA/HxZv+jpk6oI4F9uHRiEuFK5KhvsmUw7iilWa8F1BChdmIDEdlziO4lwsLvW+woGk0g9XTXpxeevrHpNahxsuucJr00K+JLKnA1uzltM80m11/DFiPsRAovQjhYmAgLEym5DYVyGCILN8O3SLnORXxIqNuGWfC2RtMLucWsdBRC/P6SHT16lJjU9dNoTUbaWjvk72I5+74uLgbvRVnNL/jsVeSmfYcnp/msmWhlCN2+S/aptXB9/YZ3HXTh0fA7dq1sQafVN0t/YAHIP8214eWjIhcGfsNBw32+F8EXfZGJF70e+1iBVUlqFLMfycnm6h4QT3xwiy/Q8tBhiNl7c1LQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iHnAIFS29pK5qaA+RGUEVyIXejNaRp+Z0E6Y3MCuAExEE6SUwIBiyZoM12O5?= =?us-ascii?Q?0CpYemYm1O+F7W50uzFNcu1Yveh6EQFAdqrZ9qo6lE/Y95+EHbZu2nUzGhFz?= =?us-ascii?Q?3XnqoEQT25i1lP+W0kGrbfoSTt/qCZALmY54Zb/yI5LLJRZS2IBSDFPJ+rgp?= =?us-ascii?Q?uY/6K2MC5YwkceP1/SBnMGDUaLe3p+FQh73u+fCFrOla6GE3/EMS1fHqyoPD?= =?us-ascii?Q?8NyKxd+kMl/Y5ZYroDGwoZ2qrCxstQayqVW9dbNCJZZr7p3/F0zU/sDIB8CQ?= =?us-ascii?Q?jT+okds22bKNi+NA9qb5GORb5Axu6u/AfM7zQj70h1VlQx1GlihxJXMtbHz9?= =?us-ascii?Q?RDx/esvVXl6ZUQStUcWPx3fkpGsuGfItczUYmMggjddssIuCYxdb/sxM8kBB?= =?us-ascii?Q?hTk+W9/TFx6Tk50ZyXJTpRKAqI7BCDtfKHmKI34I3jCgmkmewuMdKK6r4DUG?= =?us-ascii?Q?Z7DwywskpKTF+nLkg8FGhdPIx1rP1VpJxYTCbsuF5uflRJ/vjJoczw+PSlQD?= =?us-ascii?Q?tZmqUMCSnNPHk6QJHGmbdw1EKB4iIVvZJiAadtcAuSVlDFPsWZAqvLkJk67D?= =?us-ascii?Q?dKBK4mkGepaNzcluy2DTdSexxkWfZVCN30TzHEBUtMJFz4KTt3rtqTwuY8Lv?= =?us-ascii?Q?3eQAa6wTzv1pIN30HO8RjILE7NXUox54NyPgpvBmj6peSclQQt6HNGbnMG3M?= =?us-ascii?Q?r1vg4OLCR87Wyqw2tjiB31LzlcU27qvXM2VgDH2N4i/n0Yqh/qpflpWEJqrJ?= =?us-ascii?Q?o4rp1DnG3au//0bHTyawVHQF5T8jbqd9VPjSlFyhzBDb0LefOS3EodactI1T?= =?us-ascii?Q?mFlctAqt4Z6eomN8B27U/Zst2HzvpNTxFWPEH3+loC67d7Tz96wWGtS4qD/n?= =?us-ascii?Q?6yM7rThzsvN5rybXbGOcXOk5waEO4om4zIJKYPWNfDuZvzuvU4D2vKybOjza?= =?us-ascii?Q?DApuCxDX10JKwkie7jb662lMFFVGVGgkvblpYDe7yGRqM8cbTHzuth7ainnm?= =?us-ascii?Q?9OZKpgl9GGkzq5qI3X2m1Uz4GmtYplYMJGOHj7LxQwxmjw1SVYbLS0qCdE9z?= =?us-ascii?Q?0JoipYwjs6Ek5VRaj1olwaP/K6UviEHXv4K54AAeZ7ifr0el057VKTDFNwmI?= =?us-ascii?Q?jBxh2eEzOsw9xSDlzuUUf9sZEFyl7F0dJ/lkvlJphCEVraY+IeyU1Bo7UlGO?= =?us-ascii?Q?D8f2RpJdFCJyhj5Af0Nb7tZuUKLX4Rmt7beIHK+MOIpS2NqWm80DYYCn8Io/?= =?us-ascii?Q?1hNK1Jfn8teexNsFPcv/joBHu7aIPrprLGDP0nbZd0O2cTN1ZeJvQi2+u1Rm?= =?us-ascii?Q?M3bF80OzTFcS/qSnoV+60Bv+smhvlxYvTUu81DNbn8miSzNUZTfQHDfhg/v3?= =?us-ascii?Q?zho3tuSzu1dDfdFPwaIJKLDd2KNGLR5mnPJKhLysvAWAQnchtLXeqTSyqW/s?= =?us-ascii?Q?TRu6Z+XVIBSf+XeIZwWFADqO6ebW3W+Qf8xSWcV6hmKNrQJjpb0EshsNgTfC?= =?us-ascii?Q?ZW5g0xmBmiQ98f1FXkhAPuprqJn/PqJvZGBxHAWgyxLcx5JejA+Q7CJFfn1j?= =?us-ascii?Q?c30GKD8mAZLvOjGJRkyH9RomWxFw65gdlTe+slGFTMATahNaHaRrQEBMCLML?= =?us-ascii?Q?KA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 165c8fd4-24b0-4a03-a53e-08dc39493f15 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 17:09:53.5105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FL+KOvujYqmo8lvRFwwn+XxcECSHKK4yyikCS17YP6OxXbKSizvClV4Ja1A5dMyKo0Zc+5YduwkVo1+ZSHi6GRxaRVgP/rSsomDUBkoZztY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5861 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 27, 2024 at 07:35:37PM +0000, Medvedkin, Vladimir wrote: > Hi Beilei, > > Just a one nit below, besides that LGTM > > Acked-by: Vladimir Medvedkin > > On 22/12/2023 16:51, beilei.xing@intel.com wrote: > > From: Beilei Xing > > > > Since the response of virtual channel virtchnl2_get_ptype_info is > > changed on IMC side, driver needs to be updated when requiring > > the virtual channel. > > > > Signed-off-by: Beilei Xing > > --- Applied to next-net-intel, with changes suggested by Vladimir, and some rewording of commit message. Thanks, /Bruce