From: Bruce Richardson <bruce.richardson@intel.com>
To: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Cc: Kevin Traynor <ktraynor@redhat.com>, <dev@dpdk.org>,
Qiming Yang <qiming.yang@intel.com>,
Wenjun Wu <wenjun1.wu@intel.com>
Subject: Re: [PATCH] net/ixgbe: increase vf reset timeout
Date: Thu, 29 Feb 2024 14:43:36 +0000 [thread overview]
Message-ID: <ZeCYGIn9Hv-gLxUX@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <492b36e4-8f60-45b2-a8c6-1bbca9f6901c@intel.com>
On Tue, Feb 27, 2024 at 12:35:28PM +0000, Medvedkin, Vladimir wrote:
> On 30/01/2024 10:00, Kevin Traynor wrote:
> > When vf issues a reset to pf there is a 50 msec wait plus an additional
> > max of 1 msec for the pf to indicate the reset is complete before
> > timeout.
> >
> > In some cases, it is seen that the reset is timing out, in which case
> > the reset does not complete and an error is returned.
> >
> > In order to account for this, continue to wait an initial 50 msecs,
> > but then allow a max of an additional 50 msecs for the command to
> > complete.
> >
> > Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
> >
> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> > ---
> > drivers/net/ixgbe/base/ixgbe_type.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/drivers/net/ixgbe/base/ixgbe_type.h
> > index 1094df5891..35212a561b 100644
> > --- a/drivers/net/ixgbe/base/ixgbe_type.h
> > +++ b/drivers/net/ixgbe/base/ixgbe_type.h
> > @@ -1801,5 +1801,5 @@ enum {
> > #define IXGBE_VFRE_ENABLE_ALL 0xFFFFFFFF
> > -#define IXGBE_VF_INIT_TIMEOUT 200 /* Number of retries to clear RSTI */
> > +#define IXGBE_VF_INIT_TIMEOUT 10000 /* Number of retries to clear RSTI */
> > /* RDHMPN and TDHMPN bitmasks */
>
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>
This changes the code in the "base" directory, which is not ideal, but I
see no other way to fix the issue reported.
Applied to dpdk-next-net-intel.
Thanks,
/Bruce
prev parent reply other threads:[~2024-02-29 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 10:00 Kevin Traynor
2024-02-27 10:56 ` Kevin Traynor
2024-02-27 12:35 ` Medvedkin, Vladimir
2024-02-29 14:43 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeCYGIn9Hv-gLxUX@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=qiming.yang@intel.com \
--cc=vladimir.medvedkin@intel.com \
--cc=wenjun1.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).