From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E4CC43C3B; Thu, 29 Feb 2024 15:43:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAF6D402CD; Thu, 29 Feb 2024 15:43:47 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 93EC54025C for ; Thu, 29 Feb 2024 15:43:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709217827; x=1740753827; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=GA/naA+AqGjXQ1bzpEj57oI2aaoFYTwCJP9jNd6Qtcg=; b=AXlzyNNS7pLlRiObstDRikzBlj/dqiyvkUlpaWUfeGkq1haA5IsW3qQa Z9B4Qx2mB+nIc2JZAU8Gs7+LzvqSeZuqEImJhk5Bna5n2T/TI3zDnMlR9 DGlSDctPy454ZkM6vaVXJW99gieD/fg0ZX1Uov71GY3zg8ouxXqq7GJzY 9DR3wE3dTyHNaNKVp2+9BZAQz8gaRt2YEJu2KBTzwFWSuEWbOmXinfQbm +yrhZ3OKtAiyozMQPqZfHCrEqpoDywmMWqctTZ1C+vvZlRA1nAMTM9bV8 YKAxzvvFVpX0kmRTiqlKLrDqR4vu84RDll2vmljXYmuW18b84GJXe60f5 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="7519245" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="7519245" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 06:43:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="12405577" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Feb 2024 06:43:45 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 06:43:44 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 06:43:44 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 29 Feb 2024 06:43:44 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 29 Feb 2024 06:43:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VE0u6VZ/L9akP5ccqZCaCfIuNzesJ9a6pAWEPO6zjCnCgz+t/YxHyjfgiH50GnP0tPW8Je/WMufB5HyLZ5zZ6T6X/yndoMwGrV4EOAtgTO85NU71qOKu+rxlNOih1/h6gOS3rCLEy/ETrt1GMviidE/iXico4nFi/IVF6l0rAXa0NLzC6qT6WH3rjzKWc+GYo9lSVNTa8oBY5vsu0G4Lc5SVTfD+JLl/Owuw2qKx41yvwD3FdZz2EHBjO0QacB/IttzJ7+K7k0BvUMzpUB1UtMal9WOFYYn5N+4OqeaFWEHL4KAo2I6/pW7lI/0fAxDfuicjnD/PVfFwYxqSLZ0Y4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yBCIP6hDaRcMtRIXJEpmYFhdlTAQ3ShK2DoU5YygTqI=; b=Nc41guPC/8GjKgl9ykbTNTvfsLcKl0ZiKPzow2Ku/UT91DQRwzdlAb6JNBx8yb0Hvm9J4IVOu3lIuEND19YoXqNzJSZfJvtPQyHwR5Vrg/MBIikWcQEOOvHcU0mvFWPIZ/AlVeXEX2CM1kJhI09DcA+cVjCF7RAcF0swLIsVWHj3u4rh4+rP+c75HzBo1hX1euD04xtY83yK7Z8sMQnNwP0YEBzgzl/jnJZNVVYmeg5nXldYRL4hYMosRb7dg5BvViU2xSW7uSynGKDP3qIt2GaBFvm3biCZq9gfPr7hic3DedfkgeWEYEXPqkGATYm1WgW7MlmOr4oL1RjES+0Hsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ2PR11MB8499.namprd11.prod.outlook.com (2603:10b6:a03:578::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.12; Thu, 29 Feb 2024 14:43:41 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7339.024; Thu, 29 Feb 2024 14:43:41 +0000 Date: Thu, 29 Feb 2024 14:43:36 +0000 From: Bruce Richardson To: "Medvedkin, Vladimir" CC: Kevin Traynor , , Qiming Yang , Wenjun Wu Subject: Re: [PATCH] net/ixgbe: increase vf reset timeout Message-ID: References: <20240130100027.39466-1-ktraynor@redhat.com> <492b36e4-8f60-45b2-a8c6-1bbca9f6901c@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <492b36e4-8f60-45b2-a8c6-1bbca9f6901c@intel.com> X-ClientProxiedBy: DBBPR09CA0001.eurprd09.prod.outlook.com (2603:10a6:10:c0::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ2PR11MB8499:EE_ X-MS-Office365-Filtering-Correlation-Id: c81d16f7-7d0c-469d-389d-08dc3934d22d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A3GEcXSxPfVgNbwnI0SJTQ1rIVqD8tcsoYxmRIKSocfE6vv3YD7vWBQLQKg2mX8PsdAsUerlsiKaYBV3nasn6zDGI5XOm9tiPAL7OT6yr0kD1XtqKhrpzRoKw2PlnYtPDD1FjYkrbJcg1EXckgA2Tai8KAZPNkEmWqpDsNiUzkBrsJsZMaYAWL5xFpX8YXkzTRkDQScwLFHYWSoLuJ4uHZjqq8PgQwwsi4rDMsou5M24ptyl9ZsYSYdNqgWNcInnsnNOnYOBxnE4ol1bk4feCTby7vz8C3VuQWXkdf5aXPWMqgTu/hOCipXXhRsS6CSrbILB9bTyesn3TPrSU4B42ON+UcRh14iGEJt85gOnuw2j3TiJiNu/zzwjGlXtFEJ7PHtZGEYsducWyW4dkUUb97DjlpC6m5QLRoaKtXfqB7yMLSWV6jeuWcRGvaEi3T2j7o33pJ9GRFEzOnNaclrV2IFA8/MDZlaoE2RBe9d0etxyJZb9ExB/cfBkNUcAlStEdyOsFSbQ+SA30A4hlkdaUEXZ4VCpzcPeb46AFwRaZAKB5CT4eLUBCY9FWN6frCCOinIOpsGUbT8u+rQxkQgqzJkWkJdk7C3f/srzz4rymwfCLsAhHthtE9Bl6BwCTn63CP6tymqgCbblaQgBTsX+rA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bUkhsgaTlTZ/IoEsxUmI0zgCyKge9L2fi6ZrckELT/85CMQeZ8yIdDmWO10R?= =?us-ascii?Q?1CMv4pWFrEbt+lGG8oA8y3ygo3BcF2gEhnCGY54fgmPYqEY1LBrfXcdT6Xbh?= =?us-ascii?Q?yQZpY1nFR4WFkIwvPFbmwWceU01vVynYoqUZwsEK2lngQNdOjLLprRhBGzJS?= =?us-ascii?Q?h5XNIxADpwSb4uI6AieWbHmk05db2YSwhRL35OlXtGyARX/a2O/VHiaWPaVR?= =?us-ascii?Q?65ho6Xrem6Va0wZKz15R/DNxG+6PVQHlkfocL2V9QKtnmIjpNSD/st+rb7cc?= =?us-ascii?Q?PRL9Qiigx8udKIPbHjJQq6JiOXZCCtxIjK4amhV3hMk47wzB+ssfzSL7omo6?= =?us-ascii?Q?9WsY6jE594zayWBpEi3PKMlNvLkdIZM8HPPFq7DvRmMawKaCmvx/KrVXRFUR?= =?us-ascii?Q?rq6HZrY32S9DcgwSs/YzXfnNGrvcH7Vrqdz7ZLriJ8oiSNcQnzANorZf0CFZ?= =?us-ascii?Q?kBKN9d4T33VgrjYwloIyU7d1rGrZHN1kD3P4rdvJ/CVCeAdVsrSYfy1DMew1?= =?us-ascii?Q?013/ffgTkWi2hM/NIqWTnyLtahV+GLfaQDdEdj0xZvVKwVGpILbY6exCG8Vd?= =?us-ascii?Q?0RZ/2zxUYjTjTAOmMaUFOIPZNj1swQcRzFaUgTwS80JfVTClHZk/E8wZ5sRx?= =?us-ascii?Q?Qo/I3KOKVvL+tQ878YH8IdUvc403LvwZ+mGtDBorVNhSXLGfiCG/QTNQVxh/?= =?us-ascii?Q?UKuaUVL0Rzikm6nR4Gp28wpW66rwg6rsYbiLlrtAUEw7HEvqLnl2wlMga6O8?= =?us-ascii?Q?c/n3bCAvvO+WNO/a/E/1GAy/nx3EvverHZuMPZcxLP/dXEnGpvfx8kS8ELMj?= =?us-ascii?Q?G0HtzC1y5r6g4Ht7jinGVNs3+zrJ+Gms2BpiA+isi7+Uo1LUfWm6RrJk99He?= =?us-ascii?Q?BDRt828DowrJza++GbMGy1kdQ6sZydiYUAwo0GnSMe50C02kRSQE7Y6oRWQJ?= =?us-ascii?Q?H5o9pVBRq6e/PpV2VC/Zn7mDhQdliiLQHiK0F4D1YfOAj/gF9K5sObwbRj1l?= =?us-ascii?Q?2aVb8ADLmWbc7G9gILYlb7rB9uuCmdohbLq4CMiim1BpTTSIVz1TDHNscTrP?= =?us-ascii?Q?gFBMJaul+GCHZlNaCWuIBzHIK8PHwGk9Fbya7szZpMvpoiagE3Rf7VV0NiKH?= =?us-ascii?Q?YDU2yRRHqBBE2s7Y9BhO7hAu0wTtp4XAhL2GFgJ5MdX3wTcPEH+I+WtfauMb?= =?us-ascii?Q?aQM8CYHFYVxJh8/2qcGxqxLbg1L64q9LSaYwYwNlxfZ6KWpDKwi4nq/wrFDb?= =?us-ascii?Q?Hm4Ftuo0EioWolxoZA7FGJv7YdYwY8V8YCGKDj7PAGxtryrNYoCF/4Nq/X5m?= =?us-ascii?Q?TZsw8hnkz3/FDc8FstqghsuhfmWQ8sVIJRJuwxh0j9y25M3pOgKaxtGU8kKd?= =?us-ascii?Q?m6RG92XVZWcB3skCzhTO70rhKwsfGEdxzpNLbJ9KbpNK/VoZ1hY39/mi61AB?= =?us-ascii?Q?G/K2GBJyEC8OI7wrq2rEpu35pynMczQcyloUqAIDXm4DGsbti78ajeLpCT71?= =?us-ascii?Q?AMvH4q9TCx8I/7nvevV8tksnEeeYa6pNSJo0Hn0TrX/PZt+MGUuJVU8A/35r?= =?us-ascii?Q?iZ57urvd1kiQ/QccP0fZwa7rv6TUJXbMS4sFUW5WvIUEAydIB3nSjvHQJVDX?= =?us-ascii?Q?JA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c81d16f7-7d0c-469d-389d-08dc3934d22d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 14:43:41.0186 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BWGe9a5bfldN2Q3LKUKyJsomgL2giqACLbEQ6p7KxEpF48pFSlkFL2vH3h/0WdUsStRrF4OKHANZq4yVQg+PaijY+diZOhww+GZsJBHV5VY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8499 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 27, 2024 at 12:35:28PM +0000, Medvedkin, Vladimir wrote: > On 30/01/2024 10:00, Kevin Traynor wrote: > > When vf issues a reset to pf there is a 50 msec wait plus an additional > > max of 1 msec for the pf to indicate the reset is complete before > > timeout. > > > > In some cases, it is seen that the reset is timing out, in which case > > the reset does not complete and an error is returned. > > > > In order to account for this, continue to wait an initial 50 msecs, > > but then allow a max of an additional 50 msecs for the command to > > complete. > > > > Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org > > > > Signed-off-by: Kevin Traynor > > --- > > drivers/net/ixgbe/base/ixgbe_type.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/drivers/net/ixgbe/base/ixgbe_type.h > > index 1094df5891..35212a561b 100644 > > --- a/drivers/net/ixgbe/base/ixgbe_type.h > > +++ b/drivers/net/ixgbe/base/ixgbe_type.h > > @@ -1801,5 +1801,5 @@ enum { > > #define IXGBE_VFRE_ENABLE_ALL 0xFFFFFFFF > > -#define IXGBE_VF_INIT_TIMEOUT 200 /* Number of retries to clear RSTI */ > > +#define IXGBE_VF_INIT_TIMEOUT 10000 /* Number of retries to clear RSTI */ > > /* RDHMPN and TDHMPN bitmasks */ > > Acked-by: Vladimir Medvedkin > This changes the code in the "base" directory, which is not ideal, but I see no other way to fix the issue reported. Applied to dpdk-next-net-intel. Thanks, /Bruce