From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB22843B9B; Mon, 4 Mar 2024 13:34:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9408A42E16; Mon, 4 Mar 2024 13:34:37 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id 5F26642E1E for ; Mon, 4 Mar 2024 13:34:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709555675; x=1741091675; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=t5xtwMuK6iecpIglG1H4AyQd/bufYDXkjp6ifhcGejE=; b=PIjFzQZl4K+DTRCgwmxb4yF3ZYufrwnX5N4StNNvUC/G8FTisVuy7Avb coO7vr+y4w8TS+p5htBoMzNqlbSGjPnERe/n83ciYaTFPY9iRKKMF8wRy VRjln4bLTjliHQr/vxTyOtQTjkV55/n7fU6uB2QeKAO7LYI/FxxnXGC4E kMuDqprkvu5u9r8aQwxfZ6u7bpjNBpNf6G39sfQfDXY80t+fBdAs+OhsD 17WnXT3uXZiwLgW11ppm00rEqkFTg9PH2+1/yBhLwdR9a8kkYitMHs5Yr CvwKaZV2jXBjFLwVOU453CcXKVsX+WxX/FZpJ3BLGOzyzcvpV2L86+mux g==; X-IronPort-AV: E=McAfee;i="6600,9927,11002"; a="15453485" X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="15453485" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 04:34:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="39833861" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Mar 2024 04:34:34 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Mar 2024 04:34:33 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Mar 2024 04:34:33 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 4 Mar 2024 04:34:33 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 4 Mar 2024 04:34:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PRtn/zlmliQJhrQFZpLK8Lv3N+lUBBaOK8sAKwS+ckKU/Im74poxv9V/YfAPb0nLs3QOrl49VXi+tFe+1ZMAGMt9DMTu04HnOTCBOBoW+z0zp1gr6kD+o3IqjoOPaMeKsMd95VAPX5fQYnRA5dWx27AOZ+qN6jO0AN2dsQPclP1qwy0Ck2njpYoqCsM5SXX5YJjihF8jC87+GgWZzEWOyDvv6sCP1iasuH8GYE6+k/CW71JoxOGUtTD3MC0O7xMHnp56iM2W4QEVUxylghdFEIdYsSPnS8PFZL8qeJoYkfW49/XjKtarGgTSpPZIA044IdBUojN/S0VlGCBchDCSww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zF1+WciaIAhb2UwKjTH+bYEHvlaaJ3X1QQwRA6iKXiI=; b=LbZs5nb78Gx6i4BsQkQEQxNqWIh9NU2+Yhx7H2acNYFO89UayQRW44cAr8diADmVxG1xrJgk8SSjd3D2XfjnDY9m0f5gUdz5NyaS/c3VMOkMeP9Q9qQJp4aTDVXvnwPzN/VkoDs4YWBK79v/BqJT0vp+kaxK9UCXRWZMO+7Hiib6LY8V1StPewKEZHfEA5tmQ6rHO0g1tRvgg77QZzG0eLhUOgCuF4/fUOfsOxXEXmzV09KNI8YR12/5Dbmr6FptefBjf5rfgWp7IlzlkZNJ8mjfztApKNwGtKgDana1hw+reWqkMpSv/CmfSuLTrvNndCpfNUuxT32DLMIISjrqqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB6719.namprd11.prod.outlook.com (2603:10b6:a03:478::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.23; Mon, 4 Mar 2024 12:34:30 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7362.019; Mon, 4 Mar 2024 12:34:30 +0000 Date: Mon, 4 Mar 2024 12:34:25 +0000 From: Bruce Richardson To: Mingjin Ye CC: , Yuying Zhang , Beilei Xing , Qiming Yang , Wenjun Wu , Simei Su , Jingjing Wu Subject: Re: [PATCH v12] net/iavf: add diagnostic support in TX path Message-ID: References: <20240110022555.3084426-1-mingjinx.ye@intel.com> <20240219095514.66338-1-mingjinx.ye@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8PR04CA0005.eurprd04.prod.outlook.com (2603:10a6:10:110::15) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB6719:EE_ X-MS-Office365-Filtering-Correlation-Id: 85a3861d-d8e2-47f1-8945-08dc3c477033 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X72vid40ljgMT0LzfyzW+u79sASH86RT5agNJG3N7kqTEAxNt7fbfLjejRT29dgROi6yNN5gqfTOyH+LhUCej5zKYbO89bPD/F1+DE0f2xm+gjlLo1wIJXr+dnQyp8QyQIlaAxhYMH4sIQ2rDltCcXIwJAvezJyb1+tY74w2T8k8vvt92H38tAHGTNp23UtNwT92f6JF2PqtkJtxQk8YFo6KY7Nj8r4t295/tvOuILJ/qvhykgwF6Cl3vokncrXCdOxP0TbLOAD7HfeyxVmUqQoXrRpO/6dRnmpFUfdeFdlYUlTIf17IJgKzmske8nI1PA0E9vA4AIJPcKhY6w/ZnADNKMMbRPsASldUnEgBy+96EWb00cSh4SIIu/HmUexM0gNTsaG/CTd1m37qCOjccqmrZbMBbPGOMvCl/aSGIIyTH//vSev1UE6IB3salxWt3XHdcNQvcRGUmXYvxkCv8Dw1tszJz1yByOJ3gG8u8HsrL/jwAHwKo98yKEFeyCVrSZNFtVzG52HN53KlN0DsTwH2gaOjpG2f5MVuRTJgLjiKmnLZnNLdxJ0PzwV3Or3zBrZnWV69Su3VBzWVLWT5u5e9Q/n/zz2n/pXyEvpNobL6/poMg1k7XA4KQYzZ1jiMk0WPvM6x5YlMH7Y3dr27DTayknwNBAj3EZjj7W7DdmA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ElPd7N49imK9SC4hA2wW+bLZawJAj5S0BKOAavm20MOvce+fhK3Vm8/xqx/T?= =?us-ascii?Q?pNOaQkEYgoYy+tpKI1MLfkCEfbDJfNa8N893TDWQIbo+tnjWaFtuYTckfFlB?= =?us-ascii?Q?8M7Wg/0tHtpIF+ErRKRJXR8OfXwywKZGaWH8g+G3XHKaBLAg0p+U7O+v9wFX?= =?us-ascii?Q?21vtIhV+1Hl2qMzK0BPirg2yRERa2VuXJVSiGDUtyfUAJHhP2DMimets55V0?= =?us-ascii?Q?r1HFaPIwSWXiHj30V5zaWFIsUDxxohwngtkJTW8Xmuy3BgLS5N+yIr74esoz?= =?us-ascii?Q?F0sHQa6+Qeq88saQ3Pvk4weFgqz29Q0aKN0BIKvT1JEX0LdcnsiHTyP7cHQp?= =?us-ascii?Q?LaS8Zr1iY+OT4ojxco6s38qSPey42S37REk8/nzEK5ze+4jFoRX/egL9GrQ2?= =?us-ascii?Q?3xLsbtq6aiJWAMqMSU0QhKaPiLfUMzetquo2MxYWHSf4HovjFLP8vtx5jsQT?= =?us-ascii?Q?+JqoMo1fUM7eHjG65CklrnZi3UpaZgW/qKnuxkhuUHh95Y45qGx4BWW9GvkS?= =?us-ascii?Q?q/Fhshn18nJYBfINEJqnF4cjf5dkMlJgvmkIpJGZQTDu8s0ejIVG3yoSZW4j?= =?us-ascii?Q?AF5MHNrClYJPD4ZE33zcdWqGmR2SgPNcvBanW2eg15PnNPYkQVHJqOx/9La4?= =?us-ascii?Q?U2UFalt1kJ1L6q6OTubcQlgolACThXdygLMhtifpsHkGoUNU9SqW/DTO2bV2?= =?us-ascii?Q?rNxK3s+Is76JVmpfPcMR/oIZTy+DP6bx5uz4ZBRvZTnJf5kE+KoAvCEjPpQ4?= =?us-ascii?Q?etSwWMWrRkRXTmcS+pstJZfnbJrTC9be3F3zscOg1zUlTcPHImExriuATcVn?= =?us-ascii?Q?BkoHQrnpMnrSiq2hsDeSLtPO0mL0Wk5K++xco4PNe86ouLWjgkUBHkZoiGYJ?= =?us-ascii?Q?lcu/2VGJHHd25ZqjootVwBo4ZXAdHz1rTQ5RbQFtorbTghfWf7x+rUyH5xDl?= =?us-ascii?Q?+rufi+YT4MvlxwgQMlvOxVxnNe5BUH75+3DLJjsWRdeieV4eSgsSVWWocLkE?= =?us-ascii?Q?i7VVhFjQf3W5dgwres3ijWcTkKRTag7ct3zDIVZKBXqQJs262zgvpEsFvi8O?= =?us-ascii?Q?bRgDJyq5Si9rejn3J/BSnVcNZEwhPs/joPZckxZyUR3hpilzVr0xNVvFnR2W?= =?us-ascii?Q?1lUwdWXgTUUcIM3GzQuaKv6vVhQwGeOj8YfFdPULClGlJajIIGFAS+c3IzFw?= =?us-ascii?Q?VvRYm8wHXW50LgkqMY9Pp1RQaQUzWsBbwAAUt5+3144EKnxPAixP1TxSISYZ?= =?us-ascii?Q?JvVavKInWmRMgpFFmTtpxJrUzB0cMY4WMe+qIwI3+431XqnKR8fLhYcWg5ND?= =?us-ascii?Q?vJHUel+EedUibc/CzSqXGcGxKkTm9p+6+dPvUufdNfCpSQZ31uhMGQ80ExNC?= =?us-ascii?Q?NCU5ey6AsBKj/7bBnOKvkv+2xUM79zrBIyI8r4eLQOicyzSLFgGsn3jLGJeD?= =?us-ascii?Q?OEnOlUCIF6w1FKD12+CpYkbAinI0/UtHXy8zWXRo+wLk08zhYR6yxb0d35Y7?= =?us-ascii?Q?SHngBoxoK73UCkqyF6K1t3uTKLaKD2U/z6mOw5VZyUsdim9KPljNWw4cJtBG?= =?us-ascii?Q?1lnqi4KdcoFkFYP0eZdYBoq+4n3ew7yaalQzEw4BUggOCE0FcNaOxqVbZ7RR?= =?us-ascii?Q?/A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 85a3861d-d8e2-47f1-8945-08dc3c477033 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 12:34:30.4694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iuicSAS3SBeW4zwYXA0e9Q6xNYP0LMNj1B+arbZiNAahySW4tAhbLMFfcWJozcP3FEK1Wtbmga6zS9Bo1ZVFvIm+O4aCGcQ/eHIYjgIUOoY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6719 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 29, 2024 at 06:38:47PM +0000, Bruce Richardson wrote: > On Mon, Feb 19, 2024 at 09:55:14AM +0000, Mingjin Ye wrote: > > Implemented a Tx wrapper to perform a thorough check on mbufs, > > categorizing and counting invalid cases by types for diagnostic > > purposes. The count of invalid cases is accessible through xstats_get. > > > > Also, the devarg option "mbuf_check" was introduced to configure the > > diagnostic parameters to enable the appropriate diagnostic features. > > > > supported cases: mbuf, size, segment, offload. > > 1. mbuf: check for corrupted mbuf. > > 2. size: check min/max packet length according to hw spec. > > 3. segment: check number of mbuf segments not exceed hw limitation. > > 4. offload: check any unsupported offload flag. > > > > parameter format: "mbuf_check=" or "mbuf_check=[,]" > > eg: dpdk-testpmd -a 0000:81:01.0,mbuf_check=[mbuf,size] -- -i > > > > Signed-off-by: Mingjin Ye > > --- > Carrying ack from v11: > > Acked-by: Anatoly Burakov > > Patch applied, with some minor rework of the docs, to dpdk-next-net-intel. > Also updated some line wrapping following additional review. Corrected version pushed now. /Bruce