From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37BC943B7D; Tue, 5 Mar 2024 13:59:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1B0140270; Tue, 5 Mar 2024 13:59:21 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 9A7D04026B for ; Tue, 5 Mar 2024 13:59:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709643560; x=1741179560; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=8Vq3wAa4V/4FAX3KymiGBEwvSjQb4QY7zHsHw2AZMaY=; b=X2fE1uNYNSH7WCcfogE20nnA8t+J2wtkdOT3fb/b8WP8NIGsOUASZo8Y oA0UxSRPTAk4B3eFUlGJ570hGjnsZCz/Duboq7oZK4gpoxCVLLCFjGAx4 feWEXIla+ry4vfigsmlYgUlG/wv1nwWfJW1BYSMCn1Hwda5Z+U34MWK4y EvXtt3Y068Y+2/5J1kVkRxBOpYJODgKu020i/PbiywSoxyA6pFQGXTQmx CWb0g17W0g/8A5QV9iLNX4grzPGpGFnLyiUpMCB/NorPURiquWmZho1mc QrXq3MGCRTyD18Ns17mA/33oh1wxXGmMg1Xsd+iRZ9l/usbBCCuv/ftN6 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="8001974" X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="8001974" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2024 04:59:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="9306848" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Mar 2024 04:59:18 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 5 Mar 2024 04:59:17 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 5 Mar 2024 04:59:17 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 5 Mar 2024 04:59:17 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 5 Mar 2024 04:59:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jeTmTgmgBsc6y3O+kayn0vHejVw+iqbGNxVNq5IrnyMp6OwP4wGmg/zEtWt7227CJ9P2QiQsqhHVEbd9v1GyHaBmf4pmS/IGT6nypFXX48xne+2MTRavDmLFeedXF2/0qFrDyQ4T6lh6AmqX6PA6kR/ozqKH1Y4b8uXpvRGreQO0wxcVcWfkgpJ13mUybh7fWMD4jzQXL7uDI6j6T1x1ovs5n7rGs0J/g2IDYd0wl8c2CWiIufn62q6CV2w5bnyoNXqcFEXtKTNBoqonA6IjDFHtncd9VaddxboNs0LQWBau0dA5CtFokU8/DbQRABdX8NVeJANURPbqlbE2tyqVJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5eyRE+ir+XOTBqba65g5j0IuNEtHNP6cy0RgzigOvOU=; b=N2b0r4EAOxh7fkEvKHjXR0Ia41ByNWaiHiOxXaPKRhSZNvNYcBwVqvQbmnqWlj6DRy+qKRb56omAvNDV7UW9EyHjx0xe7Bf9BSgaDWTub/LgsXKP94JDwIqZJ6w93w0jIXbeR4f417mep3hEVBszUdReDlMCND+bM5djC4sWaTKVNJNA4uTpY3Cf89yDCOAf68TzgsO/XIqQDbFhUdMQ0lNHzF6M2FUZzIaEJz9C55HT+2lIhiZ2PWgZsed0MgNDLitGVpVckLg0Lr4BrVQN1DWpuuwG+QTCJ3neO8fBFaFJQulaLn1jVxzdMWYF5mWyTuMr4zU8IdCjPW9s4G3S8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY8PR11MB7799.namprd11.prod.outlook.com (2603:10b6:930:78::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.23; Tue, 5 Mar 2024 12:59:09 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7362.019; Tue, 5 Mar 2024 12:59:09 +0000 Date: Tue, 5 Mar 2024 12:59:04 +0000 From: Bruce Richardson To: Mingjin Ye CC: , Yuying Zhang Subject: Re: [PATCH v7] net/i40e: add diagnostic support in Tx path Message-ID: References: <20240304093321.592061-1-mingjinx.ye@intel.com> <20240305101747.769464-1-mingjinx.ye@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240305101747.769464-1-mingjinx.ye@intel.com> X-ClientProxiedBy: DU6P191CA0040.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53f::15) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY8PR11MB7799:EE_ X-MS-Office365-Filtering-Correlation-Id: 282f381d-8b3e-4f0c-860d-08dc3d140bf2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b5hl8L4V0cmyCu2k1wMegPLPz4WwUanQOANLHlXAaDXm2INBsgcNHQ1DfD/XqpDj0a2NhQpft5jCzTrctH6y8cwSz+6haFHiCGq6rg2uBpJiExWZlOLRM7kki18rJSdEC+FbqvGwhZdBrdnvV7CQzOUEnIV/KZUBLU741ZEkEFD3cxKpZ+4od2IWIo4XByISOM65gEsI0x9SVOmOHEg2IsiTr0NVcVTRPa+M6hKyoxcCMSkNb4XcM7md/u+Zy+Vo3VdMiNzuQH87l4XM3QDdw2Xwgo0oDg9R3QwZbhkTKVQWUrN1eV+tUtXr6yHbBKFtAEHEsa6P1uJLtgYGGwlKiCeOAI7ExE8o/rI4Fr/9W+2IA8kHSvrkLWDwvLwRmJFM9SRHwwJw5F/zj7GEjQw/TwMSSyL8GLP861rllbuEWDw/83GG+pat35AqBbB0CahcliTfedF5d/hcwvEsyDFf7Mxvd/ML4f3Z6kyCuPSf89DT43t6tTabbyTNZwkJbHhYZWVNXpq23fRAF8Sjqw5Qt/rqpe5rEvOQkWBJuu0bsk79XosGlUWCrUHmqovxYulLwnuZzVYlj8dOLlH1S/xcy16SiP8ZP5Fju79pfwKeGOVRwRtN7B/yJaljcallDTHRvlKCaBru4w4/8QlaOa80A5GO4Vi0y+ZtmMIMesniubE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cysOPBOvySzwID5Rx+oDO230a4Sw8Xv2cO1nB36HKLyn3Z/UJDfCvIBJc/5C?= =?us-ascii?Q?aEnvP0ZFh2O8MLQMMvxL+AfXVC4FRspEhdQscNBenX0mdQPcObcQsylrEU36?= =?us-ascii?Q?u/y4BYNpXG9fsH/aqA70OVqZ1KRWAix8kyESCDIS2JavvfZ3+vt6okX909qr?= =?us-ascii?Q?cSKmXmqz2pss8zdbbGieyor6xZm4UmABIk5SoK5uUH+P2cr6BfrI12qHSZsF?= =?us-ascii?Q?srZTrPA8x94gA0Bk+bU39Kg32prMM+hvBKxpSUwXte8+eZ+xrri7WE0mtKgw?= =?us-ascii?Q?E6Z1igdDQRC2xYon8XZjfzdFgJdjeFn6Z7725AHxg84AfbLI34tFR+WPfU+k?= =?us-ascii?Q?HoystEozHpqVQlpbTAl8CUDsp1doCZ6h7RZqy5YFw5GKq95Ps6amxLir2cyg?= =?us-ascii?Q?tbJlT36lobzCNIGsdrRPZgrU/QXJTP9Sw5zq8f4Iggo3mSz0q7f0aRbKXTqL?= =?us-ascii?Q?x083rbu7FRBRsJXFsFpOkiY8hU+lTpLqtatmwGAfzdbT2E7Lq51aHOi6O1J7?= =?us-ascii?Q?DDAfq+ANLy1FSCIqxaz25Tr4iGJ7kUo2XfVMioaRahmgAh1MFI9YTqiwDsN5?= =?us-ascii?Q?2g+exf8vShMecKKf5q4GGmoyObVNlfKcOs61BRJMVsRI3RrU1enpO5ExZ49P?= =?us-ascii?Q?exUtqsozBXxAA9OBmDR1choA5Lvko+gpCdN1T5XixAUzac4I1GipiMvzU2gt?= =?us-ascii?Q?wl1y9GsBImTb9de3Hzq8CYCAtjCyZQQdWB/6aulLqxs/kx5Ui75Pguwd0DBY?= =?us-ascii?Q?wZF3cat0wyOHek7X5+SgztLwr/LvoY/XcULzg/cK7WSJFRRqbEm9bOwGM/Zr?= =?us-ascii?Q?1jU60r99YnROW9DDEOu9j9cm2CTGS+I7tHYfFAc6BeDSHqAnGFr/2vG7fDHD?= =?us-ascii?Q?vZ5gSYV0ZCb0hYDKeaSrT/XGkQw8KZZz9XR8SrhbAizonjOUXHnMziIENFYe?= =?us-ascii?Q?X+JuCDczQQpiCkbvIT3ne3D7FM9vR1ngdC2XcAPygFnZsdtVDmPr615PGdBC?= =?us-ascii?Q?bokblBSk9oqP8GO1fOE+C7ifDasyjKQwqe1zRYAVgODHaHc310h3BUeXXA8p?= =?us-ascii?Q?vA2/9I0rvAInYUTUvKFY913pklGY2kBMKId/Adpv1LPK0s3ildVQ9t1pWBr9?= =?us-ascii?Q?5Fdfl6JExOK/ugKH167gTO+fWqV5CKXpsCzADL8vo7AMaEstHsU5gI20X3bj?= =?us-ascii?Q?7EE12qqkEyOuQzYvqsgYVWOx8OeytJxn5arRGbeZ6TCkZzJO1dd3twWUcV/U?= =?us-ascii?Q?ucO9xLqHFz+IS8GFcV5UpAw8EebussQyXaPO5qlLMid8fJF2d25ki+XR776/?= =?us-ascii?Q?f8clI8KiVfGm8XNiz118qce+1PE9p6pZmBsAZt9MrTmYLPqJGFlUwRCr/3MM?= =?us-ascii?Q?0S24Q7DG3iE18jZoFwIWYB4NSIH0hNxfcKZgSSUWZsY8jlkrxCx9eg4EwU3E?= =?us-ascii?Q?FDZmSq4nMM7FF4LTnbQ6bfYGDwUF4r+DXssZ7izoGwXK2qcrQF0zUDKjuS+a?= =?us-ascii?Q?NlqjAIxY4c5xkLTPWyjSTWH9FAtqajZE6Z/WUYMkKh8F8eKpAOrwKY2E51zd?= =?us-ascii?Q?5a3x93Fi1XZWYs0ENNLu8iJti3Dh6guToTXXB8npRwGgKIwnRF+XAAP5zKwB?= =?us-ascii?Q?ZA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 282f381d-8b3e-4f0c-860d-08dc3d140bf2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 12:59:08.9916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r2vilK8gcEsJV/y6GxWO0dgOmeT2GG2Znp9vTU5D1b1Js3LQ+d+e43pRrWILgf5kzMzzsrY5F9gMUbQA/ah7e0ARNdoebf6HhgcL+6elupU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7799 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 05, 2024 at 10:17:47AM +0000, Mingjin Ye wrote: > Implemented a Tx wrapper to perform a thorough check on mbufs, > categorizing and counting invalid cases by type for diagnostic > purposes. The count of invalid cases is accessible through xstats_get. > > Also, the devarg option "mbuf_check" was introduced to configure the > diagnostic parameters to enable the appropriate diagnostic features. > > supported cases: mbuf, size, segment, offload. > 1. mbuf: Check for corrupted mbuf. > 2. size: Check min/max packet length according to HW spec. > 3. segment: Check number of mbuf segments not exceed HW limits. > 4. offload: Check for use of an unsupported offload flag. > > parameter format: "mbuf_check=" or "mbuf_check=[,]" > eg: dpdk-testpmd -a 0000:87:00.0,mbuf_check=[mbuf,size] -- -i > > Signed-off-by: Mingjin Ye > --- Acked-by: Bruce Richardson Applied to dpdk-next-net-intel with some indentation and whitespace cleanup. Thanks, /Bruce