From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3280943D17; Thu, 21 Mar 2024 17:13:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0811842DC3; Thu, 21 Mar 2024 17:13:57 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 62504427E1 for ; Thu, 21 Mar 2024 17:13:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711037635; x=1742573635; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=9YEvu35iriXuvTCZVFZs6jyw9juIWBXaPfa0lF3bnGQ=; b=NsMg0kNR1ogR70SA+e+zCBW1KYHbcyVEmkzTiH9mKDs9G0fA83LVjmEc BWpfmDIXAsnbHVQjshKrI12U8cI4Te9rWHlch44rr940qJJni9RBZitHs DXEuwO2OXUjsqPaR/Wh8TiE6mYrem8tDw7VaOwTcEdFfGWJUAiyZIMR6f GBb0zyMeJ0Cws0EedClGnJZjtDsbiDtCIi6p/v1hvcVdx1D9WaTWcBKUx hQCPrLVeqeY8xI5B8mGtWGE6q5XYNiGLojMGr1JrHZkU3v+d36sWRMD9n WJfhZovVKmf9RA17VY23GtgMjD1eg4N3VplCFXc98BekNfsYrldoHQK7h A==; X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="9827234" X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="9827234" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2024 09:13:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="19133320" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Mar 2024 09:13:44 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 21 Mar 2024 09:13:43 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 21 Mar 2024 09:13:43 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Mar 2024 09:13:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q0ffOsL2eLo5z6+U/RY+sErOg/ByaVQM4AdafM8XUsEoL4zwnd9UbZwCDGqqx6JeF+aqFVR2iJXo0GLKIy5me/se+pJPp03WiPytczGyWp7DXTUyoRYI/K21zbx+jga0Vfa/VxB7w0MqdIaEO1uyqPobiHE58iBqq7Jo34FoZG8O60Q09z/X4Wd6tO7onEjQ7FuxpCQDFK0c5wlJ55TN7DnsYrnuQtKii1cM0642aaSRyzQTxf+uwDkZVc9Ch8UCed60mlrir5zB5NAfrBsEW1M/wSAU5jj8mnV80jhAVFEij7IRwXWx188lssjsXizf+5kfgASowfsLON2YRALGCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=248U0LZ31wx5XTca1trpZheOSZzV/h6NbmDhGujp0sc=; b=MM7x9bJ38afcvSDNY+Aw7VaaF2aZfjftnRBoJHL19cwFkf//n8JlzhqINUp0r72ihSaVuzimbXHg1VnHrUfnIdwAzQU9hPy/2Ahbc92Pp+aFjM2V8WkcjJlfUGYEGqLtTzxowmT+KiVVsmEOjFCqJFhUdEIQqR0QIoGKlao8kdo5jBInH2rwbfPVptMpG0MxU9PzBkMyx5lKTTaR6g6httNl9iHb3g98p0XD/x2U6GVZOKyHw8zxOFWlhrY6ZNvM9dMnA3cFNoJ8DDEHCx6Od0OA7Ob5P72aYsae23eBAUvPL4a2zpIx0UKKx5Ui5vaPlwSDARzuByQNHz87d12N1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB4867.namprd11.prod.outlook.com (2603:10b6:303:9a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.13; Thu, 21 Mar 2024 16:13:40 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7409.010; Thu, 21 Mar 2024 16:13:39 +0000 Date: Thu, 21 Mar 2024 16:13:32 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: , Akhil Goyal , Aman Singh , Anatoly Burakov , Byron Marohn , Conor Walsh , Cristian Dumitrescu , Dariusz Sosnowski , David Hunt , Jerin Jacob , Jingjing Wu , Kirill Rybalchenko , Konstantin Ananyev , Matan Azrad , Ori Kam , Radu Nicolau , Ruifeng Wang , Sameh Gobriel , "Sivaprasad Tummala" , Suanming Mou , Sunil Kumar Kori , Vamsi Attunuru , Viacheslav Ovsiienko , Vladimir Medvedkin , Yipeng Wang , "Yuying Zhang" Subject: Re: [PATCH 07/15] dma/ioat: pack structures when building with MSVC Message-ID: References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1710968771-16435-8-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1710968771-16435-8-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DU6P191CA0033.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53f::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB4867:EE_ X-MS-Office365-Filtering-Correlation-Id: 34b784d4-bb5d-4cf0-e6ae-08dc49c1de99 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2krnaXm/xiuD6FJu+KH46QL5ZlY4tq7KdcHLj6X9LnsJjESBbrR8xZt/wpZIJPuWDYDYuUcHW7S62vfz/5Oqs1KDFc/eFwZ5REmAMoYA6ywiZq4oiciowyiHaOjz0Y6Mu/nzZcQZzXknBFMBISyEPQk/dvtQRHbWnkOZMamZxTwmZN0OtNMXat3lmnydnDa8X1naD0aq7CVaepiqx2VMFSnUMOO8fo7TGA2BxOqhr7M9y04io6dXzI9tFclZP+dOfpBPs/67s6bSyL1nzwYqkvXDjjigud82kVzw/CcXrMUWA7lUq2P86C45gZoXdzpZUcPGIWImMGmW2qjp0Lnv9PQvOyOHsPkQznfOv2YypfPY8SMmFvLp7uaumNRMXZ4rmVE1/TiTMHYTfdpZt1CYTZFugpvloFrnBRJ/oHKG6jQMk7fyO/w3Qd7qsZV7TEBU94GQds9gkiBZt6aE4vO9mLFhcYuU0FHAiP1Mokxxpd2KaV16J2IInie6l2vhcrHo0+thnuMfZXSDQ8dgpYO/DJZY8OihrUoh5FVJXJtrblDsH0MLkH20r23QUvhxaiZ8G84JGxlwhHBkPH1doiQYsJlQYc/wzH+w2EaZogFRRHgW/dbfQc0wUNY7suKJPfSMFZ404rvrzqRSSE4QoLuqVH5LDxm5sk34wXJTW106FfU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(7416005)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pgj1dMjYWbgMl4LxVThz+KBlkU3yhmhdJ35Jvta1DvQgH74fL60gk+9VebMd?= =?us-ascii?Q?nFNvCbwLJAZ7yEOhdw68gGQueEUS4y4ffo0jsp04u7F6HVciggJEtGuIp/hn?= =?us-ascii?Q?dIiBN8+tYPeiP9EVhAaMwLeR6lu7PqnWMwv5wYsHIsbDWr8QsKpjlq6iQ/G3?= =?us-ascii?Q?F9T2pSGBS8cykCTpgN3eUtZQwJAZuigIFc5I0t/eeFYeagms2F2flsMNiXO9?= =?us-ascii?Q?pVaN2+RadbrPdlwJg3sfz6Y4sn/r14lBR/PimQZKmNVFmetk+GfPjqYwvAbV?= =?us-ascii?Q?PSyq15ngpyPSkAopc7aluqC95/Vfbv7+KNLXKu8iz4TpA2zB+pDxt2wmUf2o?= =?us-ascii?Q?LA7TOx1mJhsnaOBGaBuOINozWbnMToF3CeBrw7sIzF2KsltbDqErOv4+YWVE?= =?us-ascii?Q?WDfAQL/OGMTms8+GqoMwIlQk6nd8UkEZhgGi3b0KL0TGQogKaJ0KfhU+ivFm?= =?us-ascii?Q?Q7XFGQnOTcDZtlwsQVRFmVZWqLWZeTyr6EkVfxlcmdS7ri10w9IZUXIf83T2?= =?us-ascii?Q?Lz9b0l7Du0EuPHeWJFvEuhs4m/NA2KKuopcAA++NlnOZaPYSdbrWJCgzvrw2?= =?us-ascii?Q?3ZUYicl/MmVDULMsgowJuZQJu44ETk/8M70/xunjShi/HB2TAf8xjB1ygSeW?= =?us-ascii?Q?ZNa92jH5DuKiEE3DF305U+nC3MlgSDAUQ90pY0awyIUpSI8wiq3VcWR6UARz?= =?us-ascii?Q?tPl3gBZAoFbIyP5Vbu5CXbmZelvT5WzXDyA6N3TTndZ6eQQYtxntDzTnkR0Y?= =?us-ascii?Q?Ei7fwsDty9gHuXCQObv4GtmxPdNwhcU8u1NOgQCQatsykTHU+PqAUT+VIfVt?= =?us-ascii?Q?PehRg9RDY4rtMX/Jd4kAhE9PT+Jf9s2LTSguy7AZDG7GEFo5qo2FT+SqDBHt?= =?us-ascii?Q?i2DrOc4naGIaSaCaiw+mhaVZwpNCazEhOyq0TPTqzj7W+Cbu+x+R+9vMP9KJ?= =?us-ascii?Q?eBb01h1uFpmYHHMrBvqsMNXIWhMMyWoXTqhoGyurTYQxTLnQSUikByU2BeLb?= =?us-ascii?Q?n+XFaOpKEXplHvZr7lHBy0TImjI81NIOrPeEYg5ZYd7h7GeYfMDsEwldLdHj?= =?us-ascii?Q?txrpXqdzFIvIPrr4K4KCwt8u1iWSOSg8IX738gh+bb9ZO6zyXzsoTEISkKXF?= =?us-ascii?Q?zQoqaoeAl+tWy8cA71T+3vIlxoVpMY6+UrQiRZC2V9WhYQwPCas4GomeOw8F?= =?us-ascii?Q?nfoP6gsZH7NpdP7e288rSdmOitnBGnOcc6+5E64FQ0+knu3xqh12YKUzuHSJ?= =?us-ascii?Q?NChpZnH7Y7Srl8zujU8l+DKHZtIhfkknNqXDDHgR6ClkMDS6C3C5WxB/yK14?= =?us-ascii?Q?euBzettug4Goc7YaT4G0sMUedElSEa5ft1Ft8Wrd05LzSRfV4oPJWW4can/4?= =?us-ascii?Q?cpx0ITY0HJ0QSyheGiI+L4abdyiH+BO+Z9NN5DIVSVH3KPXAwkr+U/wIttfs?= =?us-ascii?Q?SrX+itPTPdl1ptLUgkkP/ZvfI6gXz9jhUCk0v4WB6jumbdL/aadXL1aUlx2n?= =?us-ascii?Q?QPBGlEZqXhJd22a0bcibda3JbNlNdUdIXIkY6U7WYyKXJJcgRpIdK/E+0BtB?= =?us-ascii?Q?zY6uDSmaP43z2B/d3+2kfoRhvGn7Uc9pYi0OdTQ+1W71lEWe/S9t7vOvJeT6?= =?us-ascii?Q?pQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 34b784d4-bb5d-4cf0-e6ae-08dc49c1de99 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2024 16:13:39.4565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wF8Jsb1KH/z3jcOwb68Xp4W9SkmacXMGIgHSPn7d8VV//Mbx76qPpD7tfEOPt6w8wDhmjuVdJjstj1QYTlVOo0L5wbuX+2ayOJbXKSVEu1U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4867 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 20, 2024 at 02:06:03PM -0700, Tyler Retzlaff wrote: > Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing > when building with MSVC. > > Signed-off-by: Tyler Retzlaff > --- > drivers/dma/ioat/ioat_hw_defs.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/ioat/ioat_hw_defs.h b/drivers/dma/ioat/ioat_hw_defs.h > index dc3493a..6e32807 100644 > --- a/drivers/dma/ioat/ioat_hw_defs.h > +++ b/drivers/dma/ioat/ioat_hw_defs.h > @@ -52,6 +52,7 @@ > #define IOAT_DMACAP_PQ (1 << 9) > #define IOAT_DMACAP_DMA_DIF (1 << 10) > > +__rte_msvc_pack > struct ioat_registers { > uint8_t chancnt; > uint8_t xfercap; This struct has all gaps explicitly filled, so packed should not be necessary. Struct has same size with and without the attribute. /Bruce