From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD35243DF8; Thu, 4 Apr 2024 12:18:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98C8C40268; Thu, 4 Apr 2024 12:18:25 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id B60FA4025D; Thu, 4 Apr 2024 12:18:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712225904; x=1743761904; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=+87taH16MNqbIQGON1xjcqFb97RzRZ3cJAx9E+dahDU=; b=Ho6R3Ds1rZKQ0eTSoWMeH/LSDQXn6LENiNXLje/+lTu+zQBStBY5Pvpx oxRH1VCOBzqV6cx5O8fdMS+EbmofUtqSjQn8JbAU4GL018YeBS/ZMuqSG unpgr/DrKonMpKhQHKPW2ictUTp5Haieftk/yMSH5bjb36F7SoFemJRxG Y8is5bR5sm842ZDBqXB+ax50rlv5T5U1CFjfLYJB0XVFsQGEP2qCg8wyQ JIcRBgmeN7sYsQXd8utU/JsxPou6sunHuYON7xdqN0CUQF66JtMEoqpRT 69XHSietKXadrvEZ9kyBxagtxC6LZ4T0LqXG/5UPM1Zrw+gENWZkm5w6n A==; X-CSE-ConnectionGUID: 1eo/rD5aQ76J7ueLKPbxTA== X-CSE-MsgGUID: qM1sZYLWTBO760qOGli6OQ== X-IronPort-AV: E=McAfee;i="6600,9927,11033"; a="18853260" X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="18853260" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 03:18:23 -0700 X-CSE-ConnectionGUID: xceniumcQEO9TTWFdXPMPQ== X-CSE-MsgGUID: DOC66FJyTi+Zo+SuKukkhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="18857632" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Apr 2024 03:18:22 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Apr 2024 03:18:22 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 4 Apr 2024 03:18:22 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 4 Apr 2024 03:18:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Srt4h59cw49+LJmIdu5hr4ZTolT95mSLmI8iGj5+XpTDc03uZREtAimpJ4WkCKfDeo01Y2UIenVk2VMnaR+AVxmkDZ07QwUQH+drLixhGOIC43boYsWXpob2WcNLu5vCRbVWabXSRU6wio6QWNvhTLTPjZL5fMp0oe89ymjgoJ0kv0uMRjVr8GKKmItzvu4TaGncDP150GUJJqwcHxBOW/9xsUJhcXU7LiEafB1ITokVz/6EEhTOtHN7mefDEl0OPMWq/7+wBuhfR30On4NqvxEPStW0TpuAxZjZtbPH+rWs0SROBJ1KeHggmCH+uiW3jyN+flh60mYt82KP97zEvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PihcRzP1G24JnMPJFcyDNTpYmRAVCN97Z9h8NWDKnAs=; b=OD2F4F1SDUV3JnzOXWc9ABrTqzBx6AFVVEFbC1gVCJdLHzTI41nuW4MpVLEEVz0m85QWrqx60qTYIecdvnzUI3oH/NTWtv1AzOBMYVezO5DSTSNLVVttpc7PFP8Y6e3I74XVL9Y5tKbsPDn3FnOshOUFX3WpBIKbO4HOCeNh3EyEio0xqGAV8rnF0ysEjqHWGfLN47DYWSGRrQXasnrdLHmJQblCZuyxUgPrBCgGezLfEmICQnxiof4MpueFHEWtL1nA3oJzdFm7c+eOniZwQbRHUBRhIed22M2WzK3eV8y2A44QsdtrArXpPQsKrHMmG8VRcNmZTz0pRYjApTZxYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB5170.namprd11.prod.outlook.com (2603:10b6:303:91::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.26; Thu, 4 Apr 2024 10:18:20 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7452.019; Thu, 4 Apr 2024 10:18:20 +0000 Date: Thu, 4 Apr 2024 11:18:16 +0100 From: Bruce Richardson To: Julien Meunier CC: Jing Chen , Jeff Shaw , Michael Qiu , , Subject: Re: [PATCH] net/fm10k: fix cleanup during init failure Message-ID: References: <20240403115541.2369-1-julien.meunier@nokia.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240403115541.2369-1-julien.meunier@nokia.com> X-ClientProxiedBy: DUZPR01CA0169.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB5170:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cwiBbCNIs1LbyLXoSe9dRx+MselO9aLWM861j6/rGozSO6gGiZvWCQTyDSi+QBqUZV+PV+RMc1FT65Szgig/qRe9j9LKhKn9jUjlH2CE0OqNcfxiupCkPAY057Wf2YRUlmz0TGwCGmti0Kj79yiMchhKPplLLvU/uZDr0jExDFnABsCPnXkuila2gK4jGD/aUrtl8WVRMLCE9ANvhKtnjs1Pp9XSIJrap0PytsaGsGiFs8l/vKGStcVzkhvde2zWUbWttxpP08l/UYKSDWWbuaKSQpktN3dKhkdTF29p7/1w0skOW8YUF1fCDSd+49MjGzsnT6N301KuAsLCcvoCEyL5dT6AT+TVr0iXQVr6u51DDgZrHP+4TJSCiI65A5c2UAmysPKggubjvkXBq6Ne9t+WxdF9xUw2cLdnmM0Wef6pnAFwc2d8LQ5SSEdewmcAlj1uT6YAHx0v42AxourfAXrxLg8E63Ioikwz1q6h5DV0TcCpH6Z0jncPL5dP74uIoLrjI9bCvFkF/9bqV3giqpkKLj7SeCYm+E8tHxZZp6zqT129t8IrTfZC1l77E+kLHvivREp3ombqsgIAjp4ruVvD5TkPvU5LT13fYC2eTt7D+wd5FSZzfFYz2lyJJY4D5Qfwkm/zwAEUk9WNEwUFrhlf08HYl+e5hhBkmxBmRvc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P2FpyfdneVsQnEARhSxQACIek7NxFWnqSs7P8tXD1btWC14R3DDUdzn5f+G0?= =?us-ascii?Q?pFunvM6pFF9xJrz8am8bfUD394s6JQRB5mrQUtNGSR8CgNCt2WOKz2Doffby?= =?us-ascii?Q?zuGCEJ6JH6a51QxMHKv1yfPxXTF6BG3A/WkLfP5ooE8pzDL6PgI7bP7m/XYA?= =?us-ascii?Q?qo3gKUyb+pzJL1jpP6oPQ/mHg4aiaCOIvBng9iSvvTqFmCYrKeOEnSzckwGm?= =?us-ascii?Q?HHcAwUG95uDE7M0dso5Eh7EN5FcZK9wMeo3qSb4AudGzzeAswy9/zJrzzu+U?= =?us-ascii?Q?B7kTVN8HIS/FR6bIBB2X4MhAnWohe+qAi45vOgqc2DO6zHvsyi840OnHCUVO?= =?us-ascii?Q?lTRmkAg+kFGDwte1H5WUaqsMfGkaqAEQR3I2rd58GsBO0FDkCIMN5L6QP+2L?= =?us-ascii?Q?FT/XT/DirNwed3W87rLIhOSm2J7DSZitgUZaVITwxzBpHcXElyaaOmJ1elSc?= =?us-ascii?Q?CR3Rh1MufLinC/X6U5SE5xRqXspFch4gek99eo8g0Cf9+A7Mv1DKtjQ8PTmX?= =?us-ascii?Q?f+mpd1gmgQqRwRP72ddiPD/fMd/82WIhB+5Jf8tdBnQLJYwqY1Flzhv9+ZSG?= =?us-ascii?Q?9C/HcNGC0FsdI3Ch4f38fgxbzur4zm3iXae2SRVloe9pXJFpoCTwvCv4/l22?= =?us-ascii?Q?Fw44Y7khcInYXA4eIKo6z5J89SSk28UmXjzrdWzf7PkiKx0ocWzPFDfIER9x?= =?us-ascii?Q?rPeErDozMUmf9KA/maZXxcJXG5bKI5sDr7v9AjL/WuTRxnlZ9zQE++sFCkGa?= =?us-ascii?Q?HrgdWertp9sVvkJ0nvYYPbri1+xuGdJUFnBwtSNIINUa8jX07uXjWTCBS9e+?= =?us-ascii?Q?cPiuRUYbjQKyN+e9nsuz3SgYG/tFWGf/JIfSRyQcN/zWiOnpAZ+tHlXWbrBX?= =?us-ascii?Q?RDszv7dzdMh87k2eTbDOuG/Dxw/Q9T7gl5TppW83d4s+0uHZyip7PXGGv805?= =?us-ascii?Q?ib/LX+6idRNzARMMpfb+D02ddaUX9AbUTgEGU1nBueu4Z6d1B9QxnJs3R12j?= =?us-ascii?Q?41Urwi8GgV6eIxh+H3pgpMn3Ax6krmlsevEbh4uNDVwI1keYpv6cuiyHqhe+?= =?us-ascii?Q?1dkj5vaiKRFpPC4ODpkSx0DmN4DieOB9y53UoOD+HyQdvQxksosU066+edyc?= =?us-ascii?Q?oGIoxeYrdFbgC2UtZYcR3vPd0NygHPS9qw6mp2wG9B3oguIdhavW7IlrJCjt?= =?us-ascii?Q?ok+VrJHQHpOdLPJ/MKja88pQfB3EJiIvcEgW/CWhbM6LxThFtO7NTxSenIdt?= =?us-ascii?Q?DC7oIJKBJzzeEKEPeZmUstw7nLhmaoBQDEvUFpc5u/MYzZJmTnIseJG2DFha?= =?us-ascii?Q?vhBjLJfp4P0tfUM5I4qTfMS/2EicAxjFe4dIaYl771ptGkabR9WQbUxro4Dt?= =?us-ascii?Q?MympUfkHa5Rnm6zlv+WD3jcpa2l86sSHv9AAB39CmFZzmw99ArtENsxKAVWr?= =?us-ascii?Q?JHq2Tt2+cXgUFSXkh5JnjrhwUC+GRo/c/JJWzMDfT+s/2/+UmSsbKcTIhT3P?= =?us-ascii?Q?6U2Tdly+YGZFMGb6u6JV2p3pY/KTOrjW3iEiL+6yuF2NkOZXYDo3Lru8ZJZg?= =?us-ascii?Q?GA4V4vR1ddyYanC/vx4wZzPbzsWScIDWG3jQKgTQD2QSRQdZpXmm+c9ID602?= =?us-ascii?Q?eQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 00a2c0ad-cf0b-4016-4ea2-08dc54908d15 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 10:18:19.9690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 11MDUQcvYMQmQLuatSIUnTn/ePFzBIAqQoFsN0gMWlj3ElKDwPZ2y1v5qfXORL5kFItk8/zWgxkDHFjnZzqPIErSJJE6wJweHoNyLorifbk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5170 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 03, 2024 at 01:55:41PM +0200, Julien Meunier wrote: > Cleanup was not done on this PMD if a error is seen during the init: > - possible memory leak due to a missing free > - interrupt handler was not disabled: if an IRQ is received after the > init, a SIGSEGV can be seen (private data stored in > rte_eth_devices[port_id] is pointing to NULL) > > Fixes: a6061d9e7075 ("fm10k: register PF driver") > Fixes: 4c287332c39a ("fm10k: add PF and VF interrupt handling") > Cc: stable@dpdk.org > > Signed-off-by: Julien Meunier Changes LGTM Reviewed-by: Bruce Richardson