From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCCAA43DFB; Thu, 4 Apr 2024 18:55:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 963CE402E8; Thu, 4 Apr 2024 18:55:44 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 121D8402BC for ; Thu, 4 Apr 2024 18:55:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712249743; x=1743785743; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=sYvB4BTSZdtc63Xf4QkDaTOnhR3X4RsrGN1MeRCYkLY=; b=OtKyYCwVI8X6iQluXXYew8CfLG+NVbjNWNzYuMm44vCThosqKuyyxr7Q n1WLwruFV9ChpaTOwAtXex6Uuvhq29jPu7NrMOeHX8yZJhbyfdFwYLoDZ HMD54EoLuXTcAztgXZjTczSDKVlyIOX+nyDxXoJ6Vmf9BNIUO09vhwyQ1 +Sjubyw2UjSORYPXvhn2HdSacyrG569m54wucdpqHZ0hPTTu5fVOcqyD7 UF+aym51QbRMKyyta7QO4PU4YSQ/4myl2AHJh2Uq009shuXoU7Gu6bJcb RCtixkGyBroM32/ih9cimjPPMunnlr1OhV7aNpIvkLPmXrHqEbVEVJDZ5 g==; X-CSE-ConnectionGUID: c8c0egflTE+EYQ4OxchlQw== X-CSE-MsgGUID: FMQQAE8/RI6rcgOJY2v1WQ== X-IronPort-AV: E=McAfee;i="6600,9927,11034"; a="7393461" X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="7393461" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 09:55:42 -0700 X-CSE-ConnectionGUID: PxYZg1a2SRi/tpqBXVBxfQ== X-CSE-MsgGUID: BhFKpHKWRn694h/Lys2qyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="56324239" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Apr 2024 09:55:42 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Apr 2024 09:55:41 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 4 Apr 2024 09:55:41 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 4 Apr 2024 09:55:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CIOsuCOwMknL9+aRPj2rnR5++c2Gr+MYkc9Fc7i/Ixnwu1CJJP9TMBmpqzhdh1aCzghKfNVRgwWCjguJCLcmKFDupDveiQReiuwQHOtPynrQFM61Cij0l60wEwF8qXygxvV5YDtPQgZHiYpfZhw+L2kDflsryj/3aM8CjaNu9WEo6hpcRgmri+DqRpEwBHsf8kQH1haEeWJRDV75zTFQzbF+Iaf14aP9375sGgg/2LZu2ueHMQslwZ+L7WCc+SCImYq2sA9SqmF9aKVmq8F1gZknUFpmJ58tHlqC3p0qW8ym1JUts/KtgWWI6a2WiHfW+smAiNqXbeP4SJM/Ec+6Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FKKN+nCyRV4ygJe+YVpU1YpWvfXloktLBvrBc0a36KI=; b=Al0ntHV6qDcDmOBZ99g8ZGWX2lgcyp24v978xUzvsH45LUx+9RqO2hdiUH3jWLQcx8szR4t3DEmYEyUuStB71cutiM351HvvkF8D4UqNeT/NhGCkdKpQYQ+DVZ3FY7M8G1/T+JxXWxXqBJy5hG9s1OPf0tbBFpguSUM2NF3Zz312XCo39rkeRaYNxkoD1PbmTfm8aZsD+tbpRncW9rAGUaUE3T4IvYhk8AbXQYPreTa3CfvLnA1+dX1rRLFnrxxeux+AyOulPnbSWHMwZKwCG0tICVRE1ufl+sfl9bt02Xr/dr8zdlZgVaYNb0sbWk8ktKJ8fEu8oEH+oNd6ORtCoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB7942.namprd11.prod.outlook.com (2603:10b6:208:3fa::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 16:55:40 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7452.019; Thu, 4 Apr 2024 16:55:40 +0000 Date: Thu, 4 Apr 2024 17:55:36 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: Stephen Hemminger , , , Subject: Re: [PATCH v2] eal/x86: improve rte_memcpy const size 16 performance Message-ID: References: <20240302234812.9137-1-mb@smartsharesystems.com> <20240303094621.16404-1-mb@smartsharesystems.com> <98CBD80474FA8B44BF855DF32C47DC35E9F35C@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F360@smartserver.smartshare.dk> <20240404085537.21469e1f@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F361@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F361@smartserver.smartshare.dk> X-ClientProxiedBy: DU2PR04CA0218.eurprd04.prod.outlook.com (2603:10a6:10:2b1::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB7942:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AhOLuAIRvzzBAyJO0J2BUn6UBgJzFgP68GumXRVdUTDu6mvW9wFpnsgXGZsFNshonH310be/lOLtd74ntJnE0cj6nMEaUf5LbfPVyRS4oGEHsrD+EWdIyissGEO+0YBDU9yLXxuq5gvLAYiUk7C0GPK0n3qLDs3I5V/PgETwSHL7Y9e1uXLWgx8LyoqrDYEQL2YIbOBTEo1FActIjNqLwkECWrxndHMCZSXfr1m26SNs+an5IQm3MBuJI+soSbbHSwNiLmDK72P+ZFD++USi3izqA87KKIZd0kVQXCREmEDh44gvgHEcoFI/JPOCgLgCatA0X7rPODOfPqpS5tuOsTVdY+zwfEohCuhhO16/Q/nTeKLDz2d4rz08D1JaTftbb0qc6oOIpnxnBuZ/f4BwkVxlRGxe2hpaFynuig1T3ETrMWbF7yEvUlrkvFNlWPLkY8QGlvhugS3sqIwi6E8OwjZT/t9TMqwUAzIF591ZcPLfUYxpUM86+dQ/sXaK9sIccPETEtAz/MXlwGV+4lOvK/UNU+QSBAeg0YAy9b2zBbEDUU9U6EtJXhEA7d1DbNg6MMitruu2Qa7uF1tQbdzB6un2F3bFblkYS8MjKoVTc9XQUfXYO811yBBFywrwOlCp8wKvnYjgB2vE6AnGv3eg7tU/tqB2bH3fliVN91Cy1Ho= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?i0OB4C9GVOKYcHhDnVNowhIJZMQZxtTEKmeXRspvYLSp4JKDqDS2w/ADkW?= =?iso-8859-1?Q?PefFJmAK8nO99Cr2Re4AEPHHFYO32eeLguHzuyaXVa+05hyBCj1vY/K9sB?= =?iso-8859-1?Q?EAByLoa3MkeN7KZ6FRiS3nJWnELfXKw4/txrsD/rBc5IJ8W4m4t1UprgZA?= =?iso-8859-1?Q?PE2LQdIOdGMC1hYSfEOiFGYigh9ooEJn4N+svHzSzy9nDoV6S09qaOS3GB?= =?iso-8859-1?Q?0Xu1/IO3lSzgNiFEUt2esKCo2t2Em+errl+mkOuVjQMFoyZTwYk8g/x+9n?= =?iso-8859-1?Q?kTnEWDhW2bEznn4TLoIynXHdcwh8QZ95h7jXrR6A9uL21563YWGpXSHcdK?= =?iso-8859-1?Q?AmZAYWEL+um2A3JqD/356o5DZPwlt0MNP0WARi0hkOLSmfSCR7UxNuKrUl?= =?iso-8859-1?Q?i/k/oBLFhV+c1X5QgA2momsNncMfbEcEc3+K/5jrXsOan43Flk1CxnA2O/?= =?iso-8859-1?Q?Rq12taiYk4XLXKXEFvftunkF4jOdclRxweCL1Wj4gWEOmhHoxg+5WAPEaJ?= =?iso-8859-1?Q?0L95Ckwhh05uMvI+Sprt2JZqIqB8DsVLUWo/diovwGvfQOJ1WCyR5lkO4R?= =?iso-8859-1?Q?7utgzYo3O1WbAnvmjsIgTuJgNBfCf6XU6JrH8Jsz8joDqnUXNah5sky4S6?= =?iso-8859-1?Q?xbzAJh8NFZzfgITb31l/BDwhYHrRvhIufi/sOHlNOcHLAJO256E/etiBgc?= =?iso-8859-1?Q?l+FLQI8GmZTwKQN2Inj9HP6B3s96yd+BfdfP56oa560DeSXQmsfOHaBN1L?= =?iso-8859-1?Q?SeKrz+AR/ZFMZuQswVJyMLDCRYpQb707lGPmxiQ6zWPTjoZ1LFHG6ArJvM?= =?iso-8859-1?Q?nQU5R57Az0N5eAKoQDWaGvq3LqkZG9f2p7mVk0C1VCewrCUhaZdYTJEXIB?= =?iso-8859-1?Q?GTvnExpqXyZwSJLVfo2zveIKFs5Dnbp8feplN39K4r2Vpg7iGrsObG/5tD?= =?iso-8859-1?Q?dqI6Cy/CUBa7UsedOfWZ77IXGuzHg6IG5i/YI74T2Vhw5gN6bIfYdJZRLD?= =?iso-8859-1?Q?OpIi2FwhQqW2z85bpf+zJ7IxTK7HK4c+jv7L5OWuAimDw5UEfmEjyHW2Cx?= =?iso-8859-1?Q?FpxeVH2PrJEBzycgjwIBRxIrk27XL5S32zN09svQ+/rvIsn6Vreyp5v0BV?= =?iso-8859-1?Q?p7B/WeA0CSbZkitoUjJffr7pj+5G+nNBU0u2+/RB3P10OLrH6lbsx+B0pr?= =?iso-8859-1?Q?sasCg06s8GFrmvk0bPNf6mo8ESA0L+Nf2JsX8FQoZX/8/VD8QUIhgwmSoI?= =?iso-8859-1?Q?D2eNr5wyz8E33KlrLRNzTJC9Q3CzMnkx4NxqtXryC9VtP1FY0bjorP9471?= =?iso-8859-1?Q?JxEC1mpwH6/xNmzRSzV8rqciK5LN3+94j1yfQ7gA2dICvwasuNX+D+OP/l?= =?iso-8859-1?Q?yqEWsRfuTO3J1i0DiyhSGQa8YwynqTLjf1H9tTxyxf4qjsI4955mqYrS6L?= =?iso-8859-1?Q?LeUJwEdb26cIY4Q2P3z25En1bGdwAOao0Lofso/EYDwBEYRBC7bXGSnd5J?= =?iso-8859-1?Q?2pB0UGKuim353fq3dAaYLbIXn9IT2BrXb5eG0ALWF77L7HgbHXnZuSDrnL?= =?iso-8859-1?Q?xYBGoCsAitXg6lJCLa+TGuvWJS1PMdwJUaSXT/YjYCMWacnFkDcN83/p0a?= =?iso-8859-1?Q?XcUyI6gQl2DcBkGGqG3h3k6/GJ/V6KKppodreQEIXb7JSAexDaQn+fYw?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0d9e9d5d-a9d4-4e16-2265-08dc54c80ee6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 16:55:40.2034 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dUOx54OxOpGo39QIt0CJfgy7ijvIBZExlzktAfx/CjUceJka5wcAw7StUNXTdlVEHYp4FvnBOiyLE2Queh7CzL90NWUgZwOtJs+PIJBHYpY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7942 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 04, 2024 at 06:10:32PM +0200, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Thursday, 4 April 2024 17.56 > > > > On Thu, 4 Apr 2024 17:37:53 +0200 > > Morten Brørup wrote: > > > > > > I would tend to agree with Stephen that whereever possible we should use > > > > the built-in memcpy calls. Hence my suggestion of re-introducing the > > macro. > > > > > > I agree in principle, but strongly prefer data to back up such changes in > > the fast path. > > > > > > godbolt.org shows same instructions for the cases I looked at. > > Such a fundamental change belongs in a separate patch, with a description of what has been confirmed to generate same instructions or otherwise tested. > On behalf of the distros, I'm mostly worried about older compilers. > > Anyway, this patch also tidies up the code, removing a lot of copy-paste, so I think we should go ahead with this patch first. > I agree. Best to keep such changes in separate patches.