Re: [PATCH] igc/ixgbe: add get/set link settings interface

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Mar 26, 2024 at 04:59:07PM -0700, Marek Pazdan wrote:
> There are link settings parameters available from PMD drivers level
> which are currently not exposed to the user via consistent interface.
> When interface is available for system level those information can
> be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINKSETTINGS/
> ETHTOOL_GLINKSETTINGS). There are use cases where
> physical interface is passthrough to dpdk driver and is not available
> from system level. Information provided by ioctl carries information
> useful for link auto negotiation settings among others.
> Additionally dpdk-testpmd application has been extended to provided
> testing tool for newly implemtented interface functions.
> 
> Signed-off-by: Marek Pazdan <mpazdan@arista.com>
> ---
>  .mailmap                           |   1 +
>  app/test-pmd/cmdline.c             |   9 +
>  app/test-pmd/cmdline_settings.c    | 516 +++++++++++++++++++++++++++++
>  app/test-pmd/cmdline_settings.h    |  14 +
>  app/test-pmd/meson.build           |   1 +
>  app/test-pmd/testpmd.h             |   1 +
>  app/test-pmd/util.c                |  10 +
>  drivers/net/igc/igc_ethdev.c       | 229 ++++++++++++-
>  drivers/net/ixgbe/base/ixgbe_phy.h |   7 +
>  drivers/net/ixgbe/ixgbe_ethdev.c   | 395 ++++++++++++++++++++++
>  lib/ethdev/ethdev_driver.h         |  33 ++
>  lib/ethdev/rte_ethdev.c            |  26 ++
>  lib/ethdev/rte_ethdev.h            | 215 +++++++++++-
>  lib/ethdev/version.map             |   3 +
>  14 files changed, 1450 insertions(+), 10 deletions(-)
>  create mode 100644 app/test-pmd/cmdline_settings.c
>  create mode 100644 app/test-pmd/cmdline_settings.h
> 

Hi Marek,

it seems this patch is not just for igc and ixgbe drivers, but is adding a
new feature and pair of functions to ethdev, correct? In order to simplify
review, can you please split this patch up into multiple patches based on
component, for example, ethdev hooks, then testpmd calls using those hooks
and finally the individual driver changes to implement the new functions.
Even the driver changes could probably be omitted, if you want, for the
early versions of the patchset, as we'd need to get agreement on the ethdev
APIs before looking at specific implementations in detail.

Thanks for the contribution,

/Bruce