From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7020743E04; Fri, 5 Apr 2024 11:11:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EA1C402D4; Fri, 5 Apr 2024 11:11:55 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id ACD25402CE for ; Fri, 5 Apr 2024 11:11:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712308314; x=1743844314; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=guIcYGVr+zQbvbwJNVTJyw1JO8Q6+yw7A4nTGAjo5cM=; b=DG5Kg8EBHty+jhVuwaCxIQGSPh/5iUUlEgcKdhz3knlW6RBSILNBheAo 8KAdbmtcbn2HheligT0vq9A9TIW6uh76CKoIBShMHoU8HFVrSR6dRsnC0 z7D6qa2gnIrKdFLNq/ddLVOxo/HeFpNI4rleak2+NYu8S03fver0MUPST 1nzU3XiEwJCn/wrUWDBsWeWUFhvkc4ZTgmzWJsCex9RuVxwM47SYTbisB 3TyKjOKw6KipZ3KK/4bnPvsMvnVeZLzinytvWn8l6CUVfeKBvL0MxgyW3 5s967a+DN9F0mrFztGdThs36ZWR0vRZ7fHK1FJG2X7Xz75G8kY5aOzIxE Q==; X-CSE-ConnectionGUID: C32FQpMqT5SbSXgLJ7UdYw== X-CSE-MsgGUID: iJgg74P4RN2XnbG3Lt5KSw== X-IronPort-AV: E=McAfee;i="6600,9927,11034"; a="33025853" X-IronPort-AV: E=Sophos;i="6.07,181,1708416000"; d="scan'208";a="33025853" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2024 02:11:53 -0700 X-CSE-ConnectionGUID: pMoW5nntTAi5mYyspDq9Aw== X-CSE-MsgGUID: 3smMyRPUQt+NMPO6UXN2cg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,181,1708416000"; d="scan'208";a="18975806" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Apr 2024 02:11:52 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 5 Apr 2024 02:11:52 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 5 Apr 2024 02:11:52 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 5 Apr 2024 02:11:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fHo+uQIVnaQmTDPiUunWo3pgszxKfJU5vL4FGNA3RLog7mlhuNoEJipNhOEmPIJkj3HhIrVjCCph8WKaXDMX/RGgB+7V+81KuHhDTgZu4Acwnb3+v5HYZ+O4lfjqyPd6FI6jsp3udvre6cNKf1DOC/hXyIB01VGk2fraf2Xavc0zhwk3LBDvGj+AXJiAY4TrhWi9dTuTYKW179Y8xtuMnm44xk789JZGptAmbHDpHhzT5bMaht8GvlTwP92RahMCjleyGDoTled7TX8BS+KzIAiMgUbqcQxU0+jk8YBEeCj4G9KGMrWZg0SbZptt2pyeiepyUjCRznnizNkbmb0E4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZVV3MslV9KyJ19p4icpwuQv+8VH9ILCqUZmsyoM2kcI=; b=CAbEDyy0pVkWRDlte3F2JhrFyOropTljpyR1KMI3q4OCgAwGlAcQEQWcnk7S4dAK5l05M73Nri6vwmKnptcodpTbfkysgM1auvB/CvynGJokyubHQVeWyG1+wjV6n8h/Bh44xz8s9pgnha1m8ev3sGNBTSVYRyBNHxvC/WvX8Mn8t7qpuNZIkbasi6AXISrpSMDO77f4cRW9vj8J3a6ZwNt9Z547ffn2Y3U5wBUDY7ArihUI9/42xf8RhzUIQzf4R6w3djU2BRZKRMT1Jis2O5ttQb9Jd2BUGpqdWDxvRzFChWGIpW+ymy2Nh+lHHpz9m6kEX7mj5uf9c092OpnNuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW3PR11MB4617.namprd11.prod.outlook.com (2603:10b6:303:59::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.26; Fri, 5 Apr 2024 09:11:50 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7452.019; Fri, 5 Apr 2024 09:11:50 +0000 Date: Fri, 5 Apr 2024 10:11:46 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: , Harman Kalra Subject: Re: [PATCH v2 2/2] buildtools: when building static library use static deps Message-ID: References: <1710445477-23848-1-git-send-email-roretzla@linux.microsoft.com> <1710484222-17310-1-git-send-email-roretzla@linux.microsoft.com> <1710484222-17310-3-git-send-email-roretzla@linux.microsoft.com> <20240404184749.GA12913@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240404184749.GA12913@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-ClientProxiedBy: DUZPR01CA0150.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bd::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW3PR11MB4617:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f4bGwaWeuqxaXGHnAj3NndTNEgCWvojGzaDBHWJXomQEVWrtQjTy/h3jLChZ7O8+DWGROvi1Qvtv4OCz9jxcBB7J8KDfAHMs+/9R9KpLfirVzxLR/TC2ETwmsocEsHTzTeSkOVuImPYbC/gvNbwn3FL8kgRuvjIDY+rgGq7Qm0zGzlzRLpC1NS1StAhQPZS8+PmtZEf+NJouaUE5AdzShg6KuzxzGG+zpJJUNaepaG+faGrXXdV/sZrj1IrXx+aW2dqow8zknWthL3DhauXu3VVG2nmsySDmLPya50DTG3rLAdgh5k6OKQQ0ooacEKwhdfH7Fzs6VgMzfWWFAp30zlc9ZBMgbVGZu1ZJR8KbD6++Ribu3suk18A9R7p7585SnurGaptrBPvSZxP7Jhk8lnpgHgKjcAeA26J1sv76p+Rm99tmMhEgnghy8kSWSwMDk6ZTaqdCvXe+b7nfrskt3M2/zn7u/uaYj/qKY8E6Q74C/ckcoJLVRJIjF9enryO9tz22nAlf5Tt2JgYm+xwzleYpMce/2/rBL6iqomlhhzosf6JlJfK7P9OrGUpAocJWZ9WBXkTjsA1FbMu1GKBlGUyyhjxpLLiamFEgl88HWVmHgk1WfCsQj14Jd9MjJcvqWcV3TK3denSCJdjZ76YSVTTysg50PJJ58hMJ0ExgUoE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5mP0uLAlR3GpzKzRT+RDv4I7CETcA8269YwqYF3OpgZtnxf3boU1c+rkeze/?= =?us-ascii?Q?g/MUz6baTQZ3fBPUmAiBeo9wvOSAAq9bAolKQZFBOhP3wOLs98Gy5UdCMPE3?= =?us-ascii?Q?YQDYVDssDLNuKG/G0bAt1Y9Dphn0AN7kSqA/i6ZBDsB3HIpOqPRSfAdHyCU3?= =?us-ascii?Q?8UjrIxzPdUtLqNxIZyetothFzs16beDGh3POWXqZxk97XlyvwNbegWW2eyX6?= =?us-ascii?Q?xsJ2hHVtYqy0R2fDSUJdzpe4dIXWtakA/QoOifSFzI/DlzJOGHM3/M7EUKjU?= =?us-ascii?Q?PO8MniPG1OeqTir8s6sEMlw1zED+AqSJWZVk591e4coYtsulMVTPAU1rQ6bm?= =?us-ascii?Q?QPj6z4+6X/tU0s+14IOkGtpr0dwcU9UPuXTDxLUH6Jw71Q4WoLBUZHjiSidT?= =?us-ascii?Q?HaE/ZgwZlm1y8yTWFYfheVglmW0ybMdnQ9Hi7y3UxTJcxqvmUYuVen8wiiL+?= =?us-ascii?Q?6VOPCp48WPD2qp6xl2ovyiW+KHOExFYdZVzpN1jJIC87QlZvP5Zp/7qipJCT?= =?us-ascii?Q?gS3OgkZ9xn1GAQSdT6bjH0486umIjkMbao+6p1TJEfd55C11sCCtL2MONq2F?= =?us-ascii?Q?Ak4s8sv+O2Vebw/9zX1dC/jQjo7MibF9wlSJKi3rA5aQWcJVdzSwScpgZpSs?= =?us-ascii?Q?zt19d0gtZj9sCWs+lRm+tfF1nGZNxQKXI9jSFFYGEK99f+uAhQjs4LKIb7H3?= =?us-ascii?Q?b7bGEPs3nynt3VJKMUYD34hUX0A8qQm7qC0/umjVqXb6dOA97wDSufhkWNML?= =?us-ascii?Q?qfS9gs4p/pgl/sd3EQw8SHUKbJSsCtG17i1gE/+c4xrva/IeutZkPi8EmZ6s?= =?us-ascii?Q?/aA5K7XXWo2cdwTKtBXtB62A0+QOxwinW7PQFrOUyAb7p7VOWV+qRQVjAtxz?= =?us-ascii?Q?nWkeetrhkxRaxhb24J7zeTL4CyHehV45177MtA3aa5rCN49XCJT/yctarbKz?= =?us-ascii?Q?WlEBt0L11XD7MpGCKohl2/Q/1MR7135qB8n42yklMwgmYSSd09JCNIrHXVEr?= =?us-ascii?Q?nMLNnmsjhHOoxT+TCdb6Erf1Xi4W48JtoANja4CAvv6BaersZ1rLa4rTy6It?= =?us-ascii?Q?1cUfMDIB5Fa9WcDaFTgncbBcwqAjK4V0HHE/AK0QMM5icJvSTDFHp/iSENU0?= =?us-ascii?Q?uloHaMWOBj7MLl/iOaEiabNYWpz3yU1QgFHdxLe081Ru4Gg1s8mh2Zp/+S52?= =?us-ascii?Q?3jv0UEmsadV8Kilj4JLnTiJIB867zXnT9TyALC1ln/k6/Xs4E1hr2qJC+8KD?= =?us-ascii?Q?xSUtLYpbc7GbMHVTLePk1Bg8rLQwEf6GqcjAet0U4ZGSY1jrpXNq/CY1Q4Ke?= =?us-ascii?Q?xxPHC1NfBodBcNvl6jPBwYEL799FS0eSNbsIcLHq8wVuMfmY2TWsGz5ISOLq?= =?us-ascii?Q?d5ewoJKoXz2zZh4Hhyv19uO4qDxL1lLJvsc53RQsVr2HeNvUBVPp3Z4wlvP6?= =?us-ascii?Q?eVk6GAfffRccSMbcTrCWI8M20GLsKiHV9LaLwD+6mkr3RnXivqx4nsLgoRaU?= =?us-ascii?Q?Kk2r+27OtYEGfKD6sZ64bUxw1WZpSALPSW6sC62/obJRfwaJa906U+Z6i/nh?= =?us-ascii?Q?MQjZp4wxWFcgfmtwRzPzU/r5cWGkG/zNCHAjHWvEPyK6o89QoOhNNj3DXo/0?= =?us-ascii?Q?Cw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1852395e-1c03-4b7b-6d8b-08dc55506d3e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 09:11:50.0512 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2W9WYVQLUMokUJMOPoRAfKBNUtXnXYaLylVKcTAT7rewFVifRFlq8PQXcq4XiIdANj8bnUDTbh27nEk7mgDU1Y3ETDWQbLE+OytcM0Bc9hM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4617 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 04, 2024 at 11:47:49AM -0700, Tyler Retzlaff wrote: > On Fri, Mar 15, 2024 at 08:28:55AM +0000, Bruce Richardson wrote: > > On Thu, Mar 14, 2024 at 11:30:22PM -0700, Tyler Retzlaff wrote: > > > Use static deps when default_library=static and use shared deps when > > > using default_library=shared. > > > > > > Signed-off-by: Tyler Retzlaff > > > --- > > > buildtools/chkincs/meson.build | 18 +++++++++++++----- > > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > > > diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build > > > index f2dadca..66245a5 100644 > > > --- a/buildtools/chkincs/meson.build > > > +++ b/buildtools/chkincs/meson.build > > > @@ -20,11 +20,19 @@ sources += gen_c_files.process(dpdk_chkinc_headers) > > > > > > # some driver SDK headers depend on these two buses, which are mandatory in build > > > # so we always include them in deps list > > > -deps = [get_variable('shared_rte_bus_vdev'), get_variable('shared_rte_bus_pci')] > > > -# add the rest of the libs to the dependencies > > > -foreach l:dpdk_libs_enabled > > > - deps += get_variable('shared_rte_' + l) > > > -endforeach > > > +if is_shared_enabled > > > + deps = [get_variable('shared_rte_bus_vdev'), get_variable('shared_rte_bus_pci')] > > > + # add the rest of the libs to the dependencies > > > + foreach l:dpdk_libs_enabled > > > + deps += get_variable('shared_rte_' + l) > > > + endforeach > > > +else > > > + deps = [get_variable('static_rte_bus_vdev'), get_variable('static_rte_bus_pci')] > > > + # add the rest of the libs to the dependencies > > > + foreach l:dpdk_libs_enabled > > > + deps += get_variable('static_rte_' + l) > > > + endforeach > > > +endif > > > > > > > Should the deps checks in lib and driver not be similarly conditional? > > i might need more context about what you think is wrong. i think the > problem here was that there are not separate variables for shared_deps > vs static_deps. > > for my changes to lib/meson.build there's already a separate shared_deps > and static_deps variables holding the deps that are used with > shared_library and static_library respectively. > > ty > Not sure I know the context of the question myself, but your answer certainly seems reasonable. :-) Thanks.