From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E9C443DC3; Tue, 2 Apr 2024 18:10:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 174FA4028C; Tue, 2 Apr 2024 18:10:25 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 9325E4026F; Tue, 2 Apr 2024 18:10:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712074223; x=1743610223; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=tcFc5QWtEIt7yOe7CjQCLGMGFywu3eYCmld6sx1beYg=; b=egvXdLwSK+p1nddKd9lyO+GSz1tgfBGelNhSHnx0DwrZFpz8NZOybWrj rbuy6RQf6U+ZrIViy8rIj1pY8OgcrS9plZQi3jiL+B7kiBwT2Txms5HPv AmNd7f/ksqIEd5hoVEga0fPAXOpb22VZmSXc9MrnbmOQwXVX6/xfiZMV1 wUEaUH1TC94gkil+QTc9Ry6JmufBegULh7CCXzJx0aY1dpDgzvePl7OmJ KOxzkJMKZra0Nor4592KY1lhlMLrCZ4/+QkIyCui/TJ/tbpc0HxrfvN6L vV1vh4yubMGGVy6OC/7Q9x0hQkm+FEpuAZqMxYVWZAtds8fitxT7MjiBS Q==; X-CSE-ConnectionGUID: Q0UEn6mqQOyK3JO/aM64gg== X-CSE-MsgGUID: /MgnX1wATlGOi+PgEirgqw== X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="7109189" X-IronPort-AV: E=Sophos;i="6.07,175,1708416000"; d="scan'208";a="7109189" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2024 09:10:16 -0700 X-CSE-ConnectionGUID: aHgegnBVRjSm9MwGzMyAXw== X-CSE-MsgGUID: KVuvNKgYR8CK8kJKoKvHyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,175,1708416000"; d="scan'208";a="18108425" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Apr 2024 09:10:16 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 2 Apr 2024 09:10:15 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 2 Apr 2024 09:10:15 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 2 Apr 2024 09:10:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F6TCHKaiKfjj84OnVjoDIYLjCM7hREkaa/C8pI8wXl1ph4uGFQnQyP5Dmax35Q3PoHGIcyDzKywgUcy4F1Y61ePh8fjLWrEsn3rSSur1omUkGPLa0eTP7fjDN3Jgh4if3by7WlESMk5NR26KkHBW/ERgfwstd6/hmo26bUqWIAPGPXQ+NEhSKEXwamH9Rc4pLemjjJo2tbno2M9sl9H5UINTQJAqx6H4THXPeg15DRbmKCmEn/mXbakDPMf5jksBhqiHtebDm8Z4ijYRqYKuAnNyYWzM+nbDu8IIRneELKhTzKYAQnUoZHrI6OkYT/1yGgq08hocLmM+eroENWYs+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9t28h8BzTy10iEDudxyfTtnKhtpmqOC1oNCrLphU1dk=; b=kX68J9UOLYTQW/YZiChde2tB2yY4H+rkZtztEUr6MRuTazBb0U6sPraR3zw8Rj7HVCUEMkHjX5D/F9PA8Fq5d/XA42FmBvQA8hS9stir57LtmjtFIvehx0djllKIxVwMkVOhTMvwRw3SWX2ZQnF5EmGZJL06sIMxYZ4KTf6GVKdmAcmCRmMIhwsyPt8E5NAYBGvjm7+GBYDZ2iHH/LjbVnP2WLhNetka/PhJI/uU9Nw4TS/15bhdY9cSy6GaCnIw3s8UwO9pHp+YbzDqXWE05dx2RTGdH/ZJACE0g4Ww0sa9DIq0NAntS0OUb6Pdi2nLi6pnIZ5GgZZvAV5I02wOsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB5032.namprd11.prod.outlook.com (2603:10b6:510:3a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.33; Tue, 2 Apr 2024 16:10:13 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7452.019; Tue, 2 Apr 2024 16:10:13 +0000 Date: Tue, 2 Apr 2024 17:10:09 +0100 From: Bruce Richardson To: Ashish Sadanandan CC: , Thomas Monjalon , , Subject: Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h Message-ID: References: <20240202051335.776290-1-ashish.sadanandan@gmail.com> <20240318024415.555614-1-ashish.sadanandan@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240318024415.555614-1-ashish.sadanandan@gmail.com> X-ClientProxiedBy: DUZP191CA0068.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4fa::29) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB5032:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dhevafTvDruEMLS3jO6Wtaib0Sqe290w4ZcsAOKnzJp5dBTXRngy4upax6AU29Jz9gfEJFFMM3Ft/M5XWGDI3y6dCGf1q+ESV3ZV5aR2BBtqot773JdT07O6AtXxSDatGrqL5gBsJ98VXW3p0nYyAxNy63tR4vVQQVGQJFo3fKcliZQ9c8GWYt9RE6DcxL2g6kXmEt540E3QEtCafrAITTSA22vpn+4373DhfY0uoAQUzLqsOEgoNVGcrMJ9X1IKlaeF8d3BaWJ4JCpdc+Jlou5MCrAvwbHhp5dCJr9Y54uDGnAt1C9lu/jOnUKNofOzjDNNq83aZY18f+5HKlG3qVZ0H+xBfVAlsY1atVDl2V8+F3XYsadSe5ZmK2xCMx3IR6M3Y3XEtkDf0KH51atdR0L3ZcFqqJ7a6pbHWS2RpBBniIsbHoUlKE8MRCDmVZZt3W5N4SAF+KZ2y9NXlq+Iwz2p2o9VOKu0vOR+5ZmqmaMQ/UuPqrRFs1ZX53W081VMQTAT6OHzjbioZ5+XMCmOD398bJHfT5Zaz/NVhMZ0vk2xsFxzM1mhMC2LE7QSifnwyRmrOxehtq4YB8bEJsxKOIO0UxxsZE60vfZPfmvjEXdLpIEqsZmrmT5cxSu18VXYa3JfYTshXFYYA4rHpcVecQR5sSutyEuNKyDHV/+Ip3Q= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hKhuUdEDYS0P9lZZWREcxL8moAoJtZcLeHmRpzl7Fi8efel53nZdVkk82ZkA?= =?us-ascii?Q?6c7INHpjk9NgU7OGTUaStY2p9dHKOxsfIF8YHbl+v2uMweGjFLYAXFoNi2Xp?= =?us-ascii?Q?ZVeIw74AZhfghtwRS0zNKIhZ8a9W2CaBHpOZVak5DKNP7zwu2vcdOB3L/Uvi?= =?us-ascii?Q?VER7oBoMiIdzlsrjaqhYflFfjNcrrIjSHDvIQwhj/ATn+WiH/oRlOaSJI4fE?= =?us-ascii?Q?iqo7EAzlk78fvioa4ynFPqMXXYLjvnMbn81p8pSIxmx9gmHBNJV5ZAIcWLJo?= =?us-ascii?Q?oeWv3zw/SwtMv92Lc+cC3eup/1PxMSLiLwLuWtUU+0APBfdagROD6zeg1Z4m?= =?us-ascii?Q?Wwp5fZYtmaWrvviQtGM0NbnPTVDUYuCrmkhiufu/kJF1X3OW4R4XYi9HAtN9?= =?us-ascii?Q?XwCxTyBM98eOx30Rsg+au+qsH4O2XbkNiksZCxI0RzDYoKlqZXuRrnUL8Gpy?= =?us-ascii?Q?V8/vfGtiX0bWBDjzQsyr5UCwrmnXP21QFzIe7O0OqO3m+6hZnZC9FL7MjheL?= =?us-ascii?Q?whUCjK9IMlrQQ2gHcsyI2RY31IvUVC0WNvJkAEZcsskyl3UAo/IQk+wOCnsB?= =?us-ascii?Q?kk7Fz+WM6gQU/Qb89v4w+zFcdHRUobRIeG83IpI6+FRaFbg1tBb+uTWad8/3?= =?us-ascii?Q?7tYUiOA8cGIhk/q8B2A3WQuvwIN3kfcCG4rw/exCM3FYJz7p4HXUEpWhflM5?= =?us-ascii?Q?gYb85G9ROj5UriiDtKzNC6XP8+4CIijX7kAmwxM9NqVEQzn+oY2xMR9WolR7?= =?us-ascii?Q?QbceUiGaAWxHf7gK9u7uyJq1zP6ZwJauY7qYajS7f0TEtJeET4Qu8wUQTy1c?= =?us-ascii?Q?p1XWNBly9Os/NX1U3OTavJUbpw4Lp7iSBxGYxbA7rEa4S84Rg9gaQlagk9r3?= =?us-ascii?Q?gmKUYJN1op4cTBlUX2FAxAVZHHhu99kelho8hgzwg0cEM2tqY0eO7aFiuBa5?= =?us-ascii?Q?A1vsimVqfwnQsO68qxZ3eWf3vnhuSCncdCvDNnK6oNEYPNhN/0Avm3yKHjN0?= =?us-ascii?Q?PutWpbwPh1GVw/jEjIYnLD69BRErI9SO38t6oIbeufeumlQELRTS8TNjmDGl?= =?us-ascii?Q?btH81/DEbSkRhxbsH9TOLomjHGxys7NKr5/SmO+Qu3l/L/wcc0KJLzgyEaKS?= =?us-ascii?Q?+KF9m3YXOymAq/3UXv1FqA5KsAQnHbJstX7gFaTOw5r73P4wJqY0ri3jryvo?= =?us-ascii?Q?tbBBhMfV2/SgTilGU8C7/djsVHWmj1dIX0x9LuN+oIVh4IfcUSGtg+cKO5Mz?= =?us-ascii?Q?57PNMQEHCbU+ZqovOt0KP5vM/Q2F5DMTpVpsLCYBJ5OTRCse884sNj8S8fQS?= =?us-ascii?Q?WR/I7JWRjDVQ55/iZml/DsqdDSaQOPUgIj51qLz2NARw0XlYuRIMMK4FHTOf?= =?us-ascii?Q?ViawtpxmWxT5kHws3n2nZeXQX49qxeTFL28eTjhgU/oTBeb+YRp0krr8p/Pm?= =?us-ascii?Q?if2QzSERyJse8YzXXLxL1aviULRoP8AXMsqtwhDJBvpX+tx3h4KLwJ7pxjsP?= =?us-ascii?Q?JVNenESj/txYK6iEUAof541gKHNxtdJ+ryGtzQwaeetshieS2xcUTg3H4YMs?= =?us-ascii?Q?FLgctAIsXBGZ2lHy6P+Ktp7Nc3gw5mdDopq+wrbOSyLr+9KBrASvKPPjabqu?= =?us-ascii?Q?4A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 104838ca-b00f-4e12-2105-08dc532f6105 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 16:10:13.7179 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T3klnx6sbE1FICTPcc8FtSZqw3PBZGKKpPLjIVtYurGntZhGe2cgrfBgMVTun/sXXBPe5yxg6Ms+2QmDYk9qSUbUfmdOqSG7KaJq9RalMZg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5032 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Mar 17, 2024 at 08:44:15PM -0600, Ashish Sadanandan wrote: > The header was missing the extern "C" directive which causes name > mangling of functions by C++ compilers, leading to linker errors > complaining of undefined references to these functions. > > Also updated the coding style contribution guideline with a new > "Language Linkage" section stating `extern "C"` block should be added to > public headers. > > Fixes: 86c743cf9140 ("eal: define generic vector types") > Cc: nelio.laranjeiro@6wind.com > Cc: stable@dpdk.org > > Signed-off-by: Ashish Sadanandan > --- Acked-by: Bruce Richardson