From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FC3043E7C; Mon, 15 Apr 2024 19:24:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B9594021E; Mon, 15 Apr 2024 19:24:21 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 0B0FD400EF for ; Mon, 15 Apr 2024 19:24:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713201858; x=1744737858; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=uaMWPLq6pmJGbuFZDG6Dq6oDg/b7R+wzIe1TX6HChlY=; b=kEArxa2i6qIdy0aXncGla6XED3t4JzDSmLt8gi3DeFF2+BCe1KopO6W3 CawM6yilihlmDQioY9X6w9D9ncNx85mYPXH1TyQl4YUlYYOswNkHX5B17 HaGaNb59NbIT3IxdEcH7MyCdJTSTkGp5Gf6Yp8K5yh/rWsiBE+QphNhtB 7jJZs36TUTHU8jJabZQ4+7qhej3V193yqnH3BjocWm1DhVsl6sMj+RqtA M84fh3743SA+GdhdwRmDMoAwf+Et35xQZnMqpTEmTKP7X6a5/XPkFopb6 fgDXh9zRhxb3eupYd5q16ZeQq2SCJ/soz5qXtSXy9nKralh/d7L3PPn0c A==; X-CSE-ConnectionGUID: d+bleEg8R024YBbMMoqkzg== X-CSE-MsgGUID: R5UvWuYUT8GlTB3Av9nbYg== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="8439753" X-IronPort-AV: E=Sophos;i="6.07,203,1708416000"; d="scan'208";a="8439753" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 10:24:17 -0700 X-CSE-ConnectionGUID: 8lRpdO/TSSKMYc43WN7PlA== X-CSE-MsgGUID: MpZAnOUDQ7Kl1fAAhvshcw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,203,1708416000"; d="scan'208";a="59425143" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Apr 2024 10:24:18 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 15 Apr 2024 10:24:17 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 15 Apr 2024 10:24:17 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 15 Apr 2024 10:24:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ej/r4M06SlG+6ePqmSFa8gsBVZhGxuGE0AVDwC9zxq7f9OIj79foQPZXXaPIy+q9f7iOG9HEmGI0z9vOUgu+6/1G1gvMWPxj8qHHMbGm5c9d0a1u/6BNOhKgOAClekEYToY+qBRpoc0bY5ekqGDeI6rXkS7EXs3rf+fO+/6WzDt6O13TOj4S2i/rIvMrHR8Wd28zrkOIfbPl7BbtGgw8yBIDXAihbvJ9+eRwU6TVV6FratQsMYeVyXNnByvz6u2xBRFvadDRWXGfhyinXC6jT6zB0LmXE8e7KP7x0R1c9Pu0ppZBHwKkrGP5ITWxIVsgKdi8i6YCPS07jjOQBA1Smw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rSu+euqJXwXrr5BqgBCGJHd4U60VdOEzzr58EC5xM2U=; b=QVWI5/ybsseG0lTPFQzuDOBidjWU4YK8LPsXhwPBnGGTKKY5n923xfgVNiNCZnOpLsixrrbTSID0zMvf2Gky+ptsqvCX0BeO8DXjviEilAeZVNfHEMgQAmKrqEzmtspDJEhR41Xq2fauKXhlw9UH7P/GB6EOo1iflpdJcs8SZ9tKL9tQ2RndJCYbBjbvo5vgGCPWAi7hdLbtJfepU4aILr1qkw4CZRPk9q7qbIFW0+kD/TRQX0O5tOR5GSkPCue5XDASoTfDaWU0mqfOKP4TqOa2cGPMprqHmc2rYgvgkTptjm1nXiwT2LqMN2WpY7Szwm+s5t26A6eHvaIcfuUfGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB7085.namprd11.prod.outlook.com (2603:10b6:806:2ba::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.31; Mon, 15 Apr 2024 17:24:14 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7472.025; Mon, 15 Apr 2024 17:24:14 +0000 Date: Mon, 15 Apr 2024 18:24:10 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: , Harman Kalra Subject: Re: [PATCH v5 1/2] build: build only one library type on Windows Message-ID: References: <1710445477-23848-1-git-send-email-roretzla@linux.microsoft.com> <1713201168-2233-1-git-send-email-roretzla@linux.microsoft.com> <1713201168-2233-2-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1713201168-2233-2-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: PR1P264CA0118.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2cd::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB7085:EE_ X-MS-Office365-Filtering-Correlation-Id: c1d14151-9579-43b7-c355-08dc5d70df6e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sSeLIxJDXLg1xf7r2iOkbx/gXWG7xFA9kq6ySCOEVZIfFFBC8vpOvxyJIVcqPKCrrYnNKphnFixWf+ACJHcpVxPKefe1RE87uUMFtsr111mvAumlEWY+c/prLhpLbUzZxqypsey2Bkkgoyf4Ff8o6U6ksqqr8cXzD6tHpZYJznxKFiMPMtdvIh1uI+WERVSL1idrHHdhfJTpb9KfFrbK6ADatAD4XGlz/J+J06d9cGOQi1lNC32nOuG3UBnytUFmC5o2U46Ml23lAE+if4bWVRmKHTnk0XvawA8pMd5p26o8aJmoZAl+S99lWj9qEn1vqXErlVIDl6y8xl3W3IG6mapbmmjl5oMGQmPQkgDzJ7KSyWvid4Jglrk8uqC/2TXTrvFHhXYWvdii/QBsARpHGRLPYdnE+5emjezO2AVyCP+124o580AmqMUZcX51uxvgTKfFcUnkMHlVe9qWqZN/Abg7ob05lcRvXZxMoRjACh2atyEVxCE1AcrpTOEG61hGOjH5TNTgwnixKuCNWXdxsfYuChREG3NSFgirTCUD2/UhDnKQ3yE5b0lq23y5N92aRMkeI/TQ+xs4doq5ZWG0woulQFxGQOANxOU4iRZhJFYC33YFqm9KLiGP6mP0exqOgu9u86Sv/yutix/x/4l9OtIjNwfGxSqgl1DWuL/xjgo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YE/DjaMIM/GyZWUGZk1mqmiVUGtlBnwn1bUvcgP3nH1wkHl4fP2j8F2/4DKl?= =?us-ascii?Q?Thvd8EDA748QHXnSPKfGMw1D7GaJTxMKq372a8MEVpfYYyHZCxBxDFF42ZCe?= =?us-ascii?Q?dCZInDBIvIT6MdnAPAlls2FCndRlcSjbS4x3dLWU1ELsbh6/D8Px1KX71TZE?= =?us-ascii?Q?ZGflGhfNiYu8Cxy1pJNx+I9lvjhXddegEfoEmXvoq7XV7S/rTPcRByEcwCRR?= =?us-ascii?Q?9/dU3Wl/+vLX5NPKXtlLEC/sejChmiBVZIW4oV/KZiqi0vVydmsWVwlEfPPd?= =?us-ascii?Q?5Anw8hNtM457FJXCG6SXvGcNPvqHrHmfzle11hM7mLIdBCocWp3qctFWZYxA?= =?us-ascii?Q?4sMFPOEDTOF7iO6zj0DIVPpwqZa/eMgapklZl1ZRJ0T0edOvdqCRH7lpg4qd?= =?us-ascii?Q?ss51ypHstkphyNoooMMWZwErZY5sIQOaJVcsvduMx1GueyEQSwXfrciruNbE?= =?us-ascii?Q?2Sz3WQxWHgRPk2ELz7GEHoKsrh/KjYHmipvgHSky+CfwJ3PUsu/IsQCQcxTO?= =?us-ascii?Q?N2suVqGDlmKMHpdpHoKPnsvfMHH0kXwRWF6hYmiV8YijhNgWO5q/dW2vI+Cb?= =?us-ascii?Q?bPKCNZa+PSmexeaS85AK8fVkSWCjBqiVeKIsZEWuw5ELbhRzMjsPifiGBsQI?= =?us-ascii?Q?h1Qj9nIJwGVrDVLXGus0mVss/kOLeWnVEv2l8Rk5iBE+VQP3SDrtYULR0flu?= =?us-ascii?Q?4TCwACdkEvFZu00ZtDzsps4W/Tckh1Q0t0vTvuUSwLPrdnPUFwMunoZQHkPN?= =?us-ascii?Q?gQZg60WwQeIiOKg+82TQMOXzJu3BIw1VW8OzHRHzVq5hkRlRAnLLjZKbtcpy?= =?us-ascii?Q?J65Y7GDNcdwi1dPMnUBLDeMLtPFaVA5y2AB35YMhtwEPuf3C/WbYXe6925yN?= =?us-ascii?Q?hkiYC+w/1ZIRYKecdxDKD0pHk5o5hEAJ5q1hIU8AbFs8Ha1tgqxVDEG4HO/V?= =?us-ascii?Q?2EzIy8GXsqz06mymzxVahlC1EYFqmMksTH3Xh56aMPDvMwFA9hSwgCVN/rT2?= =?us-ascii?Q?DEpQeQMjyeUiVE8njOE8oIOrXUvIXNLUtDeYaUqzydTstwGBty0U/va6jxgU?= =?us-ascii?Q?EZiXM7EYO9puszOv68jM4PFjpz8oHP7db0tKrrgH9msq+Ber+n8aoZdJsYJ8?= =?us-ascii?Q?174t3YUUiYZLOZXCkMHbSnysyEDCSLRZV6ijnljVMrayMRLxbHVdf9x08CdC?= =?us-ascii?Q?hfna9pV/24aH4v0hSrb0BLdd5yt54CdZ+R2+Fsucc3B86mpap2PZQ1wUuZG4?= =?us-ascii?Q?gxBokftgBKYK3pKYyHhTM+tfHqpFHhf1pe6u3wADPLzPihnvuUCXywFbCDet?= =?us-ascii?Q?ZThdq2VDud/Q1wBj1AykjVMVmPClzWEPQ8zYMTAeRG8O7752dYRBPx+p+D2T?= =?us-ascii?Q?2yl5KZgeQiQ6OJQixMTr8hr/H3Ioic5OohUed07ypHLRjxCJIYoYL9NTtkW6?= =?us-ascii?Q?6iY199bRKyiumAC2KfQym6onJvsx6dHgzIHJs5/rD/D8AsLyEp6MIGWTBwID?= =?us-ascii?Q?qoT/8TlKNnrGQktvduhFrFE4v5X5V1/toOTrP8Lcxr8sHjTlYgDcGAFIA/QS?= =?us-ascii?Q?EpyAP1kyw5tnctiR0om6K8YRYp2mmaw/gV8Qa5zI2BS4KB+s96FCLanEVGUI?= =?us-ascii?Q?/w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c1d14151-9579-43b7-c355-08dc5d70df6e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 17:24:14.7280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cyvSxgq+KVA0EH7q7yECcuaSkwTi86JZJVWKgi0Jwy7OhC/z4AD/3tGSfcLxyD4Lg0C0eM3Qcydz22rflcoRtGDJrFgbRhVPgMPwl6Uw+m8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7085 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Apr 15, 2024 at 10:12:47AM -0700, Tyler Retzlaff wrote: > MSVC is the only compiler that can produce usable shared libraries for > DPDK on Windows because of the use of exported TLS variables. > > Disable building of shared libraries with LLVM and MinGW so that > remaining __declspec macros needed for the functional libraries built by > MSVC can be used without triggering errors in LLVM and MinGW builds. > > For Windows only install the default_library type to avoid confusion. > Windows builds cannot build both shared and static in a single pass so > install only the functional variant. > > Signed-off-by: Tyler Retzlaff > --- Reviewed-by: Bruce Richardson