From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0CD043EA5; Thu, 18 Apr 2024 17:23:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8512240E32; Thu, 18 Apr 2024 17:23:53 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 9499840272 for ; Thu, 18 Apr 2024 17:23:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713453831; x=1744989831; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=r4fzwJVM+zSJVV96ubju15gnnRg1gT2hCRG/2+ylVIg=; b=lubJVwAhtPuu4wyTPmdnzDaL1VHHqYBNUnCwY/C1C9NLwPWvpfHzhYyr XxVf8Z4+AW0cwH/isCC4ZLvygys5SRTXqFmHVJPfmjZSeztgJvoX1zTLB O2u3wjvWbLk7T2u2PEUcLGNlG2tzG3MKSjyzTPGFMvZ7goKV2qH5r7kT3 HHaWE10+Qk/rWetZv9fyyFaO3LPli34s65joAZqcPbVdfB8F0e3UMK+Ii wEyX9u7gZyMg8VDQHx8VuWleAn9Hq5GecLM+5CATV8pBb/crXr5elLPlg s3Iqpx+WvGRkvZPFtYCBARpbas6t/7vzraiq3tMvdTsd6Xx/M0kdIb6xP A==; X-CSE-ConnectionGUID: FOg42GQGTKOiCiKzJQSuRg== X-CSE-MsgGUID: SdkbEtPuSkWiY57JDAuqRA== X-IronPort-AV: E=McAfee;i="6600,9927,11047"; a="8883125" X-IronPort-AV: E=Sophos;i="6.07,212,1708416000"; d="scan'208";a="8883125" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2024 08:23:50 -0700 X-CSE-ConnectionGUID: YvLpCoYWRrO7FgPI95Cp2g== X-CSE-MsgGUID: pbeSoBGhQeyb4zK6qCp5+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,212,1708416000"; d="scan'208";a="23062794" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Apr 2024 08:23:50 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Apr 2024 08:23:49 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 18 Apr 2024 08:23:49 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Apr 2024 08:23:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cpVfKjtmqwJmu8B0EczfH/tpiTvy0iNDeBABAaGgGBy/ZpDnIGybfpmQYfk2boBiDWCikMikSs5c31sfk1aAiCjl7ap/Gm78kiJTHz4isdfFXsM9CK0p0bSv5xv/jbRFVEb5cFT7T9o27sBCCh+/2uZkjvzWV8O9k2w4VeXekMC1GJA/z35KgQoTBN5B+LxSUxFDr898DRK3bqXRCGp8c69UNMP0RODEesT9aQJtoRM7Ll+4NDZcPZZow4i7BX6D06lE9WQEG3b5ng7EfHvzC886781Pxew7XTktwcLrn5C/G+HtloZxDizc7ptFYy3NKqMeZ1cuvDswN2DoZEdtJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x5rW7LcJHQmKkgehk4Bu3KDnlwJNpfXtJAdZSowXMaM=; b=DtE8vqZUxFfGmJjxTdJxu3/JC4ESV3ynPQUTL2T4SHryG6k9BPvKfkFi4I+E8CLOld3r4mnUFdwcZqDf3bdVQ8n2YUKauM386aGqijRS26B5aDQomVCF4tV/ywjEhdJlfeCStTV0M+l5PyWam63KABdhBMiUBTdln23qAvdt4vklAAW4t02P7Qh6n9/mmC/Fbe07jwUt26D/NX40MRFURAPduOPYW8No1eNtjROqAUJ38mXS5IWohwjaOWvidFknSLu6FzT5G6vtLtIA6Y+I9oSb4N7L/V9D3n9rPOCpYM7oZHdEB5bFf44lEx1B+YCXjoG1efaNWZUbbiGJubeoqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH8PR11MB8038.namprd11.prod.outlook.com (2603:10b6:510:25e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.38; Thu, 18 Apr 2024 15:23:45 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7519.010; Thu, 18 Apr 2024 15:23:45 +0000 Date: Thu, 18 Apr 2024 16:23:36 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: Morten =?iso-8859-1?Q?Br=F8rup?= , , Akhil Goyal , Aman Singh , Andrew Rybchenko , Chengwen Feng , Dariusz Sosnowski , Dmitry Kozlyuk , Fan Zhang , Ferruh Yigit , Harry van Haaren , Honnappa Nagarahalli , Jiayu Hu , Jingjing Wu , Kevin Laatz , Konstantin Ananyev , Matan Azrad , Ori Kam , Pallavi Kadam , Reshma Pattan , "Sameh Gobriel" , Suanming Mou , Thomas Monjalon , Viacheslav Ovsiienko , Vladimir Medvedkin , Volodymyr Fialko , Yipeng Wang , Yuying Zhang Subject: Re: [PATCH 16/16] build: enable vla warnings on Windows built code Message-ID: References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1713397319-26135-17-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35E9F3B6@smartserver.smartshare.dk> <20240418151226.GA31175@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240418151226.GA31175@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-ClientProxiedBy: DU2P251CA0012.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH8PR11MB8038:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b2a932c-5ef2-4e3e-d7a5-08dc5fbb89a4 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7XIkmOG9RKIUQeuRLneuSR7jYqoH0Av8zn8obh2IKX9AqmeNUjUBHZ3/pOGkArq2Iqta/EhtHC7dTre5UocgFWqoiCO7VlfAEhSXOVUwDKJ+um4qvItOQmr/VCanaFjt0ygbP2bh8Qq14HwksxxKWWiD+CtImGK6wybq22tQ0pEryWeYoMFGipfqpaprXfWuDuxhMvDiKHIXnV729Ied9Hvy+BzbJnCnmoNi+TVKqLt3l407LHPsZ0lUc60KfCYf2C+Fo5M9XfvxDKbx0TO3h3tELHivftzcOrecJZ0E1oe1LruX9sM9mTcR9V3VvacTZ3vZdc1iEmBHS1qvkehZ1Ays+TwLSYMiqfn0JvX9KljE7ZvlflasLfAak/ohiBPHeDGRMiINSfVnXm5oDmx1yOkhriCSTVY8dGIqxPmUwiSwJtLCLcB5HqVrEaPn5Yooh5jT8oFBvyRPbOMyHLVbblLGkDNxZfre6mlt2jS+ZZSiaGpu6cDJvpV1ylTpmcPgTfN/7sFdm6/NTyqnblM85BVaz6SDmMKlK77EYGnpUnuZpV+a0epkyRtM3g2pHiERNcC8vjbiqhTG6MlpHZyzLdVvP03whN5DVvkSDirUDX85fZL/YEYh8qpiqVm9ZZZfrvNJE8CRXExpIgkhzQgm89uFWRP/nopZe1V0dBF8NH4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(7416005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?FrAZePIPT5SOU220/QKoHaghaxmYXk33BMX16xtFFfZvpRPq492+yqwwWz?= =?iso-8859-1?Q?CyInYNZk76tajZRV0M2euheCr4W389yLCzR9OLULpBRvnNu2+INGbjMOJ6?= =?iso-8859-1?Q?t9WSzEoFjbGptJUn2AwP2a+8jmcUJMBb9Cyz2cuVm+Gj+V3uiIi1W/MRvf?= =?iso-8859-1?Q?ZjNU1x578/X6w6Ys+gszzZTy7eoTBn5+f0nK9tilijWxDXm4WamuqwY4vK?= =?iso-8859-1?Q?NqDpCAZaI3bcuUxiyOqwJURsVYyU0EcYlQQBpSSqFrdadHlTInXrNGkDGH?= =?iso-8859-1?Q?d19vieWhdj/wSQFBCg+59Bj1p9KY1p/QmmAjhay2Uxs29wPd/gmZ9H2uGC?= =?iso-8859-1?Q?lHkh6nfQhoQ5ouJHUuO6OGpShr/+7H9nqG+5RbLoCxCJ9SxQ92aA7n4lAO?= =?iso-8859-1?Q?Bu1x/WKH4iCizzieF42pz9FcP1mNtaBYDX8DVwIe+/6WrFrRTOehhBADED?= =?iso-8859-1?Q?L1UNm792SlcUtwQogf23FwLO939fYirn+rHrMPRvXBKYAxYFb7AbF8ePbe?= =?iso-8859-1?Q?Nv0BmqfZZOVPtDRYquxa8p+KO3eBYdInHgS5ht1AYC0KKT0gmjzwic8MwO?= =?iso-8859-1?Q?8gWbfVSZTu0dMA27XN4Q3PCFyUybg1M+hpL7Rf3Tr9YZHqUxKrdUHwCQo+?= =?iso-8859-1?Q?fK0dwlOI3yjA4hx5Fvf/1iSMAjdf1nD0OkCM98nW1dMhwKVitk40C69NFO?= =?iso-8859-1?Q?KSYUsPNQBNkyef4J8RpCFJ51UFL5CKqAjWUJVWWKlzcb58/B6dxfMKPneN?= =?iso-8859-1?Q?roE60yBgfY7Fk/uqAeNw3vpWrod5qUQPK4CeCkSqeKU0MRpr5gln8MZP2Y?= =?iso-8859-1?Q?w1/yuyQzr7G/hW0y6mtjMyun21IvyO0mp7l6dmvJcWTfwIkCEpskJ2dmnP?= =?iso-8859-1?Q?DvAThj9S5jft0r/cNlAoqOckw6+IyzAB2fEd8dS4/PbqcxwA+X2oce0cbn?= =?iso-8859-1?Q?PP3UeXBz3H33y148Tv66EuBEfQqmLM4Nd53FqRofQWQoR/aTPMgaVO4Cx1?= =?iso-8859-1?Q?qotRxTZ9DnJobVT5vqDrV+R+704FBR8Iyk/vzjZ93TQvy7SV5hx/ag1KlF?= =?iso-8859-1?Q?7Mo8QQwWwY5ALIo3zfmSn/zrS6g0wS3CJ7pjjQVZ0YDTtpuMWjcdHyHnD3?= =?iso-8859-1?Q?fe0yMf/VsJ3yau/K6ozNRxLTfb67MrWxmkadZz/ACB5/J74Lc2UToh0uE/?= =?iso-8859-1?Q?A8S1oZTjS8Q7hLdJGH0OX2oeDv+twBApqXqT5al1b8WGO3M9joFGtcWpiF?= =?iso-8859-1?Q?SxOSWXLaJEAkHtXGWb5VARO4mpCqHKR6a2leZm7VcEw2bk6bHcQZfSPJLK?= =?iso-8859-1?Q?TdTwlF9lknZGKFdTPOZC1NHZ9zZW79BAL0z1PW19nAf21gOZB42iftN4vk?= =?iso-8859-1?Q?+usWbj+zxrYjiSLICoYpj9TUIWeVOP0l+fhXZ11H6KCsAeUDX7ocUqbPWD?= =?iso-8859-1?Q?UIYQ5ojv3xP3Mz/O4BsiFhtKphr77CGqCYz6/CLopR/kkgonNszdRF//1R?= =?iso-8859-1?Q?d97Rm+qO3sNKeeK6RImbO5n++rXM49i/Pb6q7R9T+hpqoh6XU+ypoWyAoL?= =?iso-8859-1?Q?4xS282czAqKS4++TrOlLllpV65/e6WafJHDM03Lg1hMWOoZ7VX6Cw5TTHu?= =?iso-8859-1?Q?3JPGQoUQ5p1/lF7M2tx3dJAD2wVfb6BlzVkRJ093hjAwfy96QyueyRYQ?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8b2a932c-5ef2-4e3e-d7a5-08dc5fbb89a4 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 15:23:45.5305 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BTEWc5RkcuMhr0LlnugUThNINe5OhfvzqrxAR9yowTStcG9jRC7FgEctfCnOLJz3v2JNd9Jyo59jID7nONgKHbiqYp182vjEZmK+yBF66CA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8038 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 18, 2024 at 08:12:26AM -0700, Tyler Retzlaff wrote: > On Thu, Apr 18, 2024 at 08:48:39AM +0200, Morten Brørup wrote: > > > MSVC does not support optional C11 VLAs. When building for Windows > > > enable -Wvla so that mingw and clang also fail if a VLA is used. > > > > Minor detail, doesn't affect my Ack for the series... > > > > Applications built for Windows with mingw and clang might use VLAs in > > the application itself. > > > > Perhaps we should let them continue doing that for now. > > i guess you mean our examples or if dpdk is configured as a sub-project? > > for examples i could explicitly suppress in examples with -Wno-vla but > that means any that use VLAs could not be built with MSVC. > > for sub-module and sub-project of dpdk i feel like these > add_project_arguments are not imparted on the application with > encapsulating project meson setup no? > > anyone know? Bruce? Stephen? > Project args are not used when building external applications - either those using DPDK as a subproject or via pkg-config. So therefore, this change should be safe. It will only impact built-in DPDK apps and examples. /Bruce