From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED39743F5C; Wed, 1 May 2024 11:08:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4F6A402BE; Wed, 1 May 2024 11:08:59 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id 3E76B4021E for ; Wed, 1 May 2024 11:08:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714554538; x=1746090538; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=wcd5ocU4qe2cxr3t57IVp8I/Bv9aT+rIu1mca/4c1Vo=; b=OgIDWxDEDj2onD+b8C7jKgKt9diMN19xrE6eSyzp6u7HrNvNnhTCg9gw 4zucXIgiHTXcWjDqC+xx8dTkV0v0ISXz6eJy8Lk8EWxjnAPsuxyLuFDmx uht5s893Bz528ADyHvGGtgjhPwzaZb4fbc79jXwuQKVFrmmQOoiyZ2B1W a37CNirfR8cm4SnG9V7u1ehapJWQeOTn08rMqqvtysJZpq9eTEz5EawMj kL41bOqVsJcMdH+NAsN/LZxAOZYNCyVTPdNhy21aJFlNXwn/WyJiWquFI SfLpYtqIvTPQlPDYk1sAO7NxPUm88nXh67fRioCRK4LrDKipeGH8lAsfV A==; X-CSE-ConnectionGUID: S4fGVvS2T+iIi9UxOtWfeQ== X-CSE-MsgGUID: agpgAYn/TZyK9XqEhLpelQ== X-IronPort-AV: E=McAfee;i="6600,9927,11060"; a="21430894" X-IronPort-AV: E=Sophos;i="6.07,244,1708416000"; d="scan'208";a="21430894" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2024 02:08:57 -0700 X-CSE-ConnectionGUID: 08rScmVcTq66joDS5RCgBQ== X-CSE-MsgGUID: HZLujkvwQHWAKrN0k324Vg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,244,1708416000"; d="scan'208";a="27224364" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 May 2024 02:08:58 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 1 May 2024 02:08:56 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 1 May 2024 02:08:56 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 1 May 2024 02:08:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mOAihHZ15sv2aumjOVDaE3CrqviBpckR9bfr8gY7WW+uSi6tomTOac/n6DXFGLPs/v+wV0Bv+5FU/yfpW1iHi/fZmoGp5wU8uM+3HJTPk1+iF8fT8fpiabG7FPc7lLavcPv78d4ET2UCFI+jiT2TUeRAtMeMZczpkYanHp11gqogyPWC5iANWc3CgICyRJx/awbSZHsCb+AVvmoy0taqq4fGvCsCAUKLKRaguwgUgg+TYxbm10W0dXXcMCyGQKXhh1DBx/1n+uCrwvmNlQs0YnxD6wbRuhueanjjiEOV/mdhVF+IL4MVxt075b1wt8avkuHYaqm8rAKiX18N98wXJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mtMoiXNX3oFSbvDPD13inUnE9aXSreU/u3+qhSGRZUA=; b=Ug9tGxYpPxbUEpGxTFX6vCkUmRTqNngaQ2LOqYXcaSGa6U+WPqJy2QvCywJTUehAWuI3930ALyRVJO5a+O78jaHVUwGMB44xHFB644tVoYr3wtvPbZx+3iazRTzzaOegiEx88C/kTadchYaB4k7WXFXJPwgC2xciYkLStAQuQdudhgLRnYCXSlvLI6oa1u+TEIcdQHbKLcugeZaB7Pc8fLY6ckxminQ4I/FwsSe6Uf+vFN6Hs3/d8gau52YOCn9sqmup7pGLGLwmBkeqAvWLlbHaIDvmxmCO+4KcNmCm+o1NPsIGqzzHoEYIboqHTnRMXrmPmD5ycxTqlLmKLty2Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB4937.namprd11.prod.outlook.com (2603:10b6:806:118::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.36; Wed, 1 May 2024 09:08:54 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.023; Wed, 1 May 2024 09:08:54 +0000 Date: Wed, 1 May 2024 10:08:50 +0100 From: Bruce Richardson To: Gregory Etelson CC: , =?iso-8859-1?Q?=A0?= , , Subject: Re: [PATCH] cmdline: configure input buffer size Message-ID: References: <20240501052659.231457-1-getelson@nvidia.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240501052659.231457-1-getelson@nvidia.com> X-ClientProxiedBy: DB8PR09CA0009.eurprd09.prod.outlook.com (2603:10a6:10:a0::22) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB4937:EE_ X-MS-Office365-Filtering-Correlation-Id: 3326a410-beea-4fbe-90da-08dc69be5389 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5LHcFJBNA9+t0b+FOPbl8BZ2EAbmPPB/fimjqtNwx/8gC8lHZqodEduLosYR?= =?us-ascii?Q?J6lmExV+4IWE9AL2PHsmF7BhGSphjnuX857Ao+u3i2QgOaEnn3Hauyj5XjyI?= =?us-ascii?Q?fsGmeWwNrttfMgOyOaLR2r6U8aG7tm103p7bA8sb6SvENCBvP1G7qgaG94+2?= =?us-ascii?Q?Trr/Hxuja0jjWUcWnmU0kWSqEsXFAITl+GzHmpJWYh73x617zd/0yi8AqpTA?= =?us-ascii?Q?rxM5juqSz+gqm8rB23qtCLNqe79+EwrS8w2X9GUnDAx0+ooxZ3wl9Jj088KO?= =?us-ascii?Q?O5UCU9MsSNfz0S4mfWNEDBfyuKnHeFBxNvUjpSBnPHB75Uh1xrBkmYltPwZE?= =?us-ascii?Q?IAebzeVzxR3ps71hxH71ajwqFy58yytct33nxYWHp84RIQaS2c7ea13z4X6+?= =?us-ascii?Q?QsQ+2GLz1wC0Hzl0Eh4aapqiRh4mfHjCihJhgcbn4LJwMFUxfs57AGHfyLqd?= =?us-ascii?Q?yiOPH/nYZBA1Yospc1ROi6ltyVTQkr6uRZ5u8tBJmwC1ASwmclC6J/iKlG+R?= =?us-ascii?Q?qbdLIiTwhuTy65xCdvA6OgE7fb8dXU7C0QbT79crEYohzLCntKbPdF50L6IU?= =?us-ascii?Q?TCxCO5kElE4yDwBr4lriy5IwAqKxeuVRAgD0fvTTsyBbH1SwrSvaXxsAtU4x?= =?us-ascii?Q?zK/o9M4jc7T1wxVnK9E4T3v1a+tmHkDrEf5+aS/ikcc2Rfahk7IcKZWI0rPO?= =?us-ascii?Q?kYWVcDYOvHY0GUxQlhlehMCDcSkxmv+c5+hQx6pyT8MIiyfMc4SdjS5Hgtn9?= =?us-ascii?Q?aczF7B9KjRxZJWtclpxxFCGNGxe5ezCWPN+ZOW9Th6o9wcLbGPYHhZCuA5G4?= =?us-ascii?Q?dChhoq1dDx+jU4XfNd2R72qktSRCe9bDkkmKrGFHBiHJQUAAxq43kXg9VI1I?= =?us-ascii?Q?0V6ACCjd+EB0f6KVNWfVbEqGuJvWGwb//7/i7XqrMqrMi4SZoi4bnPnUlVeQ?= =?us-ascii?Q?T20IO5mKTBq7X5btkEGGCi3kuuzYNzWipIfNsn2pCikjyM6s5UKIg17KPnXW?= =?us-ascii?Q?q8BfhcyX+8EsHZIxdPUY8JbccXzwK0CeugC4MMDqdO6y/PRmNSIPwmerc0ld?= =?us-ascii?Q?87+8kVzt6VkheMpcuyUQ/KEzGlqy33nb4BVZMdaWnxIPy9q85GnsftTjxdjj?= =?us-ascii?Q?zgD/ApKqOUwQGArAD5OxYU3UyOcxpSiMV8dXKSvIuf4Rd85NgranUSJ1Os5Z?= =?us-ascii?Q?SKT0hT7Dhy2sCGQYXSeCTirvjpOfn/yANwd4ZldXW50wIslsjhuQHtCyzqaw?= =?us-ascii?Q?iZufAR+h1vZAHOrBOGdXkWNQXlnrkIOazamicMUBpg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sN6fmZwchN4Kpw9h5EsklsJdoL2OoFqIEEQjikLXz56g/mcyrvDfYK7OTO4D?= =?us-ascii?Q?nU9X/JCDb3hkdSOSpHj4qm9FJP4FhugEIvvS9/2ax6f5kecR+DU+Tvihod9b?= =?us-ascii?Q?4NljBpRQUU7Ea89HYOALMAlL7+8UJXEQJQpKunH4mhzhxL0ZFWOrKtYGkjFL?= =?us-ascii?Q?Mqbo1HtIXRpRLXVzlHc4ZEiDqhXlGlJn4ckAQkoMFOTUDBZNTGXmkAMN1m4M?= =?us-ascii?Q?gBE5F3o1RsgA7Dv8ifiYthiUpVxNk2KFIDRCHg5iPVSBiKKmejaguzimSLVG?= =?us-ascii?Q?x9jLz6vw4nFrvRtO6axXrrExuOTiKM4mPhp9lxS37wj+BCyLrCo1QkPvH7D9?= =?us-ascii?Q?nyAl9qbBYDEUkbv8JOWQKWMXm/DYHeR0NPNsZuiBbMZLEawItK7foAy/x8sy?= =?us-ascii?Q?gY38lozLGWEm3H3JWr9eLw4r5sCTbH9DWx2JzgP8V5OUcWg+3E7kUEjkD7eU?= =?us-ascii?Q?BsM2gi82prF/a9l/PpRVLNwESsexjF4Gg2dD+qbYAJYp92CdfZ+H08q13ceh?= =?us-ascii?Q?eb0s4TgzmbhsmFBw2bOo6lmfoKXaBJscS7YnEi7F4EVr1AtAlH3XUl0t1hC7?= =?us-ascii?Q?eGfO61s7fTN9zZnni0dyaZYt4otLc+GsMbcRAOZhoULQnMWWLWj8LW2TQ48C?= =?us-ascii?Q?0PioXNHpRXx1xGCB5MFHJc7+bCNcyK//dK0TbLtHrb6lUipSESGBfteR2YRy?= =?us-ascii?Q?8e+Zqid6iAQ1rvpLXmPcMZvDvFJ4kxw9/iBwQKJDGx38uXdENVhJ3OJJwJgY?= =?us-ascii?Q?c7ooVcDMIUsDThb5AxOnNVTD8WxGsMRzhdVqyCDRN1gGk2zekS8ufNOC5I7i?= =?us-ascii?Q?Ek4R1qfJf3Bi/aMGalOLlpGot9GBGIrtH0u9RYaTVF9dLwG7HZR8zGGGSC+m?= =?us-ascii?Q?Hmh32L58G5+n0e5l/KUKHhfj1+X+r5P8rUFMTKsLZ85SV1BnQufjFqOcNMic?= =?us-ascii?Q?Lm0mYSJ+rOIZT1be1TIuSItUkb2VzLNyq9/KIDB/GgyNxvizNgUKeAp2Jtky?= =?us-ascii?Q?XeDYyChWtJjq5NX0p7GYfDSBd3Ga1g6iyrOcE6yYSmfyDiL5qAwdaBIJ2Xi4?= =?us-ascii?Q?Y2pCM8ksQ5nfhq/myDr7LjoUDksIm7d0vXeycXJ9ZWlVQraiefC7WYVUy6+J?= =?us-ascii?Q?wA722f/wzfiBGbub1DErDcFYv5D1TozvGPsIR1u1RhYsal9qn5Rak4zcnvh9?= =?us-ascii?Q?rjqHWrs4bcGguNCWIp8iNLeEwfmwBTpMP//j0ZuN9wxjBlF2XnZtJRxtz7uM?= =?us-ascii?Q?/iTQZtKF9T3tYUahgyUeLSqF141LRd6PLy1AUsA5shaw9PuPnTbL6vB74UE6?= =?us-ascii?Q?Y4sO+tCTNhn4HIAoxJL5gPv3jJuacjkjaHvdpse5KPcRpXtBbmmK+RPTgSdF?= =?us-ascii?Q?ttA2YBCeOxgRD2s7lxV3cuyfy+jpOIl+kFWf1/b7KtK1i84Bfg42GeyXUTAl?= =?us-ascii?Q?EOMqB827/xf2naTB3oiIzFnNbVLXRHg+XCLnj4tULFipKnXdgB3J7UmhaXkA?= =?us-ascii?Q?oOMtnuvETCVxN1S47C5wR+PE/KcClI4TAmkk5TrZROnX8QqTtOiiBCNM/t/n?= =?us-ascii?Q?dEO+HNW/zgyXXwRuAkkORRq5cgdsU73jWd/sYRiMyEzQOwrs/Q96DmIr5dqq?= =?us-ascii?Q?tw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3326a410-beea-4fbe-90da-08dc69be5389 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 09:08:54.6774 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d7OhKkh24se2JBFO7D1u/zkoaNYaeRC7uQbBt1TAvxdgPsfO8zpPGIAemhhKWRuBQ3C7JYHsZ6L8jMxQ3TTLwz19Ai29YMX5WJgh8QVBgEc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4937 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 01, 2024 at 08:26:59AM +0300, Gregory Etelson wrote: > DPDK defines cmdline input buffer size to 512 characters. > That buffer size can be too small for long application input. > For example, the following flow template API testpmd command is 444 > bytes long: > ``` > flow queue 0 create 0 template_table 1000 \ > pattern_template 0 actions_template 0 postpone no \ > pattern eth / ipv4 / udp / end \ > actions modify_field op set dst_type tag dst_level 0 dst_offset 0 \ > src_type value src_value 0x31 width 32 / \ > modify_field op set dst_type ipv4_src src_type value \ > src_value 10101010 width 32 / modify_field op add dst_type \ > ipv4_ttl dst_level 0 dst_offset 0 src_type value \ > src_value ff width 8 / count / jump group 100 / end > ``` > > The patch introduces conditional `RDLINE_CUSTOM_BUF_SIZE` definition. > Application can set custom cmdline size during DPDK configuration: > > `meson setup ... -Dc_args='-DRDLINE_CUSTOM_BUF_SIZE=4096' ...` > > Signed-off-by: Gregory Etelson > --- Basic question, what would be the impact of increasing the default from 512 to 1k or 2k? Do we get a large memory footprint increase, or is it just an extra 1 or 2k of memory used? /Bruce