From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A31843F5F; Wed, 1 May 2024 12:16:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27149402A7; Wed, 1 May 2024 12:16:12 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id CA6E64021E for ; Wed, 1 May 2024 12:16:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714558572; x=1746094572; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=wb30G0wcP8zvzxcvxzR+ODK8jx/49eHkDFa7aBl8X6E=; b=FH/LpDslSGb0NgBLoN4S2l3qGdMQqtG8MeoK/ntjwpprowHGf9oJgolq KwsfykkQxcM3WWL9wb67uSdqRd3eGkjO3lAsaZeKeXm3jo/quDBUiZIIf FnSK+hqEAe2QWixgJWUTgMRyWmOoGE+60GGL9biNjexbmLn/ROPVh9qGM nX5psHEf+UcNxqe9iLA4h09DklfL51uNk1LhCbJV68cpfkjBYxWZV+987 Ag/ACfwXrZxHMKcsmJGFJ2ctI/ftFqBm9SqZrMWKnD7NEfMTA4UcQF+iV OxB+UNFNZNBjdTSLaGPgGMQHXR2NHXkKo80E2BhL385OWIaUaMnERC4YD Q==; X-CSE-ConnectionGUID: N4z3PZUNRXmO48c0ZWw4Uw== X-CSE-MsgGUID: 4RGhCI0tT2mZRVaXNZMm7Q== X-IronPort-AV: E=McAfee;i="6600,9927,11060"; a="10409883" X-IronPort-AV: E=Sophos;i="6.07,245,1708416000"; d="scan'208";a="10409883" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2024 03:16:10 -0700 X-CSE-ConnectionGUID: kR48YbL0QZ+V9gidryRGlg== X-CSE-MsgGUID: qjmOku5RSoW9aL9QTDvLaA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,245,1708416000"; d="scan'208";a="31462402" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 May 2024 03:16:10 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 1 May 2024 03:16:09 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 1 May 2024 03:16:09 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 1 May 2024 03:16:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OKMR1/C78gtsmMYU8CHiUNX6QPTYqI05zttqNE1sSW/3hsVRXY46RQqC8VpwgAs/6xwgIoByJA+tkxtd3WgdT5Y359LpeAZu4zTPWr6DlPKj9rCdQKbcn13HLC8kOKyx47dLiVb7NajPjWnJGhHQAIgab/5T6qBBsJxRUwSEvxvLVJjLnWG+u5kiGwC9kNv+BgoExS+UUQzmLa0Jwf8h1mqvJiK4xnxSC2N1xo/wRlaf7PJRjBvFqLFma/qORzX1SzZRSfTMuoCH8bZQPJIiuyzoDJVfu6n2PCxmO1ATr2/azseb2rDmkUsB+0qQnju79JFux2kPRe9GFMB6CEtY/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BYxnrU/LVX7pnAp41MWvKZBLSmtOxqLLx00jU1z6NEs=; b=HuPy7Bgs+cUbsmFT1ftK9TW/tqDe6CT47eHVnHYLYT/yRbjWv2nhCEgK6Sppnutd7yltP2EAV8LFCj78KUSo72g3JMOtxvNt1xRGJehhTmFnsgxjje22bhlHKVisUM34wE7F6IPZuu3chcPvuomBb2g3zt/8XNRt5X7a4eCIt3U2cUNPBwNL2cipdm03pvTWwJqP0qrPBM+tThIzSl9nzIsDFrM/PCOWOoVUpK8P+QyA4HLd0hkJl2cZaX5wbUaJK5OHg/C+xDycFMh2EAwd43q9DmVBKuK/K+Wc5u2aRpUkVqLJBr4EksxCG3ko+zmg/xA8VMzMgz2A/dGlmYb7Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB4902.namprd11.prod.outlook.com (2603:10b6:510:37::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Wed, 1 May 2024 10:16:02 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.023; Wed, 1 May 2024 10:15:55 +0000 Date: Wed, 1 May 2024 11:15:49 +0100 From: Bruce Richardson To: Ferruh Yigit CC: Patrick Robb , Mattias =?iso-8859-1?Q?R=F6nnblom?= , "dev@dpdk.org" , Mattias =?iso-8859-1?Q?R=F6nnblom?= Subject: Re: Run unit tests with C++ too Message-ID: References: <4d5510d1-bdc6-43de-abbc-749eaa3c75a4@lysator.liu.se> <28dc7dc7-eb26-4405-9d80-9d8ec10f88b2@lysator.liu.se> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0329.eurprd01.prod.exchangelabs.com (2603:10a6:10:4ba::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB4902:EE_ X-MS-Office365-Filtering-Correlation-Id: 89a34598-fd53-40bc-0d6d-08dc69c7b04c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TlRaWTBObURTRm1COWhZOEthbTdGVDVYKzh3MjFzZkNTaXJ1TFExMTJJV2tG?= =?utf-8?B?OTlmNU9oV2JDVXhOREU4Q3Z4dkpRVHBBaG5WV0pTYk5zaXFTMGJOUFF2WFc1?= =?utf-8?B?SVdUUEpkVWJiMXo5c21lYjNjakJ6azJjZHNJYmVFbEh3NHlpQmxJV0d2NExm?= =?utf-8?B?eGZqcm9BWEwxb0FXQzRjSmxUeVNFMFM1OFVqd0poOHpJY2ozaExuUVU1OERF?= =?utf-8?B?N205TzVZSStNWE5zSmhlYndwb0dnWitPWnZEN0wvV3RkL0FhZTBHK3Q5eWIx?= =?utf-8?B?Nng0VzVBVVgvcm5oaTNkaG9YN0pUUytlSktQTDZId2NsTEFWTWhmMGNObUtk?= =?utf-8?B?Y1krTjlRSG91TVNwemxPUEkzTTdybkZta1k0dVdSQlhqRkRjdFl3aitySzZV?= =?utf-8?B?VlBScWdBanRJVEd3bjU2eWZGNVpCZWRWYklrZXlmc05PRldpZ3pQaTF2SDU3?= =?utf-8?B?aUUxSEFRZVZ2ZTR5Tk1UWDRTK2RDcVJSeFVkQVl6MUJ0N0xRT0d6ckVlZG5h?= =?utf-8?B?LzV4TS9qVzlhTXBxNmZucjlITUEzT0twUjJqUHVQS1ZCTmFQaFVBdUc5d1hm?= =?utf-8?B?Undmb2QyYkRXTnhIWGVRNXdxWHV4eHhzQm9FM0lVOXVmUXk1cnJQK1RmTXFT?= =?utf-8?B?c0F0S2QybDYvNG04Rit4YitoQ2IwN3d5QWQ0cWYxUmxodkI5T3NTVlpyMjUr?= =?utf-8?B?WG5vY01jNGhSUkhYQm4wOFVrN01QQTVKSzVNOHBiWGlhV0lmSXZhRzllSC90?= =?utf-8?B?OFhTMVRkUVVlZ3QwTEdsMFFHUytSNlZaeFFqLzV1NjJMZVg4NVhYRzlhUXRy?= =?utf-8?B?QjhzY20zUjBiZDhNb0RuTVFZbDMwRXVVbEZFRWlYZHRYV1lDZjRoL0xUVm1z?= =?utf-8?B?bTd0Zm94Sjh2SjhoMDF2TmdTWUZucGZuencvUHd4RnhJeWFOVWVNdXFtdEgv?= =?utf-8?B?ejhRdHQ5V0xMTndrSHp1Z091NWF6V1B0YXEzY2w2ZmJXRVZyV3E5K1c0KzNh?= =?utf-8?B?WVlHajBJTzFBRGlyOUxkbitxa012VDlpTnBpaWJEOGxDaFlINkJFa0twZ0gw?= =?utf-8?B?N1d6RE1DNXpzZWJxWWRjMVByYk4wQkI2aWpzUjlYeFhoc0V4L1VLODFHY1p0?= =?utf-8?B?ZkhiZDhRTHZNbEc3U3EzN2M0RXBhYWhVb2oyR2VIV3UxWm1FczM3R21Gd0to?= =?utf-8?B?bndoWWJnZDlycGNDUkR1aUtJdTlpNVg1UlYzVGZRN0NhdjZLV0xqbVViWkIz?= =?utf-8?B?UGpuK0Z3N050cUkrc3hoWWFJQ3JVN1VlNUVWK0t3TjRjQkt1bzRib0RObm5D?= =?utf-8?B?MXAwYWlWZG1heDlHeTFGZEpuY3ErS1crRUtYaVc2QXpNSko2REdnK1QwVDRy?= =?utf-8?B?b2NwUyt2K1JJUmdHeUExbFM2cW1BVS9kN0NoZEtpL1BZRzNySitHLzV0NVZJ?= =?utf-8?B?d2ZGRXE5Ykpjdi9QUkRwS21QMENaTW1EUk4wSkRjelZCYkJsalBOOE1hdkgz?= =?utf-8?B?bnNHeGRuMldQUWt1WTdUdlAzWHhaQWZBSHRldzMrODRxQUVRbWhrYjRkWUtV?= =?utf-8?B?MEVRRk52VC9EMXVCM1FSdmx0U2dEQXlLci95dnJQZVRYTUd5SlljL0Z6Y29j?= =?utf-8?B?MEdQVmtSN1RhU01GR1ZRTVNyWXVaZDJ6ajlhNUtuRTNMejQ0dzVDcVJYRXFH?= =?utf-8?B?UHAzR3JDd3ErbDZ6MnpobC9GU1BwZ0o0N1l2RW5NL0F1UTFRU08xdjFRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHJPNXFHcy9iVnduemhWcWZYNGpIa1hKVjV1SURhYmJQd0g4MnJRUTZNcjBL?= =?utf-8?B?dVR5QkhCU3FFVUxoazdUN2huNUE2VEdTeVd5UWgvbGVZZks1VFNvVmlkenZO?= =?utf-8?B?bTEyQ2lTVkFkTDc0UlM3d2ErZGJIbkIvZWVwRW42RUpSb2V3Ukk5VlI0dUI2?= =?utf-8?B?TjhLTG14Smc4NkNvWk5SQzFNTVh3RFV6bTl6eVJtc1JFNkRuZDFUeXArTU5T?= =?utf-8?B?enY1Z0cxZGZ2cWs0Mzh6TkNxK1VLYzdBRWVGbUc0TW90Ukg5YWpGRndid3V3?= =?utf-8?B?ZW9STTVUbS9uTENVcHgyUGdweDVwbGFVaUxRZHVpbTF1UjFONEh1bEJHWVBV?= =?utf-8?B?dlEyR05lVFRReTJkRmFGK2JiL1dLVEdwdkZKcm5wWVpScjJMWVhwMDZnbmNO?= =?utf-8?B?azlBcHVMU3BseGcyZThFM1F1U0xhYkwzTVhqLzRRQVI5emwyenB1RjBvNEs2?= =?utf-8?B?ektXd3BiM25HNnA2WWFpYmZFdjBBM2UzSTY4Yk5OVFZwdElzTzVqeklEbW1X?= =?utf-8?B?TDF3K1lONlFUd3YvdXZsQVpQeDQ0RHlNV3NJdXVZQkVxM2NjVS9UQy9mRmRs?= =?utf-8?B?RzJNMmtyN3FXU1NEWFI2V0QrOTBlQmNJdmJsN2lDaE5RZEN4TXgzSTdYbUs0?= =?utf-8?B?YXlFV2hIL3IvbVp4TjBUbmRScHNmbVQ3bzZIaVFsc0tEcGh5RktIeVVhNWJ6?= =?utf-8?B?aE9XZEV1aVNIdThqdmxHMTE0QUFaRllUNis3b0VBclhDdVJoTmhUbjh2ZTcx?= =?utf-8?B?RCsybHJwSG93VGQ1MnhiclJKMDR4eDJ3dnlIaXBRMDByekE0NDBXR0ZRLzhJ?= =?utf-8?B?Ymp4SSt5Sit6MFRWSGZKTnU0UzM1VjF0L1YrbnUwVENLenN2dHVMeTBwMkJ0?= =?utf-8?B?cVVrdTRBdU55SUFpQTg0aGlzT1pWTVEzeEoyN2JHQ3hrVkRiWHF2UE15TWNr?= =?utf-8?B?M3JPci9uVUxuNFRzaXRsK2ROL2RFbXhmd0dOL0JieFgrNHZucUhwRGRmc25o?= =?utf-8?B?M2ZuR21NaDU2S3JwR0VNWGtmWkxOQzI2eTFWbHZYM21Ba0hJWXlST0lpSVVD?= =?utf-8?B?NTV4bHdBMWUzODIxa29xVnZQMmE4TkZuTVY0Z2YrMW55TkhOeEFoZVFUZGVJ?= =?utf-8?B?YlY0cXFxVmlOZHhML1NOWHBoWnc5MkhVM2VoSGpSZWRRck5tVzYxZnp6cmJK?= =?utf-8?B?M0V1dysvVzlEbW90Sm5kQXAwc3dVa3lsa0gybzhPMGp3QTBuaWl6THVFSjRp?= =?utf-8?B?blJ5VW5FQ0s3SmFjNWZTaG9zaGZqcnZDQmpna0l6WlVCa3lUUkRDZEhQcWtY?= =?utf-8?B?Ujdobm1zVlptVENwVSt4K1hYZkFHRW40UzFDeThLRHJpNm5zK2tzaXM4eG5n?= =?utf-8?B?Umc5NUxoZEYyTzlzWHVrWEpzSm5tekVGZmE3OUx2SmlUeEhHTEN5d1U3OHFM?= =?utf-8?B?VnFTbytTcXBjOGtPZjFPQVFZQ3dzTlJ6WjR3YzNOVmJtZDErUWsyNTVzNFZT?= =?utf-8?B?R1FORllwa0xtY0FwOGJ0V2F3YWxQanFCcmM1TVF2Mm9OQjZZQ2tudjZJYysv?= =?utf-8?B?bHNHQldvdy9LRG1wdlZ4MmRROEl1Y0FkMDJyamNGcjhaY0M2Qms2MElqQm5X?= =?utf-8?B?N0M3NkF5eWQ3WFVpRXZRdTY5REdRa2tXV2YxNmZpbmJHR093WUtXNU5kb3d1?= =?utf-8?B?aUIyc09JN2w2VHlkQlBvZ1N3SWJ0NGMzNGtHajExSkowVlNTQnFXYVRYTTV5?= =?utf-8?B?bEN2VjlZRWxYbVhkdEkrMVZCRU5oRGU2TUFra25kLzM5L2xKbXdpOFFkOW8w?= =?utf-8?B?Q1MzWFZlWURaWFQ0cGlwTGh4MTVLdU1NR3dwOE1iS1ZHQ0hvL3cvYmdlSFZh?= =?utf-8?B?UHhmeHRvZDNTVXlTUGV4dzZWSi9lWFlhL3Rob0ZEVjYyc3V0QkpwSzJHY1hX?= =?utf-8?B?N2pQbWIreFZlRXNiaE9iZTRtVTF1ZFJKK3M1L2Yvdk9IenJMVVUxUElwdDdT?= =?utf-8?B?eG5pUzBzNVNHNnk3OXljRFVtWTNQM0lHRGt0NWowU1NmWE9nMUR3TnBqalFw?= =?utf-8?B?d0pCK0hGSjFhSk0va1pNMENWckpJK010ME0ycWpKVzBQdE9RV3RCbEM2bmgx?= =?utf-8?B?T0lhS2tvMkd5NUpIYWNLTnRmRXRzVHdaQ2pwYkIycElXVjM4cm5ZRWM4Ymgv?= =?utf-8?B?anc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 89a34598-fd53-40bc-0d6d-08dc69c7b04c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 10:15:55.8948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4lqoHwocOs6QHGEiAAJID3CJj7Wv36hNlhcAQ3Lnd0opGGieVzGG1MDvdSPDENOPwth/4HV6D1rmeiLUOq9rcWIomSDiqkHBXMjqOZ0WlDg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4902 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 01, 2024 at 10:10:57AM +0100, Ferruh Yigit wrote: > On 4/30/2024 9:57 PM, Patrick Robb wrote: > > > > > > On Tue, Apr 30, 2024 at 4:13 PM Mattias Rönnblom > > wrote: > > > > On 2024-04-30 15:52, Patrick Robb wrote: > > > > > > > > > On Sun, Apr 28, 2024 at 3:46 AM Mattias Rönnblom > > > > > >> > > > wrote: > > > > > >     It would be great if the unit test suite (app/test/*) was > > compiled (and > > >     run) using a C++ (C++11) compiler as well. At least, if such > > >is      available. > > > > > > > > > Sure, the UNH Lab can try this. > > > > > > > > >     With the current state of affairs, header file macros or > > functions are > > >     not verified to be functional (or even valid) C++. > > > > > >     "C is a subset of C++", which was never true, is becoming > > >less and      less so. > > > > > >     If all unit tests aren't valid C++, maybe one could start > > >with > > an "opt > > >     in" model. > > > > > > > > > Okay, so basically run the fast-test suite, record all that don't > > pass, > > > submit a bugzilla ticket stating which unit tests are not valid > > > on a certain c++ compiler, then bring CI Testing online using the > > > valid subset of fast-tests. This should work. > > > > > > > Sounds good. > > > > Just to be clear: the above includes extending the DPDK build > > system to build the app/test/dpdk-test binary in two versions: one > > C and one C++, so that anyone can run the C++ tests locally as > > well. Correct? > > > > > > Okay, so now I am understanding this is not yet available. When I > > responded this morning I was figuring that c++ compiler support was > > available and I simply wasn't aware, and that we could quite easily set > > cc={some c++ compiler}, meson would pick it up, and we would be able to > > build DPDK and then run unit tests in this manner in CI testing.  > > > > I didn't mean to suggest we would submit patches extending the build > > system to this end. That's probably a little out of scope for what we > > try to accomplish at the Community Lab.  > > > > But if the aforementioned build system support is added, of course we > > are willing to add that as a build environment for unit tests and > > report those respective results.   > > Does it have to be 'app/test/dpdk-test', why not build examples with C++? > > Examples source codes can be installed with existing build support. > Later we can build these examples with C++, this doesn't require any > update in build system. > Reading through the history, I believe the ask here is to have the headers validated for C++ compatibility. We previously added support to "chkincs" for this - we can build chkincs-cpp with g++ as well as a regular C-compiled chkincs binary. /Bruce