From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F87C43F76; Fri, 3 May 2024 15:03:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92E1F402DD; Fri, 3 May 2024 15:03:54 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 61C80402C5 for ; Fri, 3 May 2024 15:03:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714741433; x=1746277433; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=iiwhyVH+HUeVMHN+jACqu8ggIb7cxoqiGkAW/PiD+Ek=; b=UbDzpMaI1ukhZqD3eP2eBALiKFbcPbee5GpcWGysq4RbGOSTniSSK/5m v8jukMRsaIZ5LB7uTJ+N91QFk8OmiacJ9Wrb22kJg0i+3ggkNhptc6oI/ 4mB0tRDSRkaf8E18kFjojRtDE/5peowNpI++ucOm1nExO/1r4YDZbIdzN k9z83gWLwzaFGP+2v02PCZiPzR3WujOlZ8GJuJ/fU/+kyJ7udOUk9+UDl AyEluVTmJHrnskfhDmO2ussex/pn0KyryLog6aJK3kiy1X+3Im23lVev/ /IIa8mFkfeT0/2Zle7dGEcNcjv1WdhAsOQZLFkYXDu/qnSEaGGR6hWxda Q==; X-CSE-ConnectionGUID: BBZuMB8RSf+OjBAhFf8veA== X-CSE-MsgGUID: mFOMc3ZQTgyMBmNuu6YnTw== X-IronPort-AV: E=McAfee;i="6600,9927,11063"; a="10706474" X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="10706474" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2024 06:03:51 -0700 X-CSE-ConnectionGUID: 4kF0vStVTrS9FDF0uRmrTQ== X-CSE-MsgGUID: oULAgQMbTw2TtAZI6RTBeQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="27959072" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 May 2024 06:03:51 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 3 May 2024 06:03:50 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 3 May 2024 06:03:50 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 3 May 2024 06:03:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y1KBsspGavLthN0iZroOOl/PakhQvXryapUVySADxOvwDK41hGP33s8fcRCvDKUaP04WLIebmZID2KRiKbLCf7IvbNQPKZT4G/Woa/hqr9Gs66DP3rUHUfPzridYkOBAkfdRT4RlbaCtvxNfpml1PjG3OaSzS2HmXxPzYrNV8gtUjG8+f1Er6TaGTD86Ew7ix/hX8BtiTpmOIvz/U5FJWyy/iXqdNtVyrtDp3xmwPO9hebP5iNlODD9FVftcc/SbN04XlcCLh562U8Dng8o88ZUN+g5T6ZafJ2qmyZXkCOKEoxuNRHhwSle6fA3kj/1q0crmV8iU1okFRfEY9NhVsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZtdaA7mRQnrJO0+YsN0FWXDMqhAMJW1erYo2MCcL4SQ=; b=QbGmfHGVcHNak5+LVJZsIoTGcY4opw2xlrI1kG4mKwGIm0OZU5IOV+zneyZw03gLSQd72ks/aTNBy0IhQEJOX5S+swBAuQCTmbFKbypotuaRCrIMseCPdmL7zSYa/5zdtCA9Rz8vFQT0dBSsz1SjrCdLh5PRCcfMoCAxyHZdjlYl4mPpFMhwaE4lWDhqVU11H3X8uXHMP+Ih5g1JooIXWej+aK5oDI/zzuhpY14nh2fZMTfWKEei9rXM9iPbDNbqPFQYrOA2a5fZSdrTR5ZlzDPVAz1DU2QndvyMMw9yu4Hhif2CtJbTQeSUSOJU0I5KCNnYMP5p9qyXSzBfYGgBog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW3PR11MB4570.namprd11.prod.outlook.com (2603:10b6:303:5f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.30; Fri, 3 May 2024 13:03:48 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.023; Fri, 3 May 2024 13:03:48 +0000 Date: Fri, 3 May 2024 14:03:41 +0100 From: Bruce Richardson To: Tom Jones CC: Subject: Re: [PATCH] freebsd: Add support for multiple dpdk instances on FreeBSD Message-ID: References: <20240502135541.47142-1-thj@freebsd.org> <20240503094615.1427-1-thj@freebsd.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240503094615.1427-1-thj@freebsd.org> X-ClientProxiedBy: DU6P191CA0015.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW3PR11MB4570:EE_ X-MS-Office365-Filtering-Correlation-Id: 1727b7f7-3eaa-41f8-cb07-08dc6b717894 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?J5WSJrgYpsyfpNATEUs4OAXdxcsZdR5kvlibEmk/ombwF9i55VHOaloobrr3?= =?us-ascii?Q?DQuUsWSIKr0Nf0zARqFXZkty/k76Ih/nQXz7AOpmD7LvbiOEUOVBqXI6l4sa?= =?us-ascii?Q?iEbMGtPA/5G9EV10mE7eAam89OU27pCPrCMhvTcBgderc6DojnTVZHWBtcIe?= =?us-ascii?Q?YPR8jEmEyHtMQPXAVh/aF+ZHYMbDCySxDg/NhEej5NSqqh0G7+07Uq2HLBSb?= =?us-ascii?Q?XmEWSjRsv94c9fw6X5Zgmuw/lWCLzLYUpUuGx8eA92yoI8fFJVsGhCLbP1kV?= =?us-ascii?Q?KfP4UI1veXecNHoI9z7R0bqce3hRJvV+eBNCvrbsfMtRohQJJOgK2fhQR6+k?= =?us-ascii?Q?CN1eET3weicMPRVrFKgpvjXDjxy1cPn4xkRGqb1YnTkQPmPk8Ma1yviRLuE8?= =?us-ascii?Q?KtuHRODVDbdciPr+ZDiT5p1O1BCTRcnrRmr+W8CdcLGBXIw0QoxqJbS/8FAo?= =?us-ascii?Q?Ae/CqWetIrDoJ2QoPZs3qVAmPqg7iL7OVNNKiN4HeFUGIDYxw6Wy7xit4Z43?= =?us-ascii?Q?dr5ui9ficRHpq7+E0hDkMKBQnrsu/P0/Pp282awDIGtzO5RfLflYpbwRcVgg?= =?us-ascii?Q?tWgMb+PucWqYpQN0jFUpjZiy3GAhBH2HJUjdzArl7SIjxjwxdnflBb7sLayh?= =?us-ascii?Q?j6bM+LY71HdzPoLCCZ2o18oj3et2Qw8k309vF+XtqvOV5vLCQW2ygt/zDxR/?= =?us-ascii?Q?DlJ7leiOTsURhqgJMOAVzH+3QO9JzprGWe+M6XE2mLo0/kmLofFbxU3J3aPs?= =?us-ascii?Q?xZ/gsr1GZG/7bAb+Fgf76gbLZlet1/sM2V5HzOdv8R5mAVcQTOgMDYM8TqfL?= =?us-ascii?Q?bRGS/kbZstUKbCUtFRiGPyDriC3M9Rd9+bCVRJ9UMORQTmfajrGVqxvtFXbl?= =?us-ascii?Q?4blIj5NppIh+y8O4GBRmHQky0+bZWZqZ5DLjdejfTnOj/H0Es1FafPw8bEsR?= =?us-ascii?Q?/WLwx8ggqTaIQG+/bbGzvFBXZ4jyj6ST169g3xO5lFSd3Jktoq3Hru24U7Gj?= =?us-ascii?Q?vzBDjP2bNzBTikh6FBHjZRCaDT4qRYfR5gye/09vqwv544dcDa6px0rWap7B?= =?us-ascii?Q?ran7X5h9r+vQyHzNTGUu5Wf0tfHSQkCWIHYW2cwf1tE+anWxLmvmrQfjK5pK?= =?us-ascii?Q?kq62XTl+GVm4TWedRNPcDI4zDflvwliQ5/3ZLOQn++rEy7AadqYLgvsoWq8Q?= =?us-ascii?Q?QUG0UmJ81TRZ5IzYlVnnYxojcZSqcTaNwjBRGiH8XsF/oEPunjnDdcEkoEtZ?= =?us-ascii?Q?ZqFqqWxxwQ0CnXzGAJuOGeplvj3RBL7v6c53k7Lx3A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wrKQrbkcF6zw6QAvqBvteJ9V0f6zYSB4pivuTtsfFKLL1tYrCDGGkS59jfS/?= =?us-ascii?Q?WttNasvxvZkCnA/UnzYMw6fyquslHrC3xtCRhNzNJLeFV7LsGX6bbxyLORlc?= =?us-ascii?Q?j6rd5zY5iPH6iAgGvR/RLTzH4w1xcgMKAzd+ubxNGTdsVBM9htaGU5F+iiqm?= =?us-ascii?Q?mIWvuUTCm4LBklhwFENINo+YyrzqzURiv6ae2CxW/5wifbBpfwD98KIfxdSu?= =?us-ascii?Q?1vIBro2Pji3aSPpiKltaDibR7jyvtHpJYtjx4/UE4ZKp6gKzhFLcOX1KK1i/?= =?us-ascii?Q?ulexUOpzpt8x+JqvXFjcLYzRVU5ut0N70dP9KX7sDJ/MI8/F/AWi9qq9VqOx?= =?us-ascii?Q?gHkV5lXyP/29aJTj5YJ8XjYWKj8qgU/OAOsYydm5GFxag5CHsE3FKrHV5wmx?= =?us-ascii?Q?URmhC5TunR8qoiPb5+Palgqn5zH4kTltF2W2KI0wI/o0B3JFGcvxw8sxJ7ZN?= =?us-ascii?Q?8lHVfzzGKKa+dfSl8GlIObgMKnUVrHWWKUswQswiIoDgjXyCRZ7vSu2BEAWf?= =?us-ascii?Q?QLmJCJ/dQRlhc4+uBWiALc0Rj0zdfTOYiB6vwsyxS+teu3dwZhh3XQuEZxkJ?= =?us-ascii?Q?fZ/3eLwdT7PFPtCwPyIpqrvV5hdNnsOYVmH05XPrlWGNaj6kCEvnRB6Auv+H?= =?us-ascii?Q?aGRW3f2y4hvOxSJqBeZY69NF25kW2O5WAwt+OfZq3cDUvkxd2Q1POwI+vTMk?= =?us-ascii?Q?5cIACcVAv0YwqACLgROD085Fpux8hOELYtjrRsVCYwIvRzaaORU0ucvPqQhG?= =?us-ascii?Q?+geKnsVE19hmznBi9Q150fuQzJdW9h+bWRK2MVGIwm2ZYb3ZZicQQiSFD+p0?= =?us-ascii?Q?FKmMoyTdMDQaxpL1njoP6zwEt8HLok4n466/CPTRKHRdbeMhiQLSsd72rHjn?= =?us-ascii?Q?q5M4KBs7w2FwdgnKeosTCdgqAmgl2vwFDxPmDSGIC4wCxxgj04P/UUcih9CY?= =?us-ascii?Q?b5O4KAOHOJsS2vdJVtDORmdb9enauXsdWr1YHxTL/NE5ENr00OwvjV7nxlCE?= =?us-ascii?Q?MaRyNXkF/wtGLc1sHuFUDBb29VhPmFOIPxBuSB2M5Q0JzJLkn8bEm1J7Wr+0?= =?us-ascii?Q?3QHt/z7/FIgu2GAjpJ2kGNgsXUyI+pkXr6vwOt4LG3pjY0P33KExVHsRiGAC?= =?us-ascii?Q?oNrBT5b0eIC2Fr6g2oAN5l+DOKqXmpVjRbfLq8Mgs4Y5p/ufww4EEhP7qfOc?= =?us-ascii?Q?UxLc9NDp3ZFFC7OWznkzlJNGWLVGeQAzuj3z/K3m+UoPHpwdatb6C/pV3BEK?= =?us-ascii?Q?2yLv2DQrkLT62r13WZNatr/m3xnMDeSaajSYVW+6q8XdpE9mTIF/kqu9BFdI?= =?us-ascii?Q?IuR8bSIQzFwXJY6B+VwEf8JlS18KMZXSyV6IiQHVnoiSnXUn7wta7l+jzIHk?= =?us-ascii?Q?gSVjD2kGGkluD3qwTpU/nXX9dl2YTA0+SBQ9Om8GrjHGMN7PPIJ97LaSzrfW?= =?us-ascii?Q?+xpGHsb4JsGvskRejCBjVNiB7ydebK0hiMINb20FGN7agjQOaUlFPGTbkzad?= =?us-ascii?Q?5YlTFHcnjB7YzF3csaR/IC6Rhb66jHrlwh/fb2azc85M4ow/QQ8oG6VpWMg1?= =?us-ascii?Q?aulPu7ZW/WYbKzBwCgj50CgQM38j0zkXzaSbzCQ3M4uWP2fVpcjAmpyLquYu?= =?us-ascii?Q?XQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1727b7f7-3eaa-41f8-cb07-08dc6b717894 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 13:03:47.9484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c2ZOtqTc7X9Lwr4a2zlC9RIgVdAyyFlEUOk8QpWc3uXrj3rsLSuPRBrCvboN43Uov853TTRgpm6erRHjToTg+hR+DyCeL3BGMAG5XDrmzbQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4570 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 03, 2024 at 09:46:15AM +0000, Tom Jones wrote: > Add support to the contigmem module on FreeBSD for multiple concurrent > files, this enables running multiple dpdk instances with the nic_uio > driver. > > Add relevant parts in dpdk to support this. > > Signed-off-by: Tom Jones --- Thanks for these patches, I hope to review and test them soon. From an initial quick scan through, I think the changes may be easier reviewed if split up into more than one patch. For example, could the changes to move the "SYSCTL_INT" declarations from being in global to local scope be separated out into one patch? Also, if the kernel module changes are backward compatible, they could be in a separate patch to the userspace changes to take advantage of the kernel module enhancements. Is such a split possible or are all the changes tightly tied together? /Bruce PS: For sending new versions of this patch, or as a patchset, please add a version number so we can track what version is the latest one in patchwork and on the mailing list. [Use -v flag to git format-patch] Thanks.