DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Tom Jones <thj@freebsd.org>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] freebsd: Add support for multiple dpdk instances on FreeBSD
Date: Fri, 3 May 2024 14:24:33 +0100	[thread overview]
Message-ID: <ZjTlkTqjXu_E_5qr@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <005a46b7-e86e-4530-80e8-955bc0cb5411@app.fastmail.com>

On Fri, May 03, 2024 at 02:12:58PM +0100, Tom Jones wrote:
> Hi Bruce,
> 
> thanks for letting me know
> 
> I'm not tied to anything particularly. This change isn't compatible with the previous API, but I'm not against making it so if that is really the best thing to do. As is, the dpdk changes and the contigmem changes need to come together because the API changes for getting the physical addresses.
> 

I don't think it's a major problem if the new kernel code doesn't work with the
older DPDK userspace code, we can apply both together in one patch.
However, it would count as an API/ABI change so would need to be deferred
for merge to 24.11 release, I think.


> It is just the sysctl paths that differ. I'm not sure what the compatibility needs to be for DPDK, for all of my usage I have built the kernel module with the package - making API changes easy.
> 
> I'm happy to follow which ever path you think is best.
> 

I'll maybe give more thoughts on this once I try the patch out. Hopefully
I'll get to test it out this afternoon. Don't bother trying to rework
anything until then! :-)

> Sorry for the patch confusion, I'll try to keep the sequence obvious going forward.
> 

No problem. Thanks for the contribution here. FreeBSD support has sadly
been lacking a number of features for some time now, so all changes to
close the feature gap vs linux are very welcome!

/Bruce


  reply	other threads:[~2024-05-03 13:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 13:55 Tom Jones
2024-05-03  9:46 ` Tom Jones
2024-05-03 13:03   ` Bruce Richardson
2024-05-03 13:12     ` Tom Jones
2024-05-03 13:24       ` Bruce Richardson [this message]
2024-05-03 16:25   ` Bruce Richardson
2024-05-03 16:48   ` Bruce Richardson
2024-05-03 16:52     ` Bruce Richardson
2024-05-06 15:34       ` Tom Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjTlkTqjXu_E_5qr@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thj@freebsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).