From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 317F443F76; Fri, 3 May 2024 15:24:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A103B402D0; Fri, 3 May 2024 15:24:45 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 0B60E402C5 for ; Fri, 3 May 2024 15:24:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714742683; x=1746278683; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=FgZ4RVu6C8ObzdxEHtCG+yrq/eEJpfpVwxvdbpsHrMU=; b=lj+uetGGnfH01bs9PUS7EA3jvzFb8SR0hSr2j6FkZ0+SCsF4mfcSSV3a wZTS1FnH502ECNGuMLywp+jNisZ+nVXnZyrV+etPfXTzCF8OBv0uW0fdr fms8q0PUsLk8LeWE8KOAa+ZNMyS2B+OV6XLH2gI2EFPZwSWNtkWk7Tx0e BwyHqNilZ8hLF1W9sjKdrkePwr7rNTrVLDpscdHRQr4CG8tYiMpgMZfyv DSVbMdXyEwPDZxhGDPCSZbN0hZw24gQsvCfuBwggkjXso4nbIPWGUQ0Pm A/upDqYGOxIhK+VJiBZt6wUNo48wSbhMGSFBmUB3LeAtKxIbEPzEvhq8p A==; X-CSE-ConnectionGUID: hOBlllxuRHWRRpsng86pKg== X-CSE-MsgGUID: 2WuEyhteTnuS/TLT0WV0cg== X-IronPort-AV: E=McAfee;i="6600,9927,11063"; a="21237004" X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="21237004" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2024 06:24:42 -0700 X-CSE-ConnectionGUID: mJ/UXiDYQjmpQyigcOAKJg== X-CSE-MsgGUID: HmaH3sJQRDOte4nDwYaTbA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="27329915" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 May 2024 06:24:41 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 3 May 2024 06:24:41 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 3 May 2024 06:24:41 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 3 May 2024 06:24:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WWdXljZt3NedvrB/axu+XGr/DqCfHc8Tpxbbq36ZyYjkMdrBPpsdVdWjS5O2JGzc4QhYk6wZNjmFzHC2tHPhDKg+EEMgWxmB3mJc79p+bnV0kgAy0KrrFhZssceg4pCQhDdjQg65rodUI+qbBctHEg+FS4uYB+T48OeSSbP5yWIDK0/hzEcZxv5cAY11tfYazHFt+FMBPeLvIaudgQW+o33XZrqBsvVV2tk/TjVce8ndZoOdUhm58AWDtj6pT/8dwzGkPIXtOTVSKVhR3FLoCX35KTDioF1rM60Aqu2paKTBFfL7DmeSrDNW0X0EGJJUewZiY3tMb6KRX7UaNTdaOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ea9ibsrcJmuY8sgIa1byfGQAWc6s2VaklHNEJrBYaao=; b=GvruA5VG2shaXWzi/mMtQeyHu+mdUA9tq0rkWXIG0KXhwEAOjohFjWBzVSfyc+CZgVPlszt9ZgyxeAUnQPDnJFnMOCYW+Re/SKUHE5w+8Jqqz/nOkmNIrBcCkNM15BwWX7WH+wc1/DElWSB6KdAPer1OCICdO6DcbVLpPO9NZiH3WzC+PG8i1kCaH3ZeZWXo1ie/F9T6SpFt45yEsJ1oIx3un/1Xy0rNsg/ucmwhJMUR1nuEALAH2Bup8o1O0ZrYPBhJY6i/GFFB+b+2Ig2IetMzj3+5LKIdANEIUkRJE3ery0i2ULJCo41bvyqUA6JT/tCX7WFZNSAZRKWTZkyJvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.31; Fri, 3 May 2024 13:24:38 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.023; Fri, 3 May 2024 13:24:38 +0000 Date: Fri, 3 May 2024 14:24:33 +0100 From: Bruce Richardson To: Tom Jones CC: Subject: Re: [PATCH] freebsd: Add support for multiple dpdk instances on FreeBSD Message-ID: References: <20240502135541.47142-1-thj@freebsd.org> <20240503094615.1427-1-thj@freebsd.org> <005a46b7-e86e-4530-80e8-955bc0cb5411@app.fastmail.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <005a46b7-e86e-4530-80e8-955bc0cb5411@app.fastmail.com> X-ClientProxiedBy: DU6P191CA0050.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53e::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB5005:EE_ X-MS-Office365-Filtering-Correlation-Id: d6cf21a0-85a4-4167-7449-08dc6b746208 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ZuuBmB5csO9hKIX03CoVWNxJMMJiPWN2zSwE5sPY29YxQ9TVFFDpZdz/ebu1?= =?us-ascii?Q?bbZSMDGdRJ6ee/FA9U3/ISJSVxXgHz2G3zdMXt/l6SzO/yIhgUsdlIhBNy1z?= =?us-ascii?Q?skilOjQJb44sZFug6t/nnKc2Xjxv0/hIrUs3QditPVMF8qXCPeTRhUZrXUpZ?= =?us-ascii?Q?a/EGdERW1nOm3vjwhAinmulstQBzHWEk6REXP6Y5G4OB5Q97K1pod36bWLRw?= =?us-ascii?Q?Ku7T7asunRgdj2CG1GRtERb6xL245ZVDpZaWmdF2exPPMeqtzaonJb3W7JyZ?= =?us-ascii?Q?6vXh0qw7PFFaq0sqUldbu5c2Y8SE7nHktX77OVnG+eLPvmscPT0GpyjMbMru?= =?us-ascii?Q?FzFwOUBDZr2d+OfZo9YpvfnZ0gbI1sj9+Ntb5yTjGEw3c9ivw9Oh5kHJgtWH?= =?us-ascii?Q?xmQHH18L9yzG4CGEdKAO+NnRTCqNtP5oXG2HSgG6YpMY7AMbho0g5rkcAxtn?= =?us-ascii?Q?LExVekDRGDIofO2OE1skucC3I+eRoXf1Yq1735uj026sdD1wRymnbp1xf5Nq?= =?us-ascii?Q?hRWqaEUzZxYKYmYp3ZODknosPyZdkONEIJltkdc4BKBR/Em2y3z9lPdvFirx?= =?us-ascii?Q?dnrHYHj5NblC/BcUj0Ju3BbRp+dw8/spIdpi9BmNYcP0lE8AwbRwaLVCF/1C?= =?us-ascii?Q?f/iEjZ3LTn8c4JrUM356DFyoaIHDJR02Vjo1B5vEpNr5N8cBMpD3g4MCR50R?= =?us-ascii?Q?tgW9wJq9qVcHtCIiUi7SZT6B1jBCUauoOc6qyXMhmQSnon+JtQ/o+DpkwlLO?= =?us-ascii?Q?fzZasFgShStJJoucuXkqshFpqnEbpn0tyFsWVz2qAz8aumqPmmYEjbHLw4wC?= =?us-ascii?Q?PKmPuJV/ocFioVo84Eqsgb88SbCCYsF5U8uNpE0gAHmAVDimMfCVfANWbX40?= =?us-ascii?Q?XzeSg1YvnKE9YFUWQey//fsrRAO//r9QNFDCeoglXD9F2ps+jAA5+LyH7AFe?= =?us-ascii?Q?FdO1YGd7zMvnra/66hqTfwIjSSvWh57wUmT+FmYr3w1ZDXhD4p1tENfq5kgo?= =?us-ascii?Q?SeYB5MKX9yVnq3iSJbkj+kum/jnrJriUtKWeI3dYq57uKnxdwx7OVGxJEc6n?= =?us-ascii?Q?Ykst1OyXp9aa5EIXM9TvCBzNIeL6kN/lT6bi9dneYRuOu9CD1v4OD4gpxGyc?= =?us-ascii?Q?vlfiEJaISPwU/Tunpzyl/A9Eg2avhZc66tb9gdfklFAv2yoH2CZTlBo6Tlp2?= =?us-ascii?Q?NZQBuYtqdhQC7oSkVH/UDI2/fuz1bK2nzBxJp7pp0F5go5pLiCbrYO+gl2UH?= =?us-ascii?Q?bMMK/rwf8JIDCXPq4PN2aAPTqGQygbCr8UB6n9qrmA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5cXxCTFRRDKggV1gflOdRNEIQWij89YB2KzuWuINhmJs8eaxDDCvEu19zwmN?= =?us-ascii?Q?3MChinXGK9pUqbEAVT8hjoK8eaZt1SnCQdQ9UbrofL9INaaWF+s39tMxljlz?= =?us-ascii?Q?C/mrkKbHGmY/G7CJO0HAiNk35XkfkvglG09ZkdiBwT43uHLQIs0qPxbd15e2?= =?us-ascii?Q?pyW6D2Zd0MoBklXcpYSqhbi7T/Gj91/FTaxfTgwZ6tEbJ9oBEuYKqA7x+ZY/?= =?us-ascii?Q?LgWP08zFBCowV2G1UKtmLCAs9ODhwOv534i6hLE1RpE9l6TfPm2/TCgKOvt0?= =?us-ascii?Q?FTmES4tdThB6t72GVFZ8EhBwPil3jylUqXHtiARXa4L8DU4pesXK8V7Nj+Zl?= =?us-ascii?Q?/5/jL+vrS5LKmHwTNrcri5m8Y533JEF7Ve8D3n+jxG8SBzFBfsfpD1GRttmp?= =?us-ascii?Q?2PvqnlHxAl5uc8Vih06wwzaeEqrwQwfHk6eWAuaVN+4vHxbAQZMibPbMqata?= =?us-ascii?Q?wYn0Azqr3gsiKIL2DTwPwpD7Tf7CYwkNS12fmgXFhkQW53J+SO4HJ0TkLlVG?= =?us-ascii?Q?TPWLzTnB0EPcJFo0vd5qr950UBmIk8scjMIaIjQPX1d9YCSwN5+iynP8z38O?= =?us-ascii?Q?ifWWfAHNjvfGEcwXaO0tF7b983rkuqg7T4U9kyiQv2A2SZekdxk6HL83hhpV?= =?us-ascii?Q?hrVK0IvHSsl+I1MsjdRvk9GyWBS9RYMgePDdpwwuSu1vRw3qMdF0+1XOEg//?= =?us-ascii?Q?E5kqPD5yjtYkNc4dqQyMQVK7wJBMVeyr8HSgWVApu+exnkF6sjSrkexAS3tB?= =?us-ascii?Q?ybAFbvfRPSLSN1is/WUxVcnG+b/FD6UEhzVEUwmVPSfcMHxo+1a6SOvgnDIM?= =?us-ascii?Q?F6lX/+tQRBn2rIUxKWaGf+qMFoibFeu9vHaZ5q/iuzU1gkMcGnT70QH3n46V?= =?us-ascii?Q?MlUhGTC4kCro5wNgZlHNkv07iQ2Fg4fH4te7fUsORDeAVpI/5rVrHGQgEviY?= =?us-ascii?Q?euiuJ7lddtJ9RoZufGZfPKZ/TeOvf6AGGVcEispqhC7WPD+tTGClG2Jh5NxC?= =?us-ascii?Q?nJg0ObKtDefUgF8/a6EMchkeE0oC472Gs27c7Y6/SahZVcK/vlLWj2NI48w8?= =?us-ascii?Q?hgFiiGFcywvUhKhCPRK3VX84hdHUK5p3uYWZVggYtof/mmA6gkZXCS/bBJM6?= =?us-ascii?Q?0bfkwV5EZPN4p2RCcdwBjTbxX322XvGdny4Wzv/DrQwS78oSjHhjatPYwxbm?= =?us-ascii?Q?DinprKgFXOc0xnfs4d5jhE1FYr0y1GINHQzrY2CyriMsV1tRJtAKY1CUN6ED?= =?us-ascii?Q?yASj8rH5YInALtxU4o2AsPyYoFUvEQTHCO/mD4LCpJoQY60R1oOSh9lI5VTZ?= =?us-ascii?Q?/Bm5oeGYMP/GiwBysrmB4cfoO2V5Ul94khoC5u3TOiuoiiVotyGn+hOV43Fj?= =?us-ascii?Q?Na2E4UoMfHGjYsXYuofAbEmcdN0tabRqYxinryzyUjSNG8Ex/h5lbeYist9k?= =?us-ascii?Q?V+LIl31jecSSgO3wsrVUisd3wGuGiByzSk2mkvuRk0P8yi5wqC0YXdgAdYT9?= =?us-ascii?Q?uDp63oKWmOmdMrpf6+w0U/U+vLcGWThdXQn38L30xAIZiYSWFQN9hbwHwM59?= =?us-ascii?Q?m0A86Jc1o68Slg7yPSbeJ1UZhLyvLBnbkudoAxagu4NPP5kpIpS+qTOtWt8C?= =?us-ascii?Q?wQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d6cf21a0-85a4-4167-7449-08dc6b746208 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 13:24:38.6887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FhDbIS16vof9zpa9GfIlWouxeWHY/SkAfVknSgAKmsgP7AyPcJwY69muizGhw+1EHQI+aBsB27IAXGtsgk1B6e0dyccM5LxewSozOULhD7I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5005 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 03, 2024 at 02:12:58PM +0100, Tom Jones wrote: > Hi Bruce, > > thanks for letting me know > > I'm not tied to anything particularly. This change isn't compatible with the previous API, but I'm not against making it so if that is really the best thing to do. As is, the dpdk changes and the contigmem changes need to come together because the API changes for getting the physical addresses. > I don't think it's a major problem if the new kernel code doesn't work with the older DPDK userspace code, we can apply both together in one patch. However, it would count as an API/ABI change so would need to be deferred for merge to 24.11 release, I think. > It is just the sysctl paths that differ. I'm not sure what the compatibility needs to be for DPDK, for all of my usage I have built the kernel module with the package - making API changes easy. > > I'm happy to follow which ever path you think is best. > I'll maybe give more thoughts on this once I try the patch out. Hopefully I'll get to test it out this afternoon. Don't bother trying to rework anything until then! :-) > Sorry for the patch confusion, I'll try to keep the sequence obvious going forward. > No problem. Thanks for the contribution here. FreeBSD support has sadly been lacking a number of features for some time now, so all changes to close the feature gap vs linux are very welcome! /Bruce