Re: [PATCH] freebsd: Add support for multiple dpdk instances on FreeBSD

[Bruce Richardson <bruce.richardson@intel.com>]

On Fri, May 03, 2024 at 09:46:15AM +0000, Tom Jones wrote:
> Add support to the contigmem module on FreeBSD for multiple concurrent
> files, this enables running multiple dpdk instances with the nic_uio
> driver.
> 
> Add relevant parts in dpdk to support this.
> 
> Signed-off-by: Tom Jones <thj@freebsd.org>
> ---
>  config/rte_config.h                  |   2 +
>  kernel/freebsd/contigmem/contigmem.c | 225 ++++++++++++++++++---------
>  lib/eal/common/eal_common_options.c  |   2 +
>  lib/eal/freebsd/eal.c                |  12 ++
>  lib/eal/freebsd/eal_hugepage_info.c  |  12 +-
>  lib/eal/freebsd/eal_memory.c         |   3 +-
>  6 files changed, 180 insertions(+), 76 deletions(-)
> 

<snip>

> @@ -238,10 +312,14 @@ contigmem_cdev_pager_ctor(void *handle, vm_ooffset_t size, vm_prot_t prot,
>  {
>  	struct contigmem_vm_handle *vmh = handle;
>  	struct contigmem_buffer *buf;
> +	struct contigmem_device *cd;
>  
> -	buf = &contigmem_buffers[vmh->buffer_index];
> +	cd = &contigmem_device_list[vmh->device_index];
> +	buf = &cd->cm_buffers[vmh->buffer_index];
> +		vmh, vmh->buffer_index, vmh->device_index, cd, buf, buf->refcnt);
>  

The CI reports build failures with this patch, and the above is the
offending line. Looking and comparing with the previous version, you've
deleted a printf, but I think you missed the line continuation of it.

/Bruce