From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B020B43D99; Fri, 3 May 2024 18:25:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7197D402D1; Fri, 3 May 2024 18:25:28 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id ABCE6402D0 for ; Fri, 3 May 2024 18:25:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714753527; x=1746289527; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=LviH2uIng1rvuFhRpDiSscgYHAEOCKm1/K0+dalx+Mk=; b=mT8THoivqfxyFyo+2MpYC9fD7uEkffSvXEICJxoMT7QVqUyEP9WCqzX9 UOn4ydwDI521FVYNkZwTLqUY4J9Sai7IHRkbr9jBSt0ZQQnv53MYPPdvq PoIPeeIKv8QZQh/TJslF+eNjbTPj1pi5eH/M8mf7HwtJ30TxilNNu3S9R feBjn24lMwnbgVmHEMelO9p1+RXOuEelxLXDIFUD3lhYzBIcG6gvOspnR QSotOxBFeEuVkeXLIzOZ685AsVmuZRI0wct8zjnHlbXN/f2R7o7yGPFfp Hu8A3VCD+Rm/5rpSq5zDO4AMDsUu7uZ/URHGV6Ew379Mo1M0sB1DOD1lJ w==; X-CSE-ConnectionGUID: f1Ky2NpnQ6+85VGik+cq1A== X-CSE-MsgGUID: ocYz4ti4QiSd5qjLr/HA2w== X-IronPort-AV: E=McAfee;i="6600,9927,11063"; a="10398315" X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="10398315" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2024 09:25:25 -0700 X-CSE-ConnectionGUID: 2PqwfiBwTzestb3U2PNTKA== X-CSE-MsgGUID: P6u8nV9aR7eE8/EjiUCncw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="64936782" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 May 2024 09:25:26 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 3 May 2024 09:25:25 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 3 May 2024 09:25:24 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 3 May 2024 09:25:24 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 3 May 2024 09:25:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N1UJqqsj8kUO9RUFNhWlauu0H/PyCb7nMfIarGBZREKxcwUQGoqpHCXs9yd5o1zTwORBFQ67SQg9wFhhx98UbA4yy7leLoFqa4BTtszkzWUa2FC+bxhv/PX9nHpocbq1dM5sJqRM+DcEaBtQHi3tRvxHEKRwjyXn6WWjD4MRP6aOS25HtnIL/wB/2nI+H9Zp5aCSZ8yxLPVynEsD5DU0fBiu6AgItqPC++t6AzUpBmd9TvCLg7j6FFb24LJYoB7qRiscJQTFhmOn4NaDmmaLx8Vb3x3G4Na9mlOGf+q6XN7ysvWToxel7uTXfNhZtALA7FGFO2rLztAP+clKHF3FNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z70uGvxwkh359DZo9l2mp6lmq4DaasQ2xj2Ld6ePV7U=; b=NJ5ninURGFputGDL6trlLos3GVu1B+2nZTj6gLrquedbLDWm7PlQUz3pods5Lshx2qj5VKwMg6qdgW0VnwhGnK6RsPBkgQlBoTBRrERJh/7BgSlJ7Y0HuauqEsqBxr9BDI+eC8wfB9GhdZSXHeV602jaAWSAaisN88rYpzzxUYVLMFn/GYbvE/DRAIOkSIvhLW9U3CSAGiVOhK4IvCynRAJimqMt+qNLV0mx8UZfeE8mASIOlZ/UAHJKxUB4YiVDsQSL9+/8JdzFIoQL5C/RFMP623VCHvcpMr3g9+OpNlyEFOvuO6JY+FHrnhunk/V4+smw8wzqG2W7ebo3mBSS7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB7154.namprd11.prod.outlook.com (2603:10b6:a03:48d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.34; Fri, 3 May 2024 16:25:20 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.023; Fri, 3 May 2024 16:25:19 +0000 Date: Fri, 3 May 2024 17:25:16 +0100 From: Bruce Richardson To: Tom Jones CC: Subject: Re: [PATCH] freebsd: Add support for multiple dpdk instances on FreeBSD Message-ID: References: <20240502135541.47142-1-thj@freebsd.org> <20240503094615.1427-1-thj@freebsd.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240503094615.1427-1-thj@freebsd.org> X-ClientProxiedBy: DBBPR09CA0040.eurprd09.prod.outlook.com (2603:10a6:10:d4::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB7154:EE_ X-MS-Office365-Filtering-Correlation-Id: 5bd358a6-042e-4939-2b6d-08dc6b8d9fe8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Ww3kC6cGwASOKJJk5pKV1BAmkPYXNidHiQdO4BCN0fXhEN7mKZdxLNDsJztV?= =?us-ascii?Q?pX0TEMTHst4QNbz4unHUFfAqgtdiwKKtTGJS87T/bSMR09BacH4b4zIvfTUR?= =?us-ascii?Q?DLqfcTeLA8UDwjuiaU7ION82pxlMcpEBbe8eBvcoI3UyrJkGoxIu4j4Dj+Hq?= =?us-ascii?Q?POeuoo1l/qctvNrQ2YOhKE1kCcLLmf1mjWkCO+vUU1Qfp6kwyHp185uyeUkE?= =?us-ascii?Q?ZxnjWSEpjVPxTurFIfbhAc4Xn8bJwvndFMVGeRV3ud+pmP7AQUF0SsNRdF/o?= =?us-ascii?Q?q8/DrWVXX6/yHmnyoEpqkfZuCGlPZYahdarVCXKy8tjZDxieDKIQGOMWA14d?= =?us-ascii?Q?JfxFDl2ZoSpQxInxVnKJNDrrwYAzeIsXFCapuosJlPztWzRBdiiYK+HzEakM?= =?us-ascii?Q?tMF/pR+Ve7X7lwxN+nJIwn2Qm+r6gPEIkNI9AT4n+HZ7Kv0hcFHXc8h4jUw4?= =?us-ascii?Q?8Ct2S2BPVF0jEJTAVlbGch4v71XT0z8Vk3Ec6TEHdyyZR6K+4Pho0GA9aJZc?= =?us-ascii?Q?82NgfY3nMDM9LKSjVk/XN2m3h8az0kRA6ydaQhv6ecPikGIg0BQ6OJYlwk8Z?= =?us-ascii?Q?McZMaFx5shsYkZo0+XFO4FXPdHijt6+gGBwdyh28dTzNPGgO8YEaH4bljdY/?= =?us-ascii?Q?ZuNsvg2lMjZzyUMEdgAjgeDNDxtXu51lpYEvln0sFP76CEKEJs0uFq9OkcZZ?= =?us-ascii?Q?9abe7/2hsXNT2UJlaT1yloV2X07meaJHPCn9TqHLHx6DiZO8Sgz9Habunxg3?= =?us-ascii?Q?gvo9Ubbs6fAlDyZoXhLD6KdNl4wgLT+Tuzm0bCuHNQ7qis6gqgBJQ7iQk1NR?= =?us-ascii?Q?LJG+QNuBbrlY724bM1F3UdmDGTYSD3AhLoHNBbsSdpub+eYHWq2fOnnNeJcY?= =?us-ascii?Q?0JP5HO6e18x7SUGgpy0dgyPmlddS9Nauz/WNV4dmUseWJZsTuE+qSGO5gHd/?= =?us-ascii?Q?eufjbYIyaXqpg3X4nQ03yxkBuSliTv9k81rsbHqIY4RrddXvWIVXmE2uqtLn?= =?us-ascii?Q?9drDV3ZA2TZOh/N9A2nKEG380qgnuwIFrGIZUO10/TCGYQDI212EkIXn8Zj7?= =?us-ascii?Q?/uGcE1jwR6cLy8O2V2XI9k4LmIYN9D2r0vexV8GARc81eHUfv3UMjx5WODiN?= =?us-ascii?Q?yJMiK4DlwbvLa1+DtNCdkddzSDvCZCoH4oQ2n482DusKWPnbjaqgb1amkWyc?= =?us-ascii?Q?Q8ovsivUGt5HQkX3CS5tRHYrxvU6qtscOAD+MGMoJ9BoSHqiLxC+gRH2c6iS?= =?us-ascii?Q?EeWITTxMaQ/DMB//7JibuLW60rHdmIuZUa3vaCTy7Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V7NeI456WTfnIpIrTYjnCI4jtsd4gmTLAIdrf/fPsF00a40kGxGR6uCjlMA1?= =?us-ascii?Q?L7yo7FGR72aHA3M66g9p02ngBTmDrGxE6X/2qZ1sulJITqdvfjzHqBlEHRfQ?= =?us-ascii?Q?CDRTVnHDzSpXA7npxoPfqBAJFJ7+n2U0xe1TVJ3RpLHycGvcSihpGpwJdFuL?= =?us-ascii?Q?iWhzYlpJRSsIJiA696u6xMllhhWl5gJ3IBLnIEcRDOFjdZgumoEFbWS5ATkc?= =?us-ascii?Q?3bXUhKeB7DpbnYiL/HZFdM4zwyecKiLFujDo7FTHzKk2RkzSy6HjqOcQe8l7?= =?us-ascii?Q?JeaPQbpdGwZVi+6JpFAiXSwtvz+F/RZQtAhj8mtzS1yqucbHD87DPxmwMTue?= =?us-ascii?Q?d1tlH69UmgK9/OBQTpuwnmENo2/4b0j1GHk7B8MkIzp47j1+lmvH2NAM61TY?= =?us-ascii?Q?7JPd+U8nqIyuS7WsPPt7aJd8yv/+uBvHy6Gif47oDS0/rc3QiphuR/lERRl3?= =?us-ascii?Q?CwKo+QD4YSm+UQOjZSeIxFnfp8PbcW0vuXZXFiyMcn0E2/bCdda3ZesIQnGl?= =?us-ascii?Q?zDP9p182MW7NXhP1VqsO0Ft17I5djMCj22Me/GXKfAfL3AKFe3+scpv1z7TM?= =?us-ascii?Q?cOqB1yYgU51DW9FjpRcb3z+mXi6PrEQSdfxSYp11J2Q8wt8thiBnKsU6uCWO?= =?us-ascii?Q?A4e0UNiAQl3zJtF4Uglm1eM8BJOaytQg0FOUaqsVfdirMNqwSx+MMEwgFi28?= =?us-ascii?Q?FXq50zYpZBl6iA9ZX10c2NrWSxHq4Wo8peR9o0Dc/Aao0/KNNTzlQd7a3LDT?= =?us-ascii?Q?BU8539IhxY8ivQLhq/+2LoM2VHRCGi+zYedze7pC9ak/t2CnalCPtw2o8mkS?= =?us-ascii?Q?qOhzPD5u3asUREF3lsGKmmlBkJdvy3Oynuh8WJAaE9HAXbB7OsLJ0aFN5+VK?= =?us-ascii?Q?RvKQrnO30pU77NsLpy7ojL6Ypf7Hpy50jcCy93LAVJwwB80RY8ZdDujs5dtd?= =?us-ascii?Q?lokGgv/LjhniZ3M5Yw9W5o5VkAFjclmhuWiZwUGJXrvWr3JSs2v+2it/g9n2?= =?us-ascii?Q?/uUUveHNyuxPaoBj1wEQH4+MRUpl33/ks7F5iLmAwDUaTrKPrUFRUaF1LLwQ?= =?us-ascii?Q?+3R4nLP4MzQj5EWABt/+smmZN+JqrEs68R9DVXiUCmQ/id5iMo6OKOt6yMVt?= =?us-ascii?Q?RZFtNzMYS0LtwevJ1EJc14W8H4S999hUGTA1iJ1JFzEd/ODlra8g9nBEDlEN?= =?us-ascii?Q?BJIlwBvm+3lKpSydwEdxZkrRdneeW3z7ubygyj3VA+wgeQ9uYDQVhQLaL9b6?= =?us-ascii?Q?eC9/Md9IUqDKGNE5M9+Ulr7Qq50xM7CzAhNdboM/kNnRMKGwnRfDN+yoC61S?= =?us-ascii?Q?U55l21aoqMr9Pivyiec4ia5hAC936EU7kHz6D4czKhvAIZILi9OOUfh/2Of/?= =?us-ascii?Q?/SB/t1A6kjzGMXxlXe4MvAG2VKdERJpmjBF4Qgl9WP0Sw90Se0Ucwku1WQZT?= =?us-ascii?Q?pncPBdVlN45WAAbV60SZeHjNjGQAQ0ASOdv9g5uFesLky3aHzbE9K2LBHYyj?= =?us-ascii?Q?fQ1x7AzusdPyVAHlJcmOH8gwklAmiTaQ3b6A1/d6dsh2pSR0CGH+QQg3IYzT?= =?us-ascii?Q?qSzR8RVJ3s6OXRIztxRVRC4B7O4JmVWQgUnxVZgA3sqfRxIjBEQi8x2+Y9+W?= =?us-ascii?Q?SQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5bd358a6-042e-4939-2b6d-08dc6b8d9fe8 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 16:25:19.9175 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MrMvSYvwlpfjOT0WYwcJMGhKITttWfrp4+RgQC/Ccfm2nnLu2qkNquDbHUsM0FEUaHi4AdLI15q+0bpy821LwgWm02l3YTfoNuFzen3AzQY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB7154 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 03, 2024 at 09:46:15AM +0000, Tom Jones wrote: > Add support to the contigmem module on FreeBSD for multiple concurrent > files, this enables running multiple dpdk instances with the nic_uio > driver. > > Add relevant parts in dpdk to support this. > > Signed-off-by: Tom Jones > --- > config/rte_config.h | 2 + > kernel/freebsd/contigmem/contigmem.c | 225 ++++++++++++++++++--------- > lib/eal/common/eal_common_options.c | 2 + > lib/eal/freebsd/eal.c | 12 ++ > lib/eal/freebsd/eal_hugepage_info.c | 12 +- > lib/eal/freebsd/eal_memory.c | 3 +- > 6 files changed, 180 insertions(+), 76 deletions(-) > > @@ -238,10 +312,14 @@ contigmem_cdev_pager_ctor(void *handle, vm_ooffset_t size, vm_prot_t prot, > { > struct contigmem_vm_handle *vmh = handle; > struct contigmem_buffer *buf; > + struct contigmem_device *cd; > > - buf = &contigmem_buffers[vmh->buffer_index]; > + cd = &contigmem_device_list[vmh->device_index]; > + buf = &cd->cm_buffers[vmh->buffer_index]; > + vmh, vmh->buffer_index, vmh->device_index, cd, buf, buf->refcnt); > The CI reports build failures with this patch, and the above is the offending line. Looking and comparing with the previous version, you've deleted a printf, but I think you missed the line continuation of it. /Bruce