From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 502FA43DD5; Fri, 3 May 2024 18:48:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD128402D1; Fri, 3 May 2024 18:48:16 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id EA257402D0 for ; Fri, 3 May 2024 18:48:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714754895; x=1746290895; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=AOTuBPi6LG/BlJTLpV0F3c0LAUPlDL9lvdBlr1D9F/0=; b=Rw2PaLtZ3I0agSJceZ/j5LXJXI3gB+45LS7nB7BJeeYMZdVxi0bx4LEo Uq4S3u8qftLL0TEdP70Wi/7X0C+gN1LaB8nmaFeKLuNorqZyf4jSXBiPF yEx2M9wD6sAHdluxxdgElshIHWXo4+IHMZOFRicjba8EMBlD3QPUaHbR3 eWh7QB9qGIpnibShoXPBGqTmVBLvir4xRPw2nxKtJsYA8z4B+zoEufqwC x/7xTrkDeqMdvsodxpqBPHszwblWxD6Kk9SUH7XWp/fFdKuYkeacAb7K7 38X4YKbMpE56XWy21j+clYsdWO64ciPug4SgC/JaQFFepsy77q6WQjsT5 w==; X-CSE-ConnectionGUID: Kd5umsiNRPSycL8SjDDThQ== X-CSE-MsgGUID: iN00p7prQgm1Mle/SfbADw== X-IronPort-AV: E=McAfee;i="6600,9927,11063"; a="21719878" X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="21719878" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2024 09:48:13 -0700 X-CSE-ConnectionGUID: LfABHu8uQ/SvkMJ5CZ5V5w== X-CSE-MsgGUID: bdDNlVgjTXSSkczFiUsdbg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="32175034" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 May 2024 09:48:13 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 3 May 2024 09:48:12 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 3 May 2024 09:48:12 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 3 May 2024 09:48:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VTJqapD9fEBchmY6Vwmz2V5eBiwAalmxvPMfdragdyXIb88hIt4C6kSPC0gEkeTFtaRmWILG0weeL/iLGzVxBpitr1fXrqlBDNRjEVTKgmsb1VLJgm1hThlTy/FnnrNEIuJNjd5ESIXotN/QJJ8U2SUyu2MmFYvtlyTHdOZt5Eux9HR9gy/tHGJ6qiLSJSQ67N7QJKqI9nnfK+5Uocv+/lc3ntRtef8IKr80EeQQvgZvtH4An9yki6PmoPQVCKYk7L5Rx1lesBOiO5ayoPyw/B74YCZUaRlIvC0eYlbRVAEkE8W05pDub7LHdflJOu369GRkaW6etNac6FAIA/hT3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wa2qNuc1NcPX7QpNEtJuQ6opX+HrgYgXAtv5xHtykG8=; b=S7afYB8CqP3sYQJ/4pPrgImQ1MRv4sdMjkBDvf3xiRW3qbN6WDK3PoYbCU8K6SbjSdoXbeXLWJjZqzpmXfIWOj8uzw9rxrmTwNc43rEjwxCWDo7buMfRNIOq2YA4OsRbTVztpFgYfS4xb8ZBafEEeM9lz9fH5CNf4BhPzaVGirVsKiXFqdziTG3gWvk1pCSvk0rmXdtKoazl7JBw92C64axc/iV88CN6BxLhFr2LIIM5NoW6u6Cj3ft4flVqUGEs++Dy3POdIPSLapNrpcPfX6mRyES4wTOdCA7djub5p5steZknPNmuQaO5t5km2nb1bz4O5Ney67kXDM5gfTQmBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB7550.namprd11.prod.outlook.com (2603:10b6:510:27d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.43; Fri, 3 May 2024 16:48:09 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.023; Fri, 3 May 2024 16:48:09 +0000 Date: Fri, 3 May 2024 17:48:05 +0100 From: Bruce Richardson To: Tom Jones CC: Subject: Re: [PATCH] freebsd: Add support for multiple dpdk instances on FreeBSD Message-ID: References: <20240502135541.47142-1-thj@freebsd.org> <20240503094615.1427-1-thj@freebsd.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240503094615.1427-1-thj@freebsd.org> X-ClientProxiedBy: DU2PR04CA0296.eurprd04.prod.outlook.com (2603:10a6:10:28c::31) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB7550:EE_ X-MS-Office365-Filtering-Correlation-Id: f995a313-67b3-4c1d-cd07-08dc6b90d063 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xUKL78z/QKVI8mGFDeD3e6MlnOANGInKlniMcQk/pKZGxHE9wZQWumDxDieU?= =?us-ascii?Q?Vym+MmJ7vBdLseJV7kh2hc5T8fQ60C5hAcm7s7EBw+6Q8m9N2lkOP6Zq5Dyl?= =?us-ascii?Q?lkUZkSgng9udJIr5IjN0Nx83BBFZH69DarUkbRgXHe5VnN+c39OGEyi14yBU?= =?us-ascii?Q?ZX/B4AgR4EmpyExybQJcS9dudaDWvrAkzYY344BNgl0NO2HLQqwwjd+nJL07?= =?us-ascii?Q?XJeJ9auDbFLr4TiPGsriwF41rjDpFxqdGrUQRc1YsfiUF7cFlShKJHC4SJpA?= =?us-ascii?Q?4niVPkzNLONX4Zn2xZ/2bDMn21DjqrkhlFcVZlnhZosVckrCK7Gvh8XYR7aB?= =?us-ascii?Q?YyDHlnT+UjFjeDMDmojTLD41c10vsOv+OK5G4d2aoTTkLKa8z5/8de0KsqRL?= =?us-ascii?Q?gyYGTVl2k8FVswDBzlmAiuGzV20/gVR1cXDq2vFmFF1QoyGY8lPA94BHrTk+?= =?us-ascii?Q?1xthA1IvJ+wsv4Ibqp5gxSAy+pMIQxJ0n7/QiDxuJHcZm0dW6q1WyOaTX+xb?= =?us-ascii?Q?HlJg1MgGZ9NiwRnpFcln4OvQpUS/dlTTFOmeUY/8wbbV+JY+feO4rwEq1IUB?= =?us-ascii?Q?6lZDZFP1Dac64Iko5bVxwzlFOpz70DonGVFS5W/6rqbieX/v572N6kezlGt4?= =?us-ascii?Q?ZoABiMIqJlJbE+yfQB/2DBpPWb9YC+shmMCq1RTzzKHGDjLpbQSwIDaWtzYQ?= =?us-ascii?Q?rnBkDXu/FGdxFHoYhHaPm+tjvRSgCdVE0BYQbSIHxWXwikXJXFS0ubtX62OG?= =?us-ascii?Q?GGx6OGemgaq5Lqb5XBXqAOdtEHqOeE9dyeGeU6Sao08kByEC68h+r7ign74u?= =?us-ascii?Q?CLcjJk/QeOUYBnmmePkQcIqeJe6exU1gRk4QIzbQ2QD1Ht7W4xmQcvWIuFIL?= =?us-ascii?Q?4HmX+3Fj0RIj7LhmhE5IxpCoJeT3biTbjbVvEG4Dh1yyBQ1qZIQmoxAwjQFU?= =?us-ascii?Q?9b1cHtdaSuNMKu50pK7oBsW0Ow7atcR8Zwk+xutqZaw6xLNr2db2zHAorIxi?= =?us-ascii?Q?0U2ltVn/QhKRG7OvvieBiCSTtgG8Ei1q75SrEe8TG6WcbFP5+aCS1c8ZtMPT?= =?us-ascii?Q?D8sZ5jig16eUCbCNTIEdGAwZ/8PPDgxHPCtoHm4CbfAx38IyVoDaNDpwygTY?= =?us-ascii?Q?AqUSE+k1RYtsW6/85/I3br0apA+46UdjpqS3dc0CeEEWB4O3802qZ4dfICuR?= =?us-ascii?Q?GLu+Ivq7ubqeSzzXyGQWk1YJmGf4XNm1FrbD9lX8Mi2/fLtixuAeIHVOiiS2?= =?us-ascii?Q?sY9aRhNqvpsfv0toWets9c+OAcO3u1fqzKZacPZ0Og=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?txql7B9eb9yn/kmIfn1eBpCg799NkkfacNqchILJxMHIEzxY4N1CPyxR9LBX?= =?us-ascii?Q?ACQ2TSlPw5/73+gUEc7/L/ZPTuym37CowLYxQjrSA+V1AeLk9vPg8XkmZ1yR?= =?us-ascii?Q?u7zfoWUjJLD2gXWF26mgT/cNIqn1/jss93Yjv9OYBAdtoUh5BwzQc8gb1u+4?= =?us-ascii?Q?vZRTQ2hJG6+MqoiuwYxpBl/DHnhk4kdyIFqhhnSbMIRHLyzzo8dI67a2SYuU?= =?us-ascii?Q?MFKvutR4UMHmd9YW7tr6cEytQxx5qROP4h/7ULFumBAFBTXzB8/b4IqatYWj?= =?us-ascii?Q?xPwHiDVkuOZzBqejOEB5TBpBtMJ1n7fxrE79NeGAQHxCgNKuFITuhEsPPzZM?= =?us-ascii?Q?0/JLZngTxE7t7cixHomQJZ8o4A7Oi6Aj7goGev9SqWUeGjpULlqhOVCPHd+G?= =?us-ascii?Q?yj5VwHoZYPWejwDM0w7hkntJnDejgMmhNhAY4l1OZLownESrtXcukVtBWG77?= =?us-ascii?Q?dZSaFFycPnmPxep8R9fTODbZSXQA5Py49VR1XooODMyc6/XBCjwSfNKPaT2t?= =?us-ascii?Q?NavTXqBD2Ni7vsnRtIqtLrRGqP5uSr8fz5sJ8Y64LQGRpcA19G4gPE3Inn4/?= =?us-ascii?Q?hb103AjfR9l3f4/ex3Y5uhG7mC5NEvHK9l++YIsFe1BKhrE3V1YYiyoubJjY?= =?us-ascii?Q?eDTINqtkO4C8HPaoCsg29O9sUsOSuF9PMKCeiHowZgThNthDAZ8ox/M+a/RF?= =?us-ascii?Q?ezVpkFrqzHjqdryNIxR2tReVNt7RddfWK+PFlDSh8vBI9fVBPdpzv/1VGrOG?= =?us-ascii?Q?EZBIQ/xDPA7ZVP7VpplRsL4A4M6eDzRsbYK3pMANxXRwxhebQTe2ghU/EQlc?= =?us-ascii?Q?4pviCYljV+27Kd4Mx0/wuXzJbVIgqpGP2JHJFTDGLxYDOYzDvCwot0lc366O?= =?us-ascii?Q?lqYvgui8u0pNHj6Wncv5As8SLDBI3Bz3d60AA3vReC6bU7Dh0c0+s85gmhh5?= =?us-ascii?Q?mo1hOGIkYcGHMAc46+YCEx0txANN+ugBBrLSMhsq0z2eEe2Q9JqftwcQx4Ex?= =?us-ascii?Q?t07UBus1HJL3thHFZBAQ0iHtBLeDfuw49SEGZmdymoFJAXHsGE++NVp4TJ50?= =?us-ascii?Q?e5m0t4I+iJDTMDhglJ+ZkuUAq13LBNoD1rgD4cJRkExTXe2aScux3KlJHKVG?= =?us-ascii?Q?K7x6q2tJqzFuhp30N60Kjopp5Xsf5Bs61iFfrY33XPcMbinapP9PturdDoxA?= =?us-ascii?Q?h77m0vgxm9akobykwq1skHQUv+9wTGtYPWrCYfIngtH9Qnntaoex8U6Qx6ZH?= =?us-ascii?Q?tHELRaVsXnWBV+j7XHCr/YXny3vuN/IPLUMZaDumKlghLfHnh3rZ3RQdXOOG?= =?us-ascii?Q?vSChW6FYVBiZYRVAnnGlQRuVZmMF5GMlfOyMi607k6OOMCYgkHW2xulQRy98?= =?us-ascii?Q?AVuTMVuEW7+cYFcHvP7tIlauqznA3pbQhT7o3DyDxKApaHiDixUIhA5jVs8r?= =?us-ascii?Q?O9EZqCnixDDDbX6RQJFIxqzF0m/8298bTD3ljA9g2D47py60/hy+ms+qMbLg?= =?us-ascii?Q?rVaUvNpsuBZx4SML7qFEYpbFqdIq/rluS5e3+NHDpsX17qno7aCNskvA1xvo?= =?us-ascii?Q?KDqSAC3L9oN/OpAFP5k4jKuX+cBbXQVsxZXqYsRNaLBRcC6E5uaz3sxbKWoS?= =?us-ascii?Q?Og=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f995a313-67b3-4c1d-cd07-08dc6b90d063 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 16:48:09.7803 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cg3sZ03lDD2MexZyqONAxURHIWpJWsO8LnG9vresqderivd8mcBE0j/7dy2ew7CNo/CGV3PntLn8+7qyeRxPWxcI07AtSVzajANpzEXyHag= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7550 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 03, 2024 at 09:46:15AM +0000, Tom Jones wrote: > Add support to the contigmem module on FreeBSD for multiple concurrent > files, this enables running multiple dpdk instances with the nic_uio > driver. > > Add relevant parts in dpdk to support this. > > Signed-off-by: Tom Jones > --- > config/rte_config.h | 2 + > kernel/freebsd/contigmem/contigmem.c | 225 ++++++++++++++++++--------- > lib/eal/common/eal_common_options.c | 2 + > lib/eal/freebsd/eal.c | 12 ++ > lib/eal/freebsd/eal_hugepage_info.c | 12 +- > lib/eal/freebsd/eal_memory.c | 3 +- > 6 files changed, 180 insertions(+), 76 deletions(-) > Hi Tom, on testing this out the biggest gap I see is that we need a documentation update for it. In V3 can you please update the FreeBSD GSG doc with some details about how to use this feature. Also, on first run using testpmd, the application failed to start, as I was missing a file-prefix option. At minimum I think the code needs to default the file-prefix on BSD to "contigmem0", so that when running a standalone app as before, it "just works". An idea for backward compatibility here that may help us, is to omit the "0" for contigmem0 device. That would mean that an older DPDK app will work with a newer kernel driver, and vice versa. Beyond that, I'm not sure how to get multiple processes working right now (hence the doc update request!). When I run a second instance of DPDK on my system with "--file-prefix=contigmem1", I get errors about the shared config file in "/var/run/dpdk/rte/config". /Bruce