From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 067DE43DD5; Fri, 3 May 2024 18:52:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F8BD402D1; Fri, 3 May 2024 18:52:15 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id BD7C3402D0 for ; Fri, 3 May 2024 18:52:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714755133; x=1746291133; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=vecOZNqVod+3uGbl397JsQ3+L11gG65FU1xK8IfRltU=; b=maKFwhQ+5U86Z35ITJS3NoJWGkiKL8E9t/m6pLWim5ndlNgSVRoIPvma 9D3YnU0z7/q7FtIGcMBmsZDDD2FSmkugbnmHq6feoNpBn3f3Ya+DNcsvo UPAbLJHleq7+agu5W3cMpl3DmACQjqJvZQt1dH6fqsyXXdWAFp8/Ywokn 3GWxn3QzbkqTgJo8TyWLOdS/zI0tp+yo5z7zTZS+tzUckjdPG3RoBraVF u0B0XYazWgSXX5NLPYDv0CteLvxUbmfYXy8hGyXunS8pV1UR2Cw8uketG NqtBAukv8MsMmPKAWsUeFaW4FNORSrWQlTwgFdSv2MH21xcFF1GyfKaqy A==; X-CSE-ConnectionGUID: KRqZzlYmS5mkdw5i51XOuQ== X-CSE-MsgGUID: pnRzvJU3SEywOpKgpWAyoQ== X-IronPort-AV: E=McAfee;i="6600,9927,11063"; a="21124019" X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="21124019" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2024 09:52:11 -0700 X-CSE-ConnectionGUID: AjzTek24SS+CE5YyzQxhJg== X-CSE-MsgGUID: kEz5syI9Qrm01C1ZaUKs3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="27526274" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 May 2024 09:52:11 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 3 May 2024 09:52:10 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 3 May 2024 09:52:10 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 3 May 2024 09:52:10 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 3 May 2024 09:52:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K61PpA34ovuHlVEEPWaKrLlXiseTXduMJ+z2LBirx9myG++BPfNRCb07LRWFaege8W+0yMSKB6LaIkb8PybjYBs8ZJ8e17rfkAfffWCS4rACwT9d8gVnGUpIA66aTm7Wspq0iG3sE9dP91l5i92cmIQ7/UtfXkTjx/Iety2+IOr6tgAcARRTBMDrFUyZfT04sk0Jl2YhOUmzn4Niyj5FWeND8b1FqguC1FXzTNPbfrMf+F6k57FYnmq3iTqHN/v9d5DqymE0vefg/8GtWtOjwVftD3X6DfQjihWGI5cYXPjJ8tIazq9c7dbIOpUH394sIaTHd9rPR1zz7Ke4/LupNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ntwBvML1V0h8t8gwAeLfMbRsoJjCCmrNt0z0QLi4HAw=; b=OQZV5g76qQ7LJvH+1Xoa0uum5PEOxvXRQfmQNx1Ud6DPagBKXUbykhRLpAFt2SfvtCN3JOUcft1YoVPsa4E8p4XiCP4AtjrAQganpZjziDjeryZNsfD+ehHd6YMoxd+sJ48NzkAupWjpVCNyjGVe0j1PtqoJgJG2iZ0wE+zcoPWJexYmr4/5GLsf1TAHrKMZF3A7R+4lluNlbaQCBiaRyTdyUyd+akC8JcgCEhpqhisHE91HwU2uds3+2/MipCiw9kth0YGG9SSiJtEnzf1wTKWJN9GZfgPFwMzpVDqySDf4gfQPCGund6EGVWfCGxC4KDHnhaJP9zPsxCn09sMUnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by LV3PR11MB8726.namprd11.prod.outlook.com (2603:10b6:408:21a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.35; Fri, 3 May 2024 16:52:08 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.023; Fri, 3 May 2024 16:52:08 +0000 Date: Fri, 3 May 2024 17:52:03 +0100 From: Bruce Richardson To: Tom Jones CC: Subject: Re: [PATCH] freebsd: Add support for multiple dpdk instances on FreeBSD Message-ID: References: <20240502135541.47142-1-thj@freebsd.org> <20240503094615.1427-1-thj@freebsd.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DBBPR09CA0018.eurprd09.prod.outlook.com (2603:10a6:10:c0::30) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV3PR11MB8726:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c872d11-47cf-4e4a-5abc-08dc6b915ea5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XpQQslrQS+NlfIH+Bob3RHiVlZbHl72g2ULUfR6LQ+xUkIWZt5YLUUo2k1RA?= =?us-ascii?Q?aP5xwL3H9HWhfgdt1zYvn1AeqmyH2OJii5NySfpCe114gtDJ2jsK/sjxgqA/?= =?us-ascii?Q?5jmmksBo7PSRQoDHdyCYkiYbZ6HX+DIdQYvhDvxINqznmYK5YNvtChjFkgq7?= =?us-ascii?Q?Cq5cTnkoMYyHqiparHUubyzLl/col7xu6olV8lxL7Zq8b7t+OhZJGSHcxaik?= =?us-ascii?Q?7LuWmN+kW5y5CpJFCt9D+lQ20ExfTLkC4ImNZIqOl4k0XrK/Dksz5vyS7qEQ?= =?us-ascii?Q?6iMpFdMs8L6pLVLJfSsFqKfasrtMHQIjrA7gW8I77Jr5Dvi+L3SuTIAn5zlt?= =?us-ascii?Q?YxNnn5Un0R0x8nN9IFn/NX/1YOfbjeie0JfDekTE80GiV88rTsqs4nXss59E?= =?us-ascii?Q?XxFO9upHPn7C9pTapyB3TFKLNhB6ltLzvm6QoEgr7aOD22jsx/6lZlOVfTZ7?= =?us-ascii?Q?JEDu6kBABoK+oNlt/iv9Ummu7mOkS3ow5iint2daCVUZBLTByp98oZtqzoPW?= =?us-ascii?Q?UxiI/RRaIzInpUMkp8Or1k21rAqU67LA/WL9M1Eyw3HJGsBB2ODUcAzCnyKD?= =?us-ascii?Q?8yHeS0XQvQk0M2sZdRiLVUNSkz15Bj+16swYaEuQokydSf3oBNxYQtXpCzP3?= =?us-ascii?Q?nWrgr8Fwo8VMyyixi+li89oczepJNwAo0WN/yJPUxSXS2iv0HfN2LFkruVwF?= =?us-ascii?Q?DjD7owLeBdPdEx10zQDIFJ5P0QPqGa8V2xi8InlhmWqK0CnR753F8UZHfyWx?= =?us-ascii?Q?pI1nYiiys9Za47gQg+NzUC/DYuSuRpp6ppquve0js3I1BqFGwSgv6XClDiiO?= =?us-ascii?Q?GnfJNDeqAOsTKHgOX6sI4O6Aow7gZTweSXrFmP7Y/7n8Oi5UmWy1rD4JOfOB?= =?us-ascii?Q?tQa1z/Xjhs8e1shtgb0fZ3z6NBviqu088ShfOBoxesLZS+sPGyUB5/mO3V37?= =?us-ascii?Q?mCycOZDiKZuibvp6hvgwxvEDk1ZQGqeM3PePEVhkH5smZWZJ4fVLcyMe3bB4?= =?us-ascii?Q?U9dWbZnEmvdD8GCl6ua1k2tvScsp3i4EmCkIXbYDic+WG7bz4/nz1htKf/tk?= =?us-ascii?Q?jYaJmIsBmNqucGM78bHFkW1YiQLMGZ8sYqTFMcGx3Fd75gYd5TVWQbQEFlLx?= =?us-ascii?Q?lZUWUGiW3Hn4nvwn92JYg4a0thbCW3ERWeGZtALhvZ2+MtuovGmgsfct86ps?= =?us-ascii?Q?VivCTrwMzptoj2I2KHeL6ZdCsq3Lo2HDskvmTBdYsxFpVJ9+BHFbXZRQ85n6?= =?us-ascii?Q?h+E30UetSL6wOoU+iru94/v5p6VUR2VPYHZXqj5YSA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W1sxx6Z64qVsNsLlfDOfHKnSkQOuon+5krN+6o/HAqg4khTJzAF5f3Rug657?= =?us-ascii?Q?5supvGagVzMRs1ajUXfSXioPLW+dEUAKNlxD13k6Q6s0CblhMfm879QRsvC7?= =?us-ascii?Q?qd/CopemI+LJhU/t/kVNTrxlGY39ilwSfxnbbKF5PBgwRUBiD+bETuTczFsB?= =?us-ascii?Q?oGDNWUaaW9VLWXUy35ji9UNqdg6SAcwL8/rd07a1nQfpwYrsffD34p0RUNcc?= =?us-ascii?Q?v32uUxqTsf+Srrdwtd93Rx+X/aTY1Oj3go0zt6kWKgVUBD0eTfDOpEU2NgjH?= =?us-ascii?Q?k+m3FT6OnavCeZzTkoG4OtKXJKsofXMrAfzm4riUw2zLrbwCmF00K+N7UmZ+?= =?us-ascii?Q?JWam5DsV9agvlyFjABs3vHFmex2OTh+wFX56Dtygls8+Dtn2v7UKmgZ+MUo8?= =?us-ascii?Q?QlOi+xucUuKCUhUFJmAtncI4pgA3DpBzniTW5uCcnxtvYUJgOXvKKE1zkh5g?= =?us-ascii?Q?ZUUrb7kAuMESliA6o/JD9O0D3MUcArUuTSjsacii3aNwrci6XOIvO9/8BHyl?= =?us-ascii?Q?+XMac4MI0+xxM7QFmfG5c2GJPAd/lH2hYOdU+RJ3xTrS923U1jaFbyRUKNNi?= =?us-ascii?Q?8pDWZcip/MYtvRM+gv8Bpko3Bfe928omS+J6P73qaJbjK/cv8moXoyk+WMjR?= =?us-ascii?Q?4y3ekovoHjIG7Xp/kIXjF/q+yXiwvSG55wa9w9+MV9yMuNaWWhYOwzDqFiUu?= =?us-ascii?Q?Z5BzWcivFXH0xH8JKZCIBN8O1n4oePDJ9mXQBnkW8LV4tQU03gMRYbx/6rx4?= =?us-ascii?Q?PCtvGJKmMPzlOAMVv6NgH86xbpMQq056abG5Uj0AP+GWRwojgE/YJpkHcogP?= =?us-ascii?Q?Xs3ioq7AGMSvRf2feM+M7LAUmdK7ImbY9GO1ecijLZiYoQxVX3/lngPrHbvG?= =?us-ascii?Q?zHep8NJS2bzxJkI9eD5F5AbavTC6+q2/m5foo023T14WL1rNQP7xX26cdErn?= =?us-ascii?Q?Yd1cNp2h0Z9LeV4yDB63c3Mc6p4hdeCxtaQewj90kGPuRuZSs/M6vFvGbfcf?= =?us-ascii?Q?Il4lY46gkkArcIcKlBRRK0vf0Myg+NC0i+Lycb36HtiuG/DKg8lEVPiHo0D9?= =?us-ascii?Q?xzrqQe/xYzv4ltJnWZtye3xzntPq+0HJse/RydjJsluLJ0ljNt87Xu/0ON7v?= =?us-ascii?Q?/lGKB5BfyVfh6qTxDSoDYOlCLgt3JfP8OERqiPHjWQyu50YaQXeMSXGKVJoI?= =?us-ascii?Q?xqr5NXJFz6yQIzm8u37m8nHc2Md9bji4HXKwG/IUSvjnSRk7QjgPCt9KSUyy?= =?us-ascii?Q?8g+rdCiQoNrSD8OkdcGpXXjPyxTksuo9zZMe3esvsLe4sclMjeK70hpwXbqM?= =?us-ascii?Q?03NDHwIUfzmmzMWFGQmc+bnZWoZdPLYgVTD6BQhS5G4MUanxN4pOj2voxHYk?= =?us-ascii?Q?5m2AiYVWwXZXjpVOfTm3z/Huu6sVCTyCD2pu915pr7ZstxZBdcXKh5keKwCl?= =?us-ascii?Q?86a2P1aCD5uQsGfMvyE6HQSmIsAU53uwe4Xb5aP2cgkJCDHptBEnei87rBZI?= =?us-ascii?Q?mDT6NcJIezmTI7s1DJ8ybeIqJrbD/GCEEIidnA0PCQVoyEfxNs1QxRsISFZ8?= =?us-ascii?Q?bQ+pTDVnG1QRR83DcYHaS/MG0dtGMh/jslpQsf6/Nkc8ElX+RgfKLph+PhA7?= =?us-ascii?Q?xg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0c872d11-47cf-4e4a-5abc-08dc6b915ea5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 16:52:08.3918 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9RsBdIhc6+Ha0srM86/M9fG+bje8/hFbdcrDmjoe9oOkj3ZdjIz20BEqNQMOlyKuabNkejbgFXtXaehNMYdRWWxWTj+4kPN72Q9mV7s8p50= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8726 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 03, 2024 at 05:48:05PM +0100, Bruce Richardson wrote: > On Fri, May 03, 2024 at 09:46:15AM +0000, Tom Jones wrote: > > Add support to the contigmem module on FreeBSD for multiple concurrent > > files, this enables running multiple dpdk instances with the nic_uio > > driver. > > > > Add relevant parts in dpdk to support this. > > > > Signed-off-by: Tom Jones > > --- > > config/rte_config.h | 2 + > > kernel/freebsd/contigmem/contigmem.c | 225 ++++++++++++++++++--------- > > lib/eal/common/eal_common_options.c | 2 + > > lib/eal/freebsd/eal.c | 12 ++ > > lib/eal/freebsd/eal_hugepage_info.c | 12 +- > > lib/eal/freebsd/eal_memory.c | 3 +- > > 6 files changed, 180 insertions(+), 76 deletions(-) > > > Hi Tom, > > on testing this out the biggest gap I see is that we need a documentation > update for it. In V3 can you please update the FreeBSD GSG doc with some > details about how to use this feature. > > Also, on first run using testpmd, the application failed to start, as I was > missing a file-prefix option. At minimum I think the code needs to default > the file-prefix on BSD to "contigmem0", so that when running a standalone > app as before, it "just works". An idea for backward compatibility here > that may help us, is to omit the "0" for contigmem0 device. That would mean > that an older DPDK app will work with a newer kernel driver, and vice > versa. > > Beyond that, I'm not sure how to get multiple processes working right now > (hence the doc update request!). When I run a second instance of DPDK on my > system with "--file-prefix=contigmem1", I get errors about the shared > config file in "/var/run/dpdk/rte/config". > Inspiration struck me just after I hit send on this email. Removing the #ifdefs in eal_common_options.c allows me to run two processes in parallel just fine. I think we need to consider how to rework this to avoid using the file-prefix argument for the contigmem files. Not sure what a better scheme is, though. Do you have any ideas or suggestions on this from your experience doing up this patch? Thanks, /Bruce